-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests with networkx 2.7 #33495
Labels
Milestone
Comments
Commit: |
Author: Antonio Rojas |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:4
You should
- return EdgesView(Graph([(u, v, L[frozenset((u, v))]) for u, v in d]))
+ return EdgesView(Graph([(u, v, L[frozenset((u, v))]) for u, v in d], format='list_of_edges'))
- sage: sorted(g.matching(use_edge_labels=True))
- [(0, 3, 3), (1, 2, 6)]
+ sage: m = g.matching(use_edge_labels=True)
+ sage: type(m)
+ <class 'sage.graphs.views.EdgesView'>
+ sage: sorted(m)
+ [(0, 3, 3), (1, 2, 6)] |
comment:6
Done, thanks |
comment:7
LGTM. |
Reviewer: David Coudert |
comment:8
Follow-up: #33520 |
Changed branch from u/arojas/fix_tests_with_networkx_2_7 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The output of
matching
displays edges in reverse order in 2.7, which break tests. To fix it, we make the output ofmatching
andEdgesview
, which also fixes some other issues, such as:Also,
networkx.node_clique_number
now outputs acollections.defaultdict
object, so we explicitly cast it todict
for backwards compatibility.CC: @mkoeppe @kiwifb @tornaria
Component: graph theory
Author: Antonio Rojas
Branch/Commit:
8452003
Reviewer: David Coudert
Issue created by migration from https://trac.sagemath.org/ticket/33495
The text was updated successfully, but these errors were encountered: