Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better boolean statements #33721

Closed
fchapoton opened this issue Apr 16, 2022 · 8 comments
Closed

better boolean statements #33721

fchapoton opened this issue Apr 16, 2022 · 8 comments
Labels
p: minor / 4 t: enhancement t: refactoring
Milestone
sage-9.7

Comments

@fchapoton
Copy link
Contributor

found using pylint R1719

avoiding something like True if bla else False

CC: @tscrim @slel @kliem @kwankyu

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 94b5a61

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/33721
@fchapoton fchapoton added this to the sage-9.6 milestone Apr 16, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/33721

@fchapoton
Copy link
Contributor Author

New commits:

94b5a61better boolean statements

@fchapoton
Copy link
Contributor Author

Commit: 94b5a61

@fchapoton
Copy link
Contributor Author

comment:2

green bot, so please review

@kliem
Copy link
Contributor

kliem commented Apr 17, 2022

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Apr 17, 2022

comment:3

LGTM.

@fchapoton
Copy link
Contributor Author

comment:4

bump to 9.7

@fchapoton fchapoton modified the milestones: sage-9.6, sage-9.7 Apr 22, 2022
@vbraun
Copy link
Member

vbraun commented May 24, 2022

Changed branch from u/chapoton/33721 to 94b5a61

@vbraun vbraun closed this as completed in 3202aea May 24, 2022
@vbraun vbraun mentioned this issue May 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @kliem