get rid of some iteritems

[fchapoton]

Change iteritems to items in two py files where iteritems makes no sense with python3.

Also in one pyx file. Note that in pyx files, with python3, items is the same as iteritems.

CC: @tscrim

Component: refactoring

Author: Frédéric Chapoton

Branch: 0d580e5

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/33726

[fchapoton]

Commit: aa51084

[fchapoton]

New commits:

aa51084

get rid of some iteritems

[fchapoton]

Branch: u/chapoton/33726

[kwankyu]

comment:2

in two py files where this makes no sense

What do you mean? You only replaced iteritems with items (of python3).

[kwankyu]

comment:3

While we are at it, why not change for t,g in ... to for t, g in ...?

[sagetrac-git]

Changed commit from aa51084 to 0d580e5

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0d580e5

more spaces after comma

[fchapoton]

comment:5

Replying to @kwankyu:

in two py files where this makes no sense

What do you mean? You only replaced iteritems with items (of python3).

Well, I suspect that this part of the code is never doctested. In python3, dictionaries no longer have an iteritems method.

The only thing that still have an iteritems method are sage own's weak dictionaries. We should switch this method's name to items, but not in this ticket.

[kwankyu]

Reviewer: Kwankyu Lee

[kwankyu]

comment:6

Replying to @fchapoton:

Replying to @kwankyu:

in two py files where this makes no sense

What do you mean? You only replaced iteritems with items (of python3).

Well, I suspect that this part of the code is never doctested. In python3, dictionaries no longer have an iteritems method.

Right.

The only thing that still have an iteritems method are sage own's weak dictionaries. We should switch this method's name to items, but not in this ticket.

Okay.

[vbraun]

Changed branch from u/chapoton/33726 to 0d580e5

[slel]

Changed commit from 0d580e5 to none

[slel]

comment:8

This change missed one of the iteritems:

-        for t,g in self._t_dict.iteritems():
-            for k,c in g.monomial_coefficients(copy=False).iteritems():
+        for t, g in self._t_dict.items():
+            for k, c in g.monomial_coefficients(copy=False).iteritems():

[mkoeppe]

comment:9

Replying to Frédéric Chapoton:

The only thing that still have an iteritems method are sage own's weak dictionaries. We should switch this method's name to items, but not in this ticket.

I've opened #34488 for this