Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modernize super() in schemes,libs,sets,quivers #33984

Closed
fchapoton opened this issue Jun 13, 2022 · 7 comments
Closed

modernize super() in schemes,libs,sets,quivers #33984

fchapoton opened this issue Jun 13, 2022 · 7 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.7

Comments

@fchapoton
Copy link
Contributor

using the much better python3 syntax super()

CC: @tscrim @kwankyu @kliem @slel

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 6e0ee6f

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/33984
@fchapoton fchapoton added this to the sage-9.7 milestone Jun 13, 2022
@fchapoton
Copy link
Contributor Author

New commits:

775ca36modernize super() in schemes/
80abab5modernize super() in quivers/
6288cd2modernize super() in sets/
6e0ee6fmodernize super() in libs/ and lfunctions/

@fchapoton
Copy link
Contributor Author

Commit: 6e0ee6f

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/33984

@fchapoton
Copy link
Contributor Author

comment:2

green lights, so please review

@tscrim
Copy link
Collaborator

tscrim commented Jun 14, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 14, 2022

comment:3

It is good to see more of this going away. LGTM.

@vbraun
Copy link
Member

vbraun commented Jun 21, 2022

Changed branch from u/chapoton/33984 to 6e0ee6f

@vbraun vbraun closed this as completed in 7ed4046 Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton