Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pep cleanup for words/morphism.py #33993

Closed
fchapoton opened this issue Jun 13, 2022 · 9 comments
Closed

pep cleanup for words/morphism.py #33993

fchapoton opened this issue Jun 13, 2022 · 9 comments

Comments

@fchapoton
Copy link
Contributor

also fixing some lgtm warnings

and some code details

CC: @tscrim @kwankyu @kliem @slel

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: f4e7ee1

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/33993

@fchapoton fchapoton added this to the sage-9.7 milestone Jun 13, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/33993

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 13, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

f4e7ee1full pycodestyle cleanup for words/morphism.py

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 13, 2022

Commit: f4e7ee1

@fchapoton
Copy link
Contributor Author

comment:3

green bot, so please review

@dcoudert
Copy link
Contributor

comment:4

Can you explain this change

             if isinstance(w, Iterable):
-                datatype = 'iter'
+                pass

@fchapoton
Copy link
Contributor Author

comment:5

variable non utilisée

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@dcoudert
Copy link
Contributor

comment:6

C'était mon impression, mais j'avais un petit doute. Merci.

LGTM.

@vbraun
Copy link
Member

vbraun commented Jun 21, 2022

Changed branch from u/chapoton/33993 to f4e7ee1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants