Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to avoid OrePolynomialRing cast to PolynomialRing #34001

Closed
kryzar opened this issue Jun 16, 2022 · 4 comments
Closed

Add flag to avoid OrePolynomialRing cast to PolynomialRing #34001

kryzar opened this issue Jun 16, 2022 · 4 comments
Labels
c: algebra p: major / 3 t: enhancement
Milestone
sage-9.7

Comments

@kryzar
Copy link
Contributor

kryzar commented Jun 16, 2022

This ticket adds the flag polcast to class OrePolynomialRing. It defaults to True.

When there is no twisting derivation and twisting morphism (or that the twisting morphism is the identity), the constructor creates a regular PolynomialRing if polcast is True or a real OrePolynomialRing if polcast is False.

CC: @xcaruso

Component: algebra

Author: Antoine Leudière

Branch/Commit: dbda51e

Reviewer: Xavier Caruso

Issue created by migration from https://trac.sagemath.org/ticket/34001
@kryzar kryzar added this to the sage-9.7 milestone Jun 16, 2022
@xcaruso
Copy link
Contributor

xcaruso commented Jun 16, 2022

comment:2

Thanks for adding this option.

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jun 17, 2022

comment:3

Reviewer name added ;)

@tscrim
Copy link
Collaborator

tscrim commented Jun 17, 2022

Reviewer: Xavier Caruso

@vbraun
Copy link
Member

vbraun commented Jun 21, 2022

Changed branch from public/rings/dont_cast_ore_polynomial_when_twist_is_identity to dbda51e

@vbraun vbraun closed this as completed in e516392 Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebra p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
4 participants
@vbraun @tscrim @xcaruso @kryzar