Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean src/sage/graphs/pq_trees.py #34014

Closed
dcoudert opened this issue Jun 18, 2022 · 12 comments
Closed

Clean src/sage/graphs/pq_trees.py #34014

dcoudert opened this issue Jun 18, 2022 · 12 comments

Comments

@dcoudert
Copy link
Contributor

We fix all issues raised by ./sage -tox -e pycodestyle -- src/sage/graphs/pq_trees.py. In particular, we turn the lambda functions to functions.

CC: @dimpase

Component: graph theory

Author: David Coudert

Branch/Commit: b97a961

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/34014

@dcoudert dcoudert added this to the sage-9.7 milestone Jun 18, 2022
@dcoudert
Copy link
Contributor Author

Branch: public/graphs/34014_pq

@dcoudert
Copy link
Contributor Author

comment:1

When turning the lambda functions to actual functions, I have not added any documentation/doctest. The reason is that I don't know what could be a suitable documentation.

I have renamed the functions adding a _ to avoid considering them in the module's documentation.


New commits:

3026bcftrac #34014: clean pq_trees.py

@dcoudert
Copy link
Contributor Author

Commit: 3026bcf

@fchapoton
Copy link
Contributor

comment:2

coverage is not 100%

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 19, 2022

Changed commit from 3026bcf to b97a961

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 19, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b97a961trac #34014: add missing doctests

@dcoudert
Copy link
Contributor Author

comment:4

It took me some time to find appropriate doctests.

@dcoudert
Copy link
Contributor Author

comment:5

green bot, please review ;)

@fchapoton
Copy link
Contributor

comment:6

ok (mais fait trop chaud)

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@dcoudert
Copy link
Contributor Author

comment:7

Thank you.

Fais attention à ne pas fondre.

@vbraun
Copy link
Member

vbraun commented Jun 28, 2022

Changed branch from public/graphs/34014_pq to b97a961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants