configure: Make display of package versions less confusing

[mkoeppe]

When we don't install the SPKG, then its exact version is not relevant.

We change the output from

gc-8.0.4:     no suitable system package; standard, will be installed as an SPKG
gcc-11.3.0:   using system package; SPKG will not be installed

to

gc:     no suitable system package; standard, SPKG version 8.0.4 will be installed
gcc:    using system package; SPKG will not be installed

Component: build: configure

Author: Matthias Koeppe

Branch: 7bda1cb

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/34193

[mkoeppe]

Branch: u/mkoeppe/configure__make_display_of_package_versions_less_confusing

[mkoeppe]

Commit: 3f8965d

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

New commits:

3f8965d

m4/sage_spkg_collect.m4: Do not show SPKG versions when system package is used

[jhpalmieri]

comment:3

Looks good to me. A few questions:

• The number 32 is hard-coded in the formatting string. How much work would it be to determine that from the list of all packages? (This is not really worth spending time on, though.)

• With or without this branch: pip packages are treated differently than others if I run this after building Sage:

charset_normalizer:             standard, SPKG version 2.0.4 will be installed
cliquer:                        already installed as an SPKG

(At least I'm guessing it's pip vs. other types.) Should the cliquer message say "already installed version $SPKG_VERSION as an SPKG"? Should they both say that?

[sagetrac-git]

Changed commit from 3f8965d to 1b61561

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1b61561

m4/sage_spkg_collect.m4: Display installed package version

[mkoeppe]

comment:5

Replying to @jhpalmieri:

• The number 32 is hard-coded in the formatting string. How much work would it be to determine that from the list of all packages? (This is not really worth spending time on, though.)

Not sure that we would want to automatically change it if a package with a longer name comes along

[mkoeppe]

comment:6

Replying to @jhpalmieri:

• With or without this branch: pip packages are treated differently than others if I run this after building Sage:

charset_normalizer:             standard, SPKG version 2.0.4 will be installed
cliquer:                        already installed as an SPKG

(At least I'm guessing it's pip vs. other types.)

This version of the message is actually for packages with an spkg-configure.m4 that are installed already (and hence the test for a system package is not run at all).

Should the cliquer message say "already installed version $SPKG_VERSION as an SPKG"? Should they both say that?

I've made a change in this direction, but I guess it could be done more generally

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

215fbbc	m4/sage_spkg_collect.m4: Omit 'version none' in messages
8273456	m4/sage_spkg_collect.m4: Show installed versions / upgrade information

[sagetrac-git]

Changed commit from 1b61561 to 8273456

[mkoeppe]

comment:8

Now it knows how to talk about package upgrades/downgrades

[sagetrac-git]

Changed commit from 8273456 to b1a4aac

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

9574e8c	m4/sage_spkg_collect.m4: Handle multiple installation records better
b1a4aac	build/make/Makefile.in: For script packages, remove old installation records

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

515a785

m4/sage_spkg_collect.m4: Update comment regarding multiple installation records of script packages

[sagetrac-git]

Changed commit from b1a4aac to 515a785

[mkoeppe]

comment:11

Ready for testing

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

46a0870

m4/sage_spkg_collect.m4: Actually find installation records in SAGE_VENV when that is set implicitly

[sagetrac-git]

Changed commit from 515a785 to 46a0870

[sagetrac-git]

Changed commit from 46a0870 to 7bda1cb

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7bda1cb

m4/sage_spkg_collect.m4: Restore uninstall message

[jhpalmieri]

comment:16

This looks good to me.

This is not new to this ticket, and not particularly relevant to the changes here, but I don't quite see how uninstall_message works. When will it be set to "use "$srcdir/configure --disable-SPKG_NAME" to uninstall" — it seems as though this would be most useful for optional/experimental packages.

[jhpalmieri]

Reviewer: John Palmieri

[mkoeppe]

comment:17

The uninstall message is only issued for packages with spkg-configure.m4 for which currently an SPKG is installed. The uninstallation command is particularly useful for these packages because after uninstallation, configure will test again whether the system package can be used.

[mkoeppe]

comment:18

Thanks for the review!

[vbraun]

Changed branch from u/mkoeppe/configure__make_display_of_package_versions_less_confusing to 7bda1cb

[slel]

Changed commit from 7bda1cb to none