Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using items in indexed_elements.pyx #34505

Closed
fchapoton opened this issue Sep 8, 2022 · 7 comments
Closed

using items in indexed_elements.pyx #34505

fchapoton opened this issue Sep 8, 2022 · 7 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.8

Comments

@fchapoton
Copy link
Contributor

instead of the old-style "iteritems"

CC: @tscrim

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 4676b51

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34505
@fchapoton fchapoton added this to the sage-9.8 milestone Sep 8, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34505

@fchapoton
Copy link
Contributor Author

Commit: 4676b51

@fchapoton
Copy link
Contributor Author

New commits:

4676b51using items in indexed_element.pyx

@tscrim
Copy link
Collaborator

tscrim commented Sep 8, 2022

comment:2

Green bot => positive review.

@tscrim
Copy link
Collaborator

tscrim commented Sep 8, 2022

Reviewer: Travis Scrimshaw

@fchapoton
Copy link
Contributor Author

comment:3

thanks, Travis

@vbraun
Copy link
Member

vbraun commented Sep 22, 2022

Changed branch from u/chapoton/34505 to 4676b51

@vbraun vbraun closed this as completed in 0b597a7 Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton