Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toml package is obsolete #36175

Closed
2 tasks done
orlitzky opened this issue Sep 2, 2023 · 1 comment · Fixed by #36176
Closed
2 tasks done

toml package is obsolete #36175

orlitzky opened this issue Sep 2, 2023 · 1 comment · Fixed by #36176
Labels
t: bug
Milestone
sage-10.2

Comments

@orlitzky
Copy link
Contributor

orlitzky commented Sep 2, 2023

Steps To Reproduce

No response

Expected Behavior

toml is not installed

Actual Behavior

toml is installed

Additional Information

I think our toml package is obsolete. The only other package listing it as a requirement is tox, but tox only needs it with ancient pythons: https://github.com/tox-dev/tox/blob/3.27.1/setup.cfg#L45

I think our dependency can be replaced with tomli at which point toml can go.

Environment

Gentoo / git develop

Checklist

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.
  • I have read the documentation and troubleshoot guide
@orlitzky orlitzky added the t: bug label Sep 2, 2023
@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 2, 2023

Our tox needs to be updated to 4.x anyway - #34840

@vbraun vbraun closed this as completed in 5b2f125 Sep 16, 2023
@mkoeppe mkoeppe added this to the sage-10.2 milestone Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t: bug
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging a pull request may close this issue.

build/pkgs/tox: Update, require tox >= 4.2.7, update dependencies mkoeppe/sage
2 participants
@orlitzky @mkoeppe