-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exceptional and reducible type branching rules #5794
Comments
Changed keywords from none to lie groups |
comment:2
The last change indicates that I changed the owner from tbd to joyner. I don't Here are some comments about the G2=>A1 Levi branching rule. There is a So G2=>A1xA1 will come in a later patch but it is relevant here so I will discuss it. In the branching rule G2=>A1xA1, the second A1 is almost but not |
comment:3
I uploaded a second patch trac_5794-f4.patch which goes on top of There is another extended rule F4=>C3xA1 (not implemented yet, In contrast with G2, for F4, both Levi branching rules are redundant I compared the output for these rules against those that I could find in a book, |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:7
Hi Dan, the change in ownership happend because you changed the component to "group_thoery". For every ticket you work on and post patches you should accept it (see the bottom left), that way ownership stays with you. Cheers, Michael |
This comment has been minimized.
This comment has been minimized.
Attachment: trac_5794-revised.patch.gz |
comment:10
I'm taking the liberty of changing the milestone to 4.0 in case there |
comment:11
Here are some tests supplementing those implemented in the doctests: |
This comment has been minimized.
This comment has been minimized.
comment:12
Attachment: trac_5794-continued.patch.gz |
comment:13
Is it possible to remove the first two patches:
They are superceded by the other patches. I am going to be adding some Dan |
comment:21
Replying to @dwbump:
Note that I'm not qualified to review the mathematical content of the patch. However, I would like to point out that the following patches and line numbers don't conform to ReST formatting: In
|
comment:22
Attachment: trac_5794-reviewer-nt.patch.gz Nicolas Thiery wrote the patch It addresses at least some of the ReST complaints. I am changing the title back to [with patch, needs review] since The patches as posted differ slightly from the versions in the combinat queue. http://groups.google.com/group/sage-combinat-devel/msg/8b3569b4e2f2b7e1?hl=en and thread for discussion. (Note: the |
comment:23
Patch review: trac_5794 The patch author is a widely acknowledged expert in the area, having written a textbook which includes a discussion of the root systems and branching rules implemented here. Although we did not check all of the details of the algorithms, the root system code has been used by the reviewer to implement the alcove path model for crystals of Lenart and Postnikov, and the branching code has computed some verified data in type E_6. This patch implements useful mathematics and the extensive documentation includes references to relevant mathematical literature. There are currently two warnings for the reference manual (sage -docbuild reference html); these require help from Sage developers to be fixed. The Sage library test passes, and all methods have doctests which pass. -- Brant Jones |
Reviewer: Brant Jones |
comment:24
This depends on #4326. |
Author: Dan Bump |
Attachment: trac_5794-long-time-nt.patch.gz Annotates the long tests with their time, and disables one which took 160s. |
comment:28
Positive review from Dan on sage-combinat-devel |
Merged: sage-4.3.alpha0 |
comment:30
Did
|
comment:31
Thanks for picking that up. I've merged that one patch in 4.3.rc1. |
comment:33
I seems the patches here on Trac are not the ones which were actually merged 4 years ago, which was discovered in #15279. |
Changed author from Dan Bump to Daniel Bump |
Patch summary for trac_5794.revised:
This patch contains #5831. If this patch is merged, that ticket may be closed.
The patch trac_5794-continued.patch goes on top of trac_5794-revised.patch. Together, the two patches
give complete coverage of branching rules from
classical root systems to maximal subgroups.
Highlights of the second patch:
The file at
http://sporadic.stanford.edu/bump/branch.sage contains additional tests demonstrating every branching rule in Patera and McKay's book of tables for Cartan types A,B,C,D. This verifies the completeness of the patch for nonexceptional types.
The patch
trac_5794-exceptional.patch
adds some more F4 and E6 branching rules. It also addsdynkin_diagram
andextended_dynkin_diagram
methods to WeylCharacterRings. It goes on top of the other two patches.The last patch
trac_5794-more-exceptional.patch
adds E6, E7 and E8 branching rules.CC: @sagetrac-sage-combinat
Component: group theory
Keywords: lie groups
Author: Daniel Bump
Reviewer: Brant Jones
Merged: sage-4.3.alpha0
Issue created by migration from https://trac.sagemath.org/ticket/5794
The text was updated successfully, but these errors were encountered: