Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sage 3.4.2: prime_pi() broken on 32 bit #5981

Closed
sagetrac-mabshoff mannequin opened this issue May 4, 2009 · 5 comments
Closed

Sage 3.4.2: prime_pi() broken on 32 bit #5981

sagetrac-mabshoff mannequin opened this issue May 4, 2009 · 5 comments
Assignees
@sagetrac-mabshoff
Labels
p: blocker / 1 t: bug t: tests
Milestone
sage-3.4.2

Comments

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented May 4, 2009

The issue is that Integer(2^40) is evaluated to 0 on 32 bit systems (maybe due to Cython folding constants?). The attached patch uses a long constant instead. Tested to work on 32 and 64 bit boxen.

Cheers,

Michael

Component: doctest coverage

Issue created by migration from https://trac.sagemath.org/ticket/5981
@sagetrac-mabshoff sagetrac-mabshoff mannequin added this to the sage-4.0 milestone May 4, 2009
@sagetrac-mabshoff sagetrac-mabshoff mannequin self-assigned this May 4, 2009
@sagetrac-mabshoff sagetrac-mabshoff mannequin modified the milestones: sage-4.0, sage-3.4.2 May 4, 2009
@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented May 4, 2009

Attachment: trac_5981.patch.gz

@sagetrac-mabshoff

This comment has been minimized.

Sign in to view
@jaapspies
Copy link
Member

comment:3

Positive review :)


 ./sage -t  "devel/sage/sage/functions/prime_pi.pyx"
sage -t  "devel/sage/sage/functions/prime_pi.pyx"
     [48.1 s]

----------------------------------------------------------------------
All tests passed!
Total time for all tests: 48.1 seconds


Jaap

@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented May 5, 2009

comment:4

Merged in Sage 3.4.2.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed May 5, 2009
@sagetrac-mabshoff

This comment has been minimized.

Sign in to view
This was referenced Nov 17, 2009
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-mabshoff sagetrac-mabshoff

Labels
p: blocker / 1 t: bug t: tests
Projects
None yet
Milestone
sage-3.4.2
Development

No branches or pull requests
1 participant
@jaapspies