Add a standard constructor for dynamic classes #5991

nthiery · 2009-05-05T22:04:01Z

This patch implements sage.structure.dynamic_class.dynamic_class, for constructing dynamically new python classes. The constructed classes can be pickled, and have unique representation.

The patch includes a discussion on the relevance of dynamic classes for Sage.

Depends on #5985 for pickling and #5120.

Used by the upcoming category framework #5891, (and sage-words?)

Issue: is sage.structure.dynamic_class.dynamic_class the natural location for this?

CC: @sagetrac-sage-combinat @saliola @roed314

Component: misc

Keywords: dynamic classes, unique representation

Author: Nicolas M. Thiéry

Reviewer: David Roe

Merged: sage-4.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/5991

nthiery · 2009-05-08T23:19:15Z

comment:4

Patch updated for new version of #5120
Please ignore dynamic_class-5991-submitted.2.patch

nthiery · 2009-05-21T08:15:11Z

Attachment: dynamic_class-5991-submitted.patch.gz

roed314 · 2009-05-21T09:04:44Z

comment:7

Looks good. Doctests pass.

ncalexan · 2009-06-13T22:00:57Z

Author: Nicolas Thiery

ncalexan · 2009-06-13T22:00:57Z

comment:8

Since this depends on #5985 which does not have a positive review it will have to wait.

ncalexan · 2009-06-13T22:00:57Z

Reviewer: David Roe

boothby · 2009-06-24T18:34:40Z

comment:9

Doctest failures:

sage -t -long devel/sage/sage/structure/dynamic_class.py
**********************************************************************
File "/space/boothby/sage-4.0.3/devel/sage-main/sage/structure/dynamic_class.py", line 210:
    sage: loads(dumps(BarFoo))
Exception raised:
    Traceback (most recent call last):
      File "/space/boothby/sage-4.0.3/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/space/boothby/sage-4.0.3/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/space/boothby/sage-4.0.3/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_1[23]>", line 1, in <module>
        loads(dumps(BarFoo))###line 210:
    sage: loads(dumps(BarFoo))
      File "sage_object.pyx", line 604, in sage.structure.sage_object.dumps (sage/structure/sage_ob$
        return comp.compress(cPickle.dumps(obj, protocol=2))
    PicklingError: Can't pickle <class '__main__.BarFoo'>: attribute lookup __main__.BarFoo failed
**********************************************************************
File "/space/boothby/sage-4.0.3/devel/sage-main/sage/structure/dynamic_class.py", line 224:
    sage: import sage.misc.cPickle as cPickle
Exception raised:
    Traceback (most recent call last):
      File "/space/boothby/sage-4.0.3/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/space/boothby/sage-4.0.3/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/space/boothby/sage-4.0.3/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_1[30]>", line 1, in <module>
        import sage.misc.cPickle as cPickle###line 224:
    sage: import sage.misc.cPickle as cPickle
    ImportError: No module named cPickle
**********************************************************************
File "/space/boothby/sage-4.0.3/devel/sage-main/sage/structure/dynamic_class.py", line 225:
    sage: cPickle.loads(cPickle.dumps(FooBar)) == FooBar
Exception raised:
    Traceback (most recent call last):
      File "/space/boothby/sage-4.0.3/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/space/boothby/sage-4.0.3/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/space/boothby/sage-4.0.3/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_1[31]>", line 1, in <module>
        cPickle.loads(cPickle.dumps(FooBar)) == FooBar###line 225:
    sage: cPickle.loads(cPickle.dumps(FooBar)) == FooBar
    NameError: name 'cPickle' is not defined
**********************************************************************
File "/space/boothby/sage-4.0.3/devel/sage-main/sage/structure/dynamic_class.py", line 238:
    sage: loads(dumps(FooUnique)) is FooUnique
Exception raised:
    Traceback (most recent call last):
      File "/space/boothby/sage-4.0.3/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/space/boothby/sage-4.0.3/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/space/boothby/sage-4.0.3/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_1[35]>", line 1, in <module>
        loads(dumps(FooUnique)) is FooUnique###line 238:
    sage: loads(dumps(FooUnique)) is FooUnique
      File "sage_object.pyx", line 604, in sage.structure.sage_object.dumps (sage/structure/sage_ob$
        return comp.compress(cPickle.dumps(obj, protocol=2))
    PicklingError: Can't pickle <class '__main__.Foo'>: it's not the same object as __main__.Foo
**********************************************************************
1 items had failures:
   4 of  36 in __main__.example_1
***Test Failed*** 4 failures.

nthiery · 2009-06-24T20:38:26Z

comment:10

Yeah: it depends on #5985, but otherwise is ready.

Should there be a new field in the trac server for listing systematically the other tickets the ticket depends on?

nthiery · 2009-07-10T23:24:36Z

comment:11

Attachment: trac_5991-dynamic_class-referee-dr.patch.gz

The two added patches, by David and myself improve introspection.
I give a positive review on David's. David, can you double check mine?

nthiery · 2009-07-10T23:24:36Z

Changed author from Nicolas Thiery to Nicolas M. Thiéry

nthiery · 2009-07-13T06:54:55Z

comment:12

Attachment: trac_5991-dynamic_class-referee-nt.patch.gz

Replying to @nthiery:

The two added patches, by David and myself improve introspection.
I give a positive review on David's. David, can you double check mine?

The updated referee patch by myself adds a copyright header, and fixes a warning in sage -docbuild.

David: please double check!

nthiery · 2009-07-17T22:30:52Z

Attachment: dynamic_class-reduction-nt.patch.gz

Fix reduction after David's referee patch

nthiery · 2009-07-17T22:40:36Z

Fold of all the patches above. Apply only this one

nthiery · 2009-07-17T22:41:39Z

comment:13

Attachment: trac_5991_dynamic_class-nt.patch.gz

David: can you have a quick look at my latest addition, and set a positive review (pending #5985)

roed314 · 2009-07-18T07:12:32Z

comment:14

So, I approve the changes. I don't have time right now to run doctests though: the release manager (or someone) should make sure to do so.

nthiery · 2009-07-18T09:02:03Z

comment:15

Replying to @roed314:

So, I approve the changes. I don't have time right now to run doctests though: the release manager (or someone) should make sure to do so.

Thanks! All the doctest pass on my machine, but yes, a triple check would be good.

nthiery · 2009-10-11T08:52:16Z

comment:16

If #5985 is ready on time to get integrated in 4.1.2, it would be great to have this on go in too.

williamstein · 2009-10-14T03:45:48Z

comment:17

NOTE to self -- the change to sageinspect needs to be ported into the separated notebook when this is merged.

mwhansen · 2009-10-15T07:02:44Z

Attachment: trac_5991_dynamic_class-nt.2.patch.gz

mwhansen · 2009-10-15T07:15:24Z

Merged: sage-4.2.alpha0

mwhansen · 2009-10-15T07:15:24Z

comment:18

I had to make the change to the way cPickle is imported as in #5985. I'll make a new ticket for sageinspect in the separated notebook.

nthiery added this to the sage-4.2 milestone May 5, 2009

nthiery added p: major / 3 labels May 5, 2009

nthiery self-assigned this May 5, 2009

nthiery changed the title ~~Add as tandard constructor for dynamic classes~~ Add a standard constructor for dynamic classes May 5, 2009

This comment has been minimized.

Sign in to view

nthiery added the s: needs review label May 8, 2009

This comment has been minimized.

Sign in to view

nthiery removed the s: needs review label May 19, 2009

roed314 added the s: positive review label May 21, 2009

boothby added s: needs work and removed s: positive review labels Jun 24, 2009

nthiery added s: needs review and removed s: needs work labels Jul 17, 2009

roed314 added s: positive review and removed s: needs review labels Jul 18, 2009

nthiery modified the milestones: sage-4.2, sage-4.1.2 Oct 11, 2009

mwhansen removed the s: positive review label Oct 15, 2009

mwhansen closed this as completed Oct 15, 2009

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a standard constructor for dynamic classes #5991

Add a standard constructor for dynamic classes #5991

nthiery commented May 5, 2009

This comment has been minimized.

This comment has been minimized.

nthiery commented May 8, 2009

This comment has been minimized.

nthiery commented May 21, 2009

roed314 commented May 21, 2009

ncalexan mannequin commented Jun 13, 2009

ncalexan mannequin commented Jun 13, 2009

ncalexan mannequin commented Jun 13, 2009

boothby commented Jun 24, 2009

nthiery commented Jun 24, 2009

nthiery commented Jul 10, 2009

nthiery commented Jul 10, 2009

nthiery commented Jul 13, 2009

nthiery commented Jul 17, 2009

nthiery commented Jul 17, 2009

nthiery commented Jul 17, 2009

roed314 commented Jul 18, 2009

nthiery commented Jul 18, 2009

nthiery commented Oct 11, 2009

williamstein commented Oct 14, 2009

mwhansen commented Oct 15, 2009

mwhansen commented Oct 15, 2009

mwhansen commented Oct 15, 2009

Add a standard constructor for dynamic classes #5991

Add a standard constructor for dynamic classes #5991

Comments

nthiery commented May 5, 2009

This comment has been minimized.

This comment has been minimized.

nthiery commented May 8, 2009

This comment has been minimized.

nthiery commented May 21, 2009

roed314 commented May 21, 2009

ncalexan mannequin commented Jun 13, 2009

ncalexan mannequin commented Jun 13, 2009

ncalexan mannequin commented Jun 13, 2009

boothby commented Jun 24, 2009

nthiery commented Jun 24, 2009

nthiery commented Jul 10, 2009

nthiery commented Jul 10, 2009

nthiery commented Jul 13, 2009

nthiery commented Jul 17, 2009

nthiery commented Jul 17, 2009

nthiery commented Jul 17, 2009

roed314 commented Jul 18, 2009

nthiery commented Jul 18, 2009

nthiery commented Oct 11, 2009

williamstein commented Oct 14, 2009

mwhansen commented Oct 15, 2009

mwhansen commented Oct 15, 2009

mwhansen commented Oct 15, 2009