Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix display2d with ecl on OSX #6054

Closed
mwhansen opened this issue May 17, 2009 · 3 comments
Closed

fix display2d with ecl on OSX #6054

mwhansen opened this issue May 17, 2009 · 3 comments

Comments

@mwhansen
Copy link
Contributor

 * ecl causes about two bugs and a half on OSX and probably some other
systems. __repr__ seems to cause sync issues, there is some problem
with numerical noise and the list of Maxima commands seems to have
different orderings on different platforms. All this can be fixed with
too many problems. The doctests affected:

32 bit OSX 10.5/Intel:

       sage -t -long "devel/sage/doc/en/constructions/calculus.rst"
       sage -t -long "devel/sage/doc/en/constructions/
polynomials.rst"
       sage -t -long "devel/sage/doc/en/tutorial/introduction.rst"
       sage -t -long "devel/sage/doc/en/tutorial/tour_algebra.rst"
       sage -t -long "devel/sage/doc/fr/tutorial/introduction.rst"
       sage -t -long "devel/sage/doc/fr/tutorial/tour_algebra.rst"
       sage -t -long "devel/sage/sage/calculus/calculus.py"
       sage -t -long "devel/sage/sage/calculus/equations.py"
       sage -t -long "devel/sage/sage/calculus/functional.py"
       sage -t -long "devel/sage/sage/calculus/test_sympy.py"
       sage -t -long "devel/sage/sage/calculus/tests.py"
       sage -t -long "devel/sage/sage/calculus/wester.py"
       sage -t -long "devel/sage/sage/interfaces/maxima.py"
       sage -t -long "devel/sage/sage/schemes/elliptic_curves/
ell_generic.py"
       sage -t -long "devel/sage/sage/symbolic/expression.pyx"

noise/blankline of "print $FOO" type

64 bit OSX 10.5/Intel

       sage -t -long "devel/sage/doc/en/constructions/calculus.rst"
       sage -t -long "devel/sage/doc/en/constructions/
polynomials.rst"
       sage -t -long "devel/sage/doc/en/tutorial/introduction.rst"
       sage -t -long "devel/sage/doc/en/tutorial/tour_algebra.rst"
       sage -t -long "devel/sage/doc/fr/tutorial/introduction.rst"
       sage -t -long "devel/sage/doc/fr/tutorial/tour_algebra.rst"
       sage -t -long "devel/sage/sage/calculus/calculus.py"
       sage -t -long "devel/sage/sage/calculus/equations.py"
       sage -t -long "devel/sage/sage/calculus/functional.py"
       sage -t -long "devel/sage/sage/calculus/test_sympy.py"
       sage -t -long "devel/sage/sage/calculus/tests.py"
       sage -t -long "devel/sage/sage/calculus/wester.py"
       sage -t -long "devel/sage/sage/interfaces/maxima.py"
       sage -t -long "devel/sage/sage/schemes/elliptic_curves/
ell_generic.py"
       sage -t -long "devel/sage/sage/symbolic/expression.pyx"

Component: doctest coverage

Issue created by migration from https://trac.sagemath.org/ticket/6054

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented May 18, 2009

comment:1

Attachment: maxima_display2d.patch.gz

Thanks. Great patch. But the semicolon removal in the patch

--- a/sage/interfaces/maxima.py Fri May 15 18:39:25 2009 -0700
+++ b/sage/interfaces/maxima.py Sat May 16 23:30:51 2009 -0700
@@ -755,7 +755,7 @@
         if self._expect is None: return
         r = randrange(2147483647)
         s = marker + str(r+1)
-        cmd = ''';sconcat("%s",(%s+1));\n'''%(marker,r)
+        cmd = '''sconcat("%s",(%s+1));\n'''%(marker,r)
         self._sendstr(cmd)
         try:
             self._expect_expr(timeout=0.5)

causes sync issues on sage.math, so I am taking it out.

Cheers,

Michael

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented May 18, 2009

comment:2

Attachment: trac_6054_maxima_display2d.patch.gz

The patch I just posted replaces Mike's patch and also fixes the failure in

devel/sage/doc/en/constructions/calculus.rst

that Mike did point out he forgot to change when he cut the patch. I committed in Mike's name obviously ;)

Cheers,

Michael

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented May 18, 2009

comment:3

Merged in Sage 4.0.rc0.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed May 18, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant