Potential issue in polybori - 0.5rc.p8 and/or 0.5rc.p9

[sagetrac-drkirkby]

I believe there is an issue which may affect Solaris with polybori 0.5rc.p8, and assuming my patch to .p9 gets positive review, will affect that too, as I have not tried to fix this.

Here are some notes I put in patches/custom.py

# Note, these 'SAGE_DEBUG' linker flags added by someone
# are likely to break if used on Solaris
# with the Sun linker, as -p option to the Sun linker is:
#         [-p auditlib]   identify audit library to accompany this object
# This has not been confirmed, and I don't have time to test it.
# David Kirkby, 21st July 2009. I suggest this is revisited by someone soon.
if os.environ.has_key('SAGE_DEBUG'):
    CPPDEFINES=[]
    CCFLAGS=[" -pg"] + CCFLAGS
    CXXFLAGS=[" -pg"] + CXXFLAGS
    LINKFLAGS=[" -pg"]

---

Duplicate of #11575.

Upstream: Completely fixed; Fix reported upstream

CC: @alexanderdreyer @sagetrac-PolyBoRi @sagetrac-drkirkby

Component: porting: Solaris

Reviewer: Alexander Dreyer

Issue created by migration from https://trac.sagemath.org/ticket/6582

[sagetrac-drkirkby]

comment:1

Another issue, which is this case I am 100% sure about, is that PolyBoRi (as of polybori-0.6.3-20090827.spkg) in sage-4.1.2.alpha4 is that PolyBoRi is sending GNU-specific options to the Sun compiler. See #7034

[jdemeyer]

comment:3

Is this still a problem?

[alexanderdreyer]

comment:4

No, it was fixed. For instance, in #12655 for PolyBoRi 0.8.1.

[alexanderdreyer]

Upstream: Completely fixed; Fix reported upstream

[alexanderdreyer]

comment:5

Duplicate of#12655.

[alexanderdreyer]

comment:6

Abusing "positive review".

[jdemeyer]

Reviewer: Alexander Dreyer

[jdemeyer]

comment:7

In such cases, you should set the milestone to "sage-duplicate/invalid/wontfix".

[alexanderdreyer]

comment:8

Replying to @jdemeyer:

In such cases, you should set the milestone to "sage-duplicate/invalid/wontfix".

Thanks, I'll do so next time.