%maxima cells are partially broken

[sagetrac-whuss]

In the new sage notebook maxima cells do not work anymore for inputs
starting with '%'.

%maxima
%pi

Traceback (click to the left for traceback)
...
AttributeError: 'sage.symbolic.expression.Expression' object has no
attribute 'eval'

or:

%maxima
%e^(%i * %pi)

Syntax Error:
    %e^(%i * %pi)

This used to work with older Sage versions.

CC: @williamstein @TimDumol

Component: notebook

Author: Mike Hansen

Reviewer: Tim Dumol, Mitesh Patel

Merged: SageNB 0.8.1

Issue created by migration from https://trac.sagemath.org/ticket/7418

[mwhansen]

comment:1

I think the best fix for this is to break from processing the percent directives once a system directive has been reached. It should be easy to detect this as the system directives are the "unknown" one has been reached.

[mwhansen]

Author: Mike Hansen

[TimDumol]

comment:3

Applying the patch on the latest version off the repository (sagenb-0.5.0 + #7843 + #7844 + #7846 + #7871) causes the system directives to display (%html, %maxima, etc. are visible on output).

[mwhansen]

comment:4

Sorry about that. I put up a new patch which should fix it. I opted for duplicating the directives.append line instead of having some sort of check to see if the system was set as it makes the flow a little cleaner.

[TimDumol]

comment:5

Same problem still here (sagenb-0.6)

[qed777]

Add one. Rebased for queue in comment. Replaces previous.

[qed777]

comment:6

Attachment: trac_7418-maxima_cells.2.patch.gz

V2 adds one --- I hope it's in the right place. The queue:

SageNB 0.7 / #8051
trac_7784-hgignore_update.patch
trac_5712-interrupt-notification.5.patch
trac_6069-missing_pub_ws.2.patch
trac_8038-email_plus_addressing_v2.patch
trac_7506-notebook_object-documentation.2.patch
trac_693-spawn_notebook.3.patch
trac_5177-delete-cell-dirs.2.patch
trac_7418-maxima_cells.2.patch

The patch version numbers may be off by one or so.

Positive review, but someone should review my change.

[qed777]

Reviewer: Tim Dumol, Mitesh Patel

[TimDumol]

comment:8

LGTM. Positive review.

[TimDumol]

Merged: SageNB 0.8.1