Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sagenb -- add "Save/ Cancel" buttons to the top of the display too for notebook settings #7633

Closed
williamstein opened this issue Dec 9, 2009 · 9 comments
Closed

sagenb -- add "Save/ Cancel" buttons to the top of the display too for notebook settings #7633

williamstein opened this issue Dec 9, 2009 · 9 comments
Assignees
@williamstein
Labels
c: user interface p: minor / 4 t: enhancement
Milestone
sage-4.5

Comments

@williamstein
Copy link
Contributor

Thanks to #7627 I just looked at the very nice notebook settings page, and noticed that the save/cancel buttons are hidden at the bottom. It would be nice replicate them at the top of the screen too.

Component: notebook

Author: Mitesh Patel

Reviewer: Tim Dumol, Alex Leone

Merged: sagenb-0.8

Issue created by migration from https://trac.sagemath.org/ticket/7633
@williamstein williamstein added this to the sage-4.5 milestone Dec 9, 2009
@williamstein williamstein self-assigned this Dec 9, 2009
@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 25, 2010

Attachment: trac_7633-nb_settings_buttons.patch.gz

Copy Save, Cancel to top of notebook settings page. sagenb repo.

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 25, 2010

Author: Mitesh Patel

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 25, 2010

comment:1

Patch attached.

@qed777 qed777 mannequin added the s: needs review label Jan 25, 2010
@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Apr 3, 2010

Attachment: trac_7633-nb_settings_buttons-reviewer.patch.gz

Reviewer patch. Apply on top of previous. Does the same for Account Settings, and changes the elements from s to s.

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Apr 3, 2010

comment:2

Nice aesthetic change. This reviewer patch does the same for account settings. Positive review, for your changes.

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Apr 3, 2010

Reviewer: Tim Dumol

@sagetrac-acleone
Copy link
Mannequin

sagetrac-acleone mannequin commented Apr 24, 2010

Changed reviewer from Tim Dumol to Tim Dumol, Alex Leone

@sagetrac-acleone
Copy link
Mannequin

sagetrac-acleone mannequin commented Apr 24, 2010

comment:3

LGTM (tested both sets of buttons).

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jul 5, 2010

Merged: sagenb-0.8

@TimDumol TimDumol mannequin removed the s: positive review label Jul 5, 2010
@TimDumol TimDumol mannequin closed this as completed Jul 5, 2010
This was referenced Jul 5, 2010
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamstein williamstein

Labels
c: user interface p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-4.5
Development

No branches or pull requests
1 participant
@williamstein