Add # -*- coding: utf-8 -*- to the top of all SageNB .py files

[qed777]

Adding the pragma now to all Python files in SageNB may prevent some of the increasingly common docbuild errors raised when we build the reference manual.

CC: @TimDumol @sagetrac-mvngu

Component: notebook

Author: Tim Dumol

Reviewer: Mitesh Patel

Merged: sagenb-0.7

Issue created by migration from https://trac.sagemath.org/ticket/8000

[qed777]

comment:1

Minh -- Is this OK? Shall we make another ticket to update the whole Sage library?

[qed777]

comment:2

Replying to @qed777:

Minh -- Is this OK? Shall we make another ticket to update the whole Sage library?

In particular, post-#7249, we've got non-ASCII Unicode characters in doctests.

[sagetrac-mvngu]

comment:3

Replying to @qed777:

Minh -- Is this OK? Shall we make another ticket to update the whole Sage library?

I'm not sure about this, although I can clearly see the benefit of it. On the one hand, this could be further discouragement to people who want to start with Sage development. Could you send an email to sage-devel polling people about this issue? I mean something along the line of, "Should each source file have the character encoding preamble # -- coding: utf-8 -- ?". Also see #7999 relating to one file in the Sage library.

[qed777]

comment:4

Actually, it seems that # -*- coding: utf-8 -*- was already at the top of worksheet.py.

[qed777]

comment:5

Perhaps a different coding slipped in?

[qed777]

comment:6

Replying to @qed777:

Perhaps a different coding slipped in?

It turns out that we could fix this problem (cf. #7249) by making the docstring a unicode or raw string (e.g., """ --> u""" or r""").

[TimDumol]

This adds the coding directive

[TimDumol]

comment:7

Attachment: trac_8000-utf-8-coding-directive.patch.gz

This patch should do the trick.

[TimDumol]

Author: Tim Dumol

[qed777]

comment:8

Replying to @TimDumol:

This patch should do the trick.

It does, indeed. V2 also fixes a failed doctest in sagenb.misc.sageinspect.

[qed777]

Reviewer: Mitesh Patel

[qed777]

Fix failed doctest. Replaces previous. sagenb repo.

[qed777]

Attachment: trac_8000-utf-8-coding-directive.2.patch.gz

Attachment: trac_8000-utf-8-coding-directive.3.patch.gz

Rebased for SageNB 0.6 + queue in comment. Replaces previous.

[qed777]

comment:9

V3 is rebased for this queue (patch version numbers may be off by one):

sagenb-0.6
trac_7249-jinja2_v9.5.patch
trac_7962-link-worksheets-zip-file.patch
trac_7969-escaped-backslash.patch
trac_4217-html-system-formatting.3.patch
trac_3083-print-documentation.5.patch
trac_6182-double-quotes-ws.2.patch
trac_5263-publish-url.patch
trac_7631-republish-name.patch
trac_6353-cookies-diff-ports.patch
trac_7207-sagenb-future-import.3.patch
trac_8000-utf-8-coding-directive.2.patch

[qed777]

Merged: sagenb-0.7