Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'make check' exits with exit code 0 on a failure. #8270

Closed
sagetrac-drkirkby mannequin opened this issue Feb 15, 2010 · 7 comments
Closed

'make check' exits with exit code 0 on a failure. #8270

sagetrac-drkirkby mannequin opened this issue Feb 15, 2010 · 7 comments

Comments

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Feb 15, 2010

The iconv package, which will soon be added to sage (#8191) has the facility to run

make check

However, despite getting a test failure on Solaris 10 (SPARC), the makefile is still exiting with an exit code of 0, so any scripts which rely on testing iconv by relying on a failure of 'make check' to exit properly with a non-zero exit code will not work as desired.

I'll report this to the iconv developers.

Upstream: Reported upstream. Developers deny it's a bug.

Component: build

Issue created by migration from https://trac.sagemath.org/ticket/8270

@sagetrac-drkirkby sagetrac-drkirkby mannequin added this to the sage-4.3.3 milestone Feb 15, 2010
@sagetrac-drkirkby sagetrac-drkirkby mannequin changed the title 'make check' on exits with 0 on a failure. 'make check' exits with exit code 0 on a failure. Feb 15, 2010
@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Feb 15, 2010

Attachment: install.gz

The file spkg/install The iconv package is added.

@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Feb 15, 2010

Attachment: install.diff.gz

Diff between the old spkg/install and the updated spkg/install for iconv support

@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Feb 15, 2010

spkg/standard/deps to show packages which depend on iconv.

@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Feb 15, 2010

Attachment: deps.gz

Diff between the old spkg/standard/deps and the new one with iconv

@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Feb 15, 2010

comment:2

Attachment: deps.diff.gz

Ignore all these file - they were attached to the wrong ticket!!
Sorry about that.

@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Feb 16, 2010

comment:3

I'm told by the iconv developers this is not a bug. The core dumps are expected and ignored.

@sagetrac-drkirkby sagetrac-drkirkby mannequin closed this as completed Feb 16, 2010
@sagetrac-mvngu sagetrac-mvngu mannequin removed this from the sage-4.3.3 milestone Feb 17, 2010
@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Feb 17, 2010

Changed upstream from Not yet reported upstream; Will do shortly. to Reported upstream. Developers deny it's a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants