-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finite field lattices via Conway polynomials #8335
Comments
comment:2
Part of a series:
I tried to make each of these mostly self contained, with doctests passing after every ticket, but I didn't entirely succeed. If you're reviewing one of these tickets, applying later tickets will hopefully fix doctest failures that you're seeing. |
This comment has been minimized.
This comment has been minimized.
Includes everything in 8218, 8332, 7880, 7883, 8333, 8334 and 8335 except the 8218 bundle, which you must apply first. |
comment:4
Attachment: finite_field_coerce_ALL.patch.gz For convenience, I added a giant patch which includes all the changes except the bundle at 8218 (which we want to leave as a bundle in order to preserve file history). |
This comment has been minimized.
This comment has been minimized.
comment:6
This doesn't apply cleanly: the patch
|
Attachment: 8335_pseudo_conway.patch.gz Apply first |
comment:8
To work against 4.7, apply 8335_pseudo_conway.patch then 8335_finite_field_coerce_vs_47.patch. |
Apply second |
Attachment: 8335_finite_field_coerce.patch.gz Against 4.7 for patchbot |
comment:9
Attachment: 8335_finite_field_coerce_vs_47.patch.gz To work against 4.7, apply 8335_pseudo_conway.patch then 8335_finite_field_coerce_vs_47.patch. |
comment:10
Apply 8335_pseudo_conway.patch, 8335_finite_field_coerce_vs_47.patch |
comment:11
I still get the following failures on 4.7.1.alpha4 with 8335_pseudo_conway.patch and 8335_finite_field_coerce_vs_47.patch applied:
|
comment:12
I also get 7 warnings when building the docs. These all seem to be missing blank lines and unmatched backquoutes in |
Attachment: trac_8335-pseudo_conway-5.7.b3.patch.gz Patch for PCP; rebased on top of 5.7.beta3. |
Attachment: trac_8335-finite_field_coerce-5.7.b3.patch.gz Patch for coercion; rebased on top of 5.7.beta3. |
This comment has been minimized.
This comment has been minimized.
Changed work issues from store ref to PCL in finite field (or implement another way of weak caching) to none |
comment:113
For patchbot:
Note: attachment: trac_8335-rebase_14958.patch is not needed if we go for this approach. |
comment:114
Looks ok. |
Merged: sage-5.13.beta1 |
Implements coercion within lattices of finite fields lying above the same prime when implemented with Conway polynomials.
When using the
conway
andprefix
parameters, one does not need to specify an explicit variable name; if no variable name is given, it is constructed from theprefix
and the degree (as in the above code snippet).In the future, the functionality of this ticket will be incorporated into that for algebraic closures of finite fields. It will then be possible to construct compatible systems of finite fields outside the range of the Conway polynomial database using the pseudo-Conway polynomials from #14958: polynomials that satisfy all of the algebraic constraints on Conway polynomials without the lexicographic constraint that imposes uniqueness.
Apply:
Depends on #14958
Depends on #12142
CC: @defeo @rbeezer @sagetrac-hds @simon-king-jena @zimmermann6 @xcaruso @pjbruin @sagetrac-mraum @fredstro @sagetrac-JCooley @loefflerd @sagetrac-dfesti
Component: algebra
Keywords: days49 sd51
Author: David Roe, Jean-Pierre Flori, Peter Bruin
Reviewer: Jean-Pierre Flori, Luca De Feo
Merged: sage-5.13.beta1
Issue created by migration from https://trac.sagemath.org/ticket/8335
The text was updated successfully, but these errors were encountered: