-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrong usage of except #9294
Comments
Attachment: js-except-fix.diff.gz |
Author: Ralf Hemmecke |
Reviewer: Tim Dumol |
comment:2
Nice catch! Positive review. |
comment:3
See also http://groups.google.com/group/sage-notebook/msg/e74a7366f9f50f3c The bug seems to be fixed already. |
comment:4
Didn't seem to be the case when I applied the patch. The boxen.math url is just giving me a 500 error. |
Merged: sagenb 0.8.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sagenb-0.8.p2/src/sagenb/sagenb/notebook/js.py
says
try:
from sage.misc.misc import SAGE_ROOT
from pkg_resources import Requirement, working_set
sagenb_path = working_set.find(Requirement.parse('sagenb')).location
debug_mode = SAGE_ROOT not in os.path.realpath(sagenb_path)
except AttributeError, ImportError:
debug_mode = False
But according to what I cite below, it should rather be
except (AttributeError, ImportError):
http://docs.python.org/tutorial/errors.html
CC: @hemmecke
Component: notebook
Author: Ralf Hemmecke
Reviewer: Tim Dumol
Merged: sagenb 0.8.1
Issue created by migration from https://trac.sagemath.org/ticket/9294
The text was updated successfully, but these errors were encountered: