Skip to content
This repository was archived by the owner on Jan 30, 2023. It is now read-only.

Commit 45cc21a

Browse files
author
Matthias Koeppe
committed
is_Real[Double]Field, is_Complex[Double]Field: Undo automatic edits, deprecate
1 parent 28e328a commit 45cc21a

File tree

4 files changed

+36
-11
lines changed

4 files changed

+36
-11
lines changed

src/sage/rings/complex_double.pyx

+9-3
Original file line numberDiff line numberDiff line change
@@ -111,18 +111,24 @@ from sage.structure.richcmp cimport rich_to_bool
111111
cimport gmpy2
112112
gmpy2.import_gmpy2()
113113

114-
def isinstance(x, sage.rings.abc.ComplexDoubleField):
114+
115+
def is_ComplexDoubleField(x):
115116
"""
116117
Return ``True`` if ``x`` is the complex double field.
117118
119+
This function is deprecated. Use :func:`isinstance` with
120+
:class:`~sage.rings.abc.ComplexDoubleField` instead.
121+
118122
EXAMPLES::
119123
120124
sage: from sage.rings.complex_double import is_ComplexDoubleField
121-
sage: isinstance(CDF, sage.rings.abc.ComplexDoubleField)
125+
sage: is_ComplexDoubleField(CDF)
122126
True
123-
sage: isinstance(ComplexField(53, sage.rings.abc.ComplexDoubleField))
127+
sage: is_ComplexDoubleField(ComplexField(53))
124128
False
125129
"""
130+
from sage.misc.superseded import deprecation
131+
deprecation(32610, 'is_ComplexDoubleField is deprecated; use isinstance(..., sage.rings.abc.ComplexDoubleField) instead')
126132
return isinstance(x, ComplexDoubleField_class)
127133

128134

src/sage/rings/complex_mpfr.pyx

+9-2
Original file line numberDiff line numberDiff line change
@@ -157,10 +157,14 @@ def is_ComplexNumber(x):
157157
"""
158158
return isinstance(x, ComplexNumber)
159159

160-
def isinstance(x, sage.rings.abc.ComplexField):
160+
161+
def is_ComplexField(x):
161162
"""
162163
Check if ``x`` is a :class:`complex field <ComplexField_class>`.
163164
165+
This function is deprecated. Use :func:`isinstance` with
166+
:class:`~sage.rings.abc.ComplexField` instead.
167+
164168
EXAMPLES::
165169
166170
sage: from sage.rings.complex_mpfr import is_ComplexField as is_CF
@@ -171,8 +175,11 @@ def isinstance(x, sage.rings.abc.ComplexField):
171175
sage: is_CF(CC)
172176
True
173177
"""
178+
from sage.misc.superseded import deprecation
179+
deprecation(32610, 'is_ComplexField is deprecated; use isinstance(..., sage.rings.abc.ComplexField) instead')
174180
return isinstance(x, ComplexField_class)
175181

182+
176183
cache = {}
177184
def ComplexField(prec=53, names=None):
178185
"""
@@ -543,7 +550,7 @@ class ComplexField_class(ring.Field):
543550
RR = self._real_field()
544551
if RR.has_coerce_map_from(S):
545552
return RRtoCC(RR, self) * RR._internal_coerce_map_from(S)
546-
if isinstance(S, sage.rings.abc.ComplexField):
553+
if isinstance(S, ComplexField_class):
547554
if self._prec <= S._prec:
548555
return self._generic_coerce_map(S)
549556
else:

src/sage/rings/real_double.pyx

+9-3
Original file line numberDiff line numberDiff line change
@@ -73,20 +73,26 @@ from sage.arith.constants cimport *
7373
cimport gmpy2
7474

7575

76-
def isinstance(x, sage.rings.abc.RealDoubleField):
76+
def is_RealDoubleField(x):
7777
"""
7878
Returns ``True`` if ``x`` is the field of real double precision numbers.
7979
80+
This function is deprecated. Use :func:`isinstance` with
81+
:class:`~sage.rings.abc.RealDoubleField` instead.
82+
8083
EXAMPLES::
8184
8285
sage: from sage.rings.real_double import is_RealDoubleField
83-
sage: isinstance(RDF, sage.rings.abc.RealDoubleField)
86+
sage: is_RealDoubleField(RDF)
8487
True
85-
sage: isinstance(RealField(53, sage.rings.abc.RealDoubleField))
88+
sage: is_RealDoubleField(RealField(53))
8689
False
8790
"""
91+
from sage.misc.superseded import deprecation
92+
deprecation(32610, 'is_RealDoubleField is deprecated; use isinstance(..., sage.rings.abc.RealDoubleField) instead')
8893
return isinstance(x, RealDoubleField_class)
8994

95+
9096
cdef class RealDoubleField_class(Field):
9197
"""
9298
An approximation to the field of real numbers using double

src/sage/rings/real_mpfr.pyx

+9-3
Original file line numberDiff line numberDiff line change
@@ -5896,19 +5896,25 @@ def create_RealNumber(s, int base=10, int pad=0, rnd="RNDN", int min_prec=53):
58965896
return RealLiteral(R, s, base)
58975897

58985898

5899-
def isinstance(x, sage.rings.abc.RealField):
5899+
def is_RealField(x):
59005900
"""
59015901
Returns ``True`` if ``x`` is technically of a Python real field type.
59025902
5903+
This function is deprecated. Use :func:`isinstance` with
5904+
:class:`~sage.rings.abc.RealField` instead.
5905+
59035906
EXAMPLES::
59045907
5905-
sage: sage.rings.real_mpfr.isinstance(RR, sage.rings.abc.RealField)
5908+
sage: sage.rings.real_mpfr.is_RealField(RR)
59065909
True
5907-
sage: sage.rings.real_mpfr.isinstance(CC, sage.rings.abc.RealField)
5910+
sage: sage.rings.real_mpfr.is_RealField(CC)
59085911
False
59095912
"""
5913+
from sage.misc.superseded import deprecation
5914+
deprecation(32610, 'is_RealField is deprecated; use isinstance(..., sage.rings.abc.RealField) instead')
59105915
return isinstance(x, RealField_class)
59115916

5917+
59125918
def is_RealNumber(x):
59135919
"""
59145920
Return ``True`` if ``x`` is of type :class:`RealNumber`, meaning that it

0 commit comments

Comments
 (0)