Skip to content
This repository was archived by the owner on Jan 30, 2023. It is now read-only.

Commit 8952684

Browse files
saraedumslel
authored andcommitted
Do not pretend to build Python 2 docker images
we are not actually building these anymore so we should not try to build everything twice.
1 parent ddaba54 commit 8952684

File tree

3 files changed

+6
-42
lines changed

3 files changed

+6
-42
lines changed

.ci/push-dockerhub.sh

+4
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,8 @@ if [ -z "$DOCKER_USER" -o -z "$SECRET_DOCKER_PASS" ]; then
2626
else
2727
cat "$SECRET_DOCKER_PASS" | docker login -u $DOCKER_USER --password-stdin
2828
docker push ${DOCKER_NAMESPACE:-sagemath}/$1:$DOCKER_TAG
29+
30+
# For historic reasons, we also provide a -py3 tag. It's identical to the non-py3 tag.
31+
docker tag ${DOCKER_NAMESPACE:-sagemath}/$1:$DOCKER_TAG ${DOCKER_NAMESPACE:-sagemath}/$1:$DOCKER_TAG-py3
32+
docker push ${DOCKER_NAMESPACE:-sagemath}/$1:$DOCKER_TAG-py3
2933
fi

.gitlab-ci.yml

-40
Original file line numberDiff line numberDiff line change
@@ -193,43 +193,3 @@ push-dockerhub-dev:
193193
script:
194194
- . .ci/pull-gitlab.sh sagemath-dev
195195
- sh .ci/push-dockerhub.sh sagemath-dev
196-
197-
.py3:
198-
variables:
199-
WITH_PYTHON: 3
200-
DEFAULT_ARTIFACT_BASE: sagemath/sagemath-dev:develop-py3
201-
202-
build-from-latest-py3:
203-
extends:
204-
- build-from-latest
205-
- .py3
206-
207-
build-from-clean-py3:
208-
extends:
209-
- build-from-clean
210-
- .py3
211-
212-
test-dev-py3:
213-
extends:
214-
- test-dev
215-
- .py3
216-
217-
test-cli-py3:
218-
extends:
219-
- test-cli
220-
- .py3
221-
222-
test-jupyter-py3:
223-
extends:
224-
- test-jupyter
225-
- .py3
226-
227-
push-dockerhub-py3:
228-
extends:
229-
- push-dockerhub
230-
- .py3
231-
232-
push-dockerhub-dev-py3:
233-
extends:
234-
- push-dockerhub-dev
235-
- .py3

docker/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
[![License: GPL v3](https://img.shields.io/badge/License-GPL%20v3-blue.svg)](https://github.com/sagemath/sage/COPYING.txt) [![Maintained](https://img.shields.io/maintenance/yes/2020.svg)](https://github.com/sagemath/sage/commits/master)
1+
[![License: GPL v3](https://img.shields.io/badge/License-GPL%20v3-blue.svg)](https://github.com/sagemath/sage/COPYING.txt)
22

33
# Supported tags
44

55
* `latest` — the stable `master` branch [![GitHub last commit (branch)](https://img.shields.io/github/last-commit/sagemath/sage/master.svg)](https://github.com/sagemath/sage/commits/master) [![GitLab CI](https://gitlab.com/sagemath/sage/badges/master/pipeline.svg)](https://gitlab.com/sagemath/sage/commits/master)
66
* `x.x` — all stable releases of Sage are tagged with their version number.
77
* `x.x.{beta,rc}x` - betas and release candidates of Sage as [tagged in our git repository](https://github.com/sagemath/sage/tags).
88
* `develop` — the current development version of Sage which gets merged into the `master` branch when a new version of Sage is released [![GitHub last commit (branch)](https://img.shields.io/github/last-commit/sagemath/sage/develop.svg)](https://github.com/sagemath/sage/commits/develop) [![GitLab CI](https://gitlab.com/sagemath/sage/badges/develop/pipeline.svg)](https://gitlab.com/sagemath/sage/commits/develop)
9-
* all the above tags can be complemented by `-py3` for Python 3 based images
9+
* `-py3` - in the past, we distinguished Python 2 and Python 3 builds. Now, since 9.1, we only provide Python 3 based images so the `-py3` suffix is only there for historic reasons.
1010

1111
# What is SageMath
1212

0 commit comments

Comments
 (0)