fix E251 in groups

Author: fchapoton

src/sage/groups/additive_abelian/additive_abelian_group.py

@@ -11,7 +11,8 @@
 from sage.modules.fg_pid.fgp_element import FGP_Element
 from sage.rings.integer_ring import ZZ
 
-def AdditiveAbelianGroup(invs, remember_generators = True):
+
+def AdditiveAbelianGroup(invs, remember_generators=True):
     r"""
     Construct a finitely-generated additive abelian group.
 

src/sage/groups/additive_abelian/additive_abelian_wrapper.py

@@ -465,7 +465,7 @@ def _element_constructor_(self, x, check=False):
             (6, 2)
         """
         if parent(x) is self.universe():
-            return self.element_class(self, self.discrete_log(x), element = x)
+            return self.element_class(self, self.discrete_log(x), element=x)
         return addgp.AdditiveAbelianGroup_fixed_gens._element_constructor_(self, x, check)
 
 

src/sage/groups/cubic_braid.py

@@ -194,7 +194,8 @@ def AssionGroupS(n=None, names='s'):
         sage: S3 == S3x
         True
     """
-    return CubicBraidGroup(n = n, names = names, cbg_type=CubicBraidGroup.type.AssionS)
+    return CubicBraidGroup(n=n, names=names,
+                           cbg_type=CubicBraidGroup.type.AssionS)
 
 
 def AssionGroupU(n=None, names='u'):
@@ -222,9 +223,9 @@ def AssionGroupU(n=None, names='u'):
         Assion group on 3 strands of type U
         sage: U3 == U3x
         True
-
     """
-    return CubicBraidGroup(n = n, names = names, cbg_type=CubicBraidGroup.type.AssionU)
+    return CubicBraidGroup(n=n, names=names,
+                           cbg_type=CubicBraidGroup.type.AssionU)
 
 
 
@@ -367,9 +368,9 @@ class :class:`Braid`.
         braid_group = self.parent().braid_group()
         return braid_group(self)
 
-
     @cached_method
-    def burau_matrix(self, root_bur = None, domain = None, characteristic = None, var='t', reduced=False):
+    def burau_matrix(self, root_bur=None, domain=None, characteristic=None,
+                     var='t', reduced=False):
         r"""
         Return the Burau matrix of the cubic braid coset.
 
@@ -2022,10 +2023,10 @@ def is_finite(self):
         from sage.rings.infinity import infinity
         return not self.order() is infinity
 
-    # ----------------------------------------------------------------------------------
+    # ------------------------------------------------------------------
     # creating a CubicBraidGroup as subgroup of self on less strands
-    # ----------------------------------------------------------------------------------
-    def cubic_braid_subgroup(self, nstrands = None):
+    # ------------------------------------------------------------------
+    def cubic_braid_subgroup(self, nstrands=None):
         r"""
         Creates a cubic braid group as subgroup of ``self`` on the first ``nstrands`` strands.
 

src/sage/groups/finitely_presented.py

@@ -1486,7 +1486,7 @@ def epimorphisms(self, H):
             res.append(fhom)
         return res
 
-    def alexander_matrix(self, im_gens = None):
+    def alexander_matrix(self, im_gens=None):
         """
         Return the Alexander matrix of the group.
 

src/sage/groups/old.pyx

@@ -31,7 +31,7 @@ cdef class Group(sage.structure.parent.Parent):
     """
     Generic group class
     """
-    def __init__(self, category = None):
+    def __init__(self, category=None):
         """
 
         TESTS::

src/sage/groups/perm_gps/cubegroup.py

@@ -944,7 +944,7 @@ def repr2d(self, mv):
         line13 = "             +--------------+\n"
         return line1+line2+line3+line4+line5+line6+line7+line8+line9+line10+line11+line12+line13
 
-    def plot_cube(self, mv, title=True, colors = [lpurple, yellow, red, green, orange, blue]):
+    def plot_cube(self, mv, title=True, colors=[lpurple, yellow, red, green, orange, blue]):
         r"""
         Input the move mv, as a string in the Singmaster notation, and
         output the 2D plot of the cube in that state.

src/sage/groups/perm_gps/partn_ref/refinement_graphs.pyx

@@ -1257,8 +1257,9 @@ cdef void free_dg_edge_gen(iterator *dg_edge_gen):
     sig_free(dg_edge_gen)
 
 
-def generate_dense_graphs_edge_addition(int n, bint loops, G = None, depth = None, bint construct = False,
-    bint indicate_mem_err = True):
+def generate_dense_graphs_edge_addition(int n, bint loops, G=None, depth=None,
+                                        bint construct=False,
+                                        bint indicate_mem_err=True):
     r"""
 
     EXAMPLES::
@@ -1534,7 +1535,10 @@ cdef void free_cgd_2(void *data):
     cdef canonical_generator_data *cgd = <canonical_generator_data *> data
     deallocate_cgd(cgd)
 
-def generate_dense_graphs_vert_addition(int n, base_G = None, bint construct = False, bint indicate_mem_err = True):
+
+def generate_dense_graphs_vert_addition(int n, base_G=None,
+                                        bint construct=False,
+                                        bint indicate_mem_err=True):
     r"""
 
     EXAMPLES::

src/sage/groups/perm_gps/partn_ref/refinement_sets.pyx

@@ -685,7 +685,9 @@ cdef iterator *setup_set_gen(iterator *subset_gen, int degree, int max_size):
         bitset_clear(&empty_set.bits)
     return subset_iterator
 
-def sets_modulo_perm_group(list generators, int max_size, bint indicate_mem_err = 1):
+
+def sets_modulo_perm_group(list generators, int max_size,
+                           bint indicate_mem_err=1):
     r"""
     Given generators of a permutation group, list subsets up to permutations in
     the group.

src/sage/groups/perm_gps/partn_ref2/refinement_generic.pyx

@@ -639,7 +639,7 @@ cdef class PartitionRefinement_generic:
         self._backtrack(True)
         self._finish_latex()
 
-    cdef void _backtrack(self, bint first_step = False):
+    cdef void _backtrack(self, bint first_step=False):
         r"""
         Backtracking with pruning.
 

src/sage/groups/perm_gps/permgroup.py

@@ -2781,7 +2781,7 @@ def semidirect_product(self, N, mapping, check=True):
             from sage.categories.finite_permutation_groups import FinitePermutationGroups
             if N not in FinitePermutationGroups():
                 raise TypeError("{0} is not a permutation group".format(N))
-            if not PermutationGroup(gens = mapping[0]) == self:
+            if not PermutationGroup(gens=mapping[0]) == self:
                 msg = 'the generator list must generate the calling group, {0} does not generate {1}'
                 raise ValueError(msg.format(mapping[0], self._repr_()))
             if len(mapping[0]) != len(mapping[1]):
@@ -3159,7 +3159,7 @@ def commutator(self, other=None):
             return PermutationGroup(gap_group=gap_group)
 
     @hap_decorator
-    def cohomology(self, n, p = 0):
+    def cohomology(self, n, p=0):
         r"""
         Computes the group cohomology `H^n(G, F)`, where `F = \ZZ`
         if `p=0` and `F = \ZZ / p \ZZ` if `p > 0` is a prime.
@@ -3208,7 +3208,7 @@ def cohomology(self, n, p = 0):
         return AbelianGroup(len(L), L)
 
     @hap_decorator
-    def cohomology_part(self, n, p = 0):
+    def cohomology_part(self, n, p=0):
         r"""
         Compute the p-part of the group cohomology `H^n(G, F)`,
         where `F = \ZZ` if `p=0` and `F = \ZZ / p \ZZ` if
@@ -3244,7 +3244,7 @@ def cohomology_part(self, n, p = 0):
             return AbelianGroup(len(L), L)
 
     @hap_decorator
-    def homology(self, n, p = 0):
+    def homology(self, n, p=0):
         r"""
         Computes the group homology `H_n(G, F)`, where
         `F = \ZZ` if `p=0` and `F = \ZZ / p \ZZ` if
@@ -3292,7 +3292,7 @@ def homology(self, n, p = 0):
         return AbelianGroup(len(L), L)
 
     @hap_decorator
-    def homology_part(self, n, p = 0):
+    def homology_part(self, n, p=0):
         r"""
         Computes the `p`-part of the group homology
         `H_n(G, F)`, where `F = \ZZ` if `p=0` and
@@ -3616,7 +3616,7 @@ def _regular_subgroup_gap(self):
         return C
 
     @cached_method
-    def has_regular_subgroup(self, return_group = False):
+    def has_regular_subgroup(self, return_group=False):
         r"""
         Return whether the group contains a regular subgroup.
 
@@ -3656,12 +3656,10 @@ def has_regular_subgroup(self, return_group = False):
                 b = (C is not None)
                 if b and return_group:
                     G = self.subgroup(gap_group=C.Representative())
-        if return_group:
-            return G
-        else:
-            return b
 
-    def blocks_all(self, representatives = True):
+        return G if return_group else b
+
+    def blocks_all(self, representatives=True):
         r"""
         Return the list of block systems of imprimitivity.
 

src/sage/groups/perm_gps/permgroup_element.pyx

@@ -1849,14 +1849,14 @@ cdef class PermutationGroupElement(MultiplicativeGroupElement):
             [2, 1, 1]
         """
         cycle_type = [len(c) for c in self.cycle_tuples(singletons)]
-        cycle_type.sort(reverse = True)
+        cycle_type.sort(reverse=True)
         if as_list:
             return cycle_type
         else:
             from sage.combinat.partition import _Partitions
             return _Partitions(cycle_type)
 
-    def has_descent(self, i, side = "right", positive = False):
+    def has_descent(self, i, side="right", positive=False):
         """
         INPUT: