Skip to content
This repository was archived by the owner on Jan 30, 2023. It is now read-only.

Commit fc75734

Browse files
committed
Use implementation="singular" instead of using 1 variable to force a Singular polynomial ring
1 parent dfb59b3 commit fc75734

File tree

7 files changed

+15
-17
lines changed

7 files changed

+15
-17
lines changed

src/sage/interfaces/singular.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -1640,13 +1640,13 @@ def sage_poly(self, R=None, kcache=None):
16401640
16411641
EXAMPLES::
16421642
1643-
sage: R = PolynomialRing(GF(2^8,'a'),2,'xy')
1644-
sage: f=R('a^20*x^2*y+a^10+x')
1645-
sage: f._singular_().sage_poly(R)==f
1643+
sage: R = PolynomialRing(GF(2^8,'a'), 'x,y')
1644+
sage: f = R('a^20*x^2*y+a^10+x')
1645+
sage: f._singular_().sage_poly(R) == f
16461646
True
1647-
sage: R = PolynomialRing(GF(2^8,'a'),1,'x')
1648-
sage: f=R('a^20*x^3+x^2+a^10')
1649-
sage: f._singular_().sage_poly(R)==f
1647+
sage: R = PolynomialRing(GF(2^8,'a'), 'x', implementation="singular")
1648+
sage: f = R('a^20*x^3+x^2+a^10')
1649+
sage: f._singular_().sage_poly(R) == f
16501650
True
16511651
16521652
::

src/sage/libs/singular/function.pyx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1317,7 +1317,7 @@ cdef class SingularFunction(SageObject):
13171317
if ring is None:
13181318
if dummy_ring is None:
13191319
from sage.all import QQ, PolynomialRing
1320-
dummy_ring = PolynomialRing(QQ,"dummy",1) # seems a reasonable default
1320+
dummy_ring = PolynomialRing(QQ, "dummy", implementation="singular") # seems a reasonable default
13211321
ring = dummy_ring
13221322
if not (isinstance(ring, MPolynomialRing_libsingular) or isinstance(ring, NCPolynomialRing_plural)):
13231323
raise TypeError("Cannot call Singular function '%s' with ring parameter of type '%s'"%(self._name,type(ring)))

src/sage/rings/ideal.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1659,7 +1659,7 @@ def Katsura(R, n=None, homog=False, singular=singular_default):
16591659
16601660
::
16611661
1662-
sage: Q.<x> = PolynomialRing(QQ,1)
1662+
sage: Q.<x> = PolynomialRing(QQ, implementation="singular")
16631663
sage: J = sage.rings.ideal.Katsura(Q,1); J
16641664
Ideal (x - 1) of Multivariate Polynomial Ring in x over Rational Field
16651665
"""

src/sage/rings/polynomial/multi_polynomial_libsingular.pyx

+2-2
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ TESTS::
137137
sage: loads(dumps(x)) == x
138138
True
139139
140-
sage: Rt.<t> = PolynomialRing(QQ,1)
140+
sage: Rt.<t> = PolynomialRing(QQ, implementation="singular")
141141
sage: p = 1+t
142142
sage: R.<u,v> = PolynomialRing(QQ, 2)
143143
sage: p(u/v)
@@ -3038,7 +3038,7 @@ cdef class MPolynomial_libsingular(MPolynomial):
30383038
sage: f[0,1]
30393039
0
30403040
3041-
sage: R.<x> = PolynomialRing(GF(7),1); R
3041+
sage: R.<x> = PolynomialRing(GF(7), implementation="singular"); R
30423042
Multivariate Polynomial Ring in x over Finite Field of size 7
30433043
sage: f = 5*x^2 + 3; f
30443044
-2*x^2 + 3

src/sage/rings/polynomial/plural.pyx

+1-1
Original file line numberDiff line numberDiff line change
@@ -2227,7 +2227,7 @@ cdef class NCPolynomial_plural(RingElement):
22272227
sage: f[0,0,0]
22282228
0
22292229
2230-
sage: R.<x> = PolynomialRing(GF(7),1); R
2230+
sage: R.<x> = PolynomialRing(GF(7), implementation="singular"); R
22312231
Multivariate Polynomial Ring in x over Finite Field of size 7
22322232
sage: f = 5*x^2 + 3; f
22332233
-2*x^2 + 3

src/sage/rings/polynomial/polynomial_ring.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@
120120
121121
Check that :trac:`5562` has been fixed::
122122
123-
sage: R.<u> = PolynomialRing(RDF, 1, 'u')
123+
sage: R.<u> = PolynomialRing(RDF, 1)
124124
sage: v1 = vector([u])
125125
sage: v2 = vector([CDF(2)])
126126
sage: v1 * v2
@@ -210,9 +210,7 @@ def is_PolynomialRing(x):
210210
211211
::
212212
213-
sage: is_PolynomialRing(PolynomialRing(ZZ,1,'w'))
214-
False
215-
sage: R = PolynomialRing(ZZ,1,'w'); R
213+
sage: R.<w> = PolynomialRing(ZZ, implementation="singular"); R
216214
Multivariate Polynomial Ring in w over Integer Ring
217215
sage: is_PolynomialRing(R)
218216
False

src/sage/rings/polynomial/polynomial_singular_interface.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ def _singular_(self, singular=singular):
105105
// : names x
106106
// block 2 : ordering C
107107
108-
sage: R = PolynomialRing(GF(127),1,'x')
108+
sage: R = PolynomialRing(GF(127), 'x', implementation="singular")
109109
sage: singular(R)
110110
polynomial ring, over a field, global ordering
111111
// coefficients: ZZ/127
@@ -114,7 +114,7 @@ def _singular_(self, singular=singular):
114114
// : names x
115115
// block 2 : ordering C
116116
117-
sage: R = PolynomialRing(QQ,1,'x')
117+
sage: R = PolynomialRing(QQ, 'x', implementation="singular")
118118
sage: singular(R)
119119
polynomial ring, over a field, global ordering
120120
// coefficients: QQ

0 commit comments

Comments
 (0)