archive/issues_019773.json:
{
"assignees": [],
"body": "<div id=\"comment:0\"></div>\n\nIn #19127, the automatic deleting of empty directories was removed, because of the mistaken assumption that it was not needed. While it's not needed in all cases, it is needed in one case:\n\nit can happen that `git checkout` leaves behind an empty directory (since it does not track directories), for example `src/doc/en/reference/manifolds`. These directories should be deleted, otherwise Sphinx complains.\n\nCC: @hivert @mezzarobba\n\nComponent: **build**\n\nAuthor: **Jeroen Demeyer**\n\nBranch/Commit: **[`cabdf45`](https://github.com/sagemath/sagetrac-mirror/commit/cabdf45dcc77c8732a13cf325a1c42293d10daae)**\n\nReviewer: **John Palmieri**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20010_\n\n",
"closed_at": "2016-02-20T11:57:42Z",
"created_at": "2016-02-04T21:45:45Z",
"labels": [
"https://github.com/sagemath/sage/labels/c%3A%20build",
"https://github.com/sagemath/sage/labels/p%3A%20blocker%20/%201",
"https://github.com/sagemath/sage/labels/bug"
],
"milestone": "https://github.com/sagemath/sage/milestones/sage-7.1",
"reactions": [],
"repository": "https://github.com/sagemath/sage",
"title": "Delete empty directories in $SAGE_DOC",
"type": "issue",
"updated_at": "2016-02-20T11:57:42Z",
"url": "https://github.com/sagemath/sage/issues/20010",
"user": "https://github.com/jdemeyer"
}
In #19127, the automatic deleting of empty directories was removed, because of the mistaken assumption that it was not needed. While it's not needed in all cases, it is needed in one case:
it can happen that git checkout
leaves behind an empty directory (since it does not track directories), for example src/doc/en/reference/manifolds
. These directories should be deleted, otherwise Sphinx complains.
CC: @hivert @mezzarobba
Component: build
Author: Jeroen Demeyer
Branch/Commit: cabdf45
Reviewer: John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/20010
archive/issue_events_280186.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-02-04T21:45:45Z",
"event": "milestoned",
"issue": "https://github.com/sagemath/sage/issues/20010",
"milestone_number": null,
"milestone_title": "sage-7.1",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20010#event-280186"
}
archive/issue_events_280187.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-02-04T21:45:45Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20010",
"label": "https://github.com/sagemath/sage/labels/c%3A%20build",
"label_color": "0000b0",
"label_name": "c: build",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20010#event-280187"
}
archive/issue_events_280188.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-02-04T21:45:45Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20010",
"label": "https://github.com/sagemath/sage/labels/p%3A%20blocker%20/%201",
"label_color": "ff0000",
"label_name": "p: blocker / 1",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20010#event-280188"
}
archive/issue_events_280189.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-02-04T21:45:45Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20010",
"label": "https://github.com/sagemath/sage/labels/bug",
"label_color": "d73a4a",
"label_name": "bug",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20010#event-280189"
}
archive/issue_comments_286571.json:
{
"body": "Dependencies: **#19127**",
"created_at": "2016-02-04T22:02:37Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20010",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20010#issuecomment-286571",
"user": "https://github.com/jdemeyer"
}
Dependencies: #19127
archive/issue_comments_286572.json:
{
"body": "Author: **Jeroen Demeyer**",
"created_at": "2016-02-04T22:02:37Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20010",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20010#issuecomment-286572",
"user": "https://github.com/jdemeyer"
}
Author: Jeroen Demeyer
archive/issue_comments_286573.json:
{
"body": "Branch: **[u/jdemeyer/delete_empty_directories_in__sage_doc](https://github.com/sagemath/sagetrac-mirror/tree/u/jdemeyer/delete_empty_directories_in__sage_doc)**",
"created_at": "2016-02-05T08:52:33Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20010",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20010#issuecomment-286573",
"user": "https://github.com/jdemeyer"
}
Branch: u/jdemeyer/delete_empty_directories_in__sage_doc
archive/issue_events_280190.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-02-05T10:02:35Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20010",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20010#event-280190"
}
archive/issue_comments_286574.json:
{
"body": "<div id=\"comment:3\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/cabdf45dcc77c8732a13cf325a1c42293d10daae\"><code>cabdf45</code></a></td><td><code>Delete empty directories in $SAGE_DOC before running Sphinx</code></td></tr></table>\n",
"created_at": "2016-02-05T10:02:35Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20010",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20010#issuecomment-286574",
"user": "https://github.com/jdemeyer"
}
New commits:
cabdf45 | Delete empty directories in $SAGE_DOC before running Sphinx |
archive/issue_comments_286575.json:
{
"body": "Commit: **[`cabdf45`](https://github.com/sagemath/sagetrac-mirror/commit/cabdf45dcc77c8732a13cf325a1c42293d10daae)**",
"created_at": "2016-02-05T10:02:35Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20010",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20010#issuecomment-286575",
"user": "https://github.com/jdemeyer"
}
Commit: cabdf45
archive/issue_comments_286576.json:
{
"body": "Changed dependencies from **#19127** to none",
"created_at": "2016-02-19T12:53:00Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20010",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20010#issuecomment-286576",
"user": "https://github.com/jdemeyer"
}
Changed dependencies from #19127 to none
archive/issue_comments_286577.json:
{
"body": "Description changed:\n``````diff\n--- \n+++ \n@@ -1,3 +1,3 @@\n In #19127, the automatic deleting of empty directories was removed, because of the mistaken assumption that it was not needed. While it's not needed in all cases, it is needed in one case:\n \n-it can happen that `git checkout` leaves behind an empty directory (since it does not track directories), for example `$SAGE_DOC/en/reference/manifolds`. These directories should be deleted, otherwise Sphinx complains.\n+it can happen that `git checkout` leaves behind an empty directory (since it does not track directories), for example `src/doc/en/reference/manifolds`. These directories should be deleted, otherwise Sphinx complains.\n``````\n",
"created_at": "2016-02-19T12:53:00Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20010",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20010#issuecomment-286577",
"user": "https://github.com/jdemeyer"
}
Description changed:
---
+++
@@ -1,3 +1,3 @@
In #19127, the automatic deleting of empty directories was removed, because of the mistaken assumption that it was not needed. While it's not needed in all cases, it is needed in one case:
-it can happen that `git checkout` leaves behind an empty directory (since it does not track directories), for example `$SAGE_DOC/en/reference/manifolds`. These directories should be deleted, otherwise Sphinx complains.
+it can happen that `git checkout` leaves behind an empty directory (since it does not track directories), for example `src/doc/en/reference/manifolds`. These directories should be deleted, otherwise Sphinx complains.
archive/issue_comments_286578.json:
{
"body": "<div id=\"comment:5\" align=\"right\">comment:5</div>\n\nLooks good. With previous versions of docbuilding, there were many empty directories and so I objected to printing out the message `Deleting empty directory ...` for each one. With this version, we should usually have just a few empty directories, if any, so it's fine to print it.",
"created_at": "2016-02-19T16:50:15Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20010",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20010#issuecomment-286578",
"user": "https://github.com/jhpalmieri"
}
Looks good. With previous versions of docbuilding, there were many empty directories and so I objected to printing out the message Deleting empty directory ...
for each one. With this version, we should usually have just a few empty directories, if any, so it's fine to print it.
archive/issue_comments_286579.json:
{
"body": "Reviewer: **John Palmieri**",
"created_at": "2016-02-19T16:50:15Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20010",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20010#issuecomment-286579",
"user": "https://github.com/jhpalmieri"
}
Reviewer: John Palmieri
archive/issue_events_280191.json:
{
"actor": "https://github.com/jhpalmieri",
"created_at": "2016-02-19T16:50:15Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20010",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20010#event-280191"
}
archive/issue_events_280192.json:
{
"actor": "https://github.com/jhpalmieri",
"created_at": "2016-02-19T16:50:15Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20010",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20010#event-280192"
}
archive/issue_comments_286580.json:
{
"body": "Changed branch from **[u/jdemeyer/delete_empty_directories_in__sage_doc](https://github.com/sagemath/sagetrac-mirror/tree/u/jdemeyer/delete_empty_directories_in__sage_doc)** to **[`cabdf45`](https://github.com/sagemath/sagetrac-mirror/commit/cabdf45dcc77c8732a13cf325a1c42293d10daae)**",
"created_at": "2016-02-20T11:57:42Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20010",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20010#issuecomment-286580",
"user": "https://github.com/vbraun"
}
Changed branch from u/jdemeyer/delete_empty_directories_in__sage_doc to cabdf45
archive/issue_events_280193.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-02-20T11:57:42Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20010",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20010#event-280193"
}
archive/issue_events_280194.json:
{
"actor": "https://github.com/vbraun",
"commit_id": "68858a4cc335bc3676173825228b54a6211ee94e",
"commit_repository": "https://github.com/sagemath/sage",
"created_at": "2016-02-20T11:57:42Z",
"event": "closed",
"issue": "https://github.com/sagemath/sage/issues/20010",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20010#event-280194"
}