Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Latest commit

 

History

History
962 lines (734 loc) · 33.5 KB

20099.md

File metadata and controls

962 lines (734 loc) · 33.5 KB

Issue 20099: test improved evaluation of trigonometric functions and complex exponential function

archive/issues_019862.json:

{
    "assignees": [],
    "body": "<div id=\"comment:0\"></div>\n\nIn the current [development version of pynac](https://github.com/pynac/pynac) the evaluation of trigonometric functions has been improved. This enables the following behavior:\n\n```\nsage: var('k', domain='integer')\nk\nsage: sin(k*pi)\n0\nsage: cos(k*pi)\n(-1)^k\nsage: sin(1 + 2*k*pi)\nsin(1)\nsage: tan(k*pi)\n0\nsage: cos(2*k*pi + pi/3)\n1/2\n```\nand so on. Additionally, this introduces simplification for the complex exponential function:\n\n```\nsage: exp(2*k*pi*I)\nsage: 1\n```\nThis ticket shall document these changes.\n\nDepends on #20134\n\nCC:  @rwst\n\nComponent: **symbolics**\n\nKeywords: **pynac**\n\nAuthor: **Benjamin Hackl**\n\nBranch/Commit: **[`edec004`](https://github.com/sagemath/sagetrac-mirror/commit/edec0041a0ef6df6df2acba2f20caea1b043178f)**\n\nReviewer: **Ralf Stephan, Julian R\u00fcth, Travis Scrimshaw**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20099_\n\n",
    "closed_at": "2017-05-21T21:51:47Z",
    "created_at": "2016-02-23T09:11:28Z",
    "labels": [
        "https://github.com/sagemath/sage/labels/c%3A%20symbolics",
        "https://github.com/sagemath/sage/labels/p%3A%20minor%20/%204",
        "https://github.com/sagemath/sage/labels/enhancement"
    ],
    "milestone": "https://github.com/sagemath/sage/milestones/sage-8.0",
    "reactions": [],
    "repository": "https://github.com/sagemath/sage",
    "title": "test improved evaluation of trigonometric functions and complex exponential function",
    "type": "issue",
    "updated_at": "2017-05-21T21:51:47Z",
    "url": "https://github.com/sagemath/sage/issues/20099",
    "user": "https://github.com/behackl"
}

In the current development version of pynac the evaluation of trigonometric functions has been improved. This enables the following behavior:

sage: var('k', domain='integer')
k
sage: sin(k*pi)
0
sage: cos(k*pi)
(-1)^k
sage: sin(1 + 2*k*pi)
sin(1)
sage: tan(k*pi)
0
sage: cos(2*k*pi + pi/3)
1/2

and so on. Additionally, this introduces simplification for the complex exponential function:

sage: exp(2*k*pi*I)
sage: 1

This ticket shall document these changes.

Depends on #20134

CC: @rwst

Component: symbolics

Keywords: pynac

Author: Benjamin Hackl

Branch/Commit: edec004

Reviewer: Ralf Stephan, Julian Rüth, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20099


archive/issue_events_281342.json:

{
    "actor": "https://github.com/behackl",
    "created_at": "2016-02-23T09:11:28Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "milestone_number": null,
    "milestone_title": "sage-7.1",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281342"
}

archive/issue_events_281343.json:

{
    "actor": "https://github.com/behackl",
    "created_at": "2016-02-23T09:11:28Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/c%3A%20symbolics",
    "label_color": "0000ff",
    "label_name": "c: symbolics",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281343"
}

archive/issue_events_281344.json:

{
    "actor": "https://github.com/behackl",
    "created_at": "2016-02-23T09:11:28Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/p%3A%20minor%20/%204",
    "label_color": "ffe799",
    "label_name": "p: minor / 4",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281344"
}

archive/issue_events_281345.json:

{
    "actor": "https://github.com/behackl",
    "created_at": "2016-02-23T09:11:28Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/enhancement",
    "label_color": "696969",
    "label_name": "enhancement",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281345"
}

archive/issue_comments_288205.json:

{
    "body": "Changed dependencies from **pynac-0.6.3** to **#20134**",
    "created_at": "2016-03-03T21:42:02Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288205",
    "user": "https://github.com/behackl"
}

Changed dependencies from pynac-0.6.3 to #20134


archive/issue_comments_288206.json:

{
    "body": "Branch: **[u/behackl/symbolic/period-reduction-doctests](https://github.com/sagemath/sagetrac-mirror/tree/u/behackl/symbolic/period-reduction-doctests)**",
    "created_at": "2016-03-03T22:20:20Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288206",
    "user": "https://github.com/behackl"
}

Branch: u/behackl/symbolic/period-reduction-doctests


archive/issue_comments_288207.json:

{
    "body": "<div id=\"comment:2\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/9db23dea0bd39693ad444cd164fd8842ef98b50a\"><code>9db23de</code></a></td><td><code>package version / checksum</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/7785109f7a21e04e3759a144dfbc2bc18dd611aa\"><code>7785109</code></a></td><td><code>coth/acoth BuiltinFunction --> GinacFunction and fixes</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/2fab819852116989ae3676d1a4ff61ecd4adc9b9\"><code>2fab819</code></a></td><td><code>doctest fixes</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/867bd3d983538fad02a597875f0346ffe6f61296\"><code>867bd3d</code></a></td><td><code>doctests for reduction of exp-arguments</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/f868e90c6492e4ee0f46fa238a1544eed18f77a8\"><code>f868e90</code></a></td><td><code>doctests for argument reduction of sin, cos, tan</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/16045ae2a4f0765a879a78be0aa85f4d7451525c\"><code>16045ae</code></a></td><td><code>additional doctest for computation of residues</code></td></tr></table>\n",
    "created_at": "2016-03-03T22:20:20Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288207",
    "user": "https://github.com/behackl"
}

New commits:

9db23depackage version / checksum
7785109coth/acoth BuiltinFunction --> GinacFunction and fixes
2fab819doctest fixes
867bd3ddoctests for reduction of exp-arguments
f868e90doctests for argument reduction of sin, cos, tan
16045aeadditional doctest for computation of residues

archive/issue_comments_288208.json:

{
    "body": "Commit: **[`16045ae`](https://github.com/sagemath/sagetrac-mirror/commit/16045ae2a4f0765a879a78be0aa85f4d7451525c)**",
    "created_at": "2016-03-03T22:20:20Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288208",
    "user": "https://github.com/behackl"
}

Commit: 16045ae


archive/issue_events_281346.json:

{
    "actor": "https://github.com/behackl",
    "created_at": "2016-03-03T22:20:20Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281346"
}

archive/issue_events_281347.json:

{
    "actor": "https://github.com/behackl",
    "created_at": "2016-03-03T22:20:20Z",
    "event": "renamed",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "title_is": "test improved evaluation of trigonometric functions and complex exponential function",
    "title_was": "test improved evaluation of trigonometric functions",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281347"
}

archive/issue_comments_288209.json:

{
    "body": "Reviewer: **Ralf Stephan**",
    "created_at": "2016-03-04T06:38:44Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288209",
    "user": "https://github.com/rwst"
}

Reviewer: Ralf Stephan


archive/issue_comments_288210.json:

{
    "body": "<div id=\"comment:3\" align=\"right\">comment:3</div>\n\nCan be set positive as soon as the dependency is reviewed.",
    "created_at": "2016-03-04T06:38:44Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288210",
    "user": "https://github.com/rwst"
}
comment:3

Can be set positive as soon as the dependency is reviewed.


archive/issue_events_281348.json:

{
    "actor": "https://github.com/rwst",
    "created_at": "2016-03-21T07:33:10Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281348"
}

archive/issue_events_281349.json:

{
    "actor": "https://github.com/rwst",
    "created_at": "2016-03-21T07:33:10Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281349"
}

archive/issue_events_281350.json:

{
    "actor": "https://github.com/rwst",
    "created_at": "2016-03-21T07:33:28Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281350"
}

archive/issue_events_281351.json:

{
    "actor": "https://github.com/rwst",
    "created_at": "2016-03-21T07:33:28Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281351"
}

archive/issue_comments_288211.json:

{
    "body": "<div id=\"comment:6\" align=\"right\">comment:6</div>\n\nNeeds merge.",
    "created_at": "2016-03-25T13:50:50Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288211",
    "user": "https://github.com/rwst"
}
comment:6

Needs merge.


archive/issue_events_281352.json:

{
    "actor": "https://github.com/rwst",
    "created_at": "2016-03-25T13:50:50Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281352"
}

archive/issue_events_281353.json:

{
    "actor": "https://github.com/rwst",
    "created_at": "2016-03-25T13:50:50Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281353"
}

archive/issue_comments_288212.json:

{
    "body": "Changed commit from **[`16045ae`](https://github.com/sagemath/sagetrac-mirror/commit/16045ae2a4f0765a879a78be0aa85f4d7451525c)** to **[`871c4c9`](https://github.com/sagemath/sagetrac-mirror/commit/871c4c936410352ea5124df8f78013dd1c19a753)**",
    "created_at": "2016-03-29T00:00:33Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288212",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 16045ae to 871c4c9


archive/issue_comments_288213.json:

{
    "body": "<div id=\"comment:7\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/871c4c936410352ea5124df8f78013dd1c19a753\"><code>871c4c9</code></a></td><td><code>Merge tag '7.2.beta1' into symbolic/period-reduction-doctests</code></td></tr></table>\n",
    "created_at": "2016-03-29T00:00:33Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288213",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

871c4c9Merge tag '7.2.beta1' into symbolic/period-reduction-doctests

archive/issue_events_281354.json:

{
    "actor": "https://github.com/behackl",
    "created_at": "2016-03-29T00:01:16Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281354"
}

archive/issue_events_281355.json:

{
    "actor": "https://github.com/behackl",
    "created_at": "2016-03-29T00:01:16Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281355"
}

archive/issue_comments_288214.json:

{
    "body": "<div id=\"comment:8\" align=\"right\">comment:8</div>\n\nDone, back to `needs_review`.",
    "created_at": "2016-03-29T00:01:16Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288214",
    "user": "https://github.com/behackl"
}
comment:8

Done, back to needs_review.


archive/issue_comments_288215.json:

{
    "body": "Author: **Benjamin Hackl**",
    "created_at": "2016-04-04T08:57:57Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288215",
    "user": "https://github.com/saraedum"
}

Author: Benjamin Hackl


archive/issue_comments_288216.json:

{
    "body": "<div id=\"comment:10\" align=\"right\">comment:10</div>\n\nI think \"For the sake of simplification, the argument is reduced the period of the complex exponential function\" is missing a \"modulo\" or something like that. Once that is fixed, feel free to set it to positive review yourself.",
    "created_at": "2016-06-08T22:15:19Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288216",
    "user": "https://github.com/saraedum"
}
comment:10

I think "For the sake of simplification, the argument is reduced the period of the complex exponential function" is missing a "modulo" or something like that. Once that is fixed, feel free to set it to positive review yourself.


archive/issue_comments_288217.json:

{
    "body": "Changed reviewer from **Ralf Stephan** to **Ralf Stephan, Julian R\u00fcth**",
    "created_at": "2016-06-08T22:15:43Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288217",
    "user": "https://github.com/saraedum"
}

Changed reviewer from Ralf Stephan to Ralf Stephan, Julian Rüth


archive/issue_events_281356.json:

{
    "actor": "https://github.com/rwst",
    "created_at": "2016-06-09T06:23:39Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281356"
}

archive/issue_events_281357.json:

{
    "actor": "https://github.com/rwst",
    "created_at": "2016-06-09T06:23:39Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281357"
}

archive/issue_comments_288218.json:

{
    "body": "<div id=\"comment:13\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/5b01423f3b027207fd3f0e5ca9064ccac45e6623\"><code>5b01423</code></a></td><td><code>trac 23030  removing bad apply</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/7b4ec6cf444e2f89ae77ea6f6a8670743c47ff18\"><code>7b4ec6c</code></a></td><td><code>Add sys.version_info as \"PYTHON_VERSION\" to cython compile-time environment</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/71b68d22215182fa7700ddb73ecd1bf82fda84f4\"><code>71b68d2</code></a></td><td><code>tract #22305 -- split off del_dictitem_by_exact_value and compile conditionally based on Py2/Py3</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/54d8c2da8ad19e610fe9939b90bc23202c5b5525\"><code>54d8c2d</code></a></td><td><code>Correction: Py3 does provide PyDict_GetItemWithError but Cython doesn't provide it yet</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/5bc719c93a74fafe461d352d5daabb8e5ebf44ba\"><code>5bc719c</code></a></td><td><code>Merge branch 'public/22305' of ssh://trac.sagemath.org:22/sage into test</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/adabef0e6b63bb86cee33bda51a95ad8cfa92527\"><code>adabef0</code></a></td><td><code>Merge branch 'u/behackl/symbolic/period-reduction-doctests' in 8.0.b7</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/e91dda21be86d0db5c00daf9860fed6f6a4e0556\"><code>e91dda2</code></a></td><td><code>trac 20099 details</code></td></tr></table>\n",
    "created_at": "2017-05-20T18:35:12Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288218",
    "user": "https://github.com/fchapoton"
}

New commits:

5b01423trac 23030 removing bad apply
7b4ec6cAdd sys.version_info as "PYTHON_VERSION" to cython compile-time environment
71b68d2tract #22305 -- split off del_dictitem_by_exact_value and compile conditionally based on Py2/Py3
54d8c2dCorrection: Py3 does provide PyDict_GetItemWithError but Cython doesn't provide it yet
5bc719cMerge branch 'public/22305' of ssh://trac.sagemath.org:22/sage into test
adabef0Merge branch 'u/behackl/symbolic/period-reduction-doctests' in 8.0.b7
e91dda2trac 20099 details

archive/issue_comments_288219.json:

{
    "body": "Changed commit from **[`871c4c9`](https://github.com/sagemath/sagetrac-mirror/commit/871c4c936410352ea5124df8f78013dd1c19a753)** to **[`e91dda2`](https://github.com/sagemath/sagetrac-mirror/commit/e91dda21be86d0db5c00daf9860fed6f6a4e0556)**",
    "created_at": "2017-05-20T18:35:12Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288219",
    "user": "https://github.com/fchapoton"
}

Changed commit from 871c4c9 to e91dda2


archive/issue_events_281358.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2017-05-20T18:35:12Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281358"
}

archive/issue_events_281359.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2017-05-20T18:35:12Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281359"
}

archive/issue_comments_288220.json:

{
    "body": "Changed branch from **[u/behackl/symbolic/period-reduction-doctests](https://github.com/sagemath/sagetrac-mirror/tree/u/behackl/symbolic/period-reduction-doctests)** to **[public/20099](https://github.com/sagemath/sagetrac-mirror/tree/public/20099)**",
    "created_at": "2017-05-20T18:35:12Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288220",
    "user": "https://github.com/fchapoton"
}

Changed branch from u/behackl/symbolic/period-reduction-doctests to public/20099


archive/issue_comments_288221.json:

{
    "body": "Changed commit from **[`e91dda2`](https://github.com/sagemath/sagetrac-mirror/commit/e91dda21be86d0db5c00daf9860fed6f6a4e0556)** to **[`edec004`](https://github.com/sagemath/sagetrac-mirror/commit/edec0041a0ef6df6df2acba2f20caea1b043178f)**",
    "created_at": "2017-05-20T18:39:29Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288221",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from e91dda2 to edec004


archive/issue_comments_288222.json:

{
    "body": "<div id=\"comment:14\"></div>\n\nBranch pushed to git repo; I updated commit sha1. This was a forced push. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/6e908397f33868a26aed1c619796b72edda93229\"><code>6e90839</code></a></td><td><code>Merge branch 'u/behackl/symbolic/period-reduction-doctests' in 8.0.b7</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/edec0041a0ef6df6df2acba2f20caea1b043178f\"><code>edec004</code></a></td><td><code>trac 20099 details</code></td></tr></table>\n",
    "created_at": "2017-05-20T18:39:29Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288222",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6e90839Merge branch 'u/behackl/symbolic/period-reduction-doctests' in 8.0.b7
edec004trac 20099 details

archive/issue_events_281360.json:

{
    "actor": "https://github.com/tscrim",
    "created_at": "2017-05-21T01:39:17Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281360"
}

archive/issue_events_281361.json:

{
    "actor": "https://github.com/tscrim",
    "created_at": "2017-05-21T01:39:17Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281361"
}

archive/issue_comments_288223.json:

{
    "body": "<div id=\"comment:15\" align=\"right\">comment:15</div>\n\nLGTM.",
    "created_at": "2017-05-21T01:39:17Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288223",
    "user": "https://github.com/tscrim"
}
comment:15

LGTM.


archive/issue_events_281362.json:

{
    "actor": "https://github.com/tscrim",
    "created_at": "2017-05-21T01:39:17Z",
    "event": "demilestoned",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "milestone_number": null,
    "milestone_title": "sage-7.1",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281362"
}

archive/issue_events_281363.json:

{
    "actor": "https://github.com/tscrim",
    "created_at": "2017-05-21T01:39:17Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "milestone_number": null,
    "milestone_title": "sage-8.0",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281363"
}

archive/issue_comments_288224.json:

{
    "body": "Changed reviewer from **Ralf Stephan, Julian R\u00fcth** to **Ralf Stephan, Julian R\u00fcth, Travis Scrimshaw**",
    "created_at": "2017-05-21T01:39:17Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288224",
    "user": "https://github.com/tscrim"
}

Changed reviewer from Ralf Stephan, Julian Rüth to Ralf Stephan, Julian Rüth, Travis Scrimshaw


archive/issue_events_281364.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2017-05-21T21:51:47Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281364"
}

archive/issue_events_281365.json:

{
    "actor": "https://github.com/vbraun",
    "commit_id": "033128dfd5a641eacc4f27f7ecaa82f0048812d5",
    "commit_repository": "https://github.com/sagemath/sage",
    "created_at": "2017-05-21T21:51:47Z",
    "event": "closed",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20099#event-281365"
}

archive/issue_comments_288225.json:

{
    "body": "Changed branch from **[public/20099](https://github.com/sagemath/sagetrac-mirror/tree/public/20099)** to **[`edec004`](https://github.com/sagemath/sagetrac-mirror/commit/edec0041a0ef6df6df2acba2f20caea1b043178f)**",
    "created_at": "2017-05-21T21:51:47Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20099",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20099#issuecomment-288225",
    "user": "https://github.com/vbraun"
}

Changed branch from public/20099 to edec004