archive/issues_019876.json:
{
"assignees": [],
"body": "<div id=\"comment:0\"></div>\n\nImplementation of method `zero` from `AbstractLinearCode` can be improved by just returning the zero vector of the ambient space of the code.\n\nComponent: **coding theory**\n\nAuthor: **David Lucas**\n\nBranch/Commit: **[`806642e`](https://github.com/sagemath/sagetrac-mirror/commit/806642e6eb32d0ad146606512e80351e0f481b3f)**\n\nReviewer: **Arpit Merchant**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20113_\n\n",
"closed_at": "2016-03-20T23:41:34Z",
"created_at": "2016-02-25T17:07:58Z",
"labels": [
"https://github.com/sagemath/sage/labels/c%3A%20coding%20theory",
"https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"https://github.com/sagemath/sage/labels/enhancement",
"https://github.com/sagemath/sage/labels/good%20first%20issue"
],
"milestone": "https://github.com/sagemath/sage/milestones/sage-7.1",
"reactions": [],
"repository": "https://github.com/sagemath/sage",
"title": "Simplify LinearCode.zero method",
"type": "issue",
"updated_at": "2016-03-20T23:41:34Z",
"url": "https://github.com/sagemath/sage/issues/20113",
"user": "https://github.com/sagetrac-dlucas"
}Implementation of method zero from AbstractLinearCode can be improved by just returning the zero vector of the ambient space of the code.
Component: coding theory
Author: David Lucas
Branch/Commit: 806642e
Reviewer: Arpit Merchant
Issue created by migration from https://trac.sagemath.org/ticket/20113
archive/issue_events_281564.json:
{
"actor": "https://github.com/sagetrac-dlucas",
"created_at": "2016-02-25T17:07:58Z",
"event": "milestoned",
"issue": "https://github.com/sagemath/sage/issues/20113",
"milestone_number": null,
"milestone_title": "sage-7.1",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20113#event-281564"
}archive/issue_events_281565.json:
{
"actor": "https://github.com/sagetrac-dlucas",
"created_at": "2016-02-25T17:07:58Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20113",
"label": "https://github.com/sagemath/sage/labels/c%3A%20coding%20theory",
"label_color": "0000ff",
"label_name": "c: coding theory",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20113#event-281565"
}archive/issue_events_281566.json:
{
"actor": "https://github.com/sagetrac-dlucas",
"created_at": "2016-02-25T17:07:58Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20113",
"label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"label_color": "ffbb00",
"label_name": "p: major / 3",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20113#event-281566"
}archive/issue_events_281567.json:
{
"actor": "https://github.com/sagetrac-dlucas",
"created_at": "2016-02-25T17:07:58Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20113",
"label": "https://github.com/sagemath/sage/labels/enhancement",
"label_color": "696969",
"label_name": "enhancement",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20113#event-281567"
}archive/issue_comments_288658.json:
{
"body": "Branch: **[u/dlucas/zero_of_codes](https://github.com/sagemath/sagetrac-mirror/tree/u/dlucas/zero_of_codes)**",
"created_at": "2016-02-25T17:08:29Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20113",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20113#issuecomment-288658",
"user": "https://github.com/sagetrac-dlucas"
}Branch: u/dlucas/zero_of_codes
archive/issue_comments_288659.json:
{
"body": "Changed keywords from **\"beginner\"** to none",
"created_at": "2016-02-25T17:09:06Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20113",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20113#issuecomment-288659",
"user": "https://github.com/sagetrac-dlucas"
}Changed keywords from "beginner" to none
archive/issue_events_281568.json:
{
"actor": "https://github.com/sagetrac-dlucas",
"created_at": "2016-02-25T17:09:06Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20113",
"label": "https://github.com/sagemath/sage/labels/good%20first%20issue",
"label_color": "7057ff",
"label_name": "good first issue",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20113#event-281568"
}archive/issue_comments_288660.json:
{
"body": "Author: **David Lucas**",
"created_at": "2016-02-25T17:09:06Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20113",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20113#issuecomment-288660",
"user": "https://github.com/sagetrac-dlucas"
}Author: David Lucas
archive/issue_events_281569.json:
{
"actor": "https://github.com/sagetrac-dlucas",
"created_at": "2016-02-25T17:09:06Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20113",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20113#event-281569"
}archive/issue_comments_288661.json:
{
"body": "<div id=\"comment:2\" align=\"right\">comment:2</div>\n\nPushed the fix, it's now open for review.\n\n---\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/806642e6eb32d0ad146606512e80351e0f481b3f\"><code>806642e</code></a></td><td><code>Rewrote zero method for codes</code></td></tr></table>\n",
"created_at": "2016-02-25T17:09:06Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20113",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20113#issuecomment-288661",
"user": "https://github.com/sagetrac-dlucas"
}comment:2
Pushed the fix, it's now open for review.
New commits:
806642e | Rewrote zero method for codes |
archive/issue_comments_288662.json:
{
"body": "Commit: **[`806642e`](https://github.com/sagemath/sagetrac-mirror/commit/806642e6eb32d0ad146606512e80351e0f481b3f)**",
"created_at": "2016-02-25T17:09:06Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20113",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20113#issuecomment-288662",
"user": "https://github.com/sagetrac-dlucas"
}Commit: 806642e
archive/issue_comments_288663.json:
{
"body": "<div id=\"comment:3\" align=\"right\">comment:3</div>\n\nI agree with the changes, the tests pass. I'm giving this a positive review.",
"created_at": "2016-03-13T07:30:21Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20113",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20113#issuecomment-288663",
"user": "https://github.com/arpitdm"
}comment:3
I agree with the changes, the tests pass. I'm giving this a positive review.
archive/issue_events_281570.json:
{
"actor": "https://github.com/arpitdm",
"created_at": "2016-03-13T07:30:21Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20113",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20113#event-281570"
}archive/issue_events_281571.json:
{
"actor": "https://github.com/arpitdm",
"created_at": "2016-03-13T07:30:21Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20113",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20113#event-281571"
}archive/issue_comments_288664.json:
{
"body": "<div id=\"comment:4\" align=\"right\">comment:4</div>\n\nYou will need to put your real name as the reviewer.",
"created_at": "2016-03-13T09:25:50Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20113",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20113#issuecomment-288664",
"user": "https://github.com/tscrim"
}comment:4
You will need to put your real name as the reviewer.
archive/issue_comments_288665.json:
{
"body": "Reviewer: **Arpit Merchant**",
"created_at": "2016-03-13T17:51:45Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20113",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20113#issuecomment-288665",
"user": "https://github.com/arpitdm"
}Reviewer: Arpit Merchant
archive/issue_events_281572.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-03-20T23:41:34Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20113",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20113#event-281572"
}archive/issue_events_281573.json:
{
"actor": "https://github.com/vbraun",
"commit_id": "9ee55d0a21699ff0705372ceec4ed94ff1522e66",
"commit_repository": "https://github.com/sagemath/sage",
"created_at": "2016-03-20T23:41:34Z",
"event": "closed",
"issue": "https://github.com/sagemath/sage/issues/20113",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20113#event-281573"
}archive/issue_comments_288666.json:
{
"body": "Changed branch from **[u/dlucas/zero_of_codes](https://github.com/sagemath/sagetrac-mirror/tree/u/dlucas/zero_of_codes)** to **[`806642e`](https://github.com/sagemath/sagetrac-mirror/commit/806642e6eb32d0ad146606512e80351e0f481b3f)**",
"created_at": "2016-03-20T23:41:34Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20113",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20113#issuecomment-288666",
"user": "https://github.com/vbraun"
}Changed branch from u/dlucas/zero_of_codes to 806642e