Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Latest commit

 

History

History
1176 lines (873 loc) · 42.5 KB

20140.md

File metadata and controls

1176 lines (873 loc) · 42.5 KB

Issue 20140: dependencies: use "foo" instead of "$(INST)/$(FOO)"

archive/issues_019903.json:

{
    "assignees": [],
    "body": "<div id=\"comment:0\"></div>\n\nReplace dependencies like `$(INST)/$(PARI)` by `pari`.\n\n**configure tarball** (for buildbot testing): [http://sage.ugent.be/www/jdemeyer/sage/configure-147.tar.gz](http://sage.ugent.be/www/jdemeyer/sage/configure-147.tar.gz)\n\nDepends on #20130\n\nCC:  @simon-king-jena @vbraun @kiwifb\n\nComponent: **build**\n\nAuthor: **Jeroen Demeyer**\n\nBranch/Commit: **[`383b1b4`](https://github.com/sagemath/sagetrac-mirror/commit/383b1b404660d8845250af3fb574eb21c69c74d8)**\n\nReviewer: **Volker Braun**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20140_\n\n",
    "closed_at": "2016-03-02T23:30:19Z",
    "created_at": "2016-02-29T19:49:08Z",
    "labels": [
        "https://github.com/sagemath/sage/labels/c%3A%20build",
        "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
        "https://github.com/sagemath/sage/labels/enhancement"
    ],
    "milestone": "https://github.com/sagemath/sage/milestones/sage-7.1",
    "reactions": [],
    "repository": "https://github.com/sagemath/sage",
    "title": "dependencies: use \"foo\" instead of \"$(INST)/$(FOO)\"",
    "type": "issue",
    "updated_at": "2016-03-02T23:30:19Z",
    "url": "https://github.com/sagemath/sage/issues/20140",
    "user": "https://github.com/jdemeyer"
}

Replace dependencies like $(INST)/$(PARI) by pari.

configure tarball (for buildbot testing): http://sage.ugent.be/www/jdemeyer/sage/configure-147.tar.gz

Depends on #20130

CC: @simon-king-jena @vbraun @kiwifb

Component: build

Author: Jeroen Demeyer

Branch/Commit: 383b1b4

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/20140


archive/issue_events_281905.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-02-29T19:49:08Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "milestone_number": null,
    "milestone_title": "sage-7.1",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20140#event-281905"
}

archive/issue_events_281906.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-02-29T19:49:08Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "label": "https://github.com/sagemath/sage/labels/c%3A%20build",
    "label_color": "0000b0",
    "label_name": "c: build",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20140#event-281906"
}

archive/issue_events_281907.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-02-29T19:49:08Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
    "label_color": "ffbb00",
    "label_name": "p: major / 3",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20140#event-281907"
}

archive/issue_events_281908.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-02-29T19:49:08Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "label": "https://github.com/sagemath/sage/labels/enhancement",
    "label_color": "696969",
    "label_name": "enhancement",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20140#event-281908"
}

archive/issue_comments_289260.json:

{
    "body": "Branch: **[u/jdemeyer/dependencies__use__foo__instead_of____inst____foo__](https://github.com/sagemath/sagetrac-mirror/tree/u/jdemeyer/dependencies__use__foo__instead_of____inst____foo__)**",
    "created_at": "2016-02-29T21:41:42Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289260",
    "user": "https://github.com/jdemeyer"
}

Branch: u/jdemeyer/dependencies__use__foo__instead_of____inst____foo__


archive/issue_comments_289261.json:

{
    "body": "<div id=\"comment:2\"></div>\n\nBranch pushed to git repo; I updated commit sha1. This was a forced push. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/bbb688a391cb5e3c1478e38c8d697a9042f43a36\"><code>bbb688a</code></a></td><td><code>dependencies: use \"foo\" instead of \"$(INST)/$(FOO)\"</code></td></tr></table>\n",
    "created_at": "2016-03-01T08:52:06Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289261",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

bbb688adependencies: use "foo" instead of "$(INST)/$(FOO)"

archive/issue_comments_289262.json:

{
    "body": "Commit: **[`bbb688a`](https://github.com/sagemath/sagetrac-mirror/commit/bbb688a391cb5e3c1478e38c8d697a9042f43a36)**",
    "created_at": "2016-03-01T08:52:06Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289262",
    "user": "https://github.com/sagetrac-git"
}

Commit: bbb688a


archive/issue_comments_289263.json:

{
    "body": "<div id=\"comment:3\"></div>\n\nBranch pushed to git repo; I updated commit sha1. This was a forced push. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/9145390c3d1884730e7b00993648e0f984e641cb\"><code>9145390</code></a></td><td><code>dependencies: use \"foo\" instead of \"$(INST)/$(FOO)\"</code></td></tr></table>\n",
    "created_at": "2016-03-01T08:53:15Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289263",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9145390dependencies: use "foo" instead of "$(INST)/$(FOO)"

archive/issue_comments_289264.json:

{
    "body": "Changed commit from **[`bbb688a`](https://github.com/sagemath/sagetrac-mirror/commit/bbb688a391cb5e3c1478e38c8d697a9042f43a36)** to **[`9145390`](https://github.com/sagemath/sagetrac-mirror/commit/9145390c3d1884730e7b00993648e0f984e641cb)**",
    "created_at": "2016-03-01T08:53:15Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289264",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from bbb688a to 9145390


archive/issue_comments_289265.json:

{
    "body": "Changed commit from **[`9145390`](https://github.com/sagemath/sagetrac-mirror/commit/9145390c3d1884730e7b00993648e0f984e641cb)** to **[`f26772f`](https://github.com/sagemath/sagetrac-mirror/commit/f26772f0d19c4f137dec8bd2feb3f059c07e1570)**",
    "created_at": "2016-03-01T08:54:37Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289265",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 9145390 to f26772f


archive/issue_comments_289266.json:

{
    "body": "<div id=\"comment:4\"></div>\n\nBranch pushed to git repo; I updated commit sha1. This was a forced push. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/f26772f0d19c4f137dec8bd2feb3f059c07e1570\"><code>f26772f</code></a></td><td><code>dependencies: use \"foo\" instead of \"$(INST)/$(FOO)\"</code></td></tr></table>\n",
    "created_at": "2016-03-01T08:54:37Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289266",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f26772fdependencies: use "foo" instead of "$(INST)/$(FOO)"

archive/issue_comments_289267.json:

{
    "body": "Description changed:\n``````diff\n--- \n+++ \n@@ -1 +1 @@\n-\n+Replace dependencies like `$(INST)/$(PARI)` by `pari`.\n``````\n",
    "created_at": "2016-03-01T08:56:05Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289267",
    "user": "https://github.com/jdemeyer"
}

Description changed:

--- 
+++ 
@@ -1 +1 @@
-
+Replace dependencies like `$(INST)/$(PARI)` by `pari`.

archive/issue_comments_289268.json:

{
    "body": "Changed commit from **[`f26772f`](https://github.com/sagemath/sagetrac-mirror/commit/f26772f0d19c4f137dec8bd2feb3f059c07e1570)** to **[`87d5afd`](https://github.com/sagemath/sagetrac-mirror/commit/87d5afd009c09cc8d15e8822c1dc51925aad7dd5)**",
    "created_at": "2016-03-01T08:58:53Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289268",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from f26772f to 87d5afd


archive/issue_comments_289269.json:

{
    "body": "<div id=\"comment:6\"></div>\n\nBranch pushed to git repo; I updated commit sha1. This was a forced push. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/87d5afd009c09cc8d15e8822c1dc51925aad7dd5\"><code>87d5afd</code></a></td><td><code>dependencies: use \"foo\" instead of \"$(INST)/$(FOO)\"</code></td></tr></table>\n",
    "created_at": "2016-03-01T08:58:53Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289269",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

87d5afddependencies: use "foo" instead of "$(INST)/$(FOO)"

archive/issue_comments_289270.json:

{
    "body": "Changed commit from **[`87d5afd`](https://github.com/sagemath/sagetrac-mirror/commit/87d5afd009c09cc8d15e8822c1dc51925aad7dd5)** to **[`463d22a`](https://github.com/sagemath/sagetrac-mirror/commit/463d22a4eb4555e3180aa25446f678a79686845d)**",
    "created_at": "2016-03-01T09:03:10Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289270",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 87d5afd to 463d22a


archive/issue_comments_289271.json:

{
    "body": "<div id=\"comment:7\"></div>\n\nBranch pushed to git repo; I updated commit sha1. This was a forced push. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/463d22a4eb4555e3180aa25446f678a79686845d\"><code>463d22a</code></a></td><td><code>dependencies: use \"foo\" instead of \"$(INST)/$(FOO)\"</code></td></tr></table>\n",
    "created_at": "2016-03-01T09:03:10Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289271",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

463d22adependencies: use "foo" instead of "$(INST)/$(FOO)"

archive/issue_events_281909.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-03-01T09:04:05Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20140#event-281909"
}

archive/issue_comments_289272.json:

{
    "body": "Description changed:\n``````diff\n--- \n+++ \n@@ -1 +1,3 @@\n Replace dependencies like `$(INST)/$(PARI)` by `pari`.\n+\n+**configure tarball** (for buildbot testing): [http://sage.ugent.be/www/jdemeyer/sage/configure-147.tar.gz](http://sage.ugent.be/www/jdemeyer/sage/configure-147.tar.gz)\n``````\n",
    "created_at": "2016-03-01T09:04:05Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289272",
    "user": "https://github.com/jdemeyer"
}

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
 Replace dependencies like `$(INST)/$(PARI)` by `pari`.
+
+**configure tarball** (for buildbot testing): [http://sage.ugent.be/www/jdemeyer/sage/configure-147.tar.gz](http://sage.ugent.be/www/jdemeyer/sage/configure-147.tar.gz)

archive/issue_comments_289273.json:

{
    "body": "<div id=\"comment:9\" align=\"right\">comment:9</div>\n\nAh, I was just thinking about this.  Actually I had a broader proposal that I'd expand on later of cobbling all package metadata into a single machine-consumable file that I would like to use to better generate info on packages.  But just improving the format of the \"dependencies\" file is a good start.",
    "created_at": "2016-03-01T12:16:12Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289273",
    "user": "https://github.com/embray"
}
comment:9

Ah, I was just thinking about this. Actually I had a broader proposal that I'd expand on later of cobbling all package metadata into a single machine-consumable file that I would like to use to better generate info on packages. But just improving the format of the "dependencies" file is a good start.


archive/issue_comments_289274.json:

{
    "body": "<div id=\"comment:11\" align=\"right\">comment:11</div>\n\nI don't usually dwell in that area. It made me read some documentation. It does look ok and is a bit simpler.",
    "created_at": "2016-03-01T21:13:35Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289274",
    "user": "https://github.com/kiwifb"
}
comment:11

I don't usually dwell in that area. It made me read some documentation. It does look ok and is a bit simpler.


archive/issue_comments_289275.json:

{
    "body": "<div id=\"comment:12\" align=\"right\">comment:12</div>\n\nLgtm but can you also merge in #20129",
    "created_at": "2016-03-01T21:21:00Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289275",
    "user": "https://github.com/vbraun"
}
comment:12

Lgtm but can you also merge in #20129


archive/issue_comments_289276.json:

{
    "body": "<div id=\"comment:13\" align=\"right\">comment:13</div>\n\nReplying to [@vbraun](#comment%3A12):\n> Lgtm but can you also merge in #20129\n\nWhy? There is no conflict (`openblas` has no dependencies).",
    "created_at": "2016-03-01T21:52:05Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289276",
    "user": "https://github.com/jdemeyer"
}
comment:13

Replying to @vbraun:

Lgtm but can you also merge in #20129

Why? There is no conflict (openblas has no dependencies).


archive/issue_comments_289277.json:

{
    "body": "Reviewer: **Volker Braun**",
    "created_at": "2016-03-01T23:20:37Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289277",
    "user": "https://github.com/vbraun"
}

Reviewer: Volker Braun


archive/issue_events_281910.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-03-01T23:20:37Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20140#event-281910"
}

archive/issue_events_281911.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-03-01T23:20:37Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20140#event-281911"
}

archive/issue_comments_289278.json:

{
    "body": "<div id=\"comment:14\" align=\"right\">comment:14</div>\n\nRight, forgot about that.",
    "created_at": "2016-03-01T23:20:37Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289278",
    "user": "https://github.com/vbraun"
}
comment:14

Right, forgot about that.


archive/issue_events_281912.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-03-01T23:24:16Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20140#event-281912"
}

archive/issue_events_281913.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-03-01T23:24:16Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20140#event-281913"
}

archive/issue_comments_289279.json:

{
    "body": "<div id=\"comment:15\" align=\"right\">comment:15</div>\n\nConflicts with #20130",
    "created_at": "2016-03-01T23:24:16Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289279",
    "user": "https://github.com/vbraun"
}
comment:15

Conflicts with #20130


archive/issue_comments_289280.json:

{
    "body": "Changed commit from **[`463d22a`](https://github.com/sagemath/sagetrac-mirror/commit/463d22a4eb4555e3180aa25446f678a79686845d)** to **[`d7e720f`](https://github.com/sagemath/sagetrac-mirror/commit/d7e720f74624b5690a57d8c7eee6da3bf8557cef)**",
    "created_at": "2016-03-02T07:03:34Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289280",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 463d22a to d7e720f


archive/issue_comments_289281.json:

{
    "body": "<div id=\"comment:16\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/18d59bf4dda7b0521395b917e30edb5f026f524f\"><code>18d59bf</code></a></td><td><code>Move third-party packages to pkg-config blas</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/de7efd23ffb7c9ed223bf769e55f585f47566d1a\"><code>de7efd2</code></a></td><td><code>Fix typo: use lapack.pc not blas.pc</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/f1302b23fb533a17e91f66bda951c3394eed1463\"><code>f1302b2</code></a></td><td><code>Bump patchlevels</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/555b25811afe8da5d83c3ed6461e423a70f961f7\"><code>555b258</code></a></td><td><code>Iml version/patchlevel fix</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/d7e720f74624b5690a57d8c7eee6da3bf8557cef\"><code>d7e720f</code></a></td><td><code>Merge commit '555b25811afe8da5d83c3ed6461e423a70f961f7' into t/20140/dependencies__use__foo__instead_of____inst____foo__</code></td></tr></table>\n",
    "created_at": "2016-03-02T07:03:34Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289281",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

18d59bfMove third-party packages to pkg-config blas
de7efd2Fix typo: use lapack.pc not blas.pc
f1302b2Bump patchlevels
555b258Iml version/patchlevel fix
d7e720fMerge commit '555b25811afe8da5d83c3ed6461e423a70f961f7' into t/20140/dependencies__use__foo__instead_of____inst____foo__

archive/issue_comments_289282.json:

{
    "body": "Dependencies: **#20130**",
    "created_at": "2016-03-02T07:06:51Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289282",
    "user": "https://github.com/jdemeyer"
}

Dependencies: #20130


archive/issue_events_281914.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-03-02T07:06:51Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20140#event-281914"
}

archive/issue_events_281915.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-03-02T07:06:51Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20140#event-281915"
}

archive/issue_events_281916.json:

{
    "actor": "https://github.com/sagetrac-git",
    "created_at": "2016-03-02T11:07:50Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20140#event-281916"
}

archive/issue_events_281917.json:

{
    "actor": "https://github.com/sagetrac-git",
    "created_at": "2016-03-02T11:07:50Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20140#event-281917"
}

archive/issue_comments_289283.json:

{
    "body": "<div id=\"comment:18\"></div>\n\nBranch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/2e1cbc5ff6016d5d3ea1f2f79f770bc7c096365a\"><code>2e1cbc5</code></a></td><td><code>Use sed to transform dependencies from \"foo\" to \"$(inst_foo)\"</code></td></tr></table>\n",
    "created_at": "2016-03-02T11:07:50Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289283",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

2e1cbc5Use sed to transform dependencies from "foo" to "$(inst_foo)"

archive/issue_comments_289284.json:

{
    "body": "Changed commit from **[`d7e720f`](https://github.com/sagemath/sagetrac-mirror/commit/d7e720f74624b5690a57d8c7eee6da3bf8557cef)** to **[`2e1cbc5`](https://github.com/sagemath/sagetrac-mirror/commit/2e1cbc5ff6016d5d3ea1f2f79f770bc7c096365a)**",
    "created_at": "2016-03-02T11:07:50Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289284",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from d7e720f to 2e1cbc5


archive/issue_comments_289285.json:

{
    "body": "<div id=\"comment:19\" align=\"right\">comment:19</div>\n\nPrevious version didn't work because of phony targets in the dependencies. This new version still allows dependencies to be listed as `foo`. A small `sed` script transforms this to `$(inst_foo)`.",
    "created_at": "2016-03-02T11:11:34Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289285",
    "user": "https://github.com/jdemeyer"
}
comment:19

Previous version didn't work because of phony targets in the dependencies. This new version still allows dependencies to be listed as foo. A small sed script transforms this to $(inst_foo).


archive/issue_comments_289286.json:

{
    "body": "<div id=\"comment:20\"></div>\n\nBranch pushed to git repo; I updated commit sha1. This was a forced push. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/383b1b404660d8845250af3fb574eb21c69c74d8\"><code>383b1b4</code></a></td><td><code>Use sed to transform dependencies from \"foo\" to \"$(inst_foo)\"</code></td></tr></table>\n",
    "created_at": "2016-03-02T11:12:13Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289286",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

383b1b4Use sed to transform dependencies from "foo" to "$(inst_foo)"

archive/issue_comments_289287.json:

{
    "body": "Changed commit from **[`2e1cbc5`](https://github.com/sagemath/sagetrac-mirror/commit/2e1cbc5ff6016d5d3ea1f2f79f770bc7c096365a)** to **[`383b1b4`](https://github.com/sagemath/sagetrac-mirror/commit/383b1b404660d8845250af3fb574eb21c69c74d8)**",
    "created_at": "2016-03-02T11:12:13Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289287",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 2e1cbc5 to 383b1b4


archive/issue_comments_289288.json:

{
    "body": "<div id=\"comment:21\" align=\"right\">comment:21</div>\n\nWhile you're at it, I've noticed that some packages don't have all their dependencies listed.  I don't have an exhaustive list yet, but I just encountered that `jsonschema` is only included as a dependency of `nbformat` even though it's not listed as such.\n\nAnother one: `mistune` is a dependency of `nbconvert`.",
    "created_at": "2016-03-02T15:03:39Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289288",
    "user": "https://github.com/embray"
}
comment:21

While you're at it, I've noticed that some packages don't have all their dependencies listed. I don't have an exhaustive list yet, but I just encountered that jsonschema is only included as a dependency of nbformat even though it's not listed as such.

Another one: mistune is a dependency of nbconvert.


archive/issue_comments_289289.json:

{
    "body": "<div id=\"comment:22\" align=\"right\">comment:22</div>\n\nIf we had a way of getting the dependency information into Python then it would be easy enough to compare with the pip dependency information for testing....",
    "created_at": "2016-03-02T15:16:46Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289289",
    "user": "https://github.com/vbraun"
}
comment:22

If we had a way of getting the dependency information into Python then it would be easy enough to compare with the pip dependency information for testing....


archive/issue_comments_289290.json:

{
    "body": "<div id=\"comment:23\" align=\"right\">comment:23</div>\n\nReplying to [@embray](#comment%3A21):\n> `jsonschema` is only included as a dependency of `nbformat` even though it's not listed as such.\n\nI don't understand this sentence",
    "created_at": "2016-03-02T16:53:59Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289290",
    "user": "https://github.com/jdemeyer"
}
comment:23

Replying to @embray:

jsonschema is only included as a dependency of nbformat even though it's not listed as such.

I don't understand this sentence


archive/issue_comments_289291.json:

{
    "body": "<div id=\"comment:24\" align=\"right\">comment:24</div>\n\nThe only reason `jsonschema` has an spkg is sage is because it's a dependency of `nbformat`, but `nbformat` does not list `jsonschema` in its dependencies.",
    "created_at": "2016-03-02T16:54:56Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289291",
    "user": "https://github.com/embray"
}
comment:24

The only reason jsonschema has an spkg is sage is because it's a dependency of nbformat, but nbformat does not list jsonschema in its dependencies.


archive/issue_comments_289292.json:

{
    "body": "<div id=\"comment:25\" align=\"right\">comment:25</div>\n\nMaybe you are confusing run-time dependencies with build-time dependencies? The `dependencies` files are really only meant for build-time dependencies.\n\nAnyway, this isn't what this ticket is about...",
    "created_at": "2016-03-02T17:02:29Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289292",
    "user": "https://github.com/jdemeyer"
}
comment:25

Maybe you are confusing run-time dependencies with build-time dependencies? The dependencies files are really only meant for build-time dependencies.

Anyway, this isn't what this ticket is about...


archive/issue_comments_289293.json:

{
    "body": "<div id=\"comment:26\" align=\"right\">comment:26</div>\n\nOkay, that must be it then.  I'm confused because some of the Python packages do list dependencies that I wouldn't think of as build dependencies (unless maybe the package doesn't import without them).",
    "created_at": "2016-03-02T17:14:01Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289293",
    "user": "https://github.com/embray"
}
comment:26

Okay, that must be it then. I'm confused because some of the Python packages do list dependencies that I wouldn't think of as build dependencies (unless maybe the package doesn't import without them).


archive/issue_comments_289294.json:

{
    "body": "<div id=\"comment:27\" align=\"right\">comment:27</div>\n\nReplying to [@embray](#comment%3A26):\n> I'm confused because some of the Python packages do list dependencies that I wouldn't think of as build dependencies (unless maybe the package doesn't import without them).\n\nFirst of all, keep in mind that a test-suite is also considered \"build-time\". But it could very well be that packages list dependencies which are not strictly required. Usually, the time to build Python packages is negligible, so it's not so important.",
    "created_at": "2016-03-02T17:20:52Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289294",
    "user": "https://github.com/jdemeyer"
}
comment:27

Replying to @embray:

I'm confused because some of the Python packages do list dependencies that I wouldn't think of as build dependencies (unless maybe the package doesn't import without them).

First of all, keep in mind that a test-suite is also considered "build-time". But it could very well be that packages list dependencies which are not strictly required. Usually, the time to build Python packages is negligible, so it's not so important.


archive/issue_comments_289295.json:

{
    "body": "<div id=\"comment:28\" align=\"right\">comment:28</div>\n\nRegardless of all this, can somebody review this ticket please?",
    "created_at": "2016-03-02T17:21:20Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289295",
    "user": "https://github.com/jdemeyer"
}
comment:28

Regardless of all this, can somebody review this ticket please?


archive/issue_events_281918.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-03-02T17:28:16Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20140#event-281918"
}

archive/issue_events_281919.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-03-02T17:28:16Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20140#event-281919"
}

archive/issue_events_281920.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-03-02T23:30:19Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20140#event-281920"
}

archive/issue_events_281921.json:

{
    "actor": "https://github.com/vbraun",
    "commit_id": "77f15e96968831855f0c4e16dcfe5a118b7de66d",
    "commit_repository": "https://github.com/sagemath/sage",
    "created_at": "2016-03-02T23:30:19Z",
    "event": "closed",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20140#event-281921"
}

archive/issue_comments_289296.json:

{
    "body": "Changed branch from **[u/jdemeyer/dependencies__use__foo__instead_of____inst____foo__](https://github.com/sagemath/sagetrac-mirror/tree/u/jdemeyer/dependencies__use__foo__instead_of____inst____foo__)** to **[`383b1b4`](https://github.com/sagemath/sagetrac-mirror/commit/383b1b404660d8845250af3fb574eb21c69c74d8)**",
    "created_at": "2016-03-02T23:30:19Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20140",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20140#issuecomment-289296",
    "user": "https://github.com/vbraun"
}

Changed branch from u/jdemeyer/dependencies__use__foo__instead_of____inst____foo__ to 383b1b4