archive/issues_019939.json:
{
"assignees": [],
"body": "<div id=\"comment:0\"></div>\n\nThe developer's manual needs to be updated to include an explanation of the ellipsis in doctests. For your information: The ellipsis is part of Python's doctest framework. In Python it's not enabled by default, but in Sage it is.\n\nComponent: **documentation**\n\nAuthor: **Kwankyu Lee**\n\nBranch/Commit: **[`5694f4e`](https://github.com/sagemath/sagetrac-mirror/commit/5694f4ee95ce733d7b30619f23fcd17177194207)**\n\nReviewer: **Daniel Krenn**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20176_\n\n",
"closed_at": "2016-03-23T23:55:01Z",
"created_at": "2016-03-08T08:31:38Z",
"labels": [
"https://github.com/sagemath/sage/labels/c%3A%20documentation",
"https://github.com/sagemath/sage/labels/p%3A%20minor%20/%204",
"https://github.com/sagemath/sage/labels/enhancement"
],
"milestone": "https://github.com/sagemath/sage/milestones/sage-7.2",
"reactions": [],
"repository": "https://github.com/sagemath/sage",
"title": "Document ellipsis in doctests",
"type": "issue",
"updated_at": "2016-03-23T23:55:01Z",
"url": "https://github.com/sagemath/sage/issues/20176",
"user": "https://github.com/kwankyu"
}The developer's manual needs to be updated to include an explanation of the ellipsis in doctests. For your information: The ellipsis is part of Python's doctest framework. In Python it's not enabled by default, but in Sage it is.
Component: documentation
Author: Kwankyu Lee
Branch/Commit: 5694f4e
Reviewer: Daniel Krenn
Issue created by migration from https://trac.sagemath.org/ticket/20176
archive/issue_events_282315.json:
{
"actor": "https://github.com/kwankyu",
"created_at": "2016-03-08T08:31:38Z",
"event": "milestoned",
"issue": "https://github.com/sagemath/sage/issues/20176",
"milestone_number": null,
"milestone_title": "sage-7.1",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282315"
}archive/issue_events_282316.json:
{
"actor": "https://github.com/kwankyu",
"created_at": "2016-03-08T08:31:38Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20176",
"label": "https://github.com/sagemath/sage/labels/c%3A%20doctest%20framework",
"label_color": "0000b0",
"label_name": "c: doctest framework",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282316"
}archive/issue_events_282317.json:
{
"actor": "https://github.com/kwankyu",
"created_at": "2016-03-08T08:31:38Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20176",
"label": "https://github.com/sagemath/sage/labels/p%3A%20minor%20/%204",
"label_color": "ffe799",
"label_name": "p: minor / 4",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282317"
}archive/issue_events_282318.json:
{
"actor": "https://github.com/kwankyu",
"created_at": "2016-03-08T08:31:38Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20176",
"label": "https://github.com/sagemath/sage/labels/enhancement",
"label_color": "696969",
"label_name": "enhancement",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282318"
}archive/issue_comments_289910.json:
{
"body": "Replying to [@kwankyu](https://github.com/sagemath/sage/issues/20176#comment:0):\n> We need a new magic comment\n> \n> \\# optional - latex\n> \n> for doctests that require latex installed on the system.\n> \n> In addition, the developer's manual needs to be updated to include an explanation of the ellipsis in doctests. For your information: The ellipsis is part of Python's doctest framework. In Python it's not enabled by default, but in Sage it is. \n\nMaybe also adding a link to the corresponding part of the Python manual.\n\nThe two issues should be split on two tickets.",
"created_at": "2016-03-08T08:42:44Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289910",
"user": "https://github.com/dkrenn"
}Replying to @kwankyu:
We need a new magic comment
# optional - latex
for doctests that require latex installed on the system.
In addition, the developer's manual needs to be updated to include an explanation of the ellipsis in doctests. For your information: The ellipsis is part of Python's doctest framework. In Python it's not enabled by default, but in Sage it is.
Maybe also adding a link to the corresponding part of the Python manual.
The two issues should be split on two tickets.
archive/issue_events_282319.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-03-08T08:44:28Z",
"event": "renamed",
"issue": "https://github.com/sagemath/sage/issues/20176",
"title_is": "Document ellipsis in doctests",
"title_was": "New magic comment for doctest \"# optional - latex\"",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282319"
}archive/issue_comments_289911.json:
{
"body": "Description changed:\n``````diff\n--- \n+++ \n@@ -1,7 +1 @@\n-We need a new magic comment\n-\n-\\# optional - latex\n-\n-for doctests that require latex installed on the system.\n-\n-In addition, the developer's manual needs to be updated to include an explanation of the ellipsis in doctests. For your information: The ellipsis is part of Python's doctest framework. In Python it's not enabled by default, but in Sage it is. \n+The developer's manual needs to be updated to include an explanation of the ellipsis in doctests. For your information: The ellipsis is part of Python's doctest framework. In Python it's not enabled by default, but in Sage it is.\n``````\n",
"created_at": "2016-03-08T08:44:28Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289911",
"user": "https://github.com/jdemeyer"
}Description changed:
---
+++
@@ -1,7 +1 @@
-We need a new magic comment
-
-\# optional - latex
-
-for doctests that require latex installed on the system.
-
-In addition, the developer's manual needs to be updated to include an explanation of the ellipsis in doctests. For your information: The ellipsis is part of Python's doctest framework. In Python it's not enabled by default, but in Sage it is.
+The developer's manual needs to be updated to include an explanation of the ellipsis in doctests. For your information: The ellipsis is part of Python's doctest framework. In Python it's not enabled by default, but in Sage it is.archive/issue_events_282320.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-03-08T08:44:28Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20176",
"label": "https://github.com/sagemath/sage/labels/c%3A%20doctest%20framework",
"label_color": "0000b0",
"label_name": "c: doctest framework",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282320"
}archive/issue_events_282321.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-03-08T08:44:28Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20176",
"label": "https://github.com/sagemath/sage/labels/c%3A%20documentation",
"label_color": "0075ca",
"label_name": "c: documentation",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282321"
}archive/issue_comments_289912.json:
{
"body": "<div id=\"comment:2\" align=\"right\">comment:2</div>\n\nYou can already use `# optional - latex` right now.",
"created_at": "2016-03-08T08:44:28Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289912",
"user": "https://github.com/jdemeyer"
}comment:2
You can already use # optional - latex right now.
archive/issue_comments_289913.json:
{
"body": "<div id=\"comment:3\" align=\"right\">comment:3</div>\n\nRegarding `latex`, we could consider trying to detect whether the system has LaTeX installed and so whether to run those doctests automatically. I don't want to do this for every non-Sage piece of software mentioned in an optional flag, but maybe LaTeX deserves a special case? I'm not sure.",
"created_at": "2016-03-08T16:30:50Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289913",
"user": "https://github.com/jhpalmieri"
}comment:3
Regarding latex, we could consider trying to detect whether the system has LaTeX installed and so whether to run those doctests automatically. I don't want to do this for every non-Sage piece of software mentioned in an optional flag, but maybe LaTeX deserves a special case? I'm not sure.
archive/issue_comments_289914.json:
{
"body": "<div id=\"comment:4\" align=\"right\">comment:4</div>\n\nFor the record, I'm thinking of something like\n\n```diff\ndiff --git a/src/sage/doctest/control.py b/src/sage/doctest/control.py\nindex 6a49e68..79567db 100644\n--- a/src/sage/doctest/control.py\n+++ b/src/sage/doctest/control.py\n@@ -259,6 +259,10 @@ class DocTestController(SageObject):\n if versions[0] == versions[1]:\n options.optional.add(pkg)\n \n+ from sage.misc.latex import have_latex\n+ if have_latex():\n+ options.optional.add('latex')\n+\n # Check that all tags are valid\n for o in options.optional:\n if not optionaltag_regex.search(o):\n```",
"created_at": "2016-03-09T06:20:01Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289914",
"user": "https://github.com/jhpalmieri"
}comment:4
For the record, I'm thinking of something like
diff --git a/src/sage/doctest/control.py b/src/sage/doctest/control.py
index 6a49e68..79567db 100644
--- a/src/sage/doctest/control.py
+++ b/src/sage/doctest/control.py
@@ -259,6 +259,10 @@ class DocTestController(SageObject):
if versions[0] == versions[1]:
options.optional.add(pkg)
+ from sage.misc.latex import have_latex
+ if have_latex():
+ options.optional.add('latex')
+
# Check that all tags are valid
for o in options.optional:
if not optionaltag_regex.search(o):archive/issue_comments_289915.json:
{
"body": "<div id=\"comment:5\" align=\"right\">comment:5</div>\n\nSee #13540 and #18904 for general discussions about automatically detecting optional flags.",
"created_at": "2016-03-09T07:23:39Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289915",
"user": "https://github.com/jdemeyer"
}comment:5
See #13540 and #18904 for general discussions about automatically detecting optional flags.
archive/issue_comments_289916.json:
{
"body": "<div id=\"comment:6\" align=\"right\">comment:6</div>\n\nAnd now #20182, apparently.",
"created_at": "2016-03-09T15:56:09Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289916",
"user": "https://github.com/jhpalmieri"
}comment:6
And now #20182, apparently.
archive/issue_comments_289917.json:
{
"body": "<div id=\"comment:7\" align=\"right\">comment:7</div>\n\nWow, you are so fast! Thank you.",
"created_at": "2016-03-09T16:02:02Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289917",
"user": "https://github.com/kwankyu"
}comment:7
Wow, you are so fast! Thank you.
archive/issue_comments_289918.json:
{
"body": "<div id=\"comment:8\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/9477209496359a48efb9592b6ec9e7a306567ff8\"><code>9477209</code></a></td><td><code>Remark on the ellipsis marker</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/b4456b1047adff22bd4e5b6c56425933f89e3894\"><code>b4456b1</code></a></td><td><code>Corrected the link to Python's manual</code></td></tr></table>\n",
"created_at": "2016-03-17T06:08:29Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289918",
"user": "https://github.com/kwankyu"
}New commits:
9477209 | Remark on the ellipsis marker |
b4456b1 | Corrected the link to Python's manual |
archive/issue_comments_289919.json:
{
"body": "Branch: **[public/20176](https://github.com/sagemath/sagetrac-mirror/tree/public/20176)**",
"created_at": "2016-03-17T06:08:29Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289919",
"user": "https://github.com/kwankyu"
}Branch: public/20176
archive/issue_comments_289920.json:
{
"body": "Commit: **[`b4456b1`](https://github.com/sagemath/sagetrac-mirror/commit/b4456b1047adff22bd4e5b6c56425933f89e3894)**",
"created_at": "2016-03-17T06:08:29Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289920",
"user": "https://github.com/kwankyu"
}Commit: b4456b1
archive/issue_comments_289921.json:
{
"body": "Author: **Kwankyu Lee**",
"created_at": "2016-03-17T06:10:20Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289921",
"user": "https://github.com/kwankyu"
}Author: Kwankyu Lee
archive/issue_events_282322.json:
{
"actor": "https://github.com/kwankyu",
"created_at": "2016-03-17T06:10:20Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20176",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282322"
}archive/issue_events_282323.json:
{
"actor": "https://github.com/dkrenn",
"created_at": "2016-03-17T07:02:15Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20176",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282323"
}archive/issue_events_282324.json:
{
"actor": "https://github.com/dkrenn",
"created_at": "2016-03-17T07:02:15Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20176",
"label": "https://github.com/sagemath/sage/labels/needs%20work",
"label_color": "ffff00",
"label_name": "needs work",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282324"
}archive/issue_comments_289922.json:
{
"body": "Reviewer: **Daniel Krenn**",
"created_at": "2016-03-17T07:02:15Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289922",
"user": "https://github.com/dkrenn"
}Reviewer: Daniel Krenn
archive/issue_comments_289923.json:
{
"body": "<div id=\"comment:10\" align=\"right\">comment:10</div>\n\nSomething like <code>:python:\\`RuntimeError<library/exceptions.html#exceptions.RuntimeError>\\`</code> should work for Python-links.\n\nChanging `ellipsis marker (...)` to <code>ellipsis marker \\`\\`...\\`\\`</code> would (IMHO) make it clearer what the actual marker is, since it is typeset as code (tt-font). What do you think?",
"created_at": "2016-03-17T07:02:15Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289923",
"user": "https://github.com/dkrenn"
}comment:10
Something like :python:`RuntimeError<library/exceptions.html#exceptions.RuntimeError>` should work for Python-links.
Changing ellipsis marker (...) to ellipsis marker ``...`` would (IMHO) make it clearer what the actual marker is, since it is typeset as code (tt-font). What do you think?
archive/issue_comments_289924.json:
{
"body": "Changed commit from **[`b4456b1`](https://github.com/sagemath/sagetrac-mirror/commit/b4456b1047adff22bd4e5b6c56425933f89e3894)** to **[`57bfdee`](https://github.com/sagemath/sagetrac-mirror/commit/57bfdee4eec37a346ed6d05d262c919087f8d3da)**",
"created_at": "2016-03-18T03:00:15Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289924",
"user": "https://github.com/sagetrac-git"
}Changed commit from b4456b1 to 57bfdee
archive/issue_comments_289925.json:
{
"body": "<div id=\"comment:11\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/57bfdee4eec37a346ed6d05d262c919087f8d3da\"><code>57bfdee</code></a></td><td><code>Improve python-link</code></td></tr></table>\n",
"created_at": "2016-03-18T03:00:15Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289925",
"user": "https://github.com/sagetrac-git"
}Branch pushed to git repo; I updated commit sha1. New commits:
57bfdee | Improve python-link |
archive/issue_comments_289926.json:
{
"body": "<div id=\"comment:12\" align=\"right\">comment:12</div>\n\nReplying to [@dkrenn](#comment%3A10):\n> Something like <code>:python:\\`RuntimeError<library/exceptions.html#exceptions.RuntimeError>\\`</code> should work for Python-links.\n> \n> Changing `ellipsis marker (...)` to <code>ellipsis marker \\`\\`...\\`\\`</code> would (IMHO) make it clearer what the actual marker is, since it is typeset as code (tt-font). What do you think?\n\nNice tips. Thank you!",
"created_at": "2016-03-18T03:01:13Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289926",
"user": "https://github.com/kwankyu"
}comment:12
Replying to @dkrenn:
Something like
:python:`RuntimeError<library/exceptions.html#exceptions.RuntimeError>`should work for Python-links.Changing
ellipsis marker (...)toellipsis marker ``...``would (IMHO) make it clearer what the actual marker is, since it is typeset as code (tt-font). What do you think?
Nice tips. Thank you!
archive/issue_events_282325.json:
{
"actor": "https://github.com/kwankyu",
"created_at": "2016-03-18T03:01:52Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20176",
"label": "https://github.com/sagemath/sage/labels/needs%20work",
"label_color": "ffff00",
"label_name": "needs work",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282325"
}archive/issue_events_282326.json:
{
"actor": "https://github.com/kwankyu",
"created_at": "2016-03-18T03:01:52Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20176",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282326"
}archive/issue_events_282327.json:
{
"actor": "https://github.com/dkrenn",
"created_at": "2016-03-18T13:28:44Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20176",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282327"
}archive/issue_events_282328.json:
{
"actor": "https://github.com/dkrenn",
"created_at": "2016-03-18T13:28:44Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20176",
"label": "https://github.com/sagemath/sage/labels/needs%20work",
"label_color": "ffff00",
"label_name": "needs work",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282328"
}archive/issue_comments_289927.json:
{
"body": "<div id=\"comment:14\" align=\"right\">comment:14</div>\n\nThanks for changing. One very small issue I just saw now: Could you make two line-breaks to avoid the long lines? (PEP8)\nApart from this, positive_review.",
"created_at": "2016-03-18T13:28:44Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289927",
"user": "https://github.com/dkrenn"
}comment:14
Thanks for changing. One very small issue I just saw now: Could you make two line-breaks to avoid the long lines? (PEP8) Apart from this, positive_review.
archive/issue_comments_289928.json:
{
"body": "<div id=\"comment:15\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/5694f4ee95ce733d7b30619f23fcd17177194207\"><code>5694f4e</code></a></td><td><code>Split long lines</code></td></tr></table>\n",
"created_at": "2016-03-18T15:26:23Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289928",
"user": "https://github.com/sagetrac-git"
}Branch pushed to git repo; I updated commit sha1. New commits:
5694f4e | Split long lines |
archive/issue_comments_289929.json:
{
"body": "Changed commit from **[`57bfdee`](https://github.com/sagemath/sagetrac-mirror/commit/57bfdee4eec37a346ed6d05d262c919087f8d3da)** to **[`5694f4e`](https://github.com/sagemath/sagetrac-mirror/commit/5694f4ee95ce733d7b30619f23fcd17177194207)**",
"created_at": "2016-03-18T15:26:23Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289929",
"user": "https://github.com/sagetrac-git"
}Changed commit from 57bfdee to 5694f4e
archive/issue_events_282329.json:
{
"actor": "https://github.com/kwankyu",
"created_at": "2016-03-22T01:26:56Z",
"event": "demilestoned",
"issue": "https://github.com/sagemath/sage/issues/20176",
"milestone_number": null,
"milestone_title": "sage-7.1",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282329"
}archive/issue_events_282330.json:
{
"actor": "https://github.com/kwankyu",
"created_at": "2016-03-22T01:26:56Z",
"event": "milestoned",
"issue": "https://github.com/sagemath/sage/issues/20176",
"milestone_number": null,
"milestone_title": "sage-7.2",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282330"
}archive/issue_events_282331.json:
{
"actor": "https://github.com/kwankyu",
"created_at": "2016-03-23T04:24:19Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20176",
"label": "https://github.com/sagemath/sage/labels/needs%20work",
"label_color": "ffff00",
"label_name": "needs work",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282331"
}archive/issue_events_282332.json:
{
"actor": "https://github.com/kwankyu",
"created_at": "2016-03-23T04:24:19Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20176",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282332"
}archive/issue_comments_289930.json:
{
"body": "<div id=\"comment:18\" align=\"right\">comment:18</div>\n\nLooks good now.",
"created_at": "2016-03-23T10:34:06Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289930",
"user": "https://github.com/dkrenn"
}comment:18
Looks good now.
archive/issue_events_282333.json:
{
"actor": "https://github.com/dkrenn",
"created_at": "2016-03-23T10:34:06Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20176",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282333"
}archive/issue_events_282334.json:
{
"actor": "https://github.com/dkrenn",
"created_at": "2016-03-23T10:34:06Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20176",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282334"
}archive/issue_events_282335.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-03-23T23:55:01Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20176",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282335"
}archive/issue_events_282336.json:
{
"actor": "https://github.com/vbraun",
"commit_id": "a4669c9319c62886042da00566308c44cb472b27",
"commit_repository": "https://github.com/sagemath/sage",
"created_at": "2016-03-23T23:55:01Z",
"event": "closed",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20176#event-282336"
}archive/issue_comments_289931.json:
{
"body": "Changed branch from **[public/20176](https://github.com/sagemath/sagetrac-mirror/tree/public/20176)** to **[`5694f4e`](https://github.com/sagemath/sagetrac-mirror/commit/5694f4ee95ce733d7b30619f23fcd17177194207)**",
"created_at": "2016-03-23T23:55:01Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20176",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20176#issuecomment-289931",
"user": "https://github.com/vbraun"
}Changed branch from public/20176 to 5694f4e