Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Latest commit

 

History

History
681 lines (508 loc) · 25.7 KB

20233.md

File metadata and controls

681 lines (508 loc) · 25.7 KB

Issue 20233: AbstractLinearCode.minimum_distance fails with GAP message for large fields

archive/issues_019996.json:

{
    "assignees": [],
    "body": "<div id=\"comment:0\"></div>\n\nThe following works:\n\n```\n   C = LinearCode(random_matrix(GF(5^2,'a'), 2, 5)); C.minimum_distance()\n```\n\nwhile the following explodes with a GAP error\n\n```\n   C = LinearCode(random_matrix(GF(17^2,'a'), 2, 5)); C.minimum_distance()\n```\n\nIt seems to be conditioned only on the size of the field: All fields with cardinality greater than 256 seem to fail.\n\n\nCC:  @sagetrac-dlucas @wdjoyner\n\nComponent: **coding theory**\n\nKeywords: **sd75**\n\nAuthor: **Joe Fields**\n\nBranch/Commit: **[`2809840`](https://github.com/sagemath/sagetrac-mirror/commit/2809840d085219903103521bb9a79c74994b2005)**\n\nReviewer: **Travis Scrimshaw**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20233_\n\n",
    "closed_at": "2016-09-10T09:00:30Z",
    "created_at": "2016-03-19T17:48:38Z",
    "labels": [
        "https://github.com/sagemath/sage/labels/c%3A%20coding%20theory",
        "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
        "https://github.com/sagemath/sage/labels/bug"
    ],
    "milestone": "https://github.com/sagemath/sage/milestones/sage-7.4",
    "reactions": [],
    "repository": "https://github.com/sagemath/sage",
    "title": "`AbstractLinearCode.minimum_distance` fails with GAP message for large fields",
    "type": "issue",
    "updated_at": "2016-09-10T09:00:30Z",
    "url": "https://github.com/sagemath/sage/issues/20233",
    "user": "https://github.com/johanrosenkilde"
}

The following works:

   C = LinearCode(random_matrix(GF(5^2,'a'), 2, 5)); C.minimum_distance()

while the following explodes with a GAP error

   C = LinearCode(random_matrix(GF(17^2,'a'), 2, 5)); C.minimum_distance()

It seems to be conditioned only on the size of the field: All fields with cardinality greater than 256 seem to fail.

CC: @sagetrac-dlucas @wdjoyner

Component: coding theory

Keywords: sd75

Author: Joe Fields

Branch/Commit: 2809840

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20233


archive/issue_events_283128.json:

{
    "actor": "https://github.com/johanrosenkilde",
    "created_at": "2016-03-19T17:48:38Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "milestone_number": null,
    "milestone_title": "sage-7.1",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20233#event-283128"
}

archive/issue_events_283129.json:

{
    "actor": "https://github.com/johanrosenkilde",
    "created_at": "2016-03-19T17:48:38Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "label": "https://github.com/sagemath/sage/labels/c%3A%20coding%20theory",
    "label_color": "0000ff",
    "label_name": "c: coding theory",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20233#event-283129"
}

archive/issue_events_283130.json:

{
    "actor": "https://github.com/johanrosenkilde",
    "created_at": "2016-03-19T17:48:38Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
    "label_color": "ffbb00",
    "label_name": "p: major / 3",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20233#event-283130"
}

archive/issue_events_283131.json:

{
    "actor": "https://github.com/johanrosenkilde",
    "created_at": "2016-03-19T17:48:38Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "label": "https://github.com/sagemath/sage/labels/bug",
    "label_color": "d73a4a",
    "label_name": "bug",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20233#event-283131"
}

archive/issue_comments_291101.json:

{
    "body": "Branch: **[u/jfields/gap_min_dist_field_size](https://github.com/sagemath/sagetrac-mirror/tree/u/jfields/gap_min_dist_field_size)**",
    "created_at": "2016-08-26T09:44:06Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291101",
    "user": "https://github.com/osj1961"
}

Branch: u/jfields/gap_min_dist_field_size


archive/issue_comments_291102.json:

{
    "body": "<div id=\"comment:2\" align=\"right\">comment:2</div>\n\nThe GAP algorithms which sage is calling for minimum_distance() have a (poorly) documented limitation -- field size of at most 256.\nI added a check on the field size and raise a \"not implemented\" exception in that case.   So at least the user will get some explanation \nof the problem rather than an incomprehensible stack dump.\n\n---\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/2d4768234e1570307125c8479e77454871402705\"><code>2d47682</code></a></td><td><code>Added a check on the size of the finite field in minimum_distance() computation.</code></td></tr></table>\n",
    "created_at": "2016-08-26T09:47:54Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291102",
    "user": "https://github.com/osj1961"
}
comment:2

The GAP algorithms which sage is calling for minimum_distance() have a (poorly) documented limitation -- field size of at most 256. I added a check on the field size and raise a "not implemented" exception in that case. So at least the user will get some explanation of the problem rather than an incomprehensible stack dump.


New commits:

2d47682Added a check on the size of the finite field in minimum_distance() computation.

archive/issue_comments_291103.json:

{
    "body": "Commit: **[`2d47682`](https://github.com/sagemath/sagetrac-mirror/commit/2d4768234e1570307125c8479e77454871402705)**",
    "created_at": "2016-08-26T09:47:54Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291103",
    "user": "https://github.com/osj1961"
}

Commit: 2d47682


archive/issue_events_283132.json:

{
    "actor": "https://github.com/osj1961",
    "created_at": "2016-08-26T09:47:54Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20233#event-283132"
}

archive/issue_comments_291104.json:

{
    "body": "<div id=\"comment:3\" align=\"right\">comment:3</div>\n\nSome minor things:\n- I would put the fact that this only works for fields up to 256 in either a `.. NOTE::` or `.. WARNING::` block so it's more prominent in the documentation.\n- You should add something just before the added doctest, something like `The field must be size at most 256::`. I would also split the line like this:\n\n  ```\n            NotImplementedError: The GAP algorithms that sage is using\n             are limited to computing with fields of size at most 256.\n  ```\n- To be PEP8 compliant, you should align the string start points:\n\n  ```python\n            raise NotImplementedError(\"the GAP algorithm that Sage is using \"\n                                      \"is limited to computing with fields \"\n                                      \"of size at most 256\")\n  ```\n  I've also suggested a few minor changes to the error message. Although I might consider limiting the actual message to something like `the field must have size at most 256` with a more detailed comment just before it saying the issue is in GAP for those looking at the code itself.",
    "created_at": "2016-08-26T15:09:14Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291104",
    "user": "https://github.com/tscrim"
}
comment:3

Some minor things:

  • I would put the fact that this only works for fields up to 256 in either a .. NOTE:: or .. WARNING:: block so it's more prominent in the documentation.

  • You should add something just before the added doctest, something like The field must be size at most 256::. I would also split the line like this:

              NotImplementedError: The GAP algorithms that sage is using
               are limited to computing with fields of size at most 256.
    
  • To be PEP8 compliant, you should align the string start points:

              raise NotImplementedError("the GAP algorithm that Sage is using "
                                        "is limited to computing with fields "
                                        "of size at most 256")

    I've also suggested a few minor changes to the error message. Although I might consider limiting the actual message to something like the field must have size at most 256 with a more detailed comment just before it saying the issue is in GAP for those looking at the code itself.


archive/issue_comments_291105.json:

{
    "body": "Changed commit from **[`2d47682`](https://github.com/sagemath/sagetrac-mirror/commit/2d4768234e1570307125c8479e77454871402705)** to **[`4949d06`](https://github.com/sagemath/sagetrac-mirror/commit/4949d062c3fd912b3bb4fba2332b191e37f6968d)**",
    "created_at": "2016-09-08T20:06:10Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291105",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 2d47682 to 4949d06


archive/issue_comments_291106.json:

{
    "body": "<div id=\"comment:4\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/696edb0fff43b7fff69e94ef843fb56e18469697\"><code>696edb0</code></a></td><td><code>small fixes per tscrim's suggestions.</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/4949d062c3fd912b3bb4fba2332b191e37f6968d\"><code>4949d06</code></a></td><td><code>Fixed formatting of the ..warning:: block.</code></td></tr></table>\n",
    "created_at": "2016-09-08T20:06:10Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291106",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

696edb0small fixes per tscrim's suggestions.
4949d06Fixed formatting of the ..warning:: block.

archive/issue_comments_291107.json:

{
    "body": "Changed commit from **[`4949d06`](https://github.com/sagemath/sagetrac-mirror/commit/4949d062c3fd912b3bb4fba2332b191e37f6968d)** to **[`dcaafe2`](https://github.com/sagemath/sagetrac-mirror/commit/dcaafe2e732cf40770f30a5ef0f2c0eac586b6ee)**",
    "created_at": "2016-09-08T20:11:38Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291107",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 4949d06 to dcaafe2


archive/issue_comments_291108.json:

{
    "body": "<div id=\"comment:5\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/dcaafe2e732cf40770f30a5ef0f2c0eac586b6ee\"><code>dcaafe2</code></a></td><td><code>Added the sentence</code></td></tr></table>\n",
    "created_at": "2016-09-08T20:11:38Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291108",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

dcaafe2Added the sentence

archive/issue_comments_291109.json:

{
    "body": "<div id=\"comment:6\" align=\"right\">comment:6</div>\n\nNot sure if I did what you intended regarding adding the sentence before the doctest.",
    "created_at": "2016-09-08T20:15:02Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291109",
    "user": "https://github.com/osj1961"
}
comment:6

Not sure if I did what you intended regarding adding the sentence before the doctest.


archive/issue_events_283133.json:

{
    "actor": "https://github.com/tscrim",
    "created_at": "2016-09-09T13:59:39Z",
    "event": "demilestoned",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "milestone_number": null,
    "milestone_title": "sage-7.1",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20233#event-283133"
}

archive/issue_events_283134.json:

{
    "actor": "https://github.com/tscrim",
    "created_at": "2016-09-09T13:59:39Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "milestone_number": null,
    "milestone_title": "sage-7.4",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20233#event-283134"
}

archive/issue_comments_291110.json:

{
    "body": "Reviewer: **Travis Scrimshaw**",
    "created_at": "2016-09-09T13:59:39Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291110",
    "user": "https://github.com/tscrim"
}

Reviewer: Travis Scrimshaw


archive/issue_comments_291111.json:

{
    "body": "Changed branch from **[u/jfields/gap_min_dist_field_size](https://github.com/sagemath/sagetrac-mirror/tree/u/jfields/gap_min_dist_field_size)** to **[u/tscrim/20233](https://github.com/sagemath/sagetrac-mirror/tree/u/tscrim/20233)**",
    "created_at": "2016-09-09T13:59:39Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291111",
    "user": "https://github.com/tscrim"
}

Changed branch from u/jfields/gap_min_dist_field_size to u/tscrim/20233


archive/issue_comments_291112.json:

{
    "body": "<div id=\"comment:7\" align=\"right\">comment:7</div>\n\nI made some small tweaks. If you're good with my changes, then you can set a positive review (and don't forget to add your real name to the authors field).\n\n---\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/72f01a7524e00074040bd2ca927e799b1da53116\"><code>72f01a7</code></a></td><td><code>Merge branch 'u/jfields/gap_min_dist_field_size' of git://trac.sagemath.org/sage into u/jfields/gap_min_dist_field_size</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/2809840d085219903103521bb9a79c74994b2005\"><code>2809840</code></a></td><td><code>Some small reviewer changes.</code></td></tr></table>\n",
    "created_at": "2016-09-09T13:59:39Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291112",
    "user": "https://github.com/tscrim"
}
comment:7

I made some small tweaks. If you're good with my changes, then you can set a positive review (and don't forget to add your real name to the authors field).


New commits:

72f01a7Merge branch 'u/jfields/gap_min_dist_field_size' of git://trac.sagemath.org/sage into u/jfields/gap_min_dist_field_size
2809840Some small reviewer changes.

archive/issue_comments_291113.json:

{
    "body": "Changed commit from **[`dcaafe2`](https://github.com/sagemath/sagetrac-mirror/commit/dcaafe2e732cf40770f30a5ef0f2c0eac586b6ee)** to **[`2809840`](https://github.com/sagemath/sagetrac-mirror/commit/2809840d085219903103521bb9a79c74994b2005)**",
    "created_at": "2016-09-09T13:59:39Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291113",
    "user": "https://github.com/tscrim"
}

Changed commit from dcaafe2 to 2809840


archive/issue_comments_291114.json:

{
    "body": "Author: **Joe Fields**",
    "created_at": "2016-09-09T17:00:45Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291114",
    "user": "https://github.com/osj1961"
}

Author: Joe Fields


archive/issue_events_283135.json:

{
    "actor": "https://github.com/osj1961",
    "created_at": "2016-09-09T17:00:45Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20233#event-283135"
}

archive/issue_events_283136.json:

{
    "actor": "https://github.com/osj1961",
    "created_at": "2016-09-09T17:00:45Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20233#event-283136"
}

archive/issue_comments_291115.json:

{
    "body": "<div id=\"comment:8\" align=\"right\">comment:8</div>\n\nThanks Travis, your changes are definitely fine. I've switched the status to \"positive review.\"  Please forgive a noob question: do I need to do anything git-wise about merging your changes?  It looks like I don't but I'd rather be safe than sorry...",
    "created_at": "2016-09-09T17:00:45Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291115",
    "user": "https://github.com/osj1961"
}
comment:8

Thanks Travis, your changes are definitely fine. I've switched the status to "positive review." Please forgive a noob question: do I need to do anything git-wise about merging your changes? It looks like I don't but I'd rather be safe than sorry...


archive/issue_comments_291116.json:

{
    "body": "<div id=\"comment:9\" align=\"right\">comment:9</div>\n\nAdded the keyword sd75 to the ticket as this is work that began during the Sage Days 75 at INRIA Saclay.",
    "created_at": "2016-09-09T17:12:00Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291116",
    "user": "https://github.com/osj1961"
}
comment:9

Added the keyword sd75 to the ticket as this is work that began during the Sage Days 75 at INRIA Saclay.


archive/issue_comments_291117.json:

{
    "body": "Changed keywords from none to **sd75**",
    "created_at": "2016-09-09T17:12:00Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291117",
    "user": "https://github.com/osj1961"
}

Changed keywords from none to sd75


archive/issue_comments_291118.json:

{
    "body": "<div id=\"comment:10\" align=\"right\">comment:10</div>\n\nReplying to [@osj1961](#comment%3A8):\n> Thanks Travis, your changes are definitely fine. I've switched the status to \"positive review.\"  Please forgive a noob question: do I need to do anything git-wise about merging your changes?  It looks like I don't but I'd rather be safe than sorry...\n\nNo, there's nothing you need to do (in fact, mine are based on a later version of Sage than your previous push, so you might not want to pull them at this point).",
    "created_at": "2016-09-09T17:18:49Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291118",
    "user": "https://github.com/tscrim"
}
comment:10

Replying to @osj1961:

Thanks Travis, your changes are definitely fine. I've switched the status to "positive review." Please forgive a noob question: do I need to do anything git-wise about merging your changes? It looks like I don't but I'd rather be safe than sorry...

No, there's nothing you need to do (in fact, mine are based on a later version of Sage than your previous push, so you might not want to pull them at this point).


archive/issue_comments_291119.json:

{
    "body": "Changed branch from **[u/tscrim/20233](https://github.com/sagemath/sagetrac-mirror/tree/u/tscrim/20233)** to **[`2809840`](https://github.com/sagemath/sagetrac-mirror/commit/2809840d085219903103521bb9a79c74994b2005)**",
    "created_at": "2016-09-10T09:00:30Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20233#issuecomment-291119",
    "user": "https://github.com/vbraun"
}

Changed branch from u/tscrim/20233 to 2809840


archive/issue_events_283137.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-09-10T09:00:30Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20233#event-283137"
}

archive/issue_events_283138.json:

{
    "actor": "https://github.com/vbraun",
    "commit_id": "1d51e878596e503d3f30bd76ffc71dbff4267a00",
    "commit_repository": "https://github.com/sagemath/sage",
    "created_at": "2016-09-10T09:00:30Z",
    "event": "closed",
    "issue": "https://github.com/sagemath/sage/issues/20233",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20233#event-283138"
}