Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Latest commit

 

History

History
1357 lines (1007 loc) · 49.7 KB

20260.md

File metadata and controls

1357 lines (1007 loc) · 49.7 KB

Issue 20260: p-adic polylogarithms, after Besser-de Jeu

archive/issues_020023.json:

{
    "assignees": [],
    "body": "<div id=\"comment:0\"></div>\n\nAdd code to compute p-adic polylogarithms, in particular, Li_n, based on the work of Besser and de Jeu (\"Li<sup>(p)</sup>-service? An algorithm for computing p-adic polylogarithms\").\n\nCC:  @sagetrac-frvillegas @xcaruso @kedlaya\n\nComponent: **padics**\n\nKeywords: **days71, sd87, days88**\n\nAuthor: **Alex J. Best**\n\nBranch/Commit: **[`9a9b388`](https://github.com/sagemath/sagetrac-mirror/commit/9a9b388da4af27e3276e23b806b7f92f2f0b8244)**\n\nReviewer: **Aly Deines**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20260_\n\n",
    "closed_at": "2017-08-29T19:51:17Z",
    "created_at": "2016-03-23T13:44:30Z",
    "labels": [
        "https://github.com/sagemath/sage/labels/c%3A%20padics",
        "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
        "https://github.com/sagemath/sage/labels/enhancement"
    ],
    "milestone": "https://github.com/sagemath/sage/milestones/sage-7.2",
    "reactions": [],
    "repository": "https://github.com/sagemath/sage",
    "title": "p-adic polylogarithms, after Besser-de Jeu",
    "type": "issue",
    "updated_at": "2017-08-29T19:51:17Z",
    "url": "https://github.com/sagemath/sage/issues/20260",
    "user": "https://github.com/jbalakrishnan"
}

Add code to compute p-adic polylogarithms, in particular, Li_n, based on the work of Besser and de Jeu ("Li(p)-service? An algorithm for computing p-adic polylogarithms").

CC: @sagetrac-frvillegas @xcaruso @kedlaya

Component: padics

Keywords: days71, sd87, days88

Author: Alex J. Best

Branch/Commit: 9a9b388

Reviewer: Aly Deines

Issue created by migration from https://trac.sagemath.org/ticket/20260


archive/issue_events_283480.json:

{
    "actor": "https://github.com/jbalakrishnan",
    "created_at": "2016-03-23T13:44:30Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "milestone_number": null,
    "milestone_title": "sage-7.2",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20260#event-283480"
}

archive/issue_events_283481.json:

{
    "actor": "https://github.com/jbalakrishnan",
    "created_at": "2016-03-23T13:44:30Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "label": "https://github.com/sagemath/sage/labels/c%3A%20padics",
    "label_color": "0000ff",
    "label_name": "c: padics",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20260#event-283481"
}

archive/issue_events_283482.json:

{
    "actor": "https://github.com/jbalakrishnan",
    "created_at": "2016-03-23T13:44:30Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
    "label_color": "ffbb00",
    "label_name": "p: major / 3",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20260#event-283482"
}

archive/issue_events_283483.json:

{
    "actor": "https://github.com/jbalakrishnan",
    "created_at": "2016-03-23T13:44:30Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "label": "https://github.com/sagemath/sage/labels/enhancement",
    "label_color": "696969",
    "label_name": "enhancement",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20260#event-283483"
}

archive/issue_comments_291714.json:

{
    "body": "Changed keywords from **days71** to **days71, sd87**",
    "created_at": "2017-07-17T17:39:07Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291714",
    "user": "https://github.com/roed314"
}

Changed keywords from days71 to days71, sd87


archive/issue_comments_291715.json:

{
    "body": "Branch: **[u/alexjbest/padicpolylog](https://github.com/sagemath/sagetrac-mirror/tree/u/alexjbest/padicpolylog)**",
    "created_at": "2017-07-21T18:47:56Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291715",
    "user": "https://github.com/alexjbest"
}

Branch: u/alexjbest/padicpolylog


archive/issue_comments_291716.json:

{
    "body": "<div id=\"comment:4\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/41c9c1a931d9105a3bcc85450ffb1b1c0dc05623\"><code>41c9c1a</code></a></td><td><code>initial implementation of padic polylogarithms</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/b591293b9e48e70de27cb5ce4a6bf915ae83977a\"><code>b591293</code></a></td><td><code>finish polylog implementation</code></td></tr></table>\n",
    "created_at": "2017-07-21T18:49:46Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291716",
    "user": "https://github.com/alexjbest"
}

New commits:

41c9c1ainitial implementation of padic polylogarithms
b591293finish polylog implementation

archive/issue_comments_291717.json:

{
    "body": "Commit: **[`b591293`](https://github.com/sagemath/sagetrac-mirror/commit/b591293b9e48e70de27cb5ce4a6bf915ae83977a)**",
    "created_at": "2017-07-21T18:49:46Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291717",
    "user": "https://github.com/alexjbest"
}

Commit: b591293


archive/issue_events_283484.json:

{
    "actor": "https://github.com/alexjbest",
    "created_at": "2017-07-21T18:49:46Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20260#event-283484"
}

archive/issue_comments_291718.json:

{
    "body": "Author: **alexjbest**",
    "created_at": "2017-07-21T18:49:46Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291718",
    "user": "https://github.com/alexjbest"
}

Author: alexjbest


archive/issue_comments_291719.json:

{
    "body": "Description changed:\n``````diff\n--- \n+++ \n@@ -1 +1 @@\n-We plan to add code to compute p-adic polylogarithms, in particular, Li_n, based on the work of Besser and de Jeu (\"Li<sup>(p)</sup>-service? An algorithm for computing p-adic polylogarithms\").\n+Add code to compute p-adic polylogarithms, in particular, Li_n, based on the work of Besser and de Jeu (\"Li<sup>(p)</sup>-service? An algorithm for computing p-adic polylogarithms\").\n``````\n",
    "created_at": "2017-07-21T18:49:46Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291719",
    "user": "https://github.com/alexjbest"
}

Description changed:

--- 
+++ 
@@ -1 +1 @@
-We plan to add code to compute p-adic polylogarithms, in particular, Li_n, based on the work of Besser and de Jeu ("Li<sup>(p)</sup>-service? An algorithm for computing p-adic polylogarithms").
+Add code to compute p-adic polylogarithms, in particular, Li_n, based on the work of Besser and de Jeu ("Li<sup>(p)</sup>-service? An algorithm for computing p-adic polylogarithms").

archive/issue_comments_291720.json:

{
    "body": "<div id=\"comment:5\" align=\"right\">comment:5</div>\n\nThis has some trailing whitespace that should be removed.",
    "created_at": "2017-07-21T19:01:48Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291720",
    "user": "https://github.com/adeines"
}
comment:5

This has some trailing whitespace that should be removed.


archive/issue_comments_291721.json:

{
    "body": "Changed commit from **[`b591293`](https://github.com/sagemath/sagetrac-mirror/commit/b591293b9e48e70de27cb5ce4a6bf915ae83977a)** to **[`e5f1701`](https://github.com/sagemath/sagetrac-mirror/commit/e5f1701274052616477fe61b6658dc829e7c838e)**",
    "created_at": "2017-07-21T19:06:14Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291721",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from b591293 to e5f1701


archive/issue_comments_291722.json:

{
    "body": "<div id=\"comment:6\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/e5f1701274052616477fe61b6658dc829e7c838e\"><code>e5f1701</code></a></td><td><code>remove trailing whitespace</code></td></tr></table>\n",
    "created_at": "2017-07-21T19:06:14Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291722",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

e5f1701remove trailing whitespace

archive/issue_events_283485.json:

{
    "actor": "https://github.com/adeines",
    "created_at": "2017-07-21T19:23:02Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20260#event-283485"
}

archive/issue_events_283486.json:

{
    "actor": "https://github.com/adeines",
    "created_at": "2017-07-21T19:23:02Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20260#event-283486"
}

archive/issue_comments_291723.json:

{
    "body": "<div id=\"comment:8\" align=\"right\">comment:8</div>\n\n* You must not recreate the parent (by `K = Qp(p,prec)`) but instead write `K = self.parent().fraction_field()` (in order to keep the same modes)\n* You should compute once for all `K(self)` and give a name to it\n* Why are you using the name `_polylog_c` whereas your function is not written in C\n* Is that really useful to have three external functions (namely `_polylog_c`, `_findprec` and `_compute_g`); cannot we instead include them directly in the method `polylog`\n* Instead of\n\n```\n        for x in K.teichmuller_system():\n            if (self - x).valuation() > 0:\n                zeta = x\n``` \nyou probably should write `zeta = K.teichmuller(x)`.",
    "created_at": "2017-07-21T22:35:14Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291723",
    "user": "https://github.com/xcaruso"
}
comment:8
  • You must not recreate the parent (by K = Qp(p,prec)) but instead write K = self.parent().fraction_field() (in order to keep the same modes)
  • You should compute once for all K(self) and give a name to it
  • Why are you using the name _polylog_c whereas your function is not written in C
  • Is that really useful to have three external functions (namely _polylog_c, _findprec and _compute_g); cannot we instead include them directly in the method polylog
  • Instead of
        for x in K.teichmuller_system():
            if (self - x).valuation() > 0:
                zeta = x

you probably should write zeta = K.teichmuller(x).


archive/issue_comments_291724.json:

{
    "body": "<div id=\"comment:9\" align=\"right\">comment:9</div>\n\nYou should put a real name into the Authors field (so it shows up like that in the change notes.)",
    "created_at": "2017-07-23T21:18:30Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291724",
    "user": "https://github.com/saraedum"
}
comment:9

You should put a real name into the Authors field (so it shows up like that in the change notes.)


archive/issue_comments_291725.json:

{
    "body": "Changed author from **alexjbest** to none",
    "created_at": "2017-07-23T21:18:30Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291725",
    "user": "https://github.com/saraedum"
}

Changed author from alexjbest to none


archive/issue_comments_291726.json:

{
    "body": "Changed commit from **[`e5f1701`](https://github.com/sagemath/sagetrac-mirror/commit/e5f1701274052616477fe61b6658dc829e7c838e)** to **[`d22d7a2`](https://github.com/sagemath/sagetrac-mirror/commit/d22d7a25db9f892050de5e3484df5633386eaeb6)**",
    "created_at": "2017-08-07T05:16:58Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291726",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from e5f1701 to d22d7a2


archive/issue_comments_291727.json:

{
    "body": "<div id=\"comment:10\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/d22d7a25db9f892050de5e3484df5633386eaeb6\"><code>d22d7a2</code></a></td><td><code>Improved polylog implementation</code></td></tr></table>\n",
    "created_at": "2017-08-07T05:16:58Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291727",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

d22d7a2Improved polylog implementation

archive/issue_comments_291728.json:

{
    "body": "Author: **Alex J. Best**",
    "created_at": "2017-08-07T05:22:25Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291728",
    "user": "https://github.com/alexjbest"
}

Author: Alex J. Best


archive/issue_events_283487.json:

{
    "actor": "https://github.com/alexjbest",
    "created_at": "2017-08-07T05:22:25Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20260#event-283487"
}

archive/issue_events_283488.json:

{
    "actor": "https://github.com/alexjbest",
    "created_at": "2017-08-07T05:22:25Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20260#event-283488"
}

archive/issue_comments_291729.json:

{
    "body": "<div id=\"comment:11\" align=\"right\">comment:11</div>\n\nThanks for all the comments caruso, I have made many of the changes you suggested, we discussed this offline but for completeness of the ticket:\n\nRegarding the module functions, they are used in two of the public methods, so they cannot really be moved/removed, and the function _c is so named to be consistent with the paper of Besser-de Jeu I've tried to make that clearer in the docstring.\nThe way precision works has been made much better, the user no longer specifies a precision instead the best possible is chosen and it is up to the user to change their element to lower precision first if they want quicker evaluation.",
    "created_at": "2017-08-07T05:22:25Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291729",
    "user": "https://github.com/alexjbest"
}
comment:11

Thanks for all the comments caruso, I have made many of the changes you suggested, we discussed this offline but for completeness of the ticket:

Regarding the module functions, they are used in two of the public methods, so they cannot really be moved/removed, and the function _c is so named to be consistent with the paper of Besser-de Jeu I've tried to make that clearer in the docstring. The way precision works has been made much better, the user no longer specifies a precision instead the best possible is chosen and it is up to the user to change their element to lower precision first if they want quicker evaluation.


archive/issue_comments_291730.json:

{
    "body": "Changed commit from **[`d22d7a2`](https://github.com/sagemath/sagetrac-mirror/commit/d22d7a25db9f892050de5e3484df5633386eaeb6)** to **[`3655591`](https://github.com/sagemath/sagetrac-mirror/commit/36555913e09a3319384d8487528a5656d19debeb)**",
    "created_at": "2017-08-08T16:41:30Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291730",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from d22d7a2 to 3655591


archive/issue_comments_291731.json:

{
    "body": "<div id=\"comment:12\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/36555913e09a3319384d8487528a5656d19debeb\"><code>3655591</code></a></td><td><code>Fix docstring</code></td></tr></table>\n",
    "created_at": "2017-08-08T16:41:30Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291731",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

3655591Fix docstring

archive/issue_comments_291732.json:

{
    "body": "<div id=\"comment:13\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/1adce545f98d83e726e9faa00c4d10de49acf7e8\"><code>1adce54</code></a></td><td><code>made a lot of improvements suggested by roed and caruso</code></td></tr></table>\n",
    "created_at": "2017-08-09T02:01:53Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291732",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

1adce54made a lot of improvements suggested by roed and caruso

archive/issue_comments_291733.json:

{
    "body": "Changed commit from **[`3655591`](https://github.com/sagemath/sagetrac-mirror/commit/36555913e09a3319384d8487528a5656d19debeb)** to **[`1adce54`](https://github.com/sagemath/sagetrac-mirror/commit/1adce545f98d83e726e9faa00c4d10de49acf7e8)**",
    "created_at": "2017-08-09T02:01:53Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291733",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 3655591 to 1adce54


archive/issue_comments_291734.json:

{
    "body": "Changed commit from **[`1adce54`](https://github.com/sagemath/sagetrac-mirror/commit/1adce545f98d83e726e9faa00c4d10de49acf7e8)** to **[`33b4e87`](https://github.com/sagemath/sagetrac-mirror/commit/33b4e87ebb9901b0cc8b4c695df5e0f3edf2790a)**",
    "created_at": "2017-08-09T04:33:19Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291734",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 1adce54 to 33b4e87


archive/issue_comments_291735.json:

{
    "body": "<div id=\"comment:14\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/33b4e87ebb9901b0cc8b4c695df5e0f3edf2790a\"><code>33b4e87</code></a></td><td><code>fix power series initialisation when tsl not an integer</code></td></tr></table>\n",
    "created_at": "2017-08-09T04:33:19Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291735",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

33b4e87fix power series initialisation when tsl not an integer

archive/issue_comments_291736.json:

{
    "body": "Changed commit from **[`33b4e87`](https://github.com/sagemath/sagetrac-mirror/commit/33b4e87ebb9901b0cc8b4c695df5e0f3edf2790a)** to **[`afc8e21`](https://github.com/sagemath/sagetrac-mirror/commit/afc8e211df6f1ca33bd285c25d8aff2d6f5c6712)**",
    "created_at": "2017-08-18T12:06:28Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291736",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 33b4e87 to afc8e21


archive/issue_comments_291737.json:

{
    "body": "<div id=\"comment:15\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/aafb6f0f90fd897fc5a3003b4a766125ed38d5b2\"><code>aafb6f0</code></a></td><td><code>Merge branch 'develop' into padicpolylog</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/afc8e211df6f1ca33bd285c25d8aff2d6f5c6712\"><code>afc8e21</code></a></td><td><code>Correct known precision in residue zero case</code></td></tr></table>\n",
    "created_at": "2017-08-18T12:06:28Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291737",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

aafb6f0Merge branch 'develop' into padicpolylog
afc8e21Correct known precision in residue zero case

archive/issue_comments_291738.json:

{
    "body": "<div id=\"comment:16\" align=\"right\">comment:16</div>\n\nHi Alex,\nThis doesn't currently merge.\n\nI won't be able to look at this over the weekend, but I'll be at Sage Days 88 next week and should have a chance then.",
    "created_at": "2017-08-19T06:11:27Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291738",
    "user": "https://github.com/roed314"
}
comment:16

Hi Alex, This doesn't currently merge.

I won't be able to look at this over the weekend, but I'll be at Sage Days 88 next week and should have a chance then.


archive/issue_comments_291739.json:

{
    "body": "<div id=\"comment:17\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/f2e28ffd2c5cdb7436709ab7c0a19264694212bd\"><code>f2e28ff</code></a></td><td><code>Merge branch 'develop' into padicpolylog</code></td></tr></table>\n",
    "created_at": "2017-08-19T07:46:41Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291739",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

f2e28ffMerge branch 'develop' into padicpolylog

archive/issue_comments_291740.json:

{
    "body": "Changed commit from **[`afc8e21`](https://github.com/sagemath/sagetrac-mirror/commit/afc8e211df6f1ca33bd285c25d8aff2d6f5c6712)** to **[`f2e28ff`](https://github.com/sagemath/sagetrac-mirror/commit/f2e28ffd2c5cdb7436709ab7c0a19264694212bd)**",
    "created_at": "2017-08-19T07:46:41Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291740",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from afc8e21 to f2e28ff


archive/issue_comments_291741.json:

{
    "body": "<div id=\"comment:18\" align=\"right\">comment:18</div>\n\nHi David, oops, hopefully it's fixed now.\nI'm pretty happy with the code right now, I've thrown a lot of tests at it and it looks to be working fine, so when you do get a chance more comments would be great!",
    "created_at": "2017-08-19T07:55:01Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291741",
    "user": "https://github.com/alexjbest"
}
comment:18

Hi David, oops, hopefully it's fixed now. I'm pretty happy with the code right now, I've thrown a lot of tests at it and it looks to be working fine, so when you do get a chance more comments would be great!


archive/issue_comments_291742.json:

{
    "body": "<div id=\"comment:19\" align=\"right\">comment:19</div>\n\nHi Alex, I found a couple typos in your documentation.\n* Rob De Jeu should be Rob de Jeu\n* Computation should be capitalized in Mathematics of Computation\n* Tate should be capitalized. \n* The year in the citation [DCW2015] should be 2016\n* In the polylog function, 'n'th the should be the `n`th\n* prop 6.1 should be Prop 6.1",
    "created_at": "2017-08-22T19:02:39Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291742",
    "user": "https://github.com/adeines"
}
comment:19

Hi Alex, I found a couple typos in your documentation.

  • Rob De Jeu should be Rob de Jeu
  • Computation should be capitalized in Mathematics of Computation
  • Tate should be capitalized.
  • The year in the citation [DCW2015] should be 2016
  • In the polylog function, 'n'th the should be the nth
  • prop 6.1 should be Prop 6.1

archive/issue_events_283489.json:

{
    "actor": "https://github.com/adeines",
    "created_at": "2017-08-22T19:02:39Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20260#event-283489"
}

archive/issue_events_283490.json:

{
    "actor": "https://github.com/adeines",
    "created_at": "2017-08-22T19:02:39Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20260#event-283490"
}

archive/issue_comments_291743.json:

{
    "body": "Changed keywords from **days71, sd87** to **days71, sd87, days88**",
    "created_at": "2017-08-22T21:14:01Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291743",
    "user": "https://github.com/jbalakrishnan"
}

Changed keywords from days71, sd87 to days71, sd87, days88


archive/issue_comments_291744.json:

{
    "body": "Changed commit from **[`f2e28ff`](https://github.com/sagemath/sagetrac-mirror/commit/f2e28ffd2c5cdb7436709ab7c0a19264694212bd)** to **[`5194c5a`](https://github.com/sagemath/sagetrac-mirror/commit/5194c5a3c11f8ecb5cdf415a5d9e1d6ce26073b8)**",
    "created_at": "2017-08-22T22:46:32Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291744",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from f2e28ff to 5194c5a


archive/issue_comments_291745.json:

{
    "body": "<div id=\"comment:21\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/5194c5a3c11f8ecb5cdf415a5d9e1d6ce26073b8\"><code>5194c5a</code></a></td><td><code>Fixes to doc</code></td></tr></table>\n",
    "created_at": "2017-08-22T22:46:32Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291745",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

5194c5aFixes to doc

archive/issue_comments_291746.json:

{
    "body": "Changed commit from **[`5194c5a`](https://github.com/sagemath/sagetrac-mirror/commit/5194c5a3c11f8ecb5cdf415a5d9e1d6ce26073b8)** to **[`1b581a2`](https://github.com/sagemath/sagetrac-mirror/commit/1b581a20a9e36d57e2c5eeaa8e63ead9c53d1a8b)**",
    "created_at": "2017-08-23T19:40:48Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291746",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 5194c5a to 1b581a2


archive/issue_comments_291747.json:

{
    "body": "<div id=\"comment:23\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/1b581a20a9e36d57e2c5eeaa8e63ead9c53d1a8b\"><code>1b581a2</code></a></td><td><code>More fixes to docs</code></td></tr></table>\n",
    "created_at": "2017-08-23T19:40:48Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291747",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

1b581a2More fixes to docs

archive/issue_comments_291748.json:

{
    "body": "Reviewer: **Aly Deines**",
    "created_at": "2017-08-23T20:34:58Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291748",
    "user": "https://github.com/adeines"
}

Reviewer: Aly Deines


archive/issue_comments_291749.json:

{
    "body": "<div id=\"comment:24\" align=\"right\">comment:24</div>\n\nSorry, I have another change.  Everywhere the citation [DCW2016] is referenced, the 2015 needs to be changed to 2016.  In particular:\n\n`2016.17 (2015): 5291-5354.`\n\nshould be\n\n`2016.17 (2016): 5291-5354.`\n\nThis occurs in two places.",
    "created_at": "2017-08-23T20:34:58Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291749",
    "user": "https://github.com/adeines"
}
comment:24

Sorry, I have another change. Everywhere the citation [DCW2016] is referenced, the 2015 needs to be changed to 2016. In particular:

2016.17 (2015): 5291-5354.

should be

2016.17 (2016): 5291-5354.

This occurs in two places.


archive/issue_comments_291750.json:

{
    "body": "<div id=\"comment:25\" align=\"right\">comment:25</div>\n\nNo problem, I like things to be as good/correct as possible!\nIn this instance I thought about it but was unsure what to do, if we look at https://academic.oup.com/imrn/article-abstract/2016/17/5291/2451667/Mixed-Tate-Motives-and-the-Unit-Equation?redirectedFrom=fulltext the journal issue is 2016 but date of publication listed as 2015, I don't know much about correct citation styles though.\nIf you still think it should be 2016 I will make it so!",
    "created_at": "2017-08-23T20:44:26Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291750",
    "user": "https://github.com/alexjbest"
}
comment:25

No problem, I like things to be as good/correct as possible! In this instance I thought about it but was unsure what to do, if we look at https://academic.oup.com/imrn/article-abstract/2016/17/5291/2451667/Mixed-Tate-Motives-and-the-Unit-Equation?redirectedFrom=fulltext the journal issue is 2016 but date of publication listed as 2015, I don't know much about correct citation styles though. If you still think it should be 2016 I will make it so!


archive/issue_comments_291751.json:

{
    "body": "<div id=\"comment:26\" align=\"right\">comment:26</div>\n\nHmm.  I was going off MathSciNet:\n\n```\nDan-Cohen, Ishai(D-DUES2M); Wewers, Stefan(D-ULM-IPM)\nMixed Tate motives and the unit equation. (English summary) \nInt. Math. Res. Not. IMRN 2016, no. 17, 5291\u20135354. \n```",
    "created_at": "2017-08-23T21:12:22Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291751",
    "user": "https://github.com/adeines"
}
comment:26

Hmm. I was going off MathSciNet:

Dan-Cohen, Ishai(D-DUES2M); Wewers, Stefan(D-ULM-IPM)
Mixed Tate motives and the unit equation. (English summary) 
Int. Math. Res. Not. IMRN 2016, no. 17, 5291–5354. 

archive/issue_comments_291752.json:

{
    "body": "Changed commit from **[`1b581a2`](https://github.com/sagemath/sagetrac-mirror/commit/1b581a20a9e36d57e2c5eeaa8e63ead9c53d1a8b)** to **[`48be838`](https://github.com/sagemath/sagetrac-mirror/commit/48be838a73c10e1558a489514260aeadc89625af)**",
    "created_at": "2017-08-23T21:27:59Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291752",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 1b581a2 to 48be838


archive/issue_comments_291753.json:

{
    "body": "<div id=\"comment:27\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/48be838a73c10e1558a489514260aeadc89625af\"><code>48be838</code></a></td><td><code>Change dates for references</code></td></tr></table>\n",
    "created_at": "2017-08-23T21:27:59Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291753",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

48be838Change dates for references

archive/issue_events_283491.json:

{
    "actor": "https://github.com/alexjbest",
    "created_at": "2017-08-24T11:09:16Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20260#event-283491"
}

archive/issue_events_283492.json:

{
    "actor": "https://github.com/alexjbest",
    "created_at": "2017-08-24T11:09:16Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20260#event-283492"
}

archive/issue_comments_291754.json:

{
    "body": "<div id=\"comment:28\" align=\"right\">comment:28</div>\n\nMathSciNet is good enough for me, thanks!",
    "created_at": "2017-08-24T11:09:16Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291754",
    "user": "https://github.com/alexjbest"
}
comment:28

MathSciNet is good enough for me, thanks!


archive/issue_comments_291755.json:

{
    "body": "Changed branch from **[u/alexjbest/padicpolylog](https://github.com/sagemath/sagetrac-mirror/tree/u/alexjbest/padicpolylog)** to **[u/aly.deines/padicpolylog](https://github.com/sagemath/sagetrac-mirror/tree/u/aly.deines/padicpolylog)**",
    "created_at": "2017-08-24T20:36:11Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291755",
    "user": "https://github.com/adeines"
}

Changed branch from u/alexjbest/padicpolylog to u/aly.deines/padicpolylog


archive/issue_comments_291756.json:

{
    "body": "<div id=\"comment:30\" align=\"right\">comment:30</div>\n\nI removed some trailing whitespace in the references.\n\nIt looks good to me.\n\n---\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/4b11445213e5bb93f1a516a693e6a7891c749f39\"><code>4b11445</code></a></td><td><code>Merge branch 'u/alexjbest/padicpolylog' of git://trac.sagemath.org/sage into t/20260/padicpolylog</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/9a9b388da4af27e3276e23b806b7f92f2f0b8244\"><code>9a9b388</code></a></td><td><code>Removed trailing whitespace.</code></td></tr></table>\n",
    "created_at": "2017-08-24T22:09:20Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291756",
    "user": "https://github.com/adeines"
}
comment:30

I removed some trailing whitespace in the references.

It looks good to me.


New commits:

4b11445Merge branch 'u/alexjbest/padicpolylog' of git://trac.sagemath.org/sage into t/20260/padicpolylog
9a9b388Removed trailing whitespace.

archive/issue_events_283493.json:

{
    "actor": "https://github.com/adeines",
    "created_at": "2017-08-24T22:09:20Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20260#event-283493"
}

archive/issue_events_283494.json:

{
    "actor": "https://github.com/adeines",
    "created_at": "2017-08-24T22:09:20Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20260#event-283494"
}

archive/issue_comments_291757.json:

{
    "body": "Changed commit from **[`48be838`](https://github.com/sagemath/sagetrac-mirror/commit/48be838a73c10e1558a489514260aeadc89625af)** to **[`9a9b388`](https://github.com/sagemath/sagetrac-mirror/commit/9a9b388da4af27e3276e23b806b7f92f2f0b8244)**",
    "created_at": "2017-08-24T22:09:20Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291757",
    "user": "https://github.com/adeines"
}

Changed commit from 48be838 to 9a9b388


archive/issue_events_283495.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2017-08-29T19:51:17Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20260#event-283495"
}

archive/issue_events_283496.json:

{
    "actor": "https://github.com/vbraun",
    "commit_id": "4f28059ed3a332f034d503520321a6e58c4bdada",
    "commit_repository": "https://github.com/sagemath/sage",
    "created_at": "2017-08-29T19:51:17Z",
    "event": "closed",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20260#event-283496"
}

archive/issue_comments_291758.json:

{
    "body": "Changed branch from **[u/aly.deines/padicpolylog](https://github.com/sagemath/sagetrac-mirror/tree/u/aly.deines/padicpolylog)** to **[`9a9b388`](https://github.com/sagemath/sagetrac-mirror/commit/9a9b388da4af27e3276e23b806b7f92f2f0b8244)**",
    "created_at": "2017-08-29T19:51:17Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20260",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20260#issuecomment-291758",
    "user": "https://github.com/vbraun"
}

Changed branch from u/aly.deines/padicpolylog to 9a9b388