archive/issues_020172.json:
{
"assignees": [
"https://github.com/tscrim"
],
"body": "<div id=\"comment:0\"></div>\n\n- create a .pxd file\n- support `_ascii_art_`.\n- simplified cmp code\n\nCC: @jdemeyer\n\nComponent: **cython**\n\nAuthor: **Travis Scrimshaw**\n\nBranch/Commit: **[`1dfb606`](https://github.com/sagemath/sagetrac-mirror/commit/1dfb60600dbde5f21dc80d3b7c58f1cc40235d5f)**\n\nReviewer: **Vincent Delecroix**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20409_\n\n",
"closed_at": "2016-04-11T22:47:06Z",
"created_at": "2016-04-10T07:57:31Z",
"labels": [
"https://github.com/sagemath/sage/labels/c%3A%20cython",
"https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"https://github.com/sagemath/sage/labels/enhancement"
],
"milestone": "https://github.com/sagemath/sage/milestones/sage-7.2",
"reactions": [],
"repository": "https://github.com/sagemath/sage",
"title": "Improve element_wrapper.pyx",
"type": "issue",
"updated_at": "2016-04-11T22:47:06Z",
"url": "https://github.com/sagemath/sage/issues/20409",
"user": "https://github.com/tscrim"
}- create a .pxd file
- support
_ascii_art_. - simplified cmp code
CC: @jdemeyer
Component: cython
Author: Travis Scrimshaw
Branch/Commit: 1dfb606
Reviewer: Vincent Delecroix
Issue created by migration from https://trac.sagemath.org/ticket/20409
archive/issue_events_285321.json:
{
"actor": "https://github.com/tscrim",
"created_at": "2016-04-10T07:57:31Z",
"event": "milestoned",
"issue": "https://github.com/sagemath/sage/issues/20409",
"milestone_number": null,
"milestone_title": "sage-7.2",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20409#event-285321"
}archive/issue_events_285322.json:
{
"actor": "https://github.com/tscrim",
"created_at": "2016-04-10T07:57:31Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20409",
"label": "https://github.com/sagemath/sage/labels/c%3A%20cython",
"label_color": "0000b0",
"label_name": "c: cython",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20409#event-285322"
}archive/issue_events_285323.json:
{
"actor": "https://github.com/tscrim",
"created_at": "2016-04-10T07:57:31Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20409",
"label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"label_color": "ffbb00",
"label_name": "p: major / 3",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20409#event-285323"
}archive/issue_events_285324.json:
{
"actor": "https://github.com/tscrim",
"created_at": "2016-04-10T07:57:31Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20409",
"label": "https://github.com/sagemath/sage/labels/enhancement",
"label_color": "696969",
"label_name": "enhancement",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20409#event-285324"
}archive/issue_events_285325.json:
{
"actor": "https://github.com/tscrim",
"created_at": "2016-04-10T07:57:31Z",
"event": "assigned",
"issue": "https://github.com/sagemath/sage/issues/20409",
"subject": "https://github.com/tscrim",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20409#event-285325"
}archive/issue_events_285326.json:
{
"actor": "https://github.com/tscrim",
"created_at": "2016-04-10T07:58:07Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20409",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20409#event-285326"
}archive/issue_comments_294688.json:
{
"body": "Commit: **[`d119608`](https://github.com/sagemath/sagetrac-mirror/commit/d119608d8872007a32105cbd01224c1b041b1372)**",
"created_at": "2016-04-10T07:58:07Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20409",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20409#issuecomment-294688",
"user": "https://github.com/tscrim"
}Commit: d119608
archive/issue_comments_294689.json:
{
"body": "<div id=\"comment:1\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/d119608d8872007a32105cbd01224c1b041b1372\"><code>d119608</code></a></td><td><code>Create a pxd file for element_wrapper and pass along _ascii_art_.</code></td></tr></table>\n",
"created_at": "2016-04-10T07:58:07Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20409",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20409#issuecomment-294689",
"user": "https://github.com/tscrim"
}New commits:
d119608 | Create a pxd file for element_wrapper and pass along _ascii_art_. |
archive/issue_comments_294690.json:
{
"body": "Branch: **[public/misc/improve_element_wrapper-20409](https://github.com/sagemath/sagetrac-mirror/tree/public/misc/improve_element_wrapper-20409)**",
"created_at": "2016-04-10T07:58:07Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20409",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20409#issuecomment-294690",
"user": "https://github.com/tscrim"
}Branch: public/misc/improve_element_wrapper-20409
archive/issue_comments_294691.json:
{
"body": "<div id=\"comment:2\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/9510eda1f5c4d3025e32a60bd88487f4c785b847\"><code>9510eda</code></a></td><td><code>Trac 20399: fix t_COL conversion</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/5ac825e0549d3dcbe8bbc62d67598b10a5382d3d\"><code>5ac825e</code></a></td><td><code>merge public/misc/improve_element_wrapper-20409 in Sage-7.2.beta3</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/99243b14781334678f1eb2c929ee116f9398455b\"><code>99243b1</code></a></td><td><code>Trac 20409: simplified cmp code</code></td></tr></table>\n",
"created_at": "2016-04-10T15:21:58Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20409",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20409#issuecomment-294691",
"user": "https://github.com/sagetrac-git"
}Branch pushed to git repo; I updated commit sha1. New commits:
9510eda | Trac 20399: fix t_COL conversion |
5ac825e | merge public/misc/improve_element_wrapper-20409 in Sage-7.2.beta3 |
99243b1 | Trac 20409: simplified cmp code |
archive/issue_comments_294692.json:
{
"body": "Changed commit from **[`d119608`](https://github.com/sagemath/sagetrac-mirror/commit/d119608d8872007a32105cbd01224c1b041b1372)** to **[`99243b1`](https://github.com/sagemath/sagetrac-mirror/commit/99243b14781334678f1eb2c929ee116f9398455b)**",
"created_at": "2016-04-10T15:21:58Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20409",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20409#issuecomment-294692",
"user": "https://github.com/sagetrac-git"
}Changed commit from d119608 to 99243b1
archive/issue_comments_294693.json:
{
"body": "Changed commit from **[`99243b1`](https://github.com/sagemath/sagetrac-mirror/commit/99243b14781334678f1eb2c929ee116f9398455b)** to **[`1dfb606`](https://github.com/sagemath/sagetrac-mirror/commit/1dfb60600dbde5f21dc80d3b7c58f1cc40235d5f)**",
"created_at": "2016-04-10T15:23:12Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20409",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20409#issuecomment-294693",
"user": "https://github.com/sagetrac-git"
}Changed commit from 99243b1 to 1dfb606
archive/issue_comments_294694.json:
{
"body": "<div id=\"comment:3\"></div>\n\nBranch pushed to git repo; I updated commit sha1. This was a forced push. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/1dfb60600dbde5f21dc80d3b7c58f1cc40235d5f\"><code>1dfb606</code></a></td><td><code>Trac 20409: simplified cmp code</code></td></tr></table>\n",
"created_at": "2016-04-10T15:23:12Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20409",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20409#issuecomment-294694",
"user": "https://github.com/sagetrac-git"
}Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
1dfb606 | Trac 20409: simplified cmp code |
archive/issue_comments_294695.json:
{
"body": "Description changed:\n``````diff\n--- \n+++ \n@@ -1 +1,3 @@\n-We create a .pxd file and also pass along `_ascii_art_`.\n+- create a .pxd file\n+- support `_ascii_art_`.\n+- simplified cmp code\n``````\n",
"created_at": "2016-04-10T15:23:50Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20409",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20409#issuecomment-294695",
"user": "https://github.com/videlec"
}Description changed:
---
+++
@@ -1 +1,3 @@
-We create a .pxd file and also pass along `_ascii_art_`.
+- create a .pxd file
+- support `_ascii_art_`.
+- simplified cmp codearchive/issue_comments_294696.json:
{
"body": "Reviewer: **Vincent Delecroix**",
"created_at": "2016-04-10T15:23:50Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20409",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20409#issuecomment-294696",
"user": "https://github.com/videlec"
}Reviewer: Vincent Delecroix
archive/issue_comments_294697.json:
{
"body": "<div id=\"comment:4\" align=\"right\">comment:4</div>\n\nThis is good for me. Could you check my commit.",
"created_at": "2016-04-10T15:23:50Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20409",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20409#issuecomment-294697",
"user": "https://github.com/videlec"
}comment:4
This is good for me. Could you check my commit.
archive/issue_events_285327.json:
{
"actor": "https://github.com/tscrim",
"created_at": "2016-04-10T15:49:18Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20409",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20409#event-285327"
}archive/issue_events_285328.json:
{
"actor": "https://github.com/tscrim",
"created_at": "2016-04-10T15:49:18Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20409",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20409#event-285328"
}archive/issue_comments_294698.json:
{
"body": "<div id=\"comment:5\" align=\"right\">comment:5</div>\n\nThanks.",
"created_at": "2016-04-10T15:49:18Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20409",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20409#issuecomment-294698",
"user": "https://github.com/tscrim"
}comment:5
Thanks.
archive/issue_comments_294699.json:
{
"body": "Changed branch from **[public/misc/improve_element_wrapper-20409](https://github.com/sagemath/sagetrac-mirror/tree/public/misc/improve_element_wrapper-20409)** to **[`1dfb606`](https://github.com/sagemath/sagetrac-mirror/commit/1dfb60600dbde5f21dc80d3b7c58f1cc40235d5f)**",
"created_at": "2016-04-11T22:47:06Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20409",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20409#issuecomment-294699",
"user": "https://github.com/vbraun"
}Changed branch from public/misc/improve_element_wrapper-20409 to 1dfb606
archive/issue_events_285329.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-04-11T22:47:06Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20409",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20409#event-285329"
}archive/issue_events_285330.json:
{
"actor": "https://github.com/vbraun",
"commit_id": "f03ec122d88dda6937b432473f0b96e1a4342739",
"commit_repository": "https://github.com/sagemath/sage",
"created_at": "2016-04-11T22:47:06Z",
"event": "closed",
"issue": "https://github.com/sagemath/sage/issues/20409",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20409#event-285330"
}