archive/issues_020186.json:
{
"assignees": [],
"body": "<div id=\"comment:0\"></div>\n\nThis is the update to #20380 with a new patch mirroring the upstream fix for the same issue. The patch I added was taking [directly from SVN](https://gforge.inria.fr/scm/viewvc.php/mpfr/trunk/src/mpfr-impl.h?r1=10257&r2=10260&view=patch) and applies to the current version of MPFR in sage with some fuzz (I don't know if this matters or not).\n\nI confirmed that, as expected, like #20380 this fixes building MPFR on Cygwin.\n\nUpstream: **Fixed upstream, but not in a stable release.**\n\nComponent: **porting: Cygwin**\n\nKeywords: **windows cygwin days77**\n\nAuthor: **Erik Bray**\n\nBranch/Commit: **[`8856152`](https://github.com/sagemath/sagetrac-mirror/commit/88561528acf90120d298a14d21062ee7ede2600b)**\n\nReviewer: **Jeroen Demeyer**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20423_\n\n",
"closed_at": "2016-04-14T21:56:54Z",
"created_at": "2016-04-11T14:25:49Z",
"labels": [
"https://github.com/sagemath/sage/labels/c%3A%20porting%3A%20cygwin",
"https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"https://github.com/sagemath/sage/labels/bug",
"https://github.com/sagemath/sage/labels/c%3A%20porting%3A%20cygwin"
],
"milestone": "https://github.com/sagemath/sage/milestones/sage-7.2",
"reactions": [],
"repository": "https://github.com/sagemath/sage",
"title": "Updated patch for building MPFR on Cygwin",
"type": "issue",
"updated_at": "2016-04-14T21:56:54Z",
"url": "https://github.com/sagemath/sage/issues/20423",
"user": "https://github.com/embray"
}This is the update to #20380 with a new patch mirroring the upstream fix for the same issue. The patch I added was taking directly from SVN and applies to the current version of MPFR in sage with some fuzz (I don't know if this matters or not).
I confirmed that, as expected, like #20380 this fixes building MPFR on Cygwin.
Upstream: Fixed upstream, but not in a stable release.
Component: porting: Cygwin
Keywords: windows cygwin days77
Author: Erik Bray
Branch/Commit: 8856152
Reviewer: Jeroen Demeyer
Issue created by migration from https://trac.sagemath.org/ticket/20423
archive/issue_events_285458.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-04-11T14:25:49Z",
"event": "milestoned",
"issue": "https://github.com/sagemath/sage/issues/20423",
"milestone_number": null,
"milestone_title": "sage-7.2",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20423#event-285458"
}archive/issue_events_285459.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-04-11T14:25:49Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20423",
"label": "https://github.com/sagemath/sage/labels/c%3A%20build",
"label_color": "0000b0",
"label_name": "c: build",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20423#event-285459"
}archive/issue_events_285460.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-04-11T14:25:49Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20423",
"label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"label_color": "ffbb00",
"label_name": "p: major / 3",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20423#event-285460"
}archive/issue_events_285461.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-04-11T14:25:49Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20423",
"label": "https://github.com/sagemath/sage/labels/bug",
"label_color": "d73a4a",
"label_name": "bug",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20423#event-285461"
}archive/issue_events_285462.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-04-11T14:25:49Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20423",
"label": "https://github.com/sagemath/sage/labels/c%3A%20porting%3A%20cygwin",
"label_color": "0000b0",
"label_name": "c: porting: cygwin",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20423#event-285462"
}archive/issue_events_285463.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-04-11T14:25:59Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20423",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20423#event-285463"
}archive/issue_comments_294837.json:
{
"body": "<div id=\"comment:2\" align=\"right\">comment:2</div>\n\nOne detail: could you add some comment on the top of the patch file? In particular, a link to the SVN repo and this Sage ticket would be useful.\n\nI cannot test on Cygwin myself, but if you tell me that it works for you, then I'll believe that. I checked that it doesn't break anything on Linux.",
"created_at": "2016-04-12T09:14:00Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294837",
"user": "https://github.com/jdemeyer"
}comment:2
One detail: could you add some comment on the top of the patch file? In particular, a link to the SVN repo and this Sage ticket would be useful.
I cannot test on Cygwin myself, but if you tell me that it works for you, then I'll believe that. I checked that it doesn't break anything on Linux.
archive/issue_comments_294838.json:
{
"body": "<div id=\"comment:3\" align=\"right\">comment:3</div>\n\nSure--perhaps something in the SPKG.txt as well?",
"created_at": "2016-04-12T09:21:51Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294838",
"user": "https://github.com/embray"
}comment:3
Sure--perhaps something in the SPKG.txt as well?
archive/issue_comments_294839.json:
{
"body": "<div id=\"comment:4\" align=\"right\">comment:4</div>\n\nReplying to [@embray](#comment%3A3):\n> Sure--perhaps something in the SPKG.txt as well?\n\nThat's not really needed. Better just document it in one place.",
"created_at": "2016-04-12T09:26:14Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294839",
"user": "https://github.com/jdemeyer"
}comment:4
Replying to @embray:
Sure--perhaps something in the SPKG.txt as well?
That's not really needed. Better just document it in one place.
archive/issue_comments_294840.json:
{
"body": "Changed commit from **[`69079c3`](https://github.com/sagemath/sagetrac-mirror/commit/69079c3a1179a9d396e05ca9d4b53b040a9555b4)** to **[`5f4777a`](https://github.com/sagemath/sagetrac-mirror/commit/5f4777aa7ebb6e31d9439e21842182d074ec18ec)**",
"created_at": "2016-04-12T09:46:36Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294840",
"user": "https://github.com/sagetrac-git"
}Changed commit from 69079c3 to 5f4777a
archive/issue_comments_294841.json:
{
"body": "<div id=\"comment:5\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/5f4777aa7ebb6e31d9439e21842182d074ec18ec\"><code>5f4777a</code></a></td><td><code>Added a brief explanatory comment to the patch.</code></td></tr></table>\n",
"created_at": "2016-04-12T09:46:36Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294841",
"user": "https://github.com/sagetrac-git"
}Branch pushed to git repo; I updated commit sha1. New commits:
5f4777a | Added a brief explanatory comment to the patch. |
archive/issue_events_285464.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-04-12T09:51:23Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20423",
"label": "https://github.com/sagemath/sage/labels/c%3A%20build",
"label_color": "0000b0",
"label_name": "c: build",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20423#event-285464"
}archive/issue_comments_294842.json:
{
"body": "Reviewer: **Jeroen Demeyer**",
"created_at": "2016-04-12T09:51:23Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294842",
"user": "https://github.com/jdemeyer"
}Reviewer: Jeroen Demeyer
archive/issue_events_285465.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-04-12T09:51:23Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20423",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20423#event-285465"
}archive/issue_events_285466.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-04-12T09:51:23Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20423",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20423#event-285466"
}archive/issue_comments_294843.json:
{
"body": "<div id=\"comment:7\" align=\"right\">comment:7</div>\n\nmerge conflict",
"created_at": "2016-04-12T20:23:21Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294843",
"user": "https://github.com/vbraun"
}comment:7
merge conflict
archive/issue_events_285467.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-04-12T20:23:21Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20423",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20423#event-285467"
}archive/issue_events_285468.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-04-12T20:23:21Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20423",
"label": "https://github.com/sagemath/sage/labels/needs%20work",
"label_color": "ffff00",
"label_name": "needs work",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20423#event-285468"
}archive/issue_comments_294844.json:
{
"body": "<div id=\"comment:8\" align=\"right\">comment:8</div>\n\nSo my patch from #20380 *was* merged? That was very non-obvious.",
"created_at": "2016-04-13T12:12:09Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294844",
"user": "https://github.com/embray"
}comment:8
So my patch from #20380 was merged? That was very non-obvious.
archive/issue_comments_294845.json:
{
"body": "Changed commit from **[`5f4777a`](https://github.com/sagemath/sagetrac-mirror/commit/5f4777aa7ebb6e31d9439e21842182d074ec18ec)** to **[`8856152`](https://github.com/sagemath/sagetrac-mirror/commit/88561528acf90120d298a14d21062ee7ede2600b)**",
"created_at": "2016-04-13T12:17:11Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294845",
"user": "https://github.com/sagetrac-git"
}Changed commit from 5f4777a to 8856152
archive/issue_comments_294846.json:
{
"body": "<div id=\"comment:9\"></div>\n\nBranch pushed to git repo; I updated commit sha1. This was a forced push. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/48e223529cbad63c3497a5ae3aec46fdf75de5c8\"><code>48e2235</code></a></td><td><code>Patch to mpfr required for it to get it building on Cygwin again</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/88561528acf90120d298a14d21062ee7ede2600b\"><code>8856152</code></a></td><td><code>Added a brief explanatory comment to the patch.</code></td></tr></table>\n",
"created_at": "2016-04-13T12:17:11Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294846",
"user": "https://github.com/sagetrac-git"
}Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
48e2235 | Patch to mpfr required for it to get it building on Cygwin again |
8856152 | Added a brief explanatory comment to the patch. |
archive/issue_comments_294847.json:
{
"body": "<div id=\"comment:10\" align=\"right\">comment:10</div>\n\nRebased.",
"created_at": "2016-04-13T12:17:45Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294847",
"user": "https://github.com/embray"
}comment:10
Rebased.
archive/issue_comments_294848.json:
{
"body": "<div id=\"comment:11\" align=\"right\">comment:11</div>\n\nIf it's ready for review, change the status to `needs_review`.",
"created_at": "2016-04-13T12:42:38Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294848",
"user": "https://github.com/jdemeyer"
}comment:11
If it's ready for review, change the status to needs_review.
archive/issue_comments_294849.json:
{
"body": "<div id=\"comment:12\" align=\"right\">comment:12</div>\n\nReplying to [@embray](#comment%3A8):\n> So my patch from #20380 *was* merged? That was very non-obvious.\n\nWhen a ticket is closed as \"fixed\", it means that it's merged in Volker's private branch https://github.com/vbraun/sage/tree/develop\nThis happens before buildbot testing.\n\nThis is really a private branch, which means that you should not use it for development. It is common for git history to be rewritten in that branch.\n\nAfter buildbot testing, Volker will release a new beta release and Volker's branch will become the \"real\" `develop` branch.",
"created_at": "2016-04-13T12:49:15Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294849",
"user": "https://github.com/jdemeyer"
}comment:12
Replying to @embray:
So my patch from #20380 was merged? That was very non-obvious.
When a ticket is closed as "fixed", it means that it's merged in Volker's private branch https://github.com/vbraun/sage/tree/develop This happens before buildbot testing.
This is really a private branch, which means that you should not use it for development. It is common for git history to be rewritten in that branch.
After buildbot testing, Volker will release a new beta release and Volker's branch will become the "real" develop branch.
archive/issue_events_285469.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-04-13T14:07:33Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20423",
"label": "https://github.com/sagemath/sage/labels/needs%20work",
"label_color": "ffff00",
"label_name": "needs work",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20423#event-285469"
}archive/issue_events_285470.json:
{
"actor": "https://github.com/embray",
"created_at": "2016-04-13T14:07:33Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20423",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20423#event-285470"
}archive/issue_comments_294850.json:
{
"body": "<div id=\"comment:13\" align=\"right\">comment:13</div>\n\nThanks for the explanation--that explains why I didn't see it merged in `develop`.\n\nI'm no so sure how I feel about that. It would be nice to have a branch in the main repo representing what is currently merged, rather than on someone else's fork. I'm also confused why it would be closed as \"fixed\" if buildbot testing hasn't run yet--isn't it possible the ticket will be reopened if the testing fails?",
"created_at": "2016-04-13T14:07:33Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294850",
"user": "https://github.com/embray"
}comment:13
Thanks for the explanation--that explains why I didn't see it merged in develop.
I'm no so sure how I feel about that. It would be nice to have a branch in the main repo representing what is currently merged, rather than on someone else's fork. I'm also confused why it would be closed as "fixed" if buildbot testing hasn't run yet--isn't it possible the ticket will be reopened if the testing fails?
archive/issue_comments_294851.json:
{
"body": "<div id=\"comment:14\" align=\"right\">comment:14</div>\n\nReplying to [@embray](#comment%3A13):\n> isn't it possible the ticket will be reopened if the testing fails?\n\nYes, that's possible and it happens occasionally.",
"created_at": "2016-04-13T14:41:50Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294851",
"user": "https://github.com/jdemeyer"
}comment:14
Replying to @embray:
isn't it possible the ticket will be reopened if the testing fails?
Yes, that's possible and it happens occasionally.
archive/issue_events_285471.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-04-13T14:45:35Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20423",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20423#event-285471"
}archive/issue_events_285472.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-04-13T14:45:35Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20423",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20423#event-285472"
}archive/issue_comments_294852.json:
{
"body": "<div id=\"comment:16\" align=\"right\">comment:16</div>\n\nI'd suggest an additional workflow stage representing this. To me something isn't \"fixed\" if the \"fix\" breaks the build.",
"created_at": "2016-04-14T10:23:12Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294852",
"user": "https://github.com/embray"
}comment:16
I'd suggest an additional workflow stage representing this. To me something isn't "fixed" if the "fix" breaks the build.
archive/issue_comments_294853.json:
{
"body": "<div id=\"comment:17\" align=\"right\">comment:17</div>\n\nReplying to [@embray](#comment%3A16):\n> I'd suggest an additional workflow stage representing this. To me something isn't \"fixed\" if the \"fix\" breaks the build.\n\nI would suggest no additional workflow stage, just to close the ticket as fixed only when it's actually going to be merged. That was how I operated as release manager.\n\nBut it's not my decision, you have to convince Volker.",
"created_at": "2016-04-14T11:18:19Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294853",
"user": "https://github.com/jdemeyer"
}comment:17
Replying to @embray:
I'd suggest an additional workflow stage representing this. To me something isn't "fixed" if the "fix" breaks the build.
I would suggest no additional workflow stage, just to close the ticket as fixed only when it's actually going to be merged. That was how I operated as release manager.
But it's not my decision, you have to convince Volker.
archive/issue_comments_294854.json:
{
"body": "<div id=\"comment:18\" align=\"right\">comment:18</div>\n\nEither way.",
"created_at": "2016-04-14T11:49:20Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294854",
"user": "https://github.com/embray"
}comment:18
Either way.
archive/issue_comments_294855.json:
{
"body": "Changed branch from **[u/embray/mpfr-cygwin-patch-2](https://github.com/sagemath/sagetrac-mirror/tree/u/embray/mpfr-cygwin-patch-2)** to **[`8856152`](https://github.com/sagemath/sagetrac-mirror/commit/88561528acf90120d298a14d21062ee7ede2600b)**",
"created_at": "2016-04-14T21:56:54Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20423#issuecomment-294855",
"user": "https://github.com/vbraun"
}Changed branch from u/embray/mpfr-cygwin-patch-2 to 8856152
archive/issue_events_285473.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-04-14T21:56:54Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20423",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20423#event-285473"
}archive/issue_events_285474.json:
{
"actor": "https://github.com/vbraun",
"commit_id": "6627ade10f9a48cce81c01ba9745c40f2091a39c",
"commit_repository": "https://github.com/sagemath/sage",
"created_at": "2016-04-14T21:56:54Z",
"event": "closed",
"issue": "https://github.com/sagemath/sage/issues/20423",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20423#event-285474"
}