Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Latest commit

 

History

History
815 lines (603 loc) · 32.8 KB

20437.md

File metadata and controls

815 lines (603 loc) · 32.8 KB

Issue 20437: Misinstallation of Python in Cygwin

archive/issues_020200.json:

{
    "assignees": [],
    "body": "<div id=\"comment:0\"></div>\n\nI've encountered yet another problem in my quest to get sage building on Cygwin.  I'm surprised this hasn't come up before though which makes me wonder if I'm doing something wrong.\n\nThe DLL loader library, libpython2.7.dll.a, gets installed to `$(SAGE_LOCAL)/lib/python2.7/config/` which is not normally on the ld search path (similar on Python 3 I think).\n\nThis means that when building extension modules `-lpython2.7` is actually linking against my system Python (in this case the Python that came with cygwin--also Python 2.7.10).  This is of course wrong, but isn't a problem for the majority of modules, including sage itself (at least it wasn't a problem for compiling).  It was actually PIL(low) where this fell apart because it used some `PyUnicode_` functions that were not found in my system libpython because it was compiled with `--enable-unicode=ucs2`, whereas Sage builds Python with `--enable-unicode=ucs4`.\n\nWhen installing Python, Sage should be making a symlink to `$(SAGE_LOCAL)/lib/python2.7/config/libpython2.7.dll.a` in `$(SAGE_LOCAL)/lib`.\n\nI'm leaning toward calling this an upstream bug--I don't understand why this isn't done automatically by Python's Makefile.  The relevant portion begins [here](https://hg.python.org/cpython/file/v2.7.10/Makefile.pre.in#l916).  It seems that if a DLL is built it *does not* install a symlink to the loader library in lib/.  I've brought this up here: https://mail.python.org/pipermail/python-dev/2016-April/144315.html\n\nFor reference, Cygwin's own system package for Python installs this symlink manually...  It seems odd not to do it by default.\n\nUpstream: **Reported upstream. No feedback yet.**\n\nCC:  @tscrim @sagetrac-gouezel @jpflori\n\nComponent: **porting: Cygwin**\n\nAuthor: **Erik Bray**\n\nBranch/Commit: **[`71062f0`](https://github.com/sagemath/sagetrac-mirror/commit/71062f01ef52e723f780044ffd08b4f46520bd75)**\n\nReviewer: **Sebastien Gouezel**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20437_\n\n",
    "closed_at": "2016-06-24T07:26:10Z",
    "created_at": "2016-04-13T13:57:46Z",
    "labels": [
        "https://github.com/sagemath/sage/labels/c%3A%20porting%3A%20cygwin",
        "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
        "https://github.com/sagemath/sage/labels/bug"
    ],
    "milestone": "https://github.com/sagemath/sage/milestones/sage-7.2",
    "reactions": [],
    "repository": "https://github.com/sagemath/sage",
    "title": "Misinstallation of Python in Cygwin",
    "type": "issue",
    "updated_at": "2016-06-24T07:26:10Z",
    "url": "https://github.com/sagemath/sage/issues/20437",
    "user": "https://github.com/embray"
}

I've encountered yet another problem in my quest to get sage building on Cygwin. I'm surprised this hasn't come up before though which makes me wonder if I'm doing something wrong.

The DLL loader library, libpython2.7.dll.a, gets installed to $(SAGE_LOCAL)/lib/python2.7/config/ which is not normally on the ld search path (similar on Python 3 I think).

This means that when building extension modules -lpython2.7 is actually linking against my system Python (in this case the Python that came with cygwin--also Python 2.7.10). This is of course wrong, but isn't a problem for the majority of modules, including sage itself (at least it wasn't a problem for compiling). It was actually PIL(low) where this fell apart because it used some PyUnicode_ functions that were not found in my system libpython because it was compiled with --enable-unicode=ucs2, whereas Sage builds Python with --enable-unicode=ucs4.

When installing Python, Sage should be making a symlink to $(SAGE_LOCAL)/lib/python2.7/config/libpython2.7.dll.a in $(SAGE_LOCAL)/lib.

I'm leaning toward calling this an upstream bug--I don't understand why this isn't done automatically by Python's Makefile. The relevant portion begins here. It seems that if a DLL is built it does not install a symlink to the loader library in lib/. I've brought this up here: https://mail.python.org/pipermail/python-dev/2016-April/144315.html

For reference, Cygwin's own system package for Python installs this symlink manually... It seems odd not to do it by default.

Upstream: Reported upstream. No feedback yet.

CC: @tscrim @sagetrac-gouezel @jpflori

Component: porting: Cygwin

Author: Erik Bray

Branch/Commit: 71062f0

Reviewer: Sebastien Gouezel

Issue created by migration from https://trac.sagemath.org/ticket/20437

archive/issue_events_285610.json:

{
    "actor": "https://github.com/embray",
    "created_at": "2016-04-13T13:57:46Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "milestone_number": null,
    "milestone_title": "sage-7.2",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20437#event-285610"
}

archive/issue_events_285611.json:

{
    "actor": "https://github.com/embray",
    "created_at": "2016-04-13T13:57:46Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "label": "https://github.com/sagemath/sage/labels/c%3A%20porting%3A%20cygwin",
    "label_color": "0000b0",
    "label_name": "c: porting: cygwin",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20437#event-285611"
}

archive/issue_events_285612.json:

{
    "actor": "https://github.com/embray",
    "created_at": "2016-04-13T13:57:46Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
    "label_color": "ffbb00",
    "label_name": "p: major / 3",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20437#event-285612"
}

archive/issue_events_285613.json:

{
    "actor": "https://github.com/embray",
    "created_at": "2016-04-13T13:57:46Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "label": "https://github.com/sagemath/sage/labels/bug",
    "label_color": "d73a4a",
    "label_name": "bug",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20437#event-285613"
}

archive/issue_comments_294991.json:

{
    "body": "<div id=\"comment:1\" align=\"right\">comment:1</div>\n\nAfter applying the following patch, I rebuilt python2, and was subsequently able to build pillow:\n\n```diff\ndiff --git a/build/pkgs/python2/spkg-install b/build/pkgs/python2/spkg-install\nindex db35674..b479ba3 100755\n--- a/build/pkgs/python2/spkg-install\n+++ b/build/pkgs/python2/spkg-install\n@@ -129,6 +129,9 @@ fi\n if [ \"$UNAME\" = \"Darwin\" ] && \\\n     [ `uname -r | cut '-d.' -f1` -gt 9 ]; then\n     rm -f \"$SAGE_LOCAL/lib/python2.7/config/libpython2.7.a\"\n+elif [ \"$UNAME\" = \"CYGWIN\" ]; then\n+    # See https://github.com/sagemath/sage/issues/20437\n+    ln -sf \"python2.7/config/libpython2.7.dll.a\" \"$SAGE_LOCAL/lib/libpython2.7.dll.a\"\n fi\n\n # Make sure extension modules were built correctly.\n\n```\n\nShould probably do the same for Python 3.",
    "created_at": "2016-04-13T14:24:00Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-294991",
    "user": "https://github.com/embray"
}
comment:1

After applying the following patch, I rebuilt python2, and was subsequently able to build pillow:

diff --git a/build/pkgs/python2/spkg-install b/build/pkgs/python2/spkg-install
index db35674..b479ba3 100755
--- a/build/pkgs/python2/spkg-install
+++ b/build/pkgs/python2/spkg-install
@@ -129,6 +129,9 @@ fi
 if [ "$UNAME" = "Darwin" ] && \
     [ `uname -r | cut '-d.' -f1` -gt 9 ]; then
     rm -f "$SAGE_LOCAL/lib/python2.7/config/libpython2.7.a"
+elif [ "$UNAME" = "CYGWIN" ]; then
+    # See https://github.com/sagemath/sage/issues/20437
+    ln -sf "python2.7/config/libpython2.7.dll.a" "$SAGE_LOCAL/lib/libpython2.7.dll.a"
 fi

 # Make sure extension modules were built correctly.

Should probably do the same for Python 3.

archive/issue_comments_294992.json:

{
    "body": "<div id=\"comment:2\" align=\"right\">comment:2</div>\n\nAdded a patch for python2 and python2.  Basically the same as the above diff, but slightly enhanced to not use a hard-coded `pythonX.Y` version.\n\n---\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/e45b2169db7f90927ee46b93729637a50ee67c50\"><code>e45b216</code></a></td><td><code>Create symlinks in $SAGE_LOCAL/lib to $SAGE_LOCAL/lib/pythonX.Y/config/libpythonX.Y.dll.a.  Also get Python version from python instead of hard-coding.  Note: This is required on Cygwin in order for extension modules to link to the correct DLL import library for the python in sage.  Cygwin itself does this in its system python package.</code></td></tr></table>\n",
    "created_at": "2016-04-14T15:46:30Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-294992",
    "user": "https://github.com/embray"
}
comment:2

Added a patch for python2 and python2. Basically the same as the above diff, but slightly enhanced to not use a hard-coded pythonX.Y version.

New commits:

e45b216Create symlinks in $SAGE_LOCAL/lib to $SAGE_LOCAL/lib/pythonX.Y/config/libpythonX.Y.dll.a. Also get Python version from python instead of hard-coding. Note: This is required on Cygwin in order for extension modules to link to the correct DLL import library for the python in sage. Cygwin itself does this in its system python package.

archive/issue_comments_294993.json:

{
    "body": "Commit: **[`e45b216`](https://github.com/sagemath/sagetrac-mirror/commit/e45b2169db7f90927ee46b93729637a50ee67c50)**",
    "created_at": "2016-04-14T15:46:30Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-294993",
    "user": "https://github.com/embray"
}

Commit: e45b216

archive/issue_events_285614.json:

{
    "actor": "https://github.com/embray",
    "created_at": "2016-04-14T15:46:30Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20437#event-285614"
}

archive/issue_comments_294994.json:

{
    "body": "Branch: **[u/embray/cygwin-python-install](https://github.com/sagemath/sagetrac-mirror/tree/u/embray/cygwin-python-install)**",
    "created_at": "2016-04-14T15:46:30Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-294994",
    "user": "https://github.com/embray"
}

Branch: u/embray/cygwin-python-install

archive/issue_comments_294995.json:

{
    "body": "<div id=\"comment:4\" align=\"right\">comment:4</div>\n\nHi Eric,\n\nonly sided notes (as I am not a Cygwin guy):\n\n- in the ticket, you should always fill the \"Authors\" field (with your full name). The reason is that patchbots completely ignore tickets where it is not set.\n\n- in a commit it is standard to have one short line description, a linebreak and then an optional description. That way the history is much more readable (e.g. with `git log --oneline`).",
    "created_at": "2016-04-14T17:40:07Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-294995",
    "user": "https://github.com/videlec"
}
comment:4

Hi Eric,

only sided notes (as I am not a Cygwin guy):

  • in the ticket, you should always fill the "Authors" field (with your full name). The reason is that patchbots completely ignore tickets where it is not set.

  • in a commit it is standard to have one short line description, a linebreak and then an optional description. That way the history is much more readable (e.g. with git log --oneline).

archive/issue_comments_294996.json:

{
    "body": "<div id=\"comment:5\" align=\"right\">comment:5</div>\n\nSounds reasonable.",
    "created_at": "2016-04-15T12:00:08Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-294996",
    "user": "https://github.com/embray"
}
comment:5

Sounds reasonable.

archive/issue_comments_294997.json:

{
    "body": "Author: **Erik Bray**",
    "created_at": "2016-04-15T12:04:59Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-294997",
    "user": "https://github.com/embray"
}

Author: Erik Bray

archive/issue_comments_294998.json:

{
    "body": "<div id=\"comment:6\" align=\"right\">comment:6</div>\n\nIncidentally, is this documented somewhere?  I don't see anything about this use of the \"Authors\" field under http://doc.sagemath.org/html/en/developer/trac.html#section-trac-fields or here: https://wiki.sagemath.org/buildbot.  It would be nice if there were a single, easy to point to checklist for tickets--sort of a choose your own adventure story.",
    "created_at": "2016-04-15T12:04:59Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-294998",
    "user": "https://github.com/embray"
}
comment:6

Incidentally, is this documented somewhere? I don't see anything about this use of the "Authors" field under http://doc.sagemath.org/html/en/developer/trac.html#section-trac-fields or here: https://wiki.sagemath.org/buildbot. It would be nice if there were a single, easy to point to checklist for tickets--sort of a choose your own adventure story.

archive/issue_comments_294999.json:

{
    "body": "Changed commit from **[`e45b216`](https://github.com/sagemath/sagetrac-mirror/commit/e45b2169db7f90927ee46b93729637a50ee67c50)** to **[`66ceeb2`](https://github.com/sagemath/sagetrac-mirror/commit/66ceeb2435bb4108ed3c4ecf3d0b81fa706fb1fd)**",
    "created_at": "2016-04-15T12:08:13Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-294999",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from e45b216 to 66ceeb2

archive/issue_comments_295000.json:

{
    "body": "<div id=\"comment:7\"></div>\n\nBranch pushed to git repo; I updated commit sha1. This was a forced push. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/66ceeb2435bb4108ed3c4ecf3d0b81fa706fb1fd\"><code>66ceeb2</code></a></td><td><code>On Cygwin: Create symlinks in $SAGE_LOCAL/lib to $SAGE_LOCAL/lib/pythonX.Y/config/libpythonX.Y.dll.a.</code></td></tr></table>\n",
    "created_at": "2016-04-15T12:08:13Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-295000",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

66ceeb2On Cygwin: Create symlinks in $SAGE_LOCAL/lib to $SAGE_LOCAL/lib/pythonX.Y/config/libpythonX.Y.dll.a.

archive/issue_comments_295001.json:

{
    "body": "<div id=\"comment:8\" align=\"right\">comment:8</div>\n\nBuild passed--any comments?",
    "created_at": "2016-04-22T12:23:03Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-295001",
    "user": "https://github.com/embray"
}
comment:8

Build passed--any comments?

archive/issue_comments_295002.json:

{
    "body": "<div id=\"comment:9\" align=\"right\">comment:9</div>\n\nOne detail: you should quote `$SAGE_LOCAL/bin/python` as `\"$SAGE_LOCAL/bin/python\"` in case of funny characters in `$SAGE_LOCAL`.\n\nDid you report this upstream? The \"report upstream\" field says \"Not yet reported upstream; Will do shortly.\"",
    "created_at": "2016-04-22T12:33:06Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-295002",
    "user": "https://github.com/jdemeyer"
}
comment:9

One detail: you should quote $SAGE_LOCAL/bin/python as "$SAGE_LOCAL/bin/python" in case of funny characters in $SAGE_LOCAL.

Did you report this upstream? The "report upstream" field says "Not yet reported upstream; Will do shortly."

archive/issue_events_285615.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-04-22T12:33:06Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20437#event-285615"
}

archive/issue_events_285616.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-04-22T12:33:06Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20437#event-285616"
}

archive/issue_comments_295003.json:

{
    "body": "<div id=\"comment:10\" align=\"right\">comment:10</div>\n\nReplying to [@jdemeyer](#comment%3A9):\n> One detail: you should quote `$SAGE_LOCAL/bin/python` as `\"$SAGE_LOCAL/bin/python\"` in case of funny characters in `$SAGE_LOCAL`.\n\nSure.\n\n> Did you report this upstream? The \"report upstream\" field says \"Not yet reported upstream; Will do shortly.\"\n\nI'll do that now.",
    "created_at": "2016-04-22T12:35:54Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-295003",
    "user": "https://github.com/embray"
}
comment:10

Replying to @jdemeyer:

One detail: you should quote $SAGE_LOCAL/bin/python as "$SAGE_LOCAL/bin/python" in case of funny characters in $SAGE_LOCAL.

Sure.

Did you report this upstream? The "report upstream" field says "Not yet reported upstream; Will do shortly."

I'll do that now.

archive/issue_comments_295004.json:

{
    "body": "<div id=\"comment:11\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/71062f01ef52e723f780044ffd08b4f46520bd75\"><code>71062f0</code></a></td><td><code>Adding quotes around python call in case of funny business in SAGE_LOCAL.</code></td></tr></table>\n",
    "created_at": "2016-04-22T12:39:34Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-295004",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

71062f0Adding quotes around python call in case of funny business in SAGE_LOCAL.

archive/issue_comments_295005.json:

{
    "body": "Changed commit from **[`66ceeb2`](https://github.com/sagemath/sagetrac-mirror/commit/66ceeb2435bb4108ed3c4ecf3d0b81fa706fb1fd)** to **[`71062f0`](https://github.com/sagemath/sagetrac-mirror/commit/71062f01ef52e723f780044ffd08b4f46520bd75)**",
    "created_at": "2016-04-22T12:39:34Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-295005",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 66ceeb2 to 71062f0

archive/issue_comments_295006.json:

{
    "body": "Description changed:\n``````diff\n--- \n+++ \n@@ -6,6 +6,6 @@\n \n When installing Python, Sage should be making a symlink to `$(SAGE_LOCAL)/lib/python2.7/config/libpython2.7.dll.a` in `$(SAGE_LOCAL)/lib`.\n \n-I'm leaning toward calling this an upstream bug--I don't understand why this isn't done automatically by Python's Makefile.  The relevant portion begins [here](https://hg.python.org/cpython/file/v2.7.10/Makefile.pre.in#l916).  It seems that if a DLL is built it *does not* install a symlink to the loader library in lib/.\n+I'm leaning toward calling this an upstream bug--I don't understand why this isn't done automatically by Python's Makefile.  The relevant portion begins [here](https://hg.python.org/cpython/file/v2.7.10/Makefile.pre.in#l916).  It seems that if a DLL is built it *does not* install a symlink to the loader library in lib/.  I've brought this up here: https://mail.python.org/pipermail/python-dev/2016-April/144315.html\n \n-For reference, Cygwin's own system package for Python installs this symlink manually...\n+For reference, Cygwin's own system package for Python installs this symlink manually...  It seems odd not to do it by default.\n``````\n",
    "created_at": "2016-04-22T13:11:37Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-295006",
    "user": "https://github.com/embray"
}

Description changed:

--- 
+++ 
@@ -6,6 +6,6 @@
 
 When installing Python, Sage should be making a symlink to `$(SAGE_LOCAL)/lib/python2.7/config/libpython2.7.dll.a` in `$(SAGE_LOCAL)/lib`.
 
-I'm leaning toward calling this an upstream bug--I don't understand why this isn't done automatically by Python's Makefile.  The relevant portion begins [here](https://hg.python.org/cpython/file/v2.7.10/Makefile.pre.in#l916).  It seems that if a DLL is built it *does not* install a symlink to the loader library in lib/.
+I'm leaning toward calling this an upstream bug--I don't understand why this isn't done automatically by Python's Makefile.  The relevant portion begins [here](https://hg.python.org/cpython/file/v2.7.10/Makefile.pre.in#l916).  It seems that if a DLL is built it *does not* install a symlink to the loader library in lib/.  I've brought this up here: https://mail.python.org/pipermail/python-dev/2016-April/144315.html
 
-For reference, Cygwin's own system package for Python installs this symlink manually...
+For reference, Cygwin's own system package for Python installs this symlink manually...  It seems odd not to do it by default.

archive/issue_comments_295007.json:

{
    "body": "Changed upstream from **Not yet reported upstream; Will do shortly.** to **Reported upstream. No feedback yet.**",
    "created_at": "2016-04-22T13:11:37Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-295007",
    "user": "https://github.com/embray"
}

Changed upstream from Not yet reported upstream; Will do shortly. to Reported upstream. No feedback yet.

archive/issue_events_285617.json:

{
    "actor": "https://github.com/embray",
    "created_at": "2016-04-22T13:11:37Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20437#event-285617"
}

archive/issue_events_285618.json:

{
    "actor": "https://github.com/embray",
    "created_at": "2016-04-22T13:11:37Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20437#event-285618"
}

archive/issue_comments_295008.json:

{
    "body": "<div id=\"comment:13\" align=\"right\">comment:13</div>\n\nWorks for me. You can set if to positive review in a few days, if there is no answer from upstream.",
    "created_at": "2016-04-23T16:16:19Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-295008",
    "user": "https://github.com/sagetrac-gouezel"
}
comment:13

Works for me. You can set if to positive review in a few days, if there is no answer from upstream.

archive/issue_comments_295009.json:

{
    "body": "<div id=\"comment:14\" align=\"right\">comment:14</div>\n\nNo response from python-dev yet. I only asked on the mailing list though--might get more response if I opened a bug report instead.  I was just being polite and not assuming it was definitely a bug :)\n\nIt's only Monday though, and early yet in the Americas so I'll wait a little longer.",
    "created_at": "2016-04-25T10:28:09Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-295009",
    "user": "https://github.com/embray"
}
comment:14

No response from python-dev yet. I only asked on the mailing list though--might get more response if I opened a bug report instead. I was just being polite and not assuming it was definitely a bug :)

It's only Monday though, and early yet in the Americas so I'll wait a little longer.

archive/issue_comments_295010.json:

{
    "body": "<div id=\"comment:15\" align=\"right\">comment:15</div>\n\nI opened a bug report about this in Python, and included a patch: http://bugs.python.org/issue27374 as this is more likely to at least be acknowledged than my original mailing list post.\n\nI wouldn't be surprised if this isn't acted on, or even if it is it won't be of any immediately help.  So it would be nice to go ahead and get this merged, given a positive review.",
    "created_at": "2016-06-23T15:23:45Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-295010",
    "user": "https://github.com/embray"
}
comment:15

I opened a bug report about this in Python, and included a patch: http://bugs.python.org/issue27374 as this is more likely to at least be acknowledged than my original mailing list post.

I wouldn't be surprised if this isn't acted on, or even if it is it won't be of any immediately help. So it would be nice to go ahead and get this merged, given a positive review.

archive/issue_comments_295011.json:

{
    "body": "Reviewer: **Sebastien Gouezel**",
    "created_at": "2016-06-23T15:27:12Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-295011",
    "user": "https://github.com/sagetrac-gouezel"
}

Reviewer: Sebastien Gouezel

archive/issue_events_285619.json:

{
    "actor": "https://github.com/sagetrac-gouezel",
    "created_at": "2016-06-23T15:27:12Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20437#event-285619"
}

archive/issue_events_285620.json:

{
    "actor": "https://github.com/sagetrac-gouezel",
    "created_at": "2016-06-23T15:27:12Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20437#event-285620"
}

archive/issue_comments_295012.json:

{
    "body": "Changed branch from **[u/embray/cygwin-python-install](https://github.com/sagemath/sagetrac-mirror/tree/u/embray/cygwin-python-install)** to **[`71062f0`](https://github.com/sagemath/sagetrac-mirror/commit/71062f01ef52e723f780044ffd08b4f46520bd75)**",
    "created_at": "2016-06-24T07:26:10Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20437#issuecomment-295012",
    "user": "https://github.com/vbraun"
}

Changed branch from u/embray/cygwin-python-install to 71062f0

archive/issue_events_285621.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-06-24T07:26:10Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20437#event-285621"
}

archive/issue_events_285622.json:

{
    "actor": "https://github.com/vbraun",
    "commit_id": "b6c1b962630b483df91851c1c36dd216ffb477bc",
    "commit_repository": "https://github.com/sagemath/sage",
    "created_at": "2016-06-24T07:26:10Z",
    "event": "closed",
    "issue": "https://github.com/sagemath/sage/issues/20437",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20437#event-285622"
}