archive/issues_020212.json:
{
"assignees": [],
"body": "<div id=\"comment:0\"></div>\n\nFollowup of #13580, which creates a module whose doctests assume that the host has at least two cores.\n\nIn the longer term, we could imagine to have a `# multicore` option for doctests, but let us just fix the doctests for this ticket to test whether the host has a single core first.\n\n\nCC: @hivert\n\nComponent: **combinatorics**\n\nKeywords: **sdl**\n\nAuthor: **Florent Hivert**\n\nBranch/Commit: **[`d969623`](https://github.com/sagemath/sagetrac-mirror/commit/d969623fd858087879e559754631c081d7d311e8)**\n\nReviewer: **Thierry Monteil**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20449_\n\n",
"closed_at": "2016-08-21T23:39:41Z",
"created_at": "2016-04-15T20:41:00Z",
"labels": [
"https://github.com/sagemath/sage/labels/c%3A%20combinatorics",
"https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"https://github.com/sagemath/sage/labels/bug"
],
"milestone": "https://github.com/sagemath/sage/milestones/sage-7.2",
"reactions": [],
"repository": "https://github.com/sagemath/sage",
"title": "Let the doctest of map_reduce work for single-core computers",
"type": "issue",
"updated_at": "2019-08-27T19:45:19Z",
"url": "https://github.com/sagemath/sage/issues/20449",
"user": "https://github.com/sagetrac-tmonteil"
}Followup of #13580, which creates a module whose doctests assume that the host has at least two cores.
In the longer term, we could imagine to have a # multicore option for doctests, but let us just fix the doctests for this ticket to test whether the host has a single core first.
CC: @hivert
Component: combinatorics
Keywords: sdl
Author: Florent Hivert
Branch/Commit: d969623
Reviewer: Thierry Monteil
Issue created by migration from https://trac.sagemath.org/ticket/20449
archive/issue_events_285743.json:
{
"actor": "https://github.com/sagetrac-tmonteil",
"created_at": "2016-04-15T20:41:00Z",
"event": "milestoned",
"issue": "https://github.com/sagemath/sage/issues/20449",
"milestone_number": null,
"milestone_title": "sage-7.2",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20449#event-285743"
}archive/issue_events_285744.json:
{
"actor": "https://github.com/sagetrac-tmonteil",
"created_at": "2016-04-15T20:41:00Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20449",
"label": "https://github.com/sagemath/sage/labels/c%3A%20combinatorics",
"label_color": "0000ff",
"label_name": "c: combinatorics",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20449#event-285744"
}archive/issue_events_285745.json:
{
"actor": "https://github.com/sagetrac-tmonteil",
"created_at": "2016-04-15T20:41:00Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20449",
"label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"label_color": "ffbb00",
"label_name": "p: major / 3",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20449#event-285745"
}archive/issue_events_285746.json:
{
"actor": "https://github.com/sagetrac-tmonteil",
"created_at": "2016-04-15T20:41:00Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20449",
"label": "https://github.com/sagemath/sage/labels/bug",
"label_color": "d73a4a",
"label_name": "bug",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20449#event-285746"
}archive/issue_events_285747.json:
{
"actor": "https://github.com/sagetrac-tmonteil",
"created_at": "2016-04-15T20:51:46Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20449",
"label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"label_color": "ffbb00",
"label_name": "p: major / 3",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20449#event-285747"
}archive/issue_events_285748.json:
{
"actor": "https://github.com/sagetrac-tmonteil",
"created_at": "2016-04-15T20:51:46Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20449",
"label": "https://github.com/sagemath/sage/labels/p%3A%20blocker%20/%201",
"label_color": "ff0000",
"label_name": "p: blocker / 1",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20449#event-285748"
}archive/issue_comments_295194.json:
{
"body": "<div id=\"comment:1\" align=\"right\">comment:1</div>\n\nLet me put this ticket as blocker since the doctest are currently broken on single core computers.",
"created_at": "2016-04-15T20:51:46Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20449",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20449#issuecomment-295194",
"user": "https://github.com/sagetrac-tmonteil"
}comment:1
Let me put this ticket as blocker since the doctest are currently broken on single core computers.
archive/issue_comments_295195.json:
{
"body": "Branch: **[u/hivert/let_the_doctest_of_map_reduce_work_for_single_core_computers](https://github.com/sagemath/sagetrac-mirror/tree/u/hivert/let_the_doctest_of_map_reduce_work_for_single_core_computers)**",
"created_at": "2016-04-15T21:06:38Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20449",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20449#issuecomment-295195",
"user": "https://github.com/hivert"
}Branch: u/hivert/let_the_doctest_of_map_reduce_work_for_single_core_computers
archive/issue_comments_295196.json:
{
"body": "<div id=\"comment:3\" align=\"right\">comment:3</div>\n\nHi thiery,\n\nI just pushed a 1 character fix. It allows two parallel processes even on single core machines. Note that on those kinds of machines, it make no sense to use map_reduce. The same functionality is provided by the `run_serial` method which makes no use of multi-core.\n\nCan you test this patch on your patchbot and report failure if any ?\n\nFlorent\n\n---\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/d969623fd858087879e559754631c081d7d311e8\"><code>d969623</code></a></td><td><code>20449 : Tentative 1 character fix</code></td></tr></table>\n",
"created_at": "2016-04-15T21:10:42Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20449",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20449#issuecomment-295196",
"user": "https://github.com/hivert"
}comment:3
Hi thiery,
I just pushed a 1 character fix. It allows two parallel processes even on single core machines. Note that on those kinds of machines, it make no sense to use map_reduce. The same functionality is provided by the run_serial method which makes no use of multi-core.
Can you test this patch on your patchbot and report failure if any ?
Florent
New commits:
d969623 | 20449 : Tentative 1 character fix |
archive/issue_comments_295197.json:
{
"body": "Commit: **[`d969623`](https://github.com/sagemath/sagetrac-mirror/commit/d969623fd858087879e559754631c081d7d311e8)**",
"created_at": "2016-04-15T21:10:42Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20449",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20449#issuecomment-295197",
"user": "https://github.com/hivert"
}Commit: d969623
archive/issue_comments_295198.json:
{
"body": "<div id=\"comment:4\" align=\"right\">comment:4</div>\n\nPatchbot launched, let us see.",
"created_at": "2016-04-15T21:43:12Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20449",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20449#issuecomment-295198",
"user": "https://github.com/sagetrac-tmonteil"
}comment:4
Patchbot launched, let us see.
archive/issue_comments_295199.json:
{
"body": "<div id=\"comment:5\" align=\"right\">comment:5</div>\n\nHi thiery,\n\nHow long will it takes ? I've to get up early tomorrow...\n\nWhile waiting, I'm playing with SSE/AVX. I've a speedup of x20 for a function which sorts 16 bytes. \n\nFlorent",
"created_at": "2016-04-15T22:03:48Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20449",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20449#issuecomment-295199",
"user": "https://github.com/hivert"
}comment:5
Hi thiery,
How long will it takes ? I've to get up early tomorrow...
While waiting, I'm playing with SSE/AVX. I've a speedup of x20 for a function which sorts 16 bytes.
Florent
archive/issue_comments_295200.json:
{
"body": "<div id=\"comment:6\" align=\"right\">comment:6</div>\n\nGoing to bed... I'll check you report tomorrow evening.",
"created_at": "2016-04-15T22:16:00Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20449",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20449#issuecomment-295200",
"user": "https://github.com/hivert"
}comment:6
Going to bed... I'll check you report tomorrow evening.
archive/issue_comments_295201.json:
{
"body": "<div id=\"comment:7\" align=\"right\">comment:7</div>\n\nI do not really like the fact that we change the code while the problem comes from the doctest, but at least the doctests now pass with that change, see http://patchbot.sagemath.org/log/20449/debian/8.3/i686/3.16.0-4-586/tmonteil-debian-jessie-32/2016-04-16%2000:11:02?short",
"created_at": "2016-04-16T10:44:02Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20449",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20449#issuecomment-295201",
"user": "https://github.com/sagetrac-tmonteil"
}comment:7
I do not really like the fact that we change the code while the problem comes from the doctest, but at least the doctests now pass with that change, see http://patchbot.sagemath.org/log/20449/debian/8.3/i686/3.16.0-4-586/tmonteil-debian-jessie-32/2016-04-16%2000:11:02?short
archive/issue_comments_295202.json:
{
"body": "<div id=\"comment:8\" align=\"right\">comment:8</div>\n\nI also had a decision like this (what to do when ncpus=1) to make recently in the parallelization of dancing links code:\n\nhttps://github.com/sagemath/sage/blob/master/src/sage/combinat/matrices/dancing_links.pyx#L373",
"created_at": "2016-04-16T12:57:44Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20449",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20449#issuecomment-295202",
"user": "https://github.com/seblabbe"
}comment:8
I also had a decision like this (what to do when ncpus=1) to make recently in the parallelization of dancing links code:
archive/issue_comments_295203.json:
{
"body": "Replying to [@sagetrac-tmonteil](https://github.com/sagemath/sage/issues/20449#comment:0):\n> In the longer term, we could imagine to have a `# multicore` option for doctests, but let us just fix the doctests for this ticket to test whether the host has a single core first.\n\nIs the problem really in the *doctest* or in the functionality?",
"created_at": "2016-04-17T07:51:04Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20449",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20449#issuecomment-295203",
"user": "https://github.com/jdemeyer"
}Replying to @sagetrac-tmonteil:
In the longer term, we could imagine to have a
# multicoreoption for doctests, but let us just fix the doctests for this ticket to test whether the host has a single core first.
Is the problem really in the doctest or in the functionality?
archive/issue_comments_295204.json:
{
"body": "<div id=\"comment:10\" align=\"right\">comment:10</div>\n\nAny progress? IMHO a failing doctest on some particular setup isn't a blocker, there are far worse bugs than that...",
"created_at": "2016-05-07T11:31:38Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20449",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20449#issuecomment-295204",
"user": "https://github.com/vbraun"
}comment:10
Any progress? IMHO a failing doctest on some particular setup isn't a blocker, there are far worse bugs than that...
archive/issue_events_285749.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-05-07T11:31:38Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20449",
"label": "https://github.com/sagemath/sage/labels/p%3A%20blocker%20/%201",
"label_color": "ff0000",
"label_name": "p: blocker / 1",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20449#event-285749"
}archive/issue_events_285750.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-05-07T11:31:38Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20449",
"label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"label_color": "ffbb00",
"label_name": "p: major / 3",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20449#event-285750"
}archive/issue_events_285751.json:
{
"actor": "https://github.com/sagetrac-tmonteil",
"created_at": "2016-08-20T20:36:27Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20449",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20449#event-285751"
}archive/issue_comments_295205.json:
{
"body": "Author: **Florent Hivert**",
"created_at": "2016-08-20T20:36:27Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20449",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20449#issuecomment-295205",
"user": "https://github.com/sagetrac-tmonteil"
}Author: Florent Hivert
archive/issue_comments_295206.json:
{
"body": "Reviewer: **Thierry Monteil**",
"created_at": "2016-08-20T20:36:27Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20449",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20449#issuecomment-295206",
"user": "https://github.com/sagetrac-tmonteil"
}Reviewer: Thierry Monteil
archive/issue_events_285752.json:
{
"actor": "https://github.com/sagetrac-tmonteil",
"created_at": "2016-08-20T20:36:38Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20449",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20449#event-285752"
}archive/issue_events_285753.json:
{
"actor": "https://github.com/sagetrac-tmonteil",
"created_at": "2016-08-20T20:36:38Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20449",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20449#event-285753"
}archive/issue_events_285754.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-08-21T23:39:41Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20449",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20449#event-285754"
}archive/issue_events_285755.json:
{
"actor": "https://github.com/vbraun",
"commit_id": "d1c9178e96645238790124ba72652de447e05afc",
"commit_repository": "https://github.com/sagemath/sage",
"created_at": "2016-08-21T23:39:41Z",
"event": "closed",
"issue": "https://github.com/sagemath/sage/issues/20449",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20449#event-285755"
}archive/issue_comments_295207.json:
{
"body": "Changed branch from **[u/hivert/let_the_doctest_of_map_reduce_work_for_single_core_computers](https://github.com/sagemath/sagetrac-mirror/tree/u/hivert/let_the_doctest_of_map_reduce_work_for_single_core_computers)** to **[`d969623`](https://github.com/sagemath/sagetrac-mirror/commit/d969623fd858087879e559754631c081d7d311e8)**",
"created_at": "2016-08-21T23:39:41Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20449",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20449#issuecomment-295207",
"user": "https://github.com/vbraun"
}Changed branch from u/hivert/let_the_doctest_of_map_reduce_work_for_single_core_computers to d969623
archive/issue_comments_295208.json:
{
"body": "Changed keywords from none to **sdl**",
"created_at": "2019-08-27T19:45:19Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20449",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20449#issuecomment-295208",
"user": "https://github.com/sagetrac-tmonteil"
}Changed keywords from none to sdl