Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Latest commit

 

History

History
697 lines (530 loc) · 23 KB

20531.md

File metadata and controls

697 lines (530 loc) · 23 KB

Issue 20531: Don't use "long double" functions for Pynac

archive/issues_020294.json:

{
    "assignees": [],
    "body": "<div id=\"comment:0\"></div>\n\nThere seems to be no reason to use the `long double` functions like `sage_logl` for Pynac. It interacts only with Python objects and Python's `float` corresponds to `double` in C.\n\nCC:  @rwst @embray\n\nComponent: **cython**\n\nAuthor: **Jeroen Demeyer**\n\nBranch/Commit: **[`20cdb45`](https://github.com/sagemath/sagetrac-mirror/commit/20cdb45b4e0bc33f9fd746959e50754caf036835)**\n\nReviewer: **Erik Bray, Ralf Stephan**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20531_\n\n",
    "closed_at": "2016-05-18T18:21:00Z",
    "created_at": "2016-05-02T12:03:12Z",
    "labels": [
        "https://github.com/sagemath/sage/labels/c%3A%20cython",
        "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
        "https://github.com/sagemath/sage/labels/enhancement"
    ],
    "milestone": "https://github.com/sagemath/sage/milestones/sage-7.2",
    "reactions": [],
    "repository": "https://github.com/sagemath/sage",
    "title": "Don't use \"long double\" functions for Pynac",
    "type": "issue",
    "updated_at": "2016-05-18T18:21:00Z",
    "url": "https://github.com/sagemath/sage/issues/20531",
    "user": "https://github.com/jdemeyer"
}

There seems to be no reason to use the long double functions like sage_logl for Pynac. It interacts only with Python objects and Python's float corresponds to double in C.

CC: @rwst @embray

Component: cython

Author: Jeroen Demeyer

Branch/Commit: 20cdb45

Reviewer: Erik Bray, Ralf Stephan

Issue created by migration from https://trac.sagemath.org/ticket/20531


archive/issue_events_286753.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-05-02T12:03:12Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "milestone_number": null,
    "milestone_title": "sage-7.2",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20531#event-286753"
}

archive/issue_events_286754.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-05-02T12:03:12Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "label": "https://github.com/sagemath/sage/labels/c%3A%20cython",
    "label_color": "0000b0",
    "label_name": "c: cython",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20531#event-286754"
}

archive/issue_events_286755.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-05-02T12:03:12Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
    "label_color": "ffbb00",
    "label_name": "p: major / 3",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20531#event-286755"
}

archive/issue_events_286756.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-05-02T12:03:12Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "label": "https://github.com/sagemath/sage/labels/enhancement",
    "label_color": "696969",
    "label_name": "enhancement",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20531#event-286756"
}

archive/issue_comments_296612.json:

{
    "body": "Branch: **[u/jdemeyer/don_t_use__long_double__functions_for_pynac](https://github.com/sagemath/sagetrac-mirror/tree/u/jdemeyer/don_t_use__long_double__functions_for_pynac)**",
    "created_at": "2016-05-02T12:28:22Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20531#issuecomment-296612",
    "user": "https://github.com/jdemeyer"
}

Branch: u/jdemeyer/don_t_use__long_double__functions_for_pynac


archive/issue_comments_296613.json:

{
    "body": "<div id=\"comment:2\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/491093cea9255af384beb6e38d321fd3f5a5b2ca\"><code>491093c</code></a></td><td><code>Return 0 instead of NULL to fix compiler warning</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/b5ff9318c0bfa9720f6947f2fcdceb8f7fe2279d\"><code>b5ff931</code></a></td><td><code>Do not use \"long double\" functions for Pynac</code></td></tr></table>\n",
    "created_at": "2016-05-02T12:28:35Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20531#issuecomment-296613",
    "user": "https://github.com/jdemeyer"
}

New commits:

491093cReturn 0 instead of NULL to fix compiler warning
b5ff931Do not use "long double" functions for Pynac

archive/issue_events_286757.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-05-02T12:28:35Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20531#event-286757"
}

archive/issue_comments_296614.json:

{
    "body": "Commit: **[`b5ff931`](https://github.com/sagemath/sagetrac-mirror/commit/b5ff9318c0bfa9720f6947f2fcdceb8f7fe2279d)**",
    "created_at": "2016-05-02T12:28:35Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20531#issuecomment-296614",
    "user": "https://github.com/jdemeyer"
}

Commit: b5ff931


archive/issue_comments_296615.json:

{
    "body": "<div id=\"comment:3\" align=\"right\">comment:3</div>\n\nI don't know anything about Pynac but LGTM otherwise.",
    "created_at": "2016-05-02T12:42:43Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20531#issuecomment-296615",
    "user": "https://github.com/embray"
}
comment:3

I don't know anything about Pynac but LGTM otherwise.


archive/issue_comments_296616.json:

{
    "body": "<div id=\"comment:4\" align=\"right\">comment:4</div>\n\nLGTM too. I have put your real name in the Reviewer: field and set positive for you.",
    "created_at": "2016-05-03T07:48:13Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20531#issuecomment-296616",
    "user": "https://github.com/rwst"
}
comment:4

LGTM too. I have put your real name in the Reviewer: field and set positive for you.


archive/issue_events_286758.json:

{
    "actor": "https://github.com/rwst",
    "created_at": "2016-05-03T07:48:13Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20531#event-286758"
}

archive/issue_events_286759.json:

{
    "actor": "https://github.com/rwst",
    "created_at": "2016-05-03T07:48:13Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20531#event-286759"
}

archive/issue_comments_296617.json:

{
    "body": "Reviewer: **Erik Bray, Ralf Stephan**",
    "created_at": "2016-05-03T07:48:13Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20531#issuecomment-296617",
    "user": "https://github.com/rwst"
}

Reviewer: Erik Bray, Ralf Stephan


archive/issue_comments_296618.json:

{
    "body": "<div id=\"comment:5\" align=\"right\">comment:5</div>\n\nActually one the commit will fix a QA problem reported by portage in sage-on-gentoo. Quite happy about that.",
    "created_at": "2016-05-03T08:10:17Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20531#issuecomment-296618",
    "user": "https://github.com/kiwifb"
}
comment:5

Actually one the commit will fix a QA problem reported by portage in sage-on-gentoo. Quite happy about that.


archive/issue_events_286760.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-05-04T17:10:34Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20531#event-286760"
}

archive/issue_events_286761.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-05-04T17:10:34Z",
    "event": "closed",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20531#event-286761"
}

archive/issue_comments_296619.json:

{
    "body": "Changed branch from **[u/jdemeyer/don_t_use__long_double__functions_for_pynac](https://github.com/sagemath/sagetrac-mirror/tree/u/jdemeyer/don_t_use__long_double__functions_for_pynac)** to **[`b5ff931`](https://github.com/sagemath/sagetrac-mirror/commit/b5ff9318c0bfa9720f6947f2fcdceb8f7fe2279d)**",
    "created_at": "2016-05-04T17:10:34Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20531#issuecomment-296619",
    "user": "https://github.com/vbraun"
}

Changed branch from u/jdemeyer/don_t_use__long_double__functions_for_pynac to b5ff931


archive/issue_events_286762.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-05-05T09:26:16Z",
    "event": "reopened",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20531#event-286762"
}

archive/issue_comments_296620.json:

{
    "body": "Changed commit from **[`b5ff931`](https://github.com/sagemath/sagetrac-mirror/commit/b5ff9318c0bfa9720f6947f2fcdceb8f7fe2279d)** to none",
    "created_at": "2016-05-05T09:26:16Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20531#issuecomment-296620",
    "user": "https://github.com/vbraun"
}

Changed commit from b5ff931 to none


archive/issue_comments_296621.json:

{
    "body": "<div id=\"comment:7\" align=\"right\">comment:7</div>\n\nOn OSX:\n\n```\nsage -t --long src/sage/symbolic/pynac.pyx\n**********************************************************************\nFile \"src/sage/symbolic/pynac.pyx\", line 1795, in sage.symbolic.pynac.py_lgamma\nFailed example:\n    py_lgamma(4.r)\nExpected:\n    1.791759469228055\nGot:\n    1.7917594692280552\n**********************************************************************\nFile \"src/sage/symbolic/pynac.pyx\", line 1797, in sage.symbolic.pynac.py_lgamma\nFailed example:\n    py_lgamma(4r)\nExpected:\n    1.791759469228055\nGot:\n    1.7917594692280552\n**********************************************************************\n1 item had failures:\n   2 of   7 in sage.symbolic.pynac.py_lgamma\n```",
    "created_at": "2016-05-05T09:26:16Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20531#issuecomment-296621",
    "user": "https://github.com/vbraun"
}
comment:7

On OSX:

sage -t --long src/sage/symbolic/pynac.pyx
**********************************************************************
File "src/sage/symbolic/pynac.pyx", line 1795, in sage.symbolic.pynac.py_lgamma
Failed example:
    py_lgamma(4.r)
Expected:
    1.791759469228055
Got:
    1.7917594692280552
**********************************************************************
File "src/sage/symbolic/pynac.pyx", line 1797, in sage.symbolic.pynac.py_lgamma
Failed example:
    py_lgamma(4r)
Expected:
    1.791759469228055
Got:
    1.7917594692280552
**********************************************************************
1 item had failures:
   2 of   7 in sage.symbolic.pynac.py_lgamma

archive/issue_comments_296622.json:

{
    "body": "<div id=\"comment:8\" align=\"right\">comment:8</div>\n\nInteresting. So on OS X, `(double)lgammal(4.0)` is not the same as `lgamma(4.0)`",
    "created_at": "2016-05-05T09:44:02Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20531#issuecomment-296622",
    "user": "https://github.com/jdemeyer"
}
comment:8

Interesting. So on OS X, (double)lgammal(4.0) is not the same as lgamma(4.0)


archive/issue_comments_296623.json:

{
    "body": "<div id=\"comment:9\" align=\"right\">comment:9</div>\n\n...which isn't that surprising perhaps, since `lgamma()` probably uses a less precise algorithm than `lgammal()`. Anyway, the error is still less than 1 ulp, so I will just add some `# abs tol`.",
    "created_at": "2016-05-05T09:50:03Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20531#issuecomment-296623",
    "user": "https://github.com/jdemeyer"
}
comment:9

...which isn't that surprising perhaps, since lgamma() probably uses a less precise algorithm than lgammal(). Anyway, the error is still less than 1 ulp, so I will just add some # abs tol.


archive/issue_comments_296624.json:

{
    "body": "Changed branch from **[`b5ff931`](https://github.com/sagemath/sagetrac-mirror/commit/b5ff9318c0bfa9720f6947f2fcdceb8f7fe2279d)** to **[u/jdemeyer/b5ff9318c0bfa9720f6947f2fcdceb8f7fe2279d](https://github.com/sagemath/sagetrac-mirror/tree/u/jdemeyer/b5ff9318c0bfa9720f6947f2fcdceb8f7fe2279d)**",
    "created_at": "2016-05-05T09:54:43Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20531#issuecomment-296624",
    "user": "https://github.com/jdemeyer"
}

Changed branch from b5ff931 to u/jdemeyer/b5ff9318c0bfa9720f6947f2fcdceb8f7fe2279d


archive/issue_comments_296625.json:

{
    "body": "Commit: **[`20cdb45`](https://github.com/sagemath/sagetrac-mirror/commit/20cdb45b4e0bc33f9fd746959e50754caf036835)**",
    "created_at": "2016-05-05T09:55:22Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20531#issuecomment-296625",
    "user": "https://github.com/jdemeyer"
}

Commit: 20cdb45


archive/issue_comments_296626.json:

{
    "body": "<div id=\"comment:11\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/491093cea9255af384beb6e38d321fd3f5a5b2ca\"><code>491093c</code></a></td><td><code>Return 0 instead of NULL to fix compiler warning</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/b5ff9318c0bfa9720f6947f2fcdceb8f7fe2279d\"><code>b5ff931</code></a></td><td><code>Do not use \"long double\" functions for Pynac</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/20cdb45b4e0bc33f9fd746959e50754caf036835\"><code>20cdb45</code></a></td><td><code>Fix py_lgamma() doctests for OS X libm</code></td></tr></table>\n",
    "created_at": "2016-05-05T09:55:22Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20531#issuecomment-296626",
    "user": "https://github.com/jdemeyer"
}

New commits:

491093cReturn 0 instead of NULL to fix compiler warning
b5ff931Do not use "long double" functions for Pynac
20cdb45Fix py_lgamma() doctests for OS X libm

archive/issue_events_286763.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-05-05T09:55:22Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20531#event-286763"
}

archive/issue_comments_296627.json:

{
    "body": "<div id=\"comment:12\" align=\"right\">comment:12</div>\n\nTrivially putting it back to positive review.",
    "created_at": "2016-05-05T10:05:05Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20531#issuecomment-296627",
    "user": "https://github.com/kiwifb"
}
comment:12

Trivially putting it back to positive review.


archive/issue_events_286764.json:

{
    "actor": "https://github.com/kiwifb",
    "created_at": "2016-05-05T10:05:05Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20531#event-286764"
}

archive/issue_events_286765.json:

{
    "actor": "https://github.com/kiwifb",
    "created_at": "2016-05-05T10:05:05Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20531#event-286765"
}

archive/issue_comments_296628.json:

{
    "body": "Changed branch from **[u/jdemeyer/b5ff9318c0bfa9720f6947f2fcdceb8f7fe2279d](https://github.com/sagemath/sagetrac-mirror/tree/u/jdemeyer/b5ff9318c0bfa9720f6947f2fcdceb8f7fe2279d)** to **[`20cdb45`](https://github.com/sagemath/sagetrac-mirror/commit/20cdb45b4e0bc33f9fd746959e50754caf036835)**",
    "created_at": "2016-05-18T18:21:00Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20531#issuecomment-296628",
    "user": "https://github.com/vbraun"
}

Changed branch from u/jdemeyer/b5ff9318c0bfa9720f6947f2fcdceb8f7fe2279d to 20cdb45


archive/issue_events_286766.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-05-18T18:21:00Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20531#event-286766"
}

archive/issue_events_286767.json:

{
    "actor": "https://github.com/vbraun",
    "commit_id": "0057a5c336b73ad7c44431d62a15edce97b5203f",
    "commit_repository": "https://github.com/sagemath/sage",
    "created_at": "2016-05-18T18:21:00Z",
    "event": "closed",
    "issue": "https://github.com/sagemath/sage/issues/20531",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20531#event-286767"
}