Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Files

Latest commit

author
Matthias Koeppe
Jan 27, 2023
ae4b3d6 · Jan 27, 2023

History

History
526 lines (400 loc) · 14.9 KB

20541.md

File metadata and controls

526 lines (400 loc) · 14.9 KB

Issue 20541: py3 print in matrix folder

archive/issues_020304.json:

{
    "assignees": [],
    "body": "<div id=\"comment:0\"></div>\n\nanother step towards python3 print\n\nComponent: **python3**\n\nAuthor: **Fr\u00e9d\u00e9ric Chapoton**\n\nBranch/Commit: **[`7c12326`](https://github.com/sagemath/sagetrac-mirror/commit/7c123263f2a5a4ac052559c53b1090fa3669bc92)**\n\nReviewer: **Jori M\u00e4ntysalo**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20541_\n\n",
    "closed_at": "2016-05-05T09:27:06Z",
    "created_at": "2016-05-03T09:37:01Z",
    "labels": [
        "https://github.com/sagemath/sage/labels/c%3A%20python3",
        "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
        "https://github.com/sagemath/sage/labels/enhancement"
    ],
    "milestone": "https://github.com/sagemath/sage/milestones/sage-7.2",
    "reactions": [],
    "repository": "https://github.com/sagemath/sage",
    "title": "py3 print in matrix folder",
    "type": "issue",
    "updated_at": "2016-05-05T09:27:06Z",
    "url": "https://github.com/sagemath/sage/issues/20541",
    "user": "https://github.com/fchapoton"
}

another step towards python3 print

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 7c12326

Reviewer: Jori Mäntysalo

Issue created by migration from https://trac.sagemath.org/ticket/20541


archive/issue_events_286869.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-05-03T09:37:01Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "milestone_number": null,
    "milestone_title": "sage-7.2",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20541#event-286869"
}

archive/issue_events_286870.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-05-03T09:37:01Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "label": "https://github.com/sagemath/sage/labels/c%3A%20python3",
    "label_color": "0000b0",
    "label_name": "c: python3",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20541#event-286870"
}

archive/issue_events_286871.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-05-03T09:37:01Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
    "label_color": "ffbb00",
    "label_name": "p: major / 3",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20541#event-286871"
}

archive/issue_events_286872.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-05-03T09:37:01Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "label": "https://github.com/sagemath/sage/labels/enhancement",
    "label_color": "696969",
    "label_name": "enhancement",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20541#event-286872"
}

archive/issue_comments_296752.json:

{
    "body": "Branch: **[public/20541](https://github.com/sagemath/sagetrac-mirror/tree/public/20541)**",
    "created_at": "2016-05-03T09:37:26Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20541#issuecomment-296752",
    "user": "https://github.com/fchapoton"
}

Branch: public/20541


archive/issue_comments_296753.json:

{
    "body": "<div id=\"comment:1\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/fd35ef0fcc09060a0fbd945a50e243631f06ceba\"><code>fd35ef0</code></a></td><td><code>python3 print in matrices folder</code></td></tr></table>\n",
    "created_at": "2016-05-03T09:37:26Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20541#issuecomment-296753",
    "user": "https://github.com/fchapoton"
}

New commits:

fd35ef0python3 print in matrices folder

archive/issue_events_286873.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-05-03T09:37:26Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20541#event-286873"
}

archive/issue_comments_296754.json:

{
    "body": "Commit: **[`fd35ef0`](https://github.com/sagemath/sagetrac-mirror/commit/fd35ef0fcc09060a0fbd945a50e243631f06ceba)**",
    "created_at": "2016-05-03T09:37:26Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20541#issuecomment-296754",
    "user": "https://github.com/fchapoton"
}

Commit: fd35ef0


archive/issue_comments_296755.json:

{
    "body": "<div id=\"comment:2\" align=\"right\">comment:2</div>\n\nSeems to be OK. I'll compile and check before setting positive review.",
    "created_at": "2016-05-03T10:11:00Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20541#issuecomment-296755",
    "user": "https://github.com/jm58660"
}
comment:2

Seems to be OK. I'll compile and check before setting positive review.


archive/issue_comments_296756.json:

{
    "body": "Reviewer: **Jori M\u00e4ntysalo**",
    "created_at": "2016-05-03T10:11:00Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20541#issuecomment-296756",
    "user": "https://github.com/jm58660"
}

Reviewer: Jori Mäntysalo


archive/issue_events_286874.json:

{
    "actor": "https://github.com/jm58660",
    "created_at": "2016-05-03T10:23:32Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20541#event-286874"
}

archive/issue_events_286875.json:

{
    "actor": "https://github.com/jm58660",
    "created_at": "2016-05-03T10:23:32Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20541#event-286875"
}

archive/issue_comments_296757.json:

{
    "body": "<div id=\"comment:3\" align=\"right\">comment:3</div>\n\nNot OK: In `matrix_modn_dense_template.pxi` first TEST block has the line\n\n```\nprint('{} x {} = {}'.format(v, m, v * m)\n```\n\ni.e. missing a closing parenthesis.",
    "created_at": "2016-05-03T10:23:32Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20541#issuecomment-296757",
    "user": "https://github.com/jm58660"
}
comment:3

Not OK: In matrix_modn_dense_template.pxi first TEST block has the line

print('{} x {} = {}'.format(v, m, v * m)

i.e. missing a closing parenthesis.


archive/issue_comments_296758.json:

{
    "body": "<div id=\"comment:4\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/7c123263f2a5a4ac052559c53b1090fa3669bc92\"><code>7c12326</code></a></td><td><code>python 3 print for matrices, detail</code></td></tr></table>\n",
    "created_at": "2016-05-03T11:32:46Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20541#issuecomment-296758",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

7c12326python 3 print for matrices, detail

archive/issue_comments_296759.json:

{
    "body": "Changed commit from **[`fd35ef0`](https://github.com/sagemath/sagetrac-mirror/commit/fd35ef0fcc09060a0fbd945a50e243631f06ceba)** to **[`7c12326`](https://github.com/sagemath/sagetrac-mirror/commit/7c123263f2a5a4ac052559c53b1090fa3669bc92)**",
    "created_at": "2016-05-03T11:32:46Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20541#issuecomment-296759",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from fd35ef0 to 7c12326


archive/issue_comments_296760.json:

{
    "body": "<div id=\"comment:5\" align=\"right\">comment:5</div>\n\ndone",
    "created_at": "2016-05-03T11:33:05Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20541#issuecomment-296760",
    "user": "https://github.com/fchapoton"
}
comment:5

done


archive/issue_events_286876.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-05-03T11:33:05Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20541#event-286876"
}

archive/issue_events_286877.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-05-03T11:33:05Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20541#event-286877"
}

archive/issue_comments_296761.json:

{
    "body": "<div id=\"comment:6\" align=\"right\">comment:6</div>\n\nGood now.",
    "created_at": "2016-05-03T12:16:28Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20541#issuecomment-296761",
    "user": "https://github.com/jm58660"
}
comment:6

Good now.


archive/issue_events_286878.json:

{
    "actor": "https://github.com/jm58660",
    "created_at": "2016-05-03T12:16:28Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20541#event-286878"
}

archive/issue_events_286879.json:

{
    "actor": "https://github.com/jm58660",
    "created_at": "2016-05-03T12:16:28Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20541#event-286879"
}

archive/issue_comments_296762.json:

{
    "body": "Changed branch from **[public/20541](https://github.com/sagemath/sagetrac-mirror/tree/public/20541)** to **[`7c12326`](https://github.com/sagemath/sagetrac-mirror/commit/7c123263f2a5a4ac052559c53b1090fa3669bc92)**",
    "created_at": "2016-05-05T09:27:06Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20541#issuecomment-296762",
    "user": "https://github.com/vbraun"
}

Changed branch from public/20541 to 7c12326


archive/issue_events_286880.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-05-05T09:27:06Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20541#event-286880"
}

archive/issue_events_286881.json:

{
    "actor": "https://github.com/vbraun",
    "commit_id": "10f7157bca0e032e80f5333a2c1653599e6b9400",
    "commit_repository": "https://github.com/sagemath/sage",
    "created_at": "2016-05-05T09:27:06Z",
    "event": "closed",
    "issue": "https://github.com/sagemath/sage/issues/20541",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20541#event-286881"
}