archive/issues_020308.json:
{
"assignees": [],
"body": "<div id=\"comment:0\"></div>\n\nSphinx's `autodoc` extension now has a custom `formatargspec` function. We should use that instead of `sage_formatargspec` (and delete the latter).\n\nDepends on #20651\n\nCC: @hivert\n\nComponent: **documentation**\n\nAuthor: **Jeroen Demeyer**\n\nBranch: **[`ea280c4`](https://github.com/sagemath/sagetrac-mirror/commit/ea280c419ea0fadd3f384967cefb7037b2ba8f4e)**\n\nReviewer: **Volker Braun**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20545_\n\n",
"closed_at": "2016-05-27T22:39:54Z",
"created_at": "2016-05-03T15:01:59Z",
"labels": [
"https://github.com/sagemath/sage/labels/c%3A%20documentation",
"https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"https://github.com/sagemath/sage/labels/enhancement"
],
"milestone": "https://github.com/sagemath/sage/milestones/sage-7.2",
"reactions": [],
"repository": "https://github.com/sagemath/sage",
"title": "Use formatargspec of Sphinx",
"type": "issue",
"updated_at": "2016-08-09T12:19:05Z",
"url": "https://github.com/sagemath/sage/issues/20545",
"user": "https://github.com/jdemeyer"
}
Sphinx's autodoc
extension now has a custom formatargspec
function. We should use that instead of sage_formatargspec
(and delete the latter).
Depends on #20651
CC: @hivert
Component: documentation
Author: Jeroen Demeyer
Branch: ea280c4
Reviewer: Volker Braun
Issue created by migration from https://trac.sagemath.org/ticket/20545
archive/issue_events_286912.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-05-03T15:01:59Z",
"event": "milestoned",
"issue": "https://github.com/sagemath/sage/issues/20545",
"milestone_number": null,
"milestone_title": "sage-7.2",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20545#event-286912"
}
archive/issue_events_286913.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-05-03T15:01:59Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20545",
"label": "https://github.com/sagemath/sage/labels/c%3A%20documentation",
"label_color": "0075ca",
"label_name": "c: documentation",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20545#event-286913"
}
archive/issue_events_286914.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-05-03T15:01:59Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20545",
"label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"label_color": "ffbb00",
"label_name": "p: major / 3",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20545#event-286914"
}
archive/issue_events_286915.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-05-03T15:01:59Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20545",
"label": "https://github.com/sagemath/sage/labels/enhancement",
"label_color": "696969",
"label_name": "enhancement",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20545#event-286915"
}
archive/issue_comments_296802.json:
{
"body": "Dependencies: **#20554**",
"created_at": "2016-05-04T13:13:19Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296802",
"user": "https://github.com/jdemeyer"
}
Dependencies: #20554
archive/issue_comments_296803.json:
{
"body": "Branch: **[u/jdemeyer/use_formatargspec_of_sphinx](https://github.com/sagemath/sagetrac-mirror/tree/u/jdemeyer/use_formatargspec_of_sphinx)**",
"created_at": "2016-05-04T15:22:08Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296803",
"user": "https://github.com/jdemeyer"
}
Branch: u/jdemeyer/use_formatargspec_of_sphinx
archive/issue_events_286916.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-05-05T07:33:24Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20545",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20545#event-286916"
}
archive/issue_comments_296804.json:
{
"body": "Commit: **[`dbaa1a4`](https://github.com/sagemath/sagetrac-mirror/commit/dbaa1a498a651628fd04f8609932afd288e38f4f)**",
"created_at": "2016-05-05T07:33:24Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296804",
"user": "https://github.com/jdemeyer"
}
Commit: dbaa1a4
archive/issue_comments_296805.json:
{
"body": "<div id=\"comment:3\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/b23f306717cd76c6e8d6970eba85075948a2b007\"><code>b23f306</code></a></td><td><code>Get rid of tuple parameter unpacking</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/dbaa1a498a651628fd04f8609932afd288e38f4f\"><code>dbaa1a4</code></a></td><td><code>Use formatargspec of Sphinx</code></td></tr></table>\n",
"created_at": "2016-05-05T07:33:24Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296805",
"user": "https://github.com/jdemeyer"
}
New commits:
b23f306 | Get rid of tuple parameter unpacking |
dbaa1a4 | Use formatargspec of Sphinx |
archive/issue_comments_296806.json:
{
"body": "<div id=\"comment:4\"></div>\n\nBranch pushed to git repo; I updated commit sha1. This was a forced push. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/00d57a204c1954c39a08559610762647afc6963e\"><code>00d57a2</code></a></td><td><code>Use formatargspec of Sphinx</code></td></tr></table>\n",
"created_at": "2016-05-09T04:28:26Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296806",
"user": "https://github.com/sagetrac-git"
}
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
00d57a2 | Use formatargspec of Sphinx |
archive/issue_comments_296807.json:
{
"body": "Changed commit from **[`dbaa1a4`](https://github.com/sagemath/sagetrac-mirror/commit/dbaa1a498a651628fd04f8609932afd288e38f4f)** to **[`00d57a2`](https://github.com/sagemath/sagetrac-mirror/commit/00d57a204c1954c39a08559610762647afc6963e)**",
"created_at": "2016-05-09T04:28:26Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296807",
"user": "https://github.com/sagetrac-git"
}
Changed commit from dbaa1a4
to 00d57a2
archive/issue_comments_296808.json:
{
"body": "Changed dependencies from **#20554** to none",
"created_at": "2016-05-09T04:28:51Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296808",
"user": "https://github.com/jdemeyer"
}
Changed dependencies from #20554 to none
archive/issue_events_286917.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-05-21T23:23:23Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20545",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20545#event-286917"
}
archive/issue_events_286918.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-05-21T23:23:23Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20545",
"label": "https://github.com/sagemath/sage/labels/needs%20work",
"label_color": "ffff00",
"label_name": "needs work",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20545#event-286918"
}
archive/issue_comments_296809.json:
{
"body": "<div id=\"comment:6\" align=\"right\">comment:6</div>\n\nmerge failure",
"created_at": "2016-05-21T23:23:23Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296809",
"user": "https://github.com/vbraun"
}
merge failure
archive/issue_comments_296810.json:
{
"body": "Changed commit from **[`00d57a2`](https://github.com/sagemath/sagetrac-mirror/commit/00d57a204c1954c39a08559610762647afc6963e)** to **[`61f19fe`](https://github.com/sagemath/sagetrac-mirror/commit/61f19fe86c2da6747ea0525560cd2c9b80a85c28)**",
"created_at": "2016-05-22T08:06:48Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296810",
"user": "https://github.com/sagetrac-git"
}
Changed commit from 00d57a2
to 61f19fe
archive/issue_comments_296811.json:
{
"body": "<div id=\"comment:7\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/61f19fe86c2da6747ea0525560cd2c9b80a85c28\"><code>61f19fe</code></a></td><td><code>Merge tag '7.3.beta0' into t/20545/use_formatargspec_of_sphinx</code></td></tr></table>\n",
"created_at": "2016-05-22T08:06:48Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296811",
"user": "https://github.com/sagetrac-git"
}
Branch pushed to git repo; I updated commit sha1. New commits:
61f19fe | Merge tag '7.3.beta0' into t/20545/use_formatargspec_of_sphinx |
archive/issue_comments_296812.json:
{
"body": "Dependencies: **#20651**",
"created_at": "2016-05-22T10:47:13Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296812",
"user": "https://github.com/jdemeyer"
}
Dependencies: #20651
archive/issue_comments_296813.json:
{
"body": "<div id=\"comment:9\"></div>\n\nBranch pushed to git repo; I updated commit sha1. This was a forced push. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/2388da16d459184f831cc0c1c59f9efd814fca36\"><code>2388da1</code></a></td><td><code>IPython depends on shutil_get_terminal_size</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/ea280c419ea0fadd3f384967cefb7037b2ba8f4e\"><code>ea280c4</code></a></td><td><code>Merge commit '2388da16d459184f831cc0c1c59f9efd814fca36' into t/20545/use_formatargspec_of_sphinx</code></td></tr></table>\n",
"created_at": "2016-05-22T10:49:10Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296813",
"user": "https://github.com/sagetrac-git"
}
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
2388da1 | IPython depends on shutil_get_terminal_size |
ea280c4 | Merge commit '2388da16d459184f831cc0c1c59f9efd814fca36' into t/20545/use_formatargspec_of_sphinx |
archive/issue_comments_296814.json:
{
"body": "Changed commit from **[`61f19fe`](https://github.com/sagemath/sagetrac-mirror/commit/61f19fe86c2da6747ea0525560cd2c9b80a85c28)** to **[`ea280c4`](https://github.com/sagemath/sagetrac-mirror/commit/ea280c419ea0fadd3f384967cefb7037b2ba8f4e)**",
"created_at": "2016-05-22T10:49:10Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296814",
"user": "https://github.com/sagetrac-git"
}
Changed commit from 61f19fe
to ea280c4
archive/issue_events_286919.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-05-22T11:22:57Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20545",
"label": "https://github.com/sagemath/sage/labels/needs%20work",
"label_color": "ffff00",
"label_name": "needs work",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20545#event-286919"
}
archive/issue_events_286920.json:
{
"actor": "https://github.com/jdemeyer",
"created_at": "2016-05-22T11:22:57Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20545",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20545#event-286920"
}
archive/issue_events_286921.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-05-25T23:26:53Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20545",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20545#event-286921"
}
archive/issue_events_286922.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-05-25T23:26:53Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20545",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20545#event-286922"
}
archive/issue_comments_296815.json:
{
"body": "Reviewer: **Volker Braun**",
"created_at": "2016-05-25T23:26:53Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296815",
"user": "https://github.com/vbraun"
}
Reviewer: Volker Braun
archive/issue_events_286923.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-05-27T22:39:54Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20545",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20545#event-286923"
}
archive/issue_events_286924.json:
{
"actor": "https://github.com/vbraun",
"commit_id": "a1820d13df7d0975d59a99aca3d57c5931f0e231",
"commit_repository": "https://github.com/sagemath/sage",
"created_at": "2016-05-27T22:39:54Z",
"event": "closed",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20545#event-286924"
}
archive/issue_comments_296816.json:
{
"body": "Changed branch from **[u/jdemeyer/use_formatargspec_of_sphinx](https://github.com/sagemath/sagetrac-mirror/tree/u/jdemeyer/use_formatargspec_of_sphinx)** to **[`ea280c4`](https://github.com/sagemath/sagetrac-mirror/commit/ea280c419ea0fadd3f384967cefb7037b2ba8f4e)**",
"created_at": "2016-05-27T22:39:54Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296816",
"user": "https://github.com/vbraun"
}
Changed branch from u/jdemeyer/use_formatargspec_of_sphinx to ea280c4
archive/issue_comments_296817.json:
{
"body": "<div id=\"comment:13\" align=\"right\">comment:13</div>\n\nThere should have been a deprecation warning before completely removing the two functions from `sage.misc.sageinspect`, which is orthogonal to using different ones in the Sphinx extension.\n\nI.e., there was no need to remove them just because the *Sphinx extension* does no longer need them. After all, IMHO `src/sage_setup/` and especially `src/sage_setup/docbuild/` don't really belong to the Sage library, in contrast to `sage.misc.*`, which certainly does.",
"created_at": "2016-08-09T11:38:24Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296817",
"user": "https://github.com/nexttime"
}
There should have been a deprecation warning before completely removing the two functions from sage.misc.sageinspect
, which is orthogonal to using different ones in the Sphinx extension.
I.e., there was no need to remove them just because the Sphinx extension does no longer need them. After all, IMHO src/sage_setup/
and especially src/sage_setup/docbuild/
don't really belong to the Sage library, in contrast to sage.misc.*
, which certainly does.
archive/issue_comments_296818.json:
{
"body": "Changed commit from **[`ea280c4`](https://github.com/sagemath/sagetrac-mirror/commit/ea280c419ea0fadd3f384967cefb7037b2ba8f4e)** to none",
"created_at": "2016-08-09T11:38:24Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296818",
"user": "https://github.com/nexttime"
}
Changed commit from ea280c4
to none
archive/issue_comments_296819.json:
{
"body": "<div id=\"comment:14\" align=\"right\">comment:14</div>\n\nOnly public stuff needs deprecation",
"created_at": "2016-08-09T11:53:31Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296819",
"user": "https://github.com/vbraun"
}
Only public stuff needs deprecation
archive/issue_comments_296820.json:
{
"body": "<div id=\"comment:15\" align=\"right\">comment:15</div>\n\nReplying to [@vbraun](#comment%3A14):\n> Only public stuff needs deprecation\n\nThese were not underscore-prefixed functions, hence \"public\".",
"created_at": "2016-08-09T11:58:42Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296820",
"user": "https://github.com/nexttime"
}
Replying to @vbraun:
Only public stuff needs deprecation
These were not underscore-prefixed functions, hence "public".
archive/issue_comments_296821.json:
{
"body": "<div id=\"comment:16\" align=\"right\">comment:16</div>\n\nThats not how we mark implementation details as private",
"created_at": "2016-08-09T12:19:05Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20545",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20545#issuecomment-296821",
"user": "https://github.com/vbraun"
}
Thats not how we mark implementation details as private