archive/issues_020310.json:
{
"assignees": [],
"body": "<div id=\"comment:0\"></div>\n\nanother small step towards python3 print\n\nComponent: **python3**\n\nAuthor: **Fr\u00e9d\u00e9ric Chapoton**\n\nBranch/Commit: **[`18ba7db`](https://github.com/sagemath/sagetrac-mirror/commit/18ba7db1f6b4734289d43f6c081e8eb298c3b090)**\n\nReviewer: **Jori M\u00e4ntysalo**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20547_\n\n",
"closed_at": "2016-05-05T09:26:59Z",
"created_at": "2016-05-03T15:40:10Z",
"labels": [
"https://github.com/sagemath/sage/labels/c%3A%20python3",
"https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"https://github.com/sagemath/sage/labels/enhancement"
],
"milestone": "https://github.com/sagemath/sage/milestones/sage-7.2",
"reactions": [],
"repository": "https://github.com/sagemath/sage",
"title": "py3 print in symbolic folder",
"type": "issue",
"updated_at": "2016-05-05T09:26:59Z",
"url": "https://github.com/sagemath/sage/issues/20547",
"user": "https://github.com/fchapoton"
}another small step towards python3 print
Component: python3
Author: Frédéric Chapoton
Branch/Commit: 18ba7db
Reviewer: Jori Mäntysalo
Issue created by migration from https://trac.sagemath.org/ticket/20547
archive/issue_events_286934.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-05-03T15:40:10Z",
"event": "milestoned",
"issue": "https://github.com/sagemath/sage/issues/20547",
"milestone_number": null,
"milestone_title": "sage-7.2",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20547#event-286934"
}archive/issue_events_286935.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-05-03T15:40:10Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20547",
"label": "https://github.com/sagemath/sage/labels/c%3A%20python3",
"label_color": "0000b0",
"label_name": "c: python3",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20547#event-286935"
}archive/issue_events_286936.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-05-03T15:40:10Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20547",
"label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"label_color": "ffbb00",
"label_name": "p: major / 3",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20547#event-286936"
}archive/issue_events_286937.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-05-03T15:40:10Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20547",
"label": "https://github.com/sagemath/sage/labels/enhancement",
"label_color": "696969",
"label_name": "enhancement",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20547#event-286937"
}archive/issue_comments_296827.json:
{
"body": "<div id=\"comment:1\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/18ba7db1f6b4734289d43f6c081e8eb298c3b090\"><code>18ba7db</code></a></td><td><code>python3 print in symbolic</code></td></tr></table>\n",
"created_at": "2016-05-03T15:40:37Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20547",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20547#issuecomment-296827",
"user": "https://github.com/fchapoton"
}New commits:
18ba7db | python3 print in symbolic |
archive/issue_events_286938.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-05-03T15:40:37Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20547",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20547#event-286938"
}archive/issue_comments_296828.json:
{
"body": "Commit: **[`18ba7db`](https://github.com/sagemath/sagetrac-mirror/commit/18ba7db1f6b4734289d43f6c081e8eb298c3b090)**",
"created_at": "2016-05-03T15:40:37Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20547",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20547#issuecomment-296828",
"user": "https://github.com/fchapoton"
}Commit: 18ba7db
archive/issue_comments_296829.json:
{
"body": "Branch: **[public/20547](https://github.com/sagemath/sagetrac-mirror/tree/public/20547)**",
"created_at": "2016-05-03T15:40:37Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20547",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20547#issuecomment-296829",
"user": "https://github.com/fchapoton"
}Branch: public/20547
archive/issue_comments_296830.json:
{
"body": "<div id=\"comment:2\" align=\"right\">comment:2</div>\n\nI can take this one.",
"created_at": "2016-05-03T18:05:52Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20547",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20547#issuecomment-296830",
"user": "https://github.com/jm58660"
}comment:2
I can take this one.
archive/issue_comments_296831.json:
{
"body": "Reviewer: **Jori M\u00e4ntysalo**",
"created_at": "2016-05-03T18:05:52Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20547",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20547#issuecomment-296831",
"user": "https://github.com/jm58660"
}Reviewer: Jori Mäntysalo
archive/issue_comments_296832.json:
{
"body": "<div id=\"comment:3\" align=\"right\">comment:3</div>\n\nYou can mark this as *positive_review* if you want.\n\nIf you want to obey PEPs strictly, add some spaces after commas; you see them with command\n\n```\ngit show | egrep '^\\+.+,[^ ]'\n```\n\nWhat is the reason to convert `print \"foo: \", x` to `print(\"foo: {}\".format(x)` instead of `print(\"foo:\", x)`?",
"created_at": "2016-05-03T18:27:47Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20547",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20547#issuecomment-296832",
"user": "https://github.com/jm58660"
}comment:3
You can mark this as positive_review if you want.
If you want to obey PEPs strictly, add some spaces after commas; you see them with command
git show | egrep '^\+.+,[^ ]'
What is the reason to convert print "foo: ", x to print("foo: {}".format(x) instead of print("foo:", x)?
archive/issue_comments_296833.json:
{
"body": "<div id=\"comment:4\" align=\"right\">comment:4</div>\n\nThanks a lot for the reviews, Jori.\n\nPep8 is not the priority now. I prefer to do minimal changes, only about print.\n\nIndeed, this is another solution, at least inside the code. I use either, in no\nsystematic way. But the simple way will not work in\nthe doc as long as we have not switched to py3.",
"created_at": "2016-05-03T18:44:41Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20547",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20547#issuecomment-296833",
"user": "https://github.com/fchapoton"
}comment:4
Thanks a lot for the reviews, Jori.
Pep8 is not the priority now. I prefer to do minimal changes, only about print.
Indeed, this is another solution, at least inside the code. I use either, in no systematic way. But the simple way will not work in the doc as long as we have not switched to py3.
archive/issue_events_286939.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-05-03T18:44:41Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20547",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20547#event-286939"
}archive/issue_events_286940.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-05-03T18:44:41Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20547",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20547#event-286940"
}archive/issue_events_286941.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-05-05T09:26:59Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20547",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20547#event-286941"
}archive/issue_events_286942.json:
{
"actor": "https://github.com/vbraun",
"commit_id": "78ac24ea6a82daf31f68b3b5e31bf202c589166e",
"commit_repository": "https://github.com/sagemath/sage",
"created_at": "2016-05-05T09:26:59Z",
"event": "closed",
"issue": "https://github.com/sagemath/sage/issues/20547",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20547#event-286942"
}archive/issue_comments_296834.json:
{
"body": "Changed branch from **[public/20547](https://github.com/sagemath/sagetrac-mirror/tree/public/20547)** to **[`18ba7db`](https://github.com/sagemath/sagetrac-mirror/commit/18ba7db1f6b4734289d43f6c081e8eb298c3b090)**",
"created_at": "2016-05-05T09:26:59Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20547",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20547#issuecomment-296834",
"user": "https://github.com/vbraun"
}Changed branch from public/20547 to 18ba7db