Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Latest commit

 

History

History
359 lines (273 loc) · 11.2 KB

20594.md

File metadata and controls

359 lines (273 loc) · 11.2 KB

Issue 20594: Allow GCC 4.8 again

archive/issues_020357.json:

{
    "assignees": [],
    "body": "<div id=\"comment:0\"></div>\n\nThe reason for blacklisting GCC 4.8 in #20231 was to support #20226, but that's not going to be merged in Sage 7.2. So maybe it's best to still support GCC 4.8 in Sage 7.2 (maybe with a deprecation warning in `configure.ac`).\n\nWhen #20226 gets merged in some later beta, we can then either re-merge #20231 or find a work-around to make it work with GCC 4.8.\n\n\nCC:  @embray @vbraun @fchapoton\n\nComponent: **build: configure**\n\nAuthor: **Jeroen Demeyer**\n\nBranch: **[`9806da4`](https://github.com/sagemath/sagetrac-mirror/commit/9806da4c10dbd9730424ae96156f2f00fdb3b066)**\n\nReviewer: **Volker Braun**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20594_\n\n",
    "closed_at": "2016-05-11T20:10:23Z",
    "created_at": "2016-05-11T19:26:58Z",
    "labels": [
        "https://github.com/sagemath/sage/labels/c%3A%20build%3A%20configure",
        "https://github.com/sagemath/sage/labels/p%3A%20blocker%20/%201",
        "https://github.com/sagemath/sage/labels/enhancement"
    ],
    "milestone": "https://github.com/sagemath/sage/milestones/sage-7.2",
    "reactions": [],
    "repository": "https://github.com/sagemath/sage",
    "title": "Allow GCC 4.8 again",
    "type": "issue",
    "updated_at": "2016-05-13T11:40:36Z",
    "url": "https://github.com/sagemath/sage/issues/20594",
    "user": "https://github.com/jdemeyer"
}

The reason for blacklisting GCC 4.8 in #20231 was to support #20226, but that's not going to be merged in Sage 7.2. So maybe it's best to still support GCC 4.8 in Sage 7.2 (maybe with a deprecation warning in configure.ac).

When #20226 gets merged in some later beta, we can then either re-merge #20231 or find a work-around to make it work with GCC 4.8.

CC: @embray @vbraun @fchapoton

Component: build: configure

Author: Jeroen Demeyer

Branch: 9806da4

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/20594


archive/issue_events_287538.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-05-11T19:26:58Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20594",
    "milestone_number": null,
    "milestone_title": "sage-7.2",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20594#event-287538"
}

archive/issue_events_287539.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-05-11T19:26:58Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20594",
    "label": "https://github.com/sagemath/sage/labels/c%3A%20build%3A%20configure",
    "label_color": "0000b0",
    "label_name": "c: build: configure",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20594#event-287539"
}

archive/issue_events_287540.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-05-11T19:26:58Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20594",
    "label": "https://github.com/sagemath/sage/labels/p%3A%20blocker%20/%201",
    "label_color": "ff0000",
    "label_name": "p: blocker / 1",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20594#event-287540"
}

archive/issue_events_287541.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-05-11T19:26:58Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20594",
    "label": "https://github.com/sagemath/sage/labels/enhancement",
    "label_color": "696969",
    "label_name": "enhancement",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20594#event-287541"
}

archive/issue_comments_297701.json:

{
    "body": "Branch: **[u/jdemeyer/allow_gcc_4_8_again](https://github.com/sagemath/sagetrac-mirror/tree/u/jdemeyer/allow_gcc_4_8_again)**",
    "created_at": "2016-05-11T19:30:12Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20594",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20594#issuecomment-297701",
    "user": "https://github.com/jdemeyer"
}

Branch: u/jdemeyer/allow_gcc_4_8_again


archive/issue_comments_297702.json:

{
    "body": "<div id=\"comment:2\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/9806da4c10dbd9730424ae96156f2f00fdb3b066\"><code>9806da4</code></a></td><td><code>Revert \"Blacklist GCC versions 4.8.x\"</code></td></tr></table>\n",
    "created_at": "2016-05-11T19:31:17Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20594",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20594#issuecomment-297702",
    "user": "https://github.com/jdemeyer"
}

New commits:

9806da4Revert "Blacklist GCC versions 4.8.x"

archive/issue_comments_297703.json:

{
    "body": "Commit: **[`9806da4`](https://github.com/sagemath/sagetrac-mirror/commit/9806da4c10dbd9730424ae96156f2f00fdb3b066)**",
    "created_at": "2016-05-11T19:31:17Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20594",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20594#issuecomment-297703",
    "user": "https://github.com/jdemeyer"
}

Commit: 9806da4


archive/issue_events_287542.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-05-11T19:31:17Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20594",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20594#event-287542"
}

archive/issue_events_287543.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-05-11T20:05:53Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20594",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20594#event-287543"
}

archive/issue_events_287544.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-05-11T20:05:53Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20594",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20594#event-287544"
}

archive/issue_comments_297704.json:

{
    "body": "Reviewer: **Volker Braun**",
    "created_at": "2016-05-11T20:05:53Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20594",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20594#issuecomment-297704",
    "user": "https://github.com/vbraun"
}

Reviewer: Volker Braun


archive/issue_comments_297705.json:

{
    "body": "Changed branch from **[u/jdemeyer/allow_gcc_4_8_again](https://github.com/sagemath/sagetrac-mirror/tree/u/jdemeyer/allow_gcc_4_8_again)** to **[`9806da4`](https://github.com/sagemath/sagetrac-mirror/commit/9806da4c10dbd9730424ae96156f2f00fdb3b066)**",
    "created_at": "2016-05-11T20:10:23Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20594",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20594#issuecomment-297705",
    "user": "https://github.com/vbraun"
}

Changed branch from u/jdemeyer/allow_gcc_4_8_again to 9806da4


archive/issue_events_287545.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-05-11T20:10:23Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20594",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20594#event-287545"
}

archive/issue_events_287546.json:

{
    "actor": "https://github.com/vbraun",
    "commit_id": "76d0c7d425c1417737c54ec74df96068d9215f3a",
    "commit_repository": "https://github.com/sagemath/sage",
    "created_at": "2016-05-11T20:10:23Z",
    "event": "closed",
    "issue": "https://github.com/sagemath/sage/issues/20594",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20594#event-287546"
}

archive/issue_comments_297706.json:

{
    "body": "Changed commit from **[`9806da4`](https://github.com/sagemath/sagetrac-mirror/commit/9806da4c10dbd9730424ae96156f2f00fdb3b066)** to none",
    "created_at": "2016-05-13T11:40:36Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20594",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20594#issuecomment-297706",
    "user": "https://github.com/embray"
}

Changed commit from 9806da4 to none


archive/issue_comments_297707.json:

{
    "body": "<div id=\"comment:5\" align=\"right\">comment:5</div>\n\nI think the message should state more explicitly that GCC 4.8 support is *deprecated* and will be dropped on the next release.  Just saying it's \"quite old\" doesn't really say anything informative :)",
    "created_at": "2016-05-13T11:40:36Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20594",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20594#issuecomment-297707",
    "user": "https://github.com/embray"
}
comment:5

I think the message should state more explicitly that GCC 4.8 support is deprecated and will be dropped on the next release. Just saying it's "quite old" doesn't really say anything informative :)