archive/issues_020375.json:
{
"assignees": [],
"body": "<div id=\"comment:0\"></div>\n\nanother step in the move towards python3 print\n\nthis one in the tests folder, that contains in particular material from books\n\nComponent: **python3**\n\nAuthor: **Fr\u00e9d\u00e9ric Chapoton**\n\nBranch/Commit: **[`88db08c`](https://github.com/sagemath/sagetrac-mirror/commit/88db08c2d8ca8c90ac7611bcccd8bbc0178da4c6)**\n\nReviewer: **Jori M\u00e4ntysalo**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20612_\n\n",
"closed_at": "2016-05-21T16:40:47Z",
"created_at": "2016-05-15T13:52:43Z",
"labels": [
"https://github.com/sagemath/sage/labels/c%3A%20python3",
"https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"https://github.com/sagemath/sage/labels/enhancement"
],
"milestone": "https://github.com/sagemath/sage/milestones/sage-7.3",
"reactions": [],
"repository": "https://github.com/sagemath/sage",
"title": "py3 print in books and tests",
"type": "issue",
"updated_at": "2016-05-21T16:40:47Z",
"url": "https://github.com/sagemath/sage/issues/20612",
"user": "https://github.com/fchapoton"
}another step in the move towards python3 print
this one in the tests folder, that contains in particular material from books
Component: python3
Author: Frédéric Chapoton
Branch/Commit: 88db08c
Reviewer: Jori Mäntysalo
Issue created by migration from https://trac.sagemath.org/ticket/20612
archive/issue_events_287773.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-05-15T13:52:43Z",
"event": "milestoned",
"issue": "https://github.com/sagemath/sage/issues/20612",
"milestone_number": null,
"milestone_title": "sage-7.3",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20612#event-287773"
}archive/issue_events_287774.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-05-15T13:52:43Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20612",
"label": "https://github.com/sagemath/sage/labels/c%3A%20python3",
"label_color": "0000b0",
"label_name": "c: python3",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20612#event-287774"
}archive/issue_events_287775.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-05-15T13:52:43Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20612",
"label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"label_color": "ffbb00",
"label_name": "p: major / 3",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20612#event-287775"
}archive/issue_events_287776.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-05-15T13:52:43Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20612",
"label": "https://github.com/sagemath/sage/labels/enhancement",
"label_color": "696969",
"label_name": "enhancement",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20612#event-287776"
}archive/issue_comments_297994.json:
{
"body": "Commit: **[`1e3f35c`](https://github.com/sagemath/sagetrac-mirror/commit/1e3f35cac172caa4c1f8d22e95969ab0a960cfc8)**",
"created_at": "2016-05-15T13:53:11Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20612",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20612#issuecomment-297994",
"user": "https://github.com/fchapoton"
}Commit: 1e3f35c
archive/issue_comments_297995.json:
{
"body": "Branch: **[public/20612](https://github.com/sagemath/sagetrac-mirror/tree/public/20612)**",
"created_at": "2016-05-15T13:53:11Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20612",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20612#issuecomment-297995",
"user": "https://github.com/fchapoton"
}Branch: public/20612
archive/issue_comments_297996.json:
{
"body": "<div id=\"comment:1\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/1e3f35cac172caa4c1f8d22e95969ab0a960cfc8\"><code>1e3f35c</code></a></td><td><code>python3 prints in tests and books</code></td></tr></table>\n",
"created_at": "2016-05-15T13:53:11Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20612",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20612#issuecomment-297996",
"user": "https://github.com/fchapoton"
}New commits:
1e3f35c | python3 prints in tests and books |
archive/issue_events_287777.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-05-15T13:53:11Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20612",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20612#event-287777"
}archive/issue_comments_297997.json:
{
"body": "Changed commit from **[`1e3f35c`](https://github.com/sagemath/sagetrac-mirror/commit/1e3f35cac172caa4c1f8d22e95969ab0a960cfc8)** to **[`27b1df7`](https://github.com/sagemath/sagetrac-mirror/commit/27b1df73d8a07da8951d00842ff855a189dc6f15)**",
"created_at": "2016-05-15T15:41:01Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20612",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20612#issuecomment-297997",
"user": "https://github.com/sagetrac-git"
}Changed commit from 1e3f35c to 27b1df7
archive/issue_comments_297998.json:
{
"body": "<div id=\"comment:2\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/27b1df73d8a07da8951d00842ff855a189dc6f15\"><code>27b1df7</code></a></td><td><code>python 3 print in tests folder, details</code></td></tr></table>\n",
"created_at": "2016-05-15T15:41:01Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20612",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20612#issuecomment-297998",
"user": "https://github.com/sagetrac-git"
}Branch pushed to git repo; I updated commit sha1. New commits:
27b1df7 | python 3 print in tests folder, details |
archive/issue_comments_297999.json:
{
"body": "<div id=\"comment:3\" align=\"right\">comment:3</div>\n\nI can take a look. At least `c.q(n)*c.p(n-2)for` needs a space before `for` IMO (not an error technically, but...). Also `print(v)` has old-style continuation (which is not an error, this is just a note).",
"created_at": "2016-05-15T19:05:51Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20612",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20612#issuecomment-297999",
"user": "https://github.com/jm58660"
}comment:3
I can take a look. At least c.q(n)*c.p(n-2)for needs a space before for IMO (not an error technically, but...). Also print(v) has old-style continuation (which is not an error, this is just a note).
archive/issue_comments_298000.json:
{
"body": "Reviewer: **Jori M\u00e4ntysalo**",
"created_at": "2016-05-15T19:05:51Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20612",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20612#issuecomment-298000",
"user": "https://github.com/jm58660"
}Reviewer: Jori Mäntysalo
archive/issue_comments_298001.json:
{
"body": "<div id=\"comment:4\" align=\"right\">comment:4</div>\n\nYou have forgotten two prints:\n\n```\nsage: print 10, 0.5 ; print(10+0.5) ; print 10.0, 5\n```\n\nand\n\n```\nprint 10+0, 5 ; print(str(10)+str(0.5))\n```\n\nI am now compiling and testing.",
"created_at": "2016-05-15T19:16:39Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20612",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20612#issuecomment-298001",
"user": "https://github.com/jm58660"
}comment:4
You have forgotten two prints:
sage: print 10, 0.5 ; print(10+0.5) ; print 10.0, 5
and
print 10+0, 5 ; print(str(10)+str(0.5))
I am now compiling and testing.
archive/issue_events_287778.json:
{
"actor": "https://github.com/jm58660",
"created_at": "2016-05-15T19:16:39Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20612",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20612#event-287778"
}archive/issue_events_287779.json:
{
"actor": "https://github.com/jm58660",
"created_at": "2016-05-15T19:16:39Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20612",
"label": "https://github.com/sagemath/sage/labels/needs%20work",
"label_color": "ffff00",
"label_name": "needs work",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20612#event-287779"
}archive/issue_comments_298002.json:
{
"body": "<div id=\"comment:5\" align=\"right\">comment:5</div>\n\nI have **chosen** to leave these two doctests as they are, because they serve (in the french book) to illustrate the behavior of print in python2. This is a difficult case.\nI would prefer to postpone changing them to the very end of the process, when we will switch\nto python3 print.",
"created_at": "2016-05-15T19:19:40Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20612",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20612#issuecomment-298002",
"user": "https://github.com/fchapoton"
}comment:5
I have chosen to leave these two doctests as they are, because they serve (in the french book) to illustrate the behavior of print in python2. This is a difficult case. I would prefer to postpone changing them to the very end of the process, when we will switch to python3 print.
archive/issue_comments_298003.json:
{
"body": "<div id=\"comment:6\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/88db08c2d8ca8c90ac7611bcccd8bbc0178da4c6\"><code>88db08c</code></a></td><td><code>trac 20612, python print in tests and book, details</code></td></tr></table>\n",
"created_at": "2016-05-15T19:54:27Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20612",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20612#issuecomment-298003",
"user": "https://github.com/sagetrac-git"
}Branch pushed to git repo; I updated commit sha1. New commits:
88db08c | trac 20612, python print in tests and book, details |
archive/issue_comments_298004.json:
{
"body": "Changed commit from **[`27b1df7`](https://github.com/sagemath/sagetrac-mirror/commit/27b1df73d8a07da8951d00842ff855a189dc6f15)** to **[`88db08c`](https://github.com/sagemath/sagetrac-mirror/commit/88db08c2d8ca8c90ac7611bcccd8bbc0178da4c6)**",
"created_at": "2016-05-15T19:54:27Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20612",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20612#issuecomment-298004",
"user": "https://github.com/sagetrac-git"
}Changed commit from 27b1df7 to 88db08c
archive/issue_events_287780.json:
{
"actor": "https://github.com/jm58660",
"created_at": "2016-05-16T04:11:58Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20612",
"label": "https://github.com/sagemath/sage/labels/needs%20work",
"label_color": "ffff00",
"label_name": "needs work",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20612#event-287780"
}archive/issue_events_287781.json:
{
"actor": "https://github.com/jm58660",
"created_at": "2016-05-16T04:11:58Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20612",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20612#event-287781"
}archive/issue_comments_298005.json:
{
"body": "<div id=\"comment:7\" align=\"right\">comment:7</div>\n\nReplying to [@fchapoton](#comment%3A5):\n> I have **chosen** to leave these two doctests as they are, because they serve (in the french book) to illustrate the behavior of print in python2.\n\nOK then...",
"created_at": "2016-05-16T04:11:58Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20612",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20612#issuecomment-298005",
"user": "https://github.com/jm58660"
}comment:7
Replying to @fchapoton:
I have chosen to leave these two doctests as they are, because they serve (in the french book) to illustrate the behavior of print in python2.
OK then...
archive/issue_comments_298006.json:
{
"body": "<div id=\"comment:8\" align=\"right\">comment:8</div>\n\n...and as tests were passed I mark this as a *positive_review*'.",
"created_at": "2016-05-16T04:12:29Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20612",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20612#issuecomment-298006",
"user": "https://github.com/jm58660"
}comment:8
...and as tests were passed I mark this as a positive_review'.
archive/issue_events_287782.json:
{
"actor": "https://github.com/jm58660",
"created_at": "2016-05-16T04:12:29Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20612",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20612#event-287782"
}archive/issue_events_287783.json:
{
"actor": "https://github.com/jm58660",
"created_at": "2016-05-16T04:12:29Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20612",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20612#event-287783"
}archive/issue_comments_298007.json:
{
"body": "Changed branch from **[public/20612](https://github.com/sagemath/sagetrac-mirror/tree/public/20612)** to **[`88db08c`](https://github.com/sagemath/sagetrac-mirror/commit/88db08c2d8ca8c90ac7611bcccd8bbc0178da4c6)**",
"created_at": "2016-05-21T16:40:47Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20612",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20612#issuecomment-298007",
"user": "https://github.com/vbraun"
}Changed branch from public/20612 to 88db08c
archive/issue_events_287784.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-05-21T16:40:47Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20612",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20612#event-287784"
}archive/issue_events_287785.json:
{
"actor": "https://github.com/vbraun",
"commit_id": "8111ae58ba8338236674f5f71ccf27b5dfeda549",
"commit_repository": "https://github.com/sagemath/sage",
"created_at": "2016-05-21T16:40:47Z",
"event": "closed",
"issue": "https://github.com/sagemath/sage/issues/20612",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20612#event-287785"
}