Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Latest commit

 

History

History
379 lines (288 loc) · 11.3 KB

20662.md

File metadata and controls

379 lines (288 loc) · 11.3 KB

Issue 20662: use python3 syntax for raise also in cython files (step2, rings part1)

archive/issues_020425.json:

{
    "assignees": [],
    "body": "<div id=\"comment:0\"></div>\n\nnow conversion to `raise Error(\"msg\")` in rings, first half\n\nCC:  @embray @jdemeyer\n\nComponent: **python3**\n\nAuthor: **Fr\u00e9d\u00e9ric Chapoton**\n\nBranch/Commit: **[`b903f5d`](https://github.com/sagemath/sagetrac-mirror/commit/b903f5d3b38009471093bc90172de43ada8a6cf5)**\n\nReviewer: **Travis Scrimshaw**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20662_\n\n",
    "closed_at": "2016-05-28T12:13:39Z",
    "created_at": "2016-05-23T19:15:28Z",
    "labels": [
        "https://github.com/sagemath/sage/labels/c%3A%20python3",
        "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
        "https://github.com/sagemath/sage/labels/enhancement"
    ],
    "milestone": "https://github.com/sagemath/sage/milestones/sage-7.3",
    "reactions": [],
    "repository": "https://github.com/sagemath/sage",
    "title": "use python3 syntax for raise also in cython files (step2, rings part1)",
    "type": "issue",
    "updated_at": "2016-05-28T12:13:39Z",
    "url": "https://github.com/sagemath/sage/issues/20662",
    "user": "https://github.com/fchapoton"
}

now conversion to raise Error("msg") in rings, first half

CC: @embray @jdemeyer

Component: python3

Author: Frédéric Chapoton

Branch/Commit: b903f5d

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20662


archive/issue_events_288340.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-05-23T19:15:28Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20662",
    "milestone_number": null,
    "milestone_title": "sage-7.3",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20662#event-288340"
}

archive/issue_events_288341.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-05-23T19:15:28Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20662",
    "label": "https://github.com/sagemath/sage/labels/c%3A%20python3",
    "label_color": "0000b0",
    "label_name": "c: python3",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20662#event-288341"
}

archive/issue_events_288342.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-05-23T19:15:28Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20662",
    "label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
    "label_color": "ffbb00",
    "label_name": "p: major / 3",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20662#event-288342"
}

archive/issue_events_288343.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-05-23T19:15:28Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20662",
    "label": "https://github.com/sagemath/sage/labels/enhancement",
    "label_color": "696969",
    "label_name": "enhancement",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20662#event-288343"
}

archive/issue_comments_298683.json:

{
    "body": "Branch: **[public/20662](https://github.com/sagemath/sagetrac-mirror/tree/public/20662)**",
    "created_at": "2016-05-23T19:16:04Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20662",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20662#issuecomment-298683",
    "user": "https://github.com/fchapoton"
}

Branch: public/20662


archive/issue_comments_298684.json:

{
    "body": "<div id=\"comment:1\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/7f9165eaff22a45ed25047d93aafee9ed56134e5\"><code>7f9165e</code></a></td><td><code>raise to py3 syntax in cython (rings, part 1)</code></td></tr></table>\n",
    "created_at": "2016-05-23T19:16:04Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20662",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20662#issuecomment-298684",
    "user": "https://github.com/fchapoton"
}

New commits:

7f9165eraise to py3 syntax in cython (rings, part 1)

archive/issue_comments_298685.json:

{
    "body": "Commit: **[`7f9165e`](https://github.com/sagemath/sagetrac-mirror/commit/7f9165eaff22a45ed25047d93aafee9ed56134e5)**",
    "created_at": "2016-05-23T19:16:04Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20662",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20662#issuecomment-298685",
    "user": "https://github.com/fchapoton"
}

Commit: 7f9165e


archive/issue_events_288344.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-05-23T19:16:04Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20662",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20662#event-288344"
}

archive/issue_comments_298686.json:

{
    "body": "Changed commit from **[`7f9165e`](https://github.com/sagemath/sagetrac-mirror/commit/7f9165eaff22a45ed25047d93aafee9ed56134e5)** to **[`b903f5d`](https://github.com/sagemath/sagetrac-mirror/commit/b903f5d3b38009471093bc90172de43ada8a6cf5)**",
    "created_at": "2016-05-26T18:42:30Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20662",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20662#issuecomment-298686",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 7f9165e to b903f5d


archive/issue_comments_298687.json:

{
    "body": "<div id=\"comment:2\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/b903f5d3b38009471093bc90172de43ada8a6cf5\"><code>b903f5d</code></a></td><td><code>Merge branch 'public/20662' into 7.3.b1</code></td></tr></table>\n",
    "created_at": "2016-05-26T18:42:30Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20662",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20662#issuecomment-298687",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

b903f5dMerge branch 'public/20662' into 7.3.b1

archive/issue_comments_298688.json:

{
    "body": "<div id=\"comment:3\" align=\"right\">comment:3</div>\n\nLGTM.",
    "created_at": "2016-05-26T20:18:33Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20662",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20662#issuecomment-298688",
    "user": "https://github.com/tscrim"
}
comment:3

LGTM.


archive/issue_comments_298689.json:

{
    "body": "Reviewer: **Travis Scrimshaw**",
    "created_at": "2016-05-26T20:18:33Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20662",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20662#issuecomment-298689",
    "user": "https://github.com/tscrim"
}

Reviewer: Travis Scrimshaw


archive/issue_events_288345.json:

{
    "actor": "https://github.com/tscrim",
    "created_at": "2016-05-26T20:18:33Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20662",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20662#event-288345"
}

archive/issue_events_288346.json:

{
    "actor": "https://github.com/tscrim",
    "created_at": "2016-05-26T20:18:33Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20662",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20662#event-288346"
}

archive/issue_events_288347.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-05-28T12:13:39Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20662",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20662#event-288347"
}

archive/issue_events_288348.json:

{
    "actor": "https://github.com/vbraun",
    "commit_id": "7bddc8fc8c92198323602e8dae20acef8a2ba6a4",
    "commit_repository": "https://github.com/sagemath/sage",
    "created_at": "2016-05-28T12:13:39Z",
    "event": "closed",
    "issue": "https://github.com/sagemath/sage/issues/20662",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20662#event-288348"
}

archive/issue_comments_298690.json:

{
    "body": "Changed branch from **[public/20662](https://github.com/sagemath/sagetrac-mirror/tree/public/20662)** to **[`b903f5d`](https://github.com/sagemath/sagetrac-mirror/commit/b903f5d3b38009471093bc90172de43ada8a6cf5)**",
    "created_at": "2016-05-28T12:13:39Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20662",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20662#issuecomment-298690",
    "user": "https://github.com/vbraun"
}

Changed branch from public/20662 to b903f5d