Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Latest commit

 

History

History
424 lines (324 loc) · 12.3 KB

20687.md

File metadata and controls

424 lines (324 loc) · 12.3 KB

Issue 20687: wrong result for is_subword_of

archive/issues_020450.json:

{
    "assignees": [],
    "body": "<div id=\"comment:0\"></div>\n\nI wouldn't have expected the following:\n\n```\nsage: phi = WordMorphism('a->aba,b->ab')\nsage: w = phi('a', 3)\nsage: w\nword: abaababaabaababaababa\nsage: Word('bb').is_subword_of(w)\nTrue\n```\n\n\nComponent: **combinatorics**\n\nAuthor: **S\u00e9bastien Labb\u00e9**\n\nBranch/Commit: **[`c84aeac`](https://github.com/sagemath/sagetrac-mirror/commit/c84aeac6cc24b29d4e1d89912d53e7de4fe04c64)**\n\nReviewer: **Daniel Krenn**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20687_\n\n",
    "closed_at": "2018-05-18T17:04:24Z",
    "created_at": "2016-05-26T17:50:34Z",
    "labels": [
        "https://github.com/sagemath/sage/labels/c%3A%20combinatorics",
        "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
        "https://github.com/sagemath/sage/labels/bug"
    ],
    "milestone": "https://github.com/sagemath/sage/milestones/sage-8.3",
    "reactions": [],
    "repository": "https://github.com/sagemath/sage",
    "title": "wrong result for is_subword_of",
    "type": "issue",
    "updated_at": "2018-05-18T17:04:24Z",
    "url": "https://github.com/sagemath/sage/issues/20687",
    "user": "https://github.com/dkrenn"
}

I wouldn't have expected the following:

sage: phi = WordMorphism('a->aba,b->ab')
sage: w = phi('a', 3)
sage: w
word: abaababaabaababaababa
sage: Word('bb').is_subword_of(w)
True

Component: combinatorics

Author: Sébastien Labbé

Branch/Commit: c84aeac

Reviewer: Daniel Krenn

Issue created by migration from https://trac.sagemath.org/ticket/20687


archive/issue_events_288683.json:

{
    "actor": "https://github.com/dkrenn",
    "created_at": "2016-05-26T17:50:34Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "milestone_number": null,
    "milestone_title": "sage-7.3",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20687#event-288683"
}

archive/issue_events_288684.json:

{
    "actor": "https://github.com/dkrenn",
    "created_at": "2016-05-26T17:50:34Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "label": "https://github.com/sagemath/sage/labels/c%3A%20combinatorics",
    "label_color": "0000ff",
    "label_name": "c: combinatorics",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20687#event-288684"
}

archive/issue_events_288685.json:

{
    "actor": "https://github.com/dkrenn",
    "created_at": "2016-05-26T17:50:34Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
    "label_color": "ffbb00",
    "label_name": "p: major / 3",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20687#event-288685"
}

archive/issue_events_288686.json:

{
    "actor": "https://github.com/dkrenn",
    "created_at": "2016-05-26T17:50:34Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "label": "https://github.com/sagemath/sage/labels/bug",
    "label_color": "d73a4a",
    "label_name": "bug",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20687#event-288686"
}

archive/issue_comments_299183.json:

{
    "body": "<div id=\"comment:1\" align=\"right\">comment:1</div>\n\nBy `subword` is meant the same definition as in [Chapter 6 Subwords](https://books.google.fr/books?id=eATLTZzwW-sC&pg=PA105&lpg=PA105&dq=subword+lothaire&source=bl&ots=ZriLpJXbK5&sig=OdHaDu_IWcUL_Qs6U0oKOZ2H0ic&hl=en&sa=X&ved=0ahUKEwjS7onE-_DaAhVC8RQKHbriAnAQ6AEIQTAE#v=onepage&q=subword%20lothaire&f=false) of 1997 Lothaire's book.",
    "created_at": "2018-05-06T11:23:19Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20687#issuecomment-299183",
    "user": "https://github.com/seblabbe"
}
comment:1

By subword is meant the same definition as in Chapter 6 Subwords of 1997 Lothaire's book.


archive/issue_comments_299184.json:

{
    "body": "Branch: **[u/slabbe/20687](https://github.com/sagemath/sagetrac-mirror/tree/u/slabbe/20687)**",
    "created_at": "2018-05-06T11:40:13Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20687#issuecomment-299184",
    "user": "https://github.com/seblabbe"
}

Branch: u/slabbe/20687


archive/issue_comments_299185.json:

{
    "body": "Commit: **[`c84aeac`](https://github.com/sagemath/sagetrac-mirror/commit/c84aeac6cc24b29d4e1d89912d53e7de4fe04c64)**",
    "created_at": "2018-05-06T11:40:13Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20687#issuecomment-299185",
    "user": "https://github.com/seblabbe"
}

Commit: c84aeac


archive/issue_comments_299186.json:

{
    "body": "<div id=\"comment:2\" align=\"right\">comment:2</div>\n\nI updated the doc.\n\n---\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/c84aeac6cc24b29d4e1d89912d53e7de4fe04c64\"><code>c84aeac</code></a></td><td><code>20687: added doc to is_subword_of</code></td></tr></table>\n",
    "created_at": "2018-05-06T11:40:13Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20687#issuecomment-299186",
    "user": "https://github.com/seblabbe"
}
comment:2

I updated the doc.


New commits:

c84aeac20687: added doc to is_subword_of

archive/issue_events_288687.json:

{
    "actor": "https://github.com/seblabbe",
    "created_at": "2018-05-06T11:40:13Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20687#event-288687"
}

archive/issue_comments_299187.json:

{
    "body": "Author: **S\u00e9bastien Labb\u00e9**",
    "created_at": "2018-05-06T11:40:13Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20687#issuecomment-299187",
    "user": "https://github.com/seblabbe"
}

Author: Sébastien Labbé


archive/issue_events_288688.json:

{
    "actor": "https://github.com/seblabbe",
    "created_at": "2018-05-06T11:40:52Z",
    "event": "demilestoned",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "milestone_number": null,
    "milestone_title": "sage-7.3",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20687#event-288688"
}

archive/issue_events_288689.json:

{
    "actor": "https://github.com/seblabbe",
    "created_at": "2018-05-06T11:40:52Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "milestone_number": null,
    "milestone_title": "sage-8.3",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20687#event-288689"
}

archive/issue_comments_299188.json:

{
    "body": "<div id=\"comment:4\" align=\"right\">comment:4</div>\n\nLGTM; let's wait for the patchbot. (If the patchbot does not complain, then anyone who sees this, feel free to give it a positive review.)",
    "created_at": "2018-05-06T12:08:52Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20687#issuecomment-299188",
    "user": "https://github.com/dkrenn"
}
comment:4

LGTM; let's wait for the patchbot. (If the patchbot does not complain, then anyone who sees this, feel free to give it a positive review.)


archive/issue_comments_299189.json:

{
    "body": "Reviewer: **Daniel Krenn**",
    "created_at": "2018-05-06T12:09:08Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20687#issuecomment-299189",
    "user": "https://github.com/dkrenn"
}

Reviewer: Daniel Krenn


archive/issue_events_288690.json:

{
    "actor": "https://github.com/seblabbe",
    "created_at": "2018-05-15T12:47:28Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20687#event-288690"
}

archive/issue_events_288691.json:

{
    "actor": "https://github.com/seblabbe",
    "created_at": "2018-05-15T12:47:28Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20687#event-288691"
}

archive/issue_comments_299190.json:

{
    "body": "Changed branch from **[u/slabbe/20687](https://github.com/sagemath/sagetrac-mirror/tree/u/slabbe/20687)** to **[`c84aeac`](https://github.com/sagemath/sagetrac-mirror/commit/c84aeac6cc24b29d4e1d89912d53e7de4fe04c64)**",
    "created_at": "2018-05-18T17:04:24Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20687#issuecomment-299190",
    "user": "https://github.com/vbraun"
}

Changed branch from u/slabbe/20687 to c84aeac


archive/issue_events_288692.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2018-05-18T17:04:24Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20687#event-288692"
}

archive/issue_events_288693.json:

{
    "actor": "https://github.com/vbraun",
    "commit_id": "f23c4263df6ae2e16ce436332693a5528eab85d8",
    "commit_repository": "https://github.com/sagemath/sage",
    "created_at": "2018-05-18T17:04:24Z",
    "event": "closed",
    "issue": "https://github.com/sagemath/sage/issues/20687",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20687#event-288693"
}