archive/issues_020467.json:
{
"assignees": [],
"body": "<div id=\"comment:0\"></div>\n\nThere remains some python2-only print, because they were not tested anywhere.\n\nLet us remove them in small bunches.\n\nComponent: **python3**\n\nKeywords: **days74**\n\nAuthor: **Fr\u00e9d\u00e9ric Chapoton**\n\nBranch/Commit: **[`6dc2024`](https://github.com/sagemath/sagetrac-mirror/commit/6dc2024e02a52c80aaa07f295f23bdcef660c1a2)**\n\nReviewer: **Travis Scrimshaw**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20704_\n\n",
"closed_at": "2016-06-09T16:14:18Z",
"created_at": "2016-05-29T12:15:47Z",
"labels": [
"https://github.com/sagemath/sage/labels/c%3A%20python3",
"https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"https://github.com/sagemath/sage/labels/enhancement"
],
"milestone": "https://github.com/sagemath/sage/milestones/sage-7.3",
"reactions": [],
"repository": "https://github.com/sagemath/sage",
"title": "py3 print : not tested cases, step 2",
"type": "issue",
"updated_at": "2016-06-09T16:14:18Z",
"url": "https://github.com/sagemath/sage/issues/20704",
"user": "https://github.com/fchapoton"
}There remains some python2-only print, because they were not tested anywhere.
Let us remove them in small bunches.
Component: python3
Keywords: days74
Author: Frédéric Chapoton
Branch/Commit: 6dc2024
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/20704
archive/issue_events_288953.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-05-29T12:15:47Z",
"event": "milestoned",
"issue": "https://github.com/sagemath/sage/issues/20704",
"milestone_number": null,
"milestone_title": "sage-7.3",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20704#event-288953"
}archive/issue_events_288954.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-05-29T12:15:47Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20704",
"label": "https://github.com/sagemath/sage/labels/c%3A%20python3",
"label_color": "0000b0",
"label_name": "c: python3",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20704#event-288954"
}archive/issue_events_288955.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-05-29T12:15:47Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20704",
"label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"label_color": "ffbb00",
"label_name": "p: major / 3",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20704#event-288955"
}archive/issue_events_288956.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-05-29T12:15:47Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20704",
"label": "https://github.com/sagemath/sage/labels/enhancement",
"label_color": "696969",
"label_name": "enhancement",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20704#event-288956"
}archive/issue_comments_299613.json:
{
"body": "Branch: **[public/20704](https://github.com/sagemath/sagetrac-mirror/tree/public/20704)**",
"created_at": "2016-05-29T12:16:53Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20704#issuecomment-299613",
"user": "https://github.com/fchapoton"
}Branch: public/20704
archive/issue_comments_299614.json:
{
"body": "<div id=\"comment:1\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/084b43afcb67e119ce0275c2d69436bf86326480\"><code>084b43a</code></a></td><td><code>python 3 print, taking care of some of the not-tested instances</code></td></tr></table>\n",
"created_at": "2016-05-29T12:16:53Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20704#issuecomment-299614",
"user": "https://github.com/fchapoton"
}New commits:
084b43a | python 3 print, taking care of some of the not-tested instances |
archive/issue_events_288957.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-05-29T12:16:53Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20704",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20704#event-288957"
}archive/issue_comments_299615.json:
{
"body": "Commit: **[`084b43a`](https://github.com/sagemath/sagetrac-mirror/commit/084b43afcb67e119ce0275c2d69436bf86326480)**",
"created_at": "2016-05-29T12:16:53Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20704#issuecomment-299615",
"user": "https://github.com/fchapoton"
}Commit: 084b43a
archive/issue_comments_299616.json:
{
"body": "Changed commit from **[`084b43a`](https://github.com/sagemath/sagetrac-mirror/commit/084b43afcb67e119ce0275c2d69436bf86326480)** to **[`719fadf`](https://github.com/sagemath/sagetrac-mirror/commit/719fadf543c94a63fa6b18847b6b8ab8b8e3a6bd)**",
"created_at": "2016-05-29T13:41:00Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20704#issuecomment-299616",
"user": "https://github.com/sagetrac-git"
}Changed commit from 084b43a to 719fadf
archive/issue_comments_299617.json:
{
"body": "<div id=\"comment:2\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/719fadf543c94a63fa6b18847b6b8ab8b8e3a6bd\"><code>719fadf</code></a></td><td><code>trac 20704 fixing some details in pxi files</code></td></tr></table>\n",
"created_at": "2016-05-29T13:41:00Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20704#issuecomment-299617",
"user": "https://github.com/sagetrac-git"
}Branch pushed to git repo; I updated commit sha1. New commits:
719fadf | trac 20704 fixing some details in pxi files |
archive/issue_comments_299618.json:
{
"body": "<div id=\"comment:3\" align=\"right\">comment:3</div>\n\nThis change will produce slightly different output:\n\n```diff\n- print \"term counting of second summand was wrong!\",P2.nterms\n+ print(\"term counting of second summand was wrong!\", P2.nterms)\n```\nIMO, the easiest way to fix this would be\n\n```\nprint(\"term counting of second summand was wrong!\" + str(P2.nterms))\n```",
"created_at": "2016-05-29T13:59:35Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20704#issuecomment-299618",
"user": "https://github.com/tscrim"
}comment:3
This change will produce slightly different output:
- print "term counting of second summand was wrong!",P2.nterms
+ print("term counting of second summand was wrong!", P2.nterms)IMO, the easiest way to fix this would be
print("term counting of second summand was wrong!" + str(P2.nterms))
archive/issue_comments_299619.json:
{
"body": "<div id=\"comment:4\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/9186fded470e0f3080840e4db657b6f556bc1db6\"><code>9186fde</code></a></td><td><code>trac 20704, detail</code></td></tr></table>\n",
"created_at": "2016-05-29T16:03:55Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20704#issuecomment-299619",
"user": "https://github.com/sagetrac-git"
}Branch pushed to git repo; I updated commit sha1. New commits:
9186fde | trac 20704, detail |
archive/issue_comments_299620.json:
{
"body": "Changed commit from **[`719fadf`](https://github.com/sagemath/sagetrac-mirror/commit/719fadf543c94a63fa6b18847b6b8ab8b8e3a6bd)** to **[`9186fde`](https://github.com/sagemath/sagetrac-mirror/commit/9186fded470e0f3080840e4db657b6f556bc1db6)**",
"created_at": "2016-05-29T16:03:55Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20704#issuecomment-299620",
"user": "https://github.com/sagetrac-git"
}Changed commit from 719fadf to 9186fde
archive/issue_comments_299621.json:
{
"body": "Changed commit from **[`9186fde`](https://github.com/sagemath/sagetrac-mirror/commit/9186fded470e0f3080840e4db657b6f556bc1db6)** to **[`ae8f984`](https://github.com/sagemath/sagetrac-mirror/commit/ae8f984a905a7bc8b646f695d81bf4eac88b5b54)**",
"created_at": "2016-05-30T06:56:28Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20704#issuecomment-299621",
"user": "https://github.com/sagetrac-git"
}Changed commit from 9186fde to ae8f984
archive/issue_comments_299622.json:
{
"body": "<div id=\"comment:5\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/ae8f984a905a7bc8b646f695d81bf4eac88b5b54\"><code>ae8f984</code></a></td><td><code>trac 20704 another detail</code></td></tr></table>\n",
"created_at": "2016-05-30T06:56:28Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20704#issuecomment-299622",
"user": "https://github.com/sagetrac-git"
}Branch pushed to git repo; I updated commit sha1. New commits:
ae8f984 | trac 20704 another detail |
archive/issue_events_288958.json:
{
"actor": "https://github.com/tscrim",
"created_at": "2016-06-01T13:18:58Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20704",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20704#event-288958"
}archive/issue_events_288959.json:
{
"actor": "https://github.com/tscrim",
"created_at": "2016-06-01T13:18:58Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20704",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20704#event-288959"
}archive/issue_comments_299623.json:
{
"body": "Reviewer: **Travis Scrimshaw**",
"created_at": "2016-06-01T13:18:58Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20704#issuecomment-299623",
"user": "https://github.com/tscrim"
}Reviewer: Travis Scrimshaw
archive/issue_comments_299624.json:
{
"body": "Changed keywords from none to **days74**",
"created_at": "2016-06-01T13:19:26Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20704#issuecomment-299624",
"user": "https://github.com/tscrim"
}Changed keywords from none to days74
archive/issue_events_288960.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-06-01T20:51:49Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20704",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20704#event-288960"
}archive/issue_events_288961.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-06-01T20:51:49Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20704",
"label": "https://github.com/sagemath/sage/labels/needs%20work",
"label_color": "ffff00",
"label_name": "needs work",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20704#event-288961"
}archive/issue_comments_299625.json:
{
"body": "<div id=\"comment:8\" align=\"right\">comment:8</div>\n\nmerge conflict",
"created_at": "2016-06-01T20:51:49Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20704#issuecomment-299625",
"user": "https://github.com/vbraun"
}comment:8
merge conflict
archive/issue_comments_299626.json:
{
"body": "Changed commit from **[`ae8f984`](https://github.com/sagemath/sagetrac-mirror/commit/ae8f984a905a7bc8b646f695d81bf4eac88b5b54)** to **[`6dc2024`](https://github.com/sagemath/sagetrac-mirror/commit/6dc2024e02a52c80aaa07f295f23bdcef660c1a2)**",
"created_at": "2016-06-08T07:04:55Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20704#issuecomment-299626",
"user": "https://github.com/sagetrac-git"
}Changed commit from ae8f984 to 6dc2024
archive/issue_comments_299627.json:
{
"body": "<div id=\"comment:9\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/6dc2024e02a52c80aaa07f295f23bdcef660c1a2\"><code>6dc2024</code></a></td><td><code>Merge branch 'public/20704' into 7.3.b3</code></td></tr></table>\n",
"created_at": "2016-06-08T07:04:55Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20704#issuecomment-299627",
"user": "https://github.com/sagetrac-git"
}Branch pushed to git repo; I updated commit sha1. New commits:
6dc2024 | Merge branch 'public/20704' into 7.3.b3 |
archive/issue_comments_299628.json:
{
"body": "<div id=\"comment:10\" align=\"right\">comment:10</div>\n\nafter a trivial merge, I allow myself to put this back to positive review.",
"created_at": "2016-06-08T07:06:12Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20704#issuecomment-299628",
"user": "https://github.com/fchapoton"
}comment:10
after a trivial merge, I allow myself to put this back to positive review.
archive/issue_events_288962.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-06-08T07:06:12Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20704",
"label": "https://github.com/sagemath/sage/labels/needs%20work",
"label_color": "ffff00",
"label_name": "needs work",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20704#event-288962"
}archive/issue_events_288963.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-06-08T07:06:12Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20704",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20704#event-288963"
}archive/issue_comments_299629.json:
{
"body": "Changed branch from **[public/20704](https://github.com/sagemath/sagetrac-mirror/tree/public/20704)** to **[`6dc2024`](https://github.com/sagemath/sagetrac-mirror/commit/6dc2024e02a52c80aaa07f295f23bdcef660c1a2)**",
"created_at": "2016-06-09T16:14:18Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20704#issuecomment-299629",
"user": "https://github.com/vbraun"
}Changed branch from public/20704 to 6dc2024
archive/issue_events_288964.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-06-09T16:14:18Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20704",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20704#event-288964"
}archive/issue_events_288965.json:
{
"actor": "https://github.com/vbraun",
"commit_id": "ba3bc576cf0c607b4c8bc312f2da07ca7a144512",
"commit_repository": "https://github.com/sagemath/sage",
"created_at": "2016-06-09T16:14:18Z",
"event": "closed",
"issue": "https://github.com/sagemath/sage/issues/20704",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20704#event-288965"
}