Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Latest commit

 

History

History
358 lines (273 loc) · 10.7 KB

20713.md

File metadata and controls

358 lines (273 loc) · 10.7 KB

Issue 20713: use six to import builtins (step 2/2)

archive/issues_020476.json:

{
    "assignees": [],
    "body": "<div id=\"comment:0\"></div>\n\nanother bunch of py3 compatible imports of builtins\n\nCC:  @tscrim @jdemeyer @jm58660 @embray\n\nComponent: **python3**\n\nAuthor: **Fr\u00e9d\u00e9ric Chapoton**\n\nBranch/Commit: **[`a63248e`](https://github.com/sagemath/sagetrac-mirror/commit/a63248edcc6653b828c858fa723f24847f16c720)**\n\nReviewer: **Travis Scrimshaw**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20713_\n\n",
    "closed_at": "2016-06-08T12:29:54Z",
    "created_at": "2016-05-30T14:10:31Z",
    "labels": [
        "https://github.com/sagemath/sage/labels/c%3A%20python3",
        "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
        "https://github.com/sagemath/sage/labels/enhancement"
    ],
    "milestone": "https://github.com/sagemath/sage/milestones/sage-7.3",
    "reactions": [],
    "repository": "https://github.com/sagemath/sage",
    "title": "use six to import builtins (step 2/2)",
    "type": "issue",
    "updated_at": "2016-06-08T12:29:54Z",
    "url": "https://github.com/sagemath/sage/issues/20713",
    "user": "https://github.com/fchapoton"
}

another bunch of py3 compatible imports of builtins

CC: @tscrim @jdemeyer @jm58660 @embray

Component: python3

Author: Frédéric Chapoton

Branch/Commit: a63248e

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20713


archive/issue_events_289069.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-05-30T14:10:31Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20713",
    "milestone_number": null,
    "milestone_title": "sage-7.3",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20713#event-289069"
}

archive/issue_events_289070.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-05-30T14:10:31Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20713",
    "label": "https://github.com/sagemath/sage/labels/c%3A%20python3",
    "label_color": "0000b0",
    "label_name": "c: python3",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20713#event-289070"
}

archive/issue_events_289071.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-05-30T14:10:31Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20713",
    "label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
    "label_color": "ffbb00",
    "label_name": "p: major / 3",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20713#event-289071"
}

archive/issue_events_289072.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-05-30T14:10:31Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20713",
    "label": "https://github.com/sagemath/sage/labels/enhancement",
    "label_color": "696969",
    "label_name": "enhancement",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20713#event-289072"
}

archive/issue_comments_299854.json:

{
    "body": "Commit: **[`a63248e`](https://github.com/sagemath/sagetrac-mirror/commit/a63248edcc6653b828c858fa723f24847f16c720)**",
    "created_at": "2016-05-30T14:11:17Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20713",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20713#issuecomment-299854",
    "user": "https://github.com/fchapoton"
}

Commit: a63248e


archive/issue_comments_299855.json:

{
    "body": "<div id=\"comment:1\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/0cbd8e2f5d9496a7cc8f2852710bf172ce2223ad\"><code>0cbd8e2</code></a></td><td><code>use from six.moves.builtins import</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/a63248edcc6653b828c858fa723f24847f16c720\"><code>a63248e</code></a></td><td><code>use from six.moves.builtins, details of imports</code></td></tr></table>\n",
    "created_at": "2016-05-30T14:11:17Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20713",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20713#issuecomment-299855",
    "user": "https://github.com/fchapoton"
}

New commits:

0cbd8e2use from six.moves.builtins import
a63248euse from six.moves.builtins, details of imports

archive/issue_comments_299856.json:

{
    "body": "Branch: **[public/20713](https://github.com/sagemath/sagetrac-mirror/tree/public/20713)**",
    "created_at": "2016-05-30T14:11:17Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20713",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20713#issuecomment-299856",
    "user": "https://github.com/fchapoton"
}

Branch: public/20713


archive/issue_events_289073.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-05-30T14:11:17Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20713",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20713#event-289073"
}

archive/issue_comments_299857.json:

{
    "body": "<div id=\"comment:2\" align=\"right\">comment:2</div>\n\nping ?",
    "created_at": "2016-06-05T06:11:54Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20713",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20713#issuecomment-299857",
    "user": "https://github.com/fchapoton"
}
comment:2

ping ?


archive/issue_events_289074.json:

{
    "actor": "https://github.com/tscrim",
    "created_at": "2016-06-05T13:23:14Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20713",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20713#event-289074"
}

archive/issue_events_289075.json:

{
    "actor": "https://github.com/tscrim",
    "created_at": "2016-06-05T13:23:14Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20713",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20713#event-289075"
}

archive/issue_comments_299858.json:

{
    "body": "<div id=\"comment:3\" align=\"right\">comment:3</div>\n\nI wonder how much these imports of `__builtin__` are really needed (i.e., we can't get rid of by just renaming some variables). Anyways, this works for now.",
    "created_at": "2016-06-05T13:23:14Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20713",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20713#issuecomment-299858",
    "user": "https://github.com/tscrim"
}
comment:3

I wonder how much these imports of __builtin__ are really needed (i.e., we can't get rid of by just renaming some variables). Anyways, this works for now.


archive/issue_comments_299859.json:

{
    "body": "Reviewer: **Travis Scrimshaw**",
    "created_at": "2016-06-05T13:23:14Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20713",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20713#issuecomment-299859",
    "user": "https://github.com/tscrim"
}

Reviewer: Travis Scrimshaw


archive/issue_comments_299860.json:

{
    "body": "Changed branch from **[public/20713](https://github.com/sagemath/sagetrac-mirror/tree/public/20713)** to **[`a63248e`](https://github.com/sagemath/sagetrac-mirror/commit/a63248edcc6653b828c858fa723f24847f16c720)**",
    "created_at": "2016-06-08T12:29:54Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20713",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20713#issuecomment-299860",
    "user": "https://github.com/vbraun"
}

Changed branch from public/20713 to a63248e


archive/issue_events_289076.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-06-08T12:29:54Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20713",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20713#event-289076"
}

archive/issue_events_289077.json:

{
    "actor": "https://github.com/vbraun",
    "commit_id": "603d6ee79c97078d3b76ca2ea7dbaf1afcec9784",
    "commit_repository": "https://github.com/sagemath/sage",
    "created_at": "2016-06-08T12:29:54Z",
    "event": "closed",
    "issue": "https://github.com/sagemath/sage/issues/20713",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20713#event-289077"
}