Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Latest commit

 

History

History
457 lines (345 loc) · 13.2 KB

20818.md

File metadata and controls

457 lines (345 loc) · 13.2 KB

Issue 20818: acsch(float) returns complex

archive/issues_020581.json:

{
    "assignees": [],
    "body": "<div id=\"comment:0\"></div>\n\n\n```\nsage: arccsch(float(0.1))\n(2.99822295029797+0j)\n\nshould be\n\n2.99822295029797\n```\n\n8-year old bug, triggered by recent Pynac changes\n\nComponent: **symbolics**\n\nAuthor: **Ralf Stephan**\n\nBranch: **[`4df530d`](https://github.com/sagemath/sagetrac-mirror/commit/4df530d269afa3cc20ce27bb12cd896c0e85f02a)**\n\nReviewer: **Fr\u00e9d\u00e9ric Chapoton**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20818_\n\n",
    "closed_at": "2016-06-12T23:11:17Z",
    "created_at": "2016-06-12T12:56:40Z",
    "labels": [
        "https://github.com/sagemath/sage/labels/c%3A%20symbolics",
        "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
        "https://github.com/sagemath/sage/labels/bug"
    ],
    "milestone": "https://github.com/sagemath/sage/milestones/sage-7.3",
    "reactions": [],
    "repository": "https://github.com/sagemath/sage",
    "title": "acsch(float) returns complex",
    "type": "issue",
    "updated_at": "2016-06-13T05:59:43Z",
    "url": "https://github.com/sagemath/sage/issues/20818",
    "user": "https://github.com/rwst"
}
sage: arccsch(float(0.1))
(2.99822295029797+0j)

should be

2.99822295029797

8-year old bug, triggered by recent Pynac changes

Component: symbolics

Author: Ralf Stephan

Branch: 4df530d

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/20818


archive/issue_events_290458.json:

{
    "actor": "https://github.com/rwst",
    "created_at": "2016-06-12T12:56:40Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "milestone_number": null,
    "milestone_title": "sage-7.3",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20818#event-290458"
}

archive/issue_events_290459.json:

{
    "actor": "https://github.com/rwst",
    "created_at": "2016-06-12T12:56:40Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "label": "https://github.com/sagemath/sage/labels/c%3A%20symbolics",
    "label_color": "0000ff",
    "label_name": "c: symbolics",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20818#event-290459"
}

archive/issue_events_290460.json:

{
    "actor": "https://github.com/rwst",
    "created_at": "2016-06-12T12:56:40Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
    "label_color": "ffbb00",
    "label_name": "p: major / 3",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20818#event-290460"
}

archive/issue_events_290461.json:

{
    "actor": "https://github.com/rwst",
    "created_at": "2016-06-12T12:56:40Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "label": "https://github.com/sagemath/sage/labels/bug",
    "label_color": "d73a4a",
    "label_name": "bug",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20818#event-290461"
}

archive/issue_comments_301947.json:

{
    "body": "Branch: **[u/rws/acsch_float__returns_complex](https://github.com/sagemath/sagetrac-mirror/tree/u/rws/acsch_float__returns_complex)**",
    "created_at": "2016-06-12T13:03:44Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20818#issuecomment-301947",
    "user": "https://github.com/rwst"
}

Branch: u/rws/acsch_float__returns_complex


archive/issue_comments_301948.json:

{
    "body": "Description changed:\n``````diff\n--- \n+++ \n@@ -8,3 +8,4 @@\n 2.99822295029797\n ```\n \n+8-year old bug, triggered by recent Pynac changes\n``````\n",
    "created_at": "2016-06-12T13:05:59Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20818#issuecomment-301948",
    "user": "https://github.com/rwst"
}

Description changed:

--- 
+++ 
@@ -8,3 +8,4 @@
 2.99822295029797
 ```
 
+8-year old bug, triggered by recent Pynac changes

archive/issue_comments_301949.json:

{
    "body": "<div id=\"comment:2\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/4df530d269afa3cc20ce27bb12cd896c0e85f02a\"><code>4df530d</code></a></td><td><code>20818: back conversion in py_asinh incomplete</code></td></tr></table>\n",
    "created_at": "2016-06-12T13:05:59Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20818#issuecomment-301949",
    "user": "https://github.com/rwst"
}

New commits:

4df530d20818: back conversion in py_asinh incomplete

archive/issue_comments_301950.json:

{
    "body": "Commit: **[`4df530d`](https://github.com/sagemath/sagetrac-mirror/commit/4df530d269afa3cc20ce27bb12cd896c0e85f02a)**",
    "created_at": "2016-06-12T13:05:59Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20818#issuecomment-301950",
    "user": "https://github.com/rwst"
}

Commit: 4df530d


archive/issue_comments_301951.json:

{
    "body": "Author: **Ralf Stephan**",
    "created_at": "2016-06-12T13:05:59Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20818#issuecomment-301951",
    "user": "https://github.com/rwst"
}

Author: Ralf Stephan


archive/issue_events_290462.json:

{
    "actor": "https://github.com/rwst",
    "created_at": "2016-06-12T13:05:59Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20818#event-290462"
}

archive/issue_comments_301952.json:

{
    "body": "Reviewer: **Fr\u00e9d\u00e9ric Chapoton**",
    "created_at": "2016-06-12T14:19:56Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20818#issuecomment-301952",
    "user": "https://github.com/fchapoton"
}

Reviewer: Frédéric Chapoton


archive/issue_comments_301953.json:

{
    "body": "<div id=\"comment:3\" align=\"right\">comment:3</div>\n\nok, looks good to me",
    "created_at": "2016-06-12T14:19:56Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20818#issuecomment-301953",
    "user": "https://github.com/fchapoton"
}
comment:3

ok, looks good to me


archive/issue_events_290463.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-06-12T14:19:56Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20818#event-290463"
}

archive/issue_events_290464.json:

{
    "actor": "https://github.com/fchapoton",
    "created_at": "2016-06-12T14:19:56Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20818#event-290464"
}

archive/issue_comments_301954.json:

{
    "body": "<div id=\"comment:4\" align=\"right\">comment:4</div>\n\nRalf, I'm curious as to how you recognized the bug. Is there a previous Trac ticket?",
    "created_at": "2016-06-12T19:58:09Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20818#issuecomment-301954",
    "user": "https://github.com/paulmasson"
}
comment:4

Ralf, I'm curious as to how you recognized the bug. Is there a previous Trac ticket?


archive/issue_comments_301955.json:

{
    "body": "Changed branch from **[u/rws/acsch_float__returns_complex](https://github.com/sagemath/sagetrac-mirror/tree/u/rws/acsch_float__returns_complex)** to **[`4df530d`](https://github.com/sagemath/sagetrac-mirror/commit/4df530d269afa3cc20ce27bb12cd896c0e85f02a)**",
    "created_at": "2016-06-12T23:11:17Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20818#issuecomment-301955",
    "user": "https://github.com/vbraun"
}

Changed branch from u/rws/acsch_float__returns_complex to 4df530d


archive/issue_events_290465.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-06-12T23:11:17Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20818#event-290465"
}

archive/issue_events_290466.json:

{
    "actor": "https://github.com/vbraun",
    "commit_id": "83d6e43c6d48de91d264a433db0d8e132195a5fc",
    "commit_repository": "https://github.com/sagemath/sage",
    "created_at": "2016-06-12T23:11:17Z",
    "event": "closed",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20818#event-290466"
}

archive/issue_comments_301956.json:

{
    "body": "<div id=\"comment:6\" align=\"right\">comment:6</div>\n\nReplying to [@paulmasson](#comment%3A4):\n> Ralf, I'm curious as to how you recognized the bug. Is there a previous Trac ticket?\n\nAfter Volker gave me a function argument that showed the problem I traced what Pynac was doing. It called the fixed function and then it was obvious. How I know that this is 8 year old? You can use git blame to see when a specific line was changed.",
    "created_at": "2016-06-13T05:59:43Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20818#issuecomment-301956",
    "user": "https://github.com/rwst"
}
comment:6

Replying to @paulmasson:

Ralf, I'm curious as to how you recognized the bug. Is there a previous Trac ticket?

After Volker gave me a function argument that showed the problem I traced what Pynac was doing. It called the fixed function and then it was obvious. How I know that this is 8 year old? You can use git blame to see when a specific line was changed.


archive/issue_comments_301957.json:

{
    "body": "Changed commit from **[`4df530d`](https://github.com/sagemath/sagetrac-mirror/commit/4df530d269afa3cc20ce27bb12cd896c0e85f02a)** to none",
    "created_at": "2016-06-13T05:59:43Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20818",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20818#issuecomment-301957",
    "user": "https://github.com/rwst"
}

Changed commit from 4df530d to none