Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Latest commit

 

History

History
389 lines (299 loc) · 11.8 KB

20825.md

File metadata and controls

389 lines (299 loc) · 11.8 KB

Issue 20825: EvaluationMethods should be a new-style class

archive/issues_020588.json:

{
    "assignees": [],
    "body": "<div id=\"comment:0\"></div>\n\nSome of the changes I'm making to #20686 will break `EvaluationMethods` otherwise. And with Python 3, every class is new-style anyway.\n\nComponent: **symbolics**\n\nAuthor: **Jeroen Demeyer**\n\nBranch/Commit: **[`44e80b3`](https://github.com/sagemath/sagetrac-mirror/commit/44e80b30d32d5b6d35c00edecf81d4313dc1c11f)**\n\nReviewer: **Travis Scrimshaw**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20825_\n\n",
    "closed_at": "2016-06-15T18:47:29Z",
    "created_at": "2016-06-14T13:21:47Z",
    "labels": [
        "https://github.com/sagemath/sage/labels/c%3A%20symbolics",
        "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
        "https://github.com/sagemath/sage/labels/enhancement"
    ],
    "milestone": "https://github.com/sagemath/sage/milestones/sage-7.3",
    "reactions": [],
    "repository": "https://github.com/sagemath/sage",
    "title": "EvaluationMethods should be a new-style class",
    "type": "issue",
    "updated_at": "2016-06-15T18:47:29Z",
    "url": "https://github.com/sagemath/sage/issues/20825",
    "user": "https://github.com/jdemeyer"
}

Some of the changes I'm making to #20686 will break EvaluationMethods otherwise. And with Python 3, every class is new-style anyway.

Component: symbolics

Author: Jeroen Demeyer

Branch/Commit: 44e80b3

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20825


archive/issue_events_290543.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-06-14T13:21:47Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20825",
    "milestone_number": null,
    "milestone_title": "sage-7.3",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20825#event-290543"
}

archive/issue_events_290544.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-06-14T13:21:47Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20825",
    "label": "https://github.com/sagemath/sage/labels/c%3A%20symbolics",
    "label_color": "0000ff",
    "label_name": "c: symbolics",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20825#event-290544"
}

archive/issue_events_290545.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-06-14T13:21:47Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20825",
    "label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
    "label_color": "ffbb00",
    "label_name": "p: major / 3",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20825#event-290545"
}

archive/issue_events_290546.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-06-14T13:21:47Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20825",
    "label": "https://github.com/sagemath/sage/labels/enhancement",
    "label_color": "696969",
    "label_name": "enhancement",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20825#event-290546"
}

archive/issue_comments_302034.json:

{
    "body": "Branch: **[u/jdemeyer/ticket/20825](https://github.com/sagemath/sagetrac-mirror/tree/u/jdemeyer/ticket/20825)**",
    "created_at": "2016-06-14T14:46:32Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20825",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20825#issuecomment-302034",
    "user": "https://github.com/jdemeyer"
}

Branch: u/jdemeyer/ticket/20825


archive/issue_comments_302035.json:

{
    "body": "<div id=\"comment:2\"></div>\n\nBranch pushed to git repo; I updated commit sha1. This was a forced push. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/44e80b30d32d5b6d35c00edecf81d4313dc1c11f\"><code>44e80b3</code></a></td><td><code>EvaluationMethods should be a new-style class</code></td></tr></table>\n",
    "created_at": "2016-06-14T15:06:49Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20825",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20825#issuecomment-302035",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

44e80b3EvaluationMethods should be a new-style class

archive/issue_comments_302036.json:

{
    "body": "Commit: **[`44e80b3`](https://github.com/sagemath/sagetrac-mirror/commit/44e80b30d32d5b6d35c00edecf81d4313dc1c11f)**",
    "created_at": "2016-06-14T15:06:49Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20825",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20825#issuecomment-302036",
    "user": "https://github.com/sagetrac-git"
}

Commit: 44e80b3


archive/issue_events_290547.json:

{
    "actor": "https://github.com/jdemeyer",
    "created_at": "2016-06-14T15:07:22Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20825",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20825#event-290547"
}

archive/issue_comments_302037.json:

{
    "body": "Description changed:\n``````diff\n--- \n+++ \n@@ -1 +1 @@\n-Some of the changes I'm making to #20686 will break `EvaluationMethods` otherwise.\n+Some of the changes I'm making to #20686 will break `EvaluationMethods` otherwise. And with Python 3, everything needs to be a new-style anyway.\n``````\n",
    "created_at": "2016-06-14T15:07:22Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20825",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20825#issuecomment-302037",
    "user": "https://github.com/jdemeyer"
}

Description changed:

--- 
+++ 
@@ -1 +1 @@
-Some of the changes I'm making to #20686 will break `EvaluationMethods` otherwise.
+Some of the changes I'm making to #20686 will break `EvaluationMethods` otherwise. And with Python 3, everything needs to be a new-style anyway.

archive/issue_comments_302038.json:

{
    "body": "<div id=\"comment:4\" align=\"right\">comment:4</div>\n\nLGTM.",
    "created_at": "2016-06-15T00:53:08Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20825",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20825#issuecomment-302038",
    "user": "https://github.com/tscrim"
}
comment:4

LGTM.


archive/issue_comments_302039.json:

{
    "body": "Reviewer: **Travis Scrimshaw**",
    "created_at": "2016-06-15T00:53:08Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20825",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20825#issuecomment-302039",
    "user": "https://github.com/tscrim"
}

Reviewer: Travis Scrimshaw


archive/issue_events_290548.json:

{
    "actor": "https://github.com/tscrim",
    "created_at": "2016-06-15T00:53:08Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20825",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20825#event-290548"
}

archive/issue_events_290549.json:

{
    "actor": "https://github.com/tscrim",
    "created_at": "2016-06-15T00:53:08Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20825",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20825#event-290549"
}

archive/issue_comments_302040.json:

{
    "body": "Description changed:\n``````diff\n--- \n+++ \n@@ -1 +1 @@\n-Some of the changes I'm making to #20686 will break `EvaluationMethods` otherwise. And with Python 3, everything needs to be a new-style anyway.\n+Some of the changes I'm making to #20686 will break `EvaluationMethods` otherwise. And with Python 3, every class is new-style anyway.\n``````\n",
    "created_at": "2016-06-15T07:27:26Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20825",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20825#issuecomment-302040",
    "user": "https://github.com/jdemeyer"
}

Description changed:

--- 
+++ 
@@ -1 +1 @@
-Some of the changes I'm making to #20686 will break `EvaluationMethods` otherwise. And with Python 3, everything needs to be a new-style anyway.
+Some of the changes I'm making to #20686 will break `EvaluationMethods` otherwise. And with Python 3, every class is new-style anyway.

archive/issue_events_290550.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-06-15T18:47:29Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20825",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20825#event-290550"
}

archive/issue_events_290551.json:

{
    "actor": "https://github.com/vbraun",
    "commit_id": "1508c59685cf25879903a96967deb6053720cadd",
    "commit_repository": "https://github.com/sagemath/sage",
    "created_at": "2016-06-15T18:47:29Z",
    "event": "closed",
    "issue": "https://github.com/sagemath/sage/issues/20825",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20825#event-290551"
}

archive/issue_comments_302041.json:

{
    "body": "Changed branch from **[u/jdemeyer/ticket/20825](https://github.com/sagemath/sagetrac-mirror/tree/u/jdemeyer/ticket/20825)** to **[`44e80b3`](https://github.com/sagemath/sagetrac-mirror/commit/44e80b30d32d5b6d35c00edecf81d4313dc1c11f)**",
    "created_at": "2016-06-15T18:47:29Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20825",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20825#issuecomment-302041",
    "user": "https://github.com/vbraun"
}

Changed branch from u/jdemeyer/ticket/20825 to 44e80b3