Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Latest commit

 

History

History
1018 lines (779 loc) · 47.8 KB

20921.md

File metadata and controls

1018 lines (779 loc) · 47.8 KB

Issue 20921: LatticePoset: add function to get lattice of sublattices

archive/issues_020684.json:

{
    "assignees": [],
    "body": "<div id=\"comment:0\"></div>\n\nAdd a function to get the lattice of sublattices.\n\n(First wait #20669 to get integrated at 7.3beta7.)\n\nCC:  @tscrim\n\nComponent: **combinatorics**\n\nKeywords: **lattice poset**\n\nAuthor: **Jori M\u00e4ntysalo**\n\nBranch/Commit: **[`fe8b4f6`](https://github.com/sagemath/sagetrac-mirror/commit/fe8b4f61aff1d5f43753c43dfde493c2d2e3eac2)**\n\nReviewer: **Travis Scrimshaw**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20921_\n\n",
    "closed_at": "2016-07-27T20:24:45Z",
    "created_at": "2016-07-02T05:42:39Z",
    "labels": [
        "https://github.com/sagemath/sage/labels/c%3A%20combinatorics",
        "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
        "https://github.com/sagemath/sage/labels/enhancement"
    ],
    "milestone": "https://github.com/sagemath/sage/milestones/sage-7.3",
    "reactions": [],
    "repository": "https://github.com/sagemath/sage",
    "title": "LatticePoset: add function to get lattice of sublattices",
    "type": "issue",
    "updated_at": "2016-07-27T20:24:45Z",
    "url": "https://github.com/sagemath/sage/issues/20921",
    "user": "https://github.com/jm58660"
}

Add a function to get the lattice of sublattices.

(First wait #20669 to get integrated at 7.3beta7.)

CC: @tscrim

Component: combinatorics

Keywords: lattice poset

Author: Jori Mäntysalo

Branch/Commit: fe8b4f6

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20921


archive/issue_events_291796.json:

{
    "actor": "https://github.com/jm58660",
    "created_at": "2016-07-02T05:42:39Z",
    "event": "milestoned",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "milestone_number": null,
    "milestone_title": "sage-7.3",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20921#event-291796"
}

archive/issue_events_291797.json:

{
    "actor": "https://github.com/jm58660",
    "created_at": "2016-07-02T05:42:39Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "label": "https://github.com/sagemath/sage/labels/c%3A%20combinatorics",
    "label_color": "0000ff",
    "label_name": "c: combinatorics",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20921#event-291797"
}

archive/issue_events_291798.json:

{
    "actor": "https://github.com/jm58660",
    "created_at": "2016-07-02T05:42:39Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
    "label_color": "ffbb00",
    "label_name": "p: major / 3",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20921#event-291798"
}

archive/issue_events_291799.json:

{
    "actor": "https://github.com/jm58660",
    "created_at": "2016-07-02T05:42:39Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "label": "https://github.com/sagemath/sage/labels/enhancement",
    "label_color": "696969",
    "label_name": "enhancement",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20921#event-291799"
}

archive/issue_comments_303858.json:

{
    "body": "Description changed:\n``````diff\n--- \n+++ \n@@ -1,3 +1,3 @@\n Add a function to get the lattice of sublattices.\n \n-(First wait #20669 to get closed.)\n+(First wait #20669 to get integrated at 7.3beta7.)\n``````\n",
    "created_at": "2016-07-02T12:16:46Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303858",
    "user": "https://github.com/jm58660"
}

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
 Add a function to get the lattice of sublattices.
 
-(First wait #20669 to get closed.)
+(First wait #20669 to get integrated at 7.3beta7.)

archive/issue_comments_303859.json:

{
    "body": "Changed keywords from **latticeposet** to **lattice poset**",
    "created_at": "2016-07-02T14:56:07Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303859",
    "user": "https://github.com/tscrim"
}

Changed keywords from latticeposet to lattice poset


archive/issue_comments_303860.json:

{
    "body": "<div id=\"comment:3\" align=\"right\">comment:3</div>\n\nIsn't \"lattice\" an ambiguous keyword? It refers to two different things, try to click it and see.",
    "created_at": "2016-07-02T20:27:31Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303860",
    "user": "https://github.com/jm58660"
}
comment:3

Isn't "lattice" an ambiguous keyword? It refers to two different things, try to click it and see.


archive/issue_comments_303861.json:

{
    "body": "<div id=\"comment:4\" align=\"right\">comment:4</div>\n\nIn and of itself, yes, \"lattice\" is ambiguous. However, \"latticeposet\" is not a word (in English), but having the \"lattice poset\" together makes it clear. (More of a random note, there are also 2 other distinct non-mathematical uses of the word lattice that comes to mind as well.)\n\nHowever, you're free to build here upon #20669 before it gets released in a beta.",
    "created_at": "2016-07-03T00:16:41Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303861",
    "user": "https://github.com/tscrim"
}
comment:4

In and of itself, yes, "lattice" is ambiguous. However, "latticeposet" is not a word (in English), but having the "lattice poset" together makes it clear. (More of a random note, there are also 2 other distinct non-mathematical uses of the word lattice that comes to mind as well.)

However, you're free to build here upon #20669 before it gets released in a beta.


archive/issue_comments_303862.json:

{
    "body": "<div id=\"comment:5\" align=\"right\">comment:5</div>\n\nReplying to [@tscrim](#comment%3A4):\n> In and of itself, yes, \"lattice\" is ambiguous. However, \"latticeposet\" is not a word (in English), but having the \"lattice poset\" together makes it clear.\n\nBut trac does not seem to accept two words keyphrase. Trying to put \"foo bar, xyzzy\" as keywords does just what \"foo, bar, xyzzy\" would do. lattice_poset maybe?\n\n> However, you're free to build here upon #20669 before it gets released in a beta.\n\nTrue, but Volker releases betas so often that it makes no big delay.",
    "created_at": "2016-07-03T06:10:08Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303862",
    "user": "https://github.com/jm58660"
}
comment:5

Replying to @tscrim:

In and of itself, yes, "lattice" is ambiguous. However, "latticeposet" is not a word (in English), but having the "lattice poset" together makes it clear.

But trac does not seem to accept two words keyphrase. Trying to put "foo bar, xyzzy" as keywords does just what "foo, bar, xyzzy" would do. lattice_poset maybe?

However, you're free to build here upon #20669 before it gets released in a beta.

True, but Volker releases betas so often that it makes no big delay.


archive/issue_comments_303863.json:

{
    "body": "Branch: **[u/jmantysalo/latticeposet__add_function_to_get_lattice_of_sublattices](https://github.com/sagemath/sagetrac-mirror/tree/u/jmantysalo/latticeposet__add_function_to_get_lattice_of_sublattices)**",
    "created_at": "2016-07-03T14:14:00Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303863",
    "user": "https://github.com/jm58660"
}

Branch: u/jmantysalo/latticeposet__add_function_to_get_lattice_of_sublattices


archive/issue_comments_303864.json:

{
    "body": "<div id=\"comment:7\" align=\"right\">comment:7</div>\n\nNot ready, but I save it here and will continue on another computer after next beta.\n\n---\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/85ccdc2ac2b6550d86c5f5aa9db6c59d8bfe6e99\"><code>85ccdc2</code></a></td><td><code>Added function sublattices_lattice.</code></td></tr></table>\n",
    "created_at": "2016-07-03T14:15:52Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303864",
    "user": "https://github.com/jm58660"
}
comment:7

Not ready, but I save it here and will continue on another computer after next beta.


New commits:

85ccdc2Added function sublattices_lattice.

archive/issue_comments_303865.json:

{
    "body": "Commit: **[`85ccdc2`](https://github.com/sagemath/sagetrac-mirror/commit/85ccdc2ac2b6550d86c5f5aa9db6c59d8bfe6e99)**",
    "created_at": "2016-07-03T14:15:52Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303865",
    "user": "https://github.com/jm58660"
}

Commit: 85ccdc2


archive/issue_comments_303866.json:

{
    "body": "<div id=\"comment:8\"></div>\n\nBranch pushed to git repo; I updated commit sha1. This was a forced push. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/29f13a12ea8a1429196951835716a4d9181785ca\"><code>29f13a1</code></a></td><td><code>Add sublattices_lattice().</code></td></tr></table>\n",
    "created_at": "2016-07-08T15:07:17Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303866",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

29f13a1Add sublattices_lattice().

archive/issue_comments_303867.json:

{
    "body": "Changed commit from **[`85ccdc2`](https://github.com/sagemath/sagetrac-mirror/commit/85ccdc2ac2b6550d86c5f5aa9db6c59d8bfe6e99)** to **[`29f13a1`](https://github.com/sagemath/sagetrac-mirror/commit/29f13a12ea8a1429196951835716a4d9181785ca)**",
    "created_at": "2016-07-08T15:07:17Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303867",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 85ccdc2 to 29f13a1


archive/issue_events_291800.json:

{
    "actor": "https://github.com/jm58660",
    "created_at": "2016-07-08T15:09:09Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20921#event-291800"
}

archive/issue_comments_303868.json:

{
    "body": "<div id=\"comment:10\" align=\"right\">comment:10</div>\n\nJust pinging... Examples are hard, as even very small lattice can generate a big lattice of sublattices.",
    "created_at": "2016-07-22T05:40:56Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303868",
    "user": "https://github.com/jm58660"
}
comment:10

Just pinging... Examples are hard, as even very small lattice can generate a big lattice of sublattices.


archive/issue_comments_303869.json:

{
    "body": "<div id=\"comment:11\" align=\"right\">comment:11</div>\n\nI would write the input section as:\n\n```\n        - ``element_constructor`` -- string; can be one of the following:\n\n          * ``'lattice'`` - (the default) elements of the lattice will\n            be lattices that correspond to sublattices of ``self``\n          * ``'tuple'`` - elements are tuples of elements of the\n            sublattices of ``self``\n          * ``'integer'`` - the elements are plain integers\n```\nAlso, it looks like you have an unneeded import of `DiGraph`. Otherwise LGTM.",
    "created_at": "2016-07-22T14:08:26Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303869",
    "user": "https://github.com/tscrim"
}
comment:11

I would write the input section as:

        - ``element_constructor`` -- string; can be one of the following:

          * ``'lattice'`` - (the default) elements of the lattice will
            be lattices that correspond to sublattices of ``self``
          * ``'tuple'`` - elements are tuples of elements of the
            sublattices of ``self``
          * ``'integer'`` - the elements are plain integers

Also, it looks like you have an unneeded import of DiGraph. Otherwise LGTM.


archive/issue_comments_303870.json:

{
    "body": "Reviewer: **Travis Scrimshaw**",
    "created_at": "2016-07-22T14:08:26Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303870",
    "user": "https://github.com/tscrim"
}

Reviewer: Travis Scrimshaw


archive/issue_comments_303871.json:

{
    "body": "<div id=\"comment:12\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/2863437d07cfc99a28c195826d20515961fb3a49\"><code>2863437</code></a></td><td><code>Reviewer comments.</code></td></tr></table>\n",
    "created_at": "2016-07-22T14:25:31Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303871",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

2863437Reviewer comments.

archive/issue_comments_303872.json:

{
    "body": "Changed commit from **[`29f13a1`](https://github.com/sagemath/sagetrac-mirror/commit/29f13a12ea8a1429196951835716a4d9181785ca)** to **[`2863437`](https://github.com/sagemath/sagetrac-mirror/commit/2863437d07cfc99a28c195826d20515961fb3a49)**",
    "created_at": "2016-07-22T14:25:31Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303872",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 29f13a1 to 2863437


archive/issue_comments_303873.json:

{
    "body": "<div id=\"comment:13\" align=\"right\">comment:13</div>\n\nCorrected those. I used format \"original lattice\", as `self` is not very much used in docstring in this file.\n\nShould it be \"elements\" or \"the elements\"?",
    "created_at": "2016-07-22T14:27:33Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303873",
    "user": "https://github.com/jm58660"
}
comment:13

Corrected those. I used format "original lattice", as self is not very much used in docstring in this file.

Should it be "elements" or "the elements"?


archive/issue_comments_303874.json:

{
    "body": "<div id=\"comment:14\" align=\"right\">comment:14</div>\n\nFormally (i.e., if a English professor looked at it), I'm not sure if the \"the\" is necessary here because it is plural and the structure of the sentence is declarative. Feel free to add it as it is not wrong. Also, I missed this above, it should just be `(default)`, i.e., no \"the\" there. Thanks.",
    "created_at": "2016-07-22T14:39:46Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303874",
    "user": "https://github.com/tscrim"
}
comment:14

Formally (i.e., if a English professor looked at it), I'm not sure if the "the" is necessary here because it is plural and the structure of the sentence is declarative. Feel free to add it as it is not wrong. Also, I missed this above, it should just be (default), i.e., no "the" there. Thanks.


archive/issue_comments_303875.json:

{
    "body": "Changed commit from **[`2863437`](https://github.com/sagemath/sagetrac-mirror/commit/2863437d07cfc99a28c195826d20515961fb3a49)** to **[`cf557bb`](https://github.com/sagemath/sagetrac-mirror/commit/cf557bbcdbe1e6d8a306d586a6cd3820c145344c)**",
    "created_at": "2016-07-22T16:51:19Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303875",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from 2863437 to cf557bb


archive/issue_comments_303876.json:

{
    "body": "<div id=\"comment:15\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/85ccdc2ac2b6550d86c5f5aa9db6c59d8bfe6e99\"><code>85ccdc2</code></a></td><td><code>Added function sublattices_lattice.</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/cf7f1e5db5576aa6f4b86006d4d1a22ba270efc9\"><code>cf7f1e5</code></a></td><td><code>Merge branch 'u/jmantysalo/latticeposet__add_function_to_get_lattice_of_sublattices' of git://trac.sagemath.org/sage into t/20921/latticeposet__add_function_to_get_lattice_of_sublattices</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/cf557bbcdbe1e6d8a306d586a6cd3820c145344c\"><code>cf557bb</code></a></td><td><code>Removed a 'the'.</code></td></tr></table>\n",
    "created_at": "2016-07-22T16:51:19Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303876",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

85ccdc2Added function sublattices_lattice.
cf7f1e5Merge branch 'u/jmantysalo/latticeposet__add_function_to_get_lattice_of_sublattices' of git://trac.sagemath.org/sage into t/20921/latticeposet__add_function_to_get_lattice_of_sublattices
cf557bbRemoved a 'the'.

archive/issue_comments_303877.json:

{
    "body": "<div id=\"comment:16\" align=\"right\">comment:16</div>\n\nReplying to [@tscrim](#comment%3A14):\n> Formally (i.e., if a English professor looked at it), I'm not sure if the \"the\" is necessary here because it is plural and the structure of the sentence is declarative. Feel free to add it as it is not wrong.\n\nIf it is not needed, I can left it off. I was just wondering when you wrote \"tuple - elements are\" vs. \"integer - the elements\".\n\nReady now?",
    "created_at": "2016-07-22T16:54:02Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303877",
    "user": "https://github.com/jm58660"
}
comment:16

Replying to @tscrim:

Formally (i.e., if a English professor looked at it), I'm not sure if the "the" is necessary here because it is plural and the structure of the sentence is declarative. Feel free to add it as it is not wrong.

If it is not needed, I can left it off. I was just wondering when you wrote "tuple - elements are" vs. "integer - the elements".

Ready now?


archive/issue_comments_303878.json:

{
    "body": "<div id=\"comment:17\" align=\"right\">comment:17</div>\n\nReplying to [@jm58660](#comment%3A16):\n> Replying to [@tscrim](#comment%3A14):\n> > Formally (i.e., if a English professor looked at it), I'm not sure if the \"the\" is necessary here because it is plural and the structure of the sentence is declarative. Feel free to add it as it is not wrong.\n> \n> \n> If it is not needed, I can left it off. I was just wondering when you wrote \"tuple - elements are\" vs. \"integer - the elements\".\n\nWhoops, my bad.\n\n> Ready now?\n\nYep. Thanks.",
    "created_at": "2016-07-22T16:55:11Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303878",
    "user": "https://github.com/tscrim"
}
comment:17

Replying to @jm58660:

Replying to @tscrim:

Formally (i.e., if a English professor looked at it), I'm not sure if the "the" is necessary here because it is plural and the structure of the sentence is declarative. Feel free to add it as it is not wrong.

If it is not needed, I can left it off. I was just wondering when you wrote "tuple - elements are" vs. "integer - the elements".

Whoops, my bad.

Ready now?

Yep. Thanks.


archive/issue_events_291801.json:

{
    "actor": "https://github.com/tscrim",
    "created_at": "2016-07-22T16:55:11Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20921#event-291801"
}

archive/issue_events_291802.json:

{
    "actor": "https://github.com/tscrim",
    "created_at": "2016-07-22T16:55:11Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20921#event-291802"
}

archive/issue_comments_303879.json:

{
    "body": "<div id=\"comment:18\" align=\"right\">comment:18</div>\n\n\n```\nsage -t --long src/sage/combinat/posets/lattices.py\n**********************************************************************\nFile \"src/sage/combinat/posets/lattices.py\", line 1743, in sage.combinat.posets.lattices.FiniteLatticePoset.sublattices_lattice\nFailed example:\n    sll = L.sublattices_lattice()\nException raised:\n    Traceback (most recent call last):\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py\", line 499, in _run\n        self.compile_and_execute(example, compiler, test.globs)\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py\", line 862, in compile_and_execute\n        exec(compiled, globs)\n      File \"<doctest sage.combinat.posets.lattices.FiniteLatticePoset.sublattices_lattice[4]>\", line 1, in <module>\n        sll = L.sublattices_lattice()\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/lattices.py\", line 1868, in sublattices_lattice\n        G.relabel(lambda x: self.sublattice(x))\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/graphs/generic_graph.py\", line 19817, in relabel\n        perm = dict( [ i, perm(i) ] for i in self.vertices() )\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/graphs/generic_graph.py\", line 19817, in <genexpr>\n        perm = dict( [ i, perm(i) ] for i in self.vertices() )\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/lattices.py\", line 1868, in <lambda>\n        G.relabel(lambda x: self.sublattice(x))\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/lattices.py\", line 1680, in sublattice\n        return LatticePoset(self.subposet(current_set))\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/posets.py\", line 4513, in subposet\n        elements = [self(e) for e in elements]\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/posets.py\", line 1232, in __call__\n        return super(FinitePoset, self).__call__(element)\n      File \"sage/structure/parent.pyx\", line 1107, in sage.structure.parent.Parent.__call__ (/home/buildbot/slave/sage_git/build/src/build/cythonized/sage/structure/parent.c:9904)\n        return mor._call_(x)\n      File \"sage/structure/coerce_maps.pyx\", line 110, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_ (/home/buildbot/slave/sage_git/build/src/build/cythonized/sage/structure/coerce_maps.c:4651)\n        raise\n      File \"sage/structure/coerce_maps.pyx\", line 105, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_ (/home/buildbot/slave/sage_git/build/src/build/cythonized/sage/structure/coerce_maps.c:4539)\n        return C._element_constructor(x)\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/posets.py\", line 1208, in _element_constructor_\n        % type(element))\n    ValueError: <type 'int'> is not an element of this poset\n**********************************************************************\nFile \"src/sage/combinat/posets/lattices.py\", line 1844, in sage.combinat.posets.lattices.FiniteLatticePoset.sublattices_lattice\nFailed example:\n    sll = L.sublattices_lattice()\nException raised:\n    Traceback (most recent call last):\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py\", line 499, in _run\n        self.compile_and_execute(example, compiler, test.globs)\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py\", line 862, in compile_and_execute\n        exec(compiled, globs)\n      File \"<doctest sage.combinat.posets.lattices.FiniteLatticePoset.sublattices_lattice[4]>\", line 1, in <module>\n        sll = L.sublattices_lattice()\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/lattices.py\", line 1868, in sublattices_lattice\n        G.relabel(lambda x: self.sublattice(x))\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/graphs/generic_graph.py\", line 19817, in relabel\n        perm = dict( [ i, perm(i) ] for i in self.vertices() )\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/graphs/generic_graph.py\", line 19817, in <genexpr>\n        perm = dict( [ i, perm(i) ] for i in self.vertices() )\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/lattices.py\", line 1868, in <lambda>\n        G.relabel(lambda x: self.sublattice(x))\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/lattices.py\", line 1680, in sublattice\n        return LatticePoset(self.subposet(current_set))\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/posets.py\", line 4513, in subposet\n        elements = [self(e) for e in elements]\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/posets.py\", line 1232, in __call__\n        return super(FinitePoset, self).__call__(element)\n      File \"sage/structure/parent.pyx\", line 1107, in sage.structure.parent.Parent.__call__ (/home/buildbot/slave/sage_git/build/src/build/cythonized/sage/structure/parent.c:9904)\n        return mor._call_(x)\n      File \"sage/structure/coerce_maps.pyx\", line 110, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_ (/home/buildbot/slave/sage_git/build/src/build/cythonized/sage/structure/coerce_maps.c:4651)\n        raise\n      File \"sage/structure/coerce_maps.pyx\", line 105, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_ (/home/buildbot/slave/sage_git/build/src/build/cythonized/sage/structure/coerce_maps.c:4539)\n        return C._element_constructor(x)\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/posets.py\", line 1208, in _element_constructor_\n        % type(element))\n    ValueError: <type 'int'> is not an element of this poset\n**********************************************************************\nFile \"src/sage/combinat/posets/lattices.py\", line 1856, in sage.combinat.posets.lattices.FiniteLatticePoset.sublattices_lattice\nFailed example:\n    sll.is_isomorphic(Posets.BoolenLattice(3))\nException raised:\n    Traceback (most recent call last):\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py\", line 499, in _run\n        self.compile_and_execute(example, compiler, test.globs)\n      File \"/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py\", line 862, in compile_and_execute\n        exec(compiled, globs)\n      File \"<doctest sage.combinat.posets.lattices.FiniteLatticePoset.sublattices_lattice[10]>\", line 1, in <module>\n        sll.is_isomorphic(Posets.BoolenLattice(Integer(3)))\n    AttributeError: type object 'Posets' has no attribute 'BoolenLattice'\n**********************************************************************\n1 item had failures:\n   3 of  24 in sage.combinat.posets.lattices.FiniteLatticePoset.sublattices_lattice\n    [310 tests, 3 failures, 0.75 s]\n```",
    "created_at": "2016-07-23T11:51:22Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303879",
    "user": "https://github.com/vbraun"
}
comment:18
sage -t --long src/sage/combinat/posets/lattices.py
**********************************************************************
File "src/sage/combinat/posets/lattices.py", line 1743, in sage.combinat.posets.lattices.FiniteLatticePoset.sublattices_lattice
Failed example:
    sll = L.sublattices_lattice()
Exception raised:
    Traceback (most recent call last):
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 499, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 862, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.combinat.posets.lattices.FiniteLatticePoset.sublattices_lattice[4]>", line 1, in <module>
        sll = L.sublattices_lattice()
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/lattices.py", line 1868, in sublattices_lattice
        G.relabel(lambda x: self.sublattice(x))
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/graphs/generic_graph.py", line 19817, in relabel
        perm = dict( [ i, perm(i) ] for i in self.vertices() )
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/graphs/generic_graph.py", line 19817, in <genexpr>
        perm = dict( [ i, perm(i) ] for i in self.vertices() )
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/lattices.py", line 1868, in <lambda>
        G.relabel(lambda x: self.sublattice(x))
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/lattices.py", line 1680, in sublattice
        return LatticePoset(self.subposet(current_set))
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/posets.py", line 4513, in subposet
        elements = [self(e) for e in elements]
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/posets.py", line 1232, in __call__
        return super(FinitePoset, self).__call__(element)
      File "sage/structure/parent.pyx", line 1107, in sage.structure.parent.Parent.__call__ (/home/buildbot/slave/sage_git/build/src/build/cythonized/sage/structure/parent.c:9904)
        return mor._call_(x)
      File "sage/structure/coerce_maps.pyx", line 110, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_ (/home/buildbot/slave/sage_git/build/src/build/cythonized/sage/structure/coerce_maps.c:4651)
        raise
      File "sage/structure/coerce_maps.pyx", line 105, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_ (/home/buildbot/slave/sage_git/build/src/build/cythonized/sage/structure/coerce_maps.c:4539)
        return C._element_constructor(x)
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/posets.py", line 1208, in _element_constructor_
        % type(element))
    ValueError: <type 'int'> is not an element of this poset
**********************************************************************
File "src/sage/combinat/posets/lattices.py", line 1844, in sage.combinat.posets.lattices.FiniteLatticePoset.sublattices_lattice
Failed example:
    sll = L.sublattices_lattice()
Exception raised:
    Traceback (most recent call last):
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 499, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 862, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.combinat.posets.lattices.FiniteLatticePoset.sublattices_lattice[4]>", line 1, in <module>
        sll = L.sublattices_lattice()
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/lattices.py", line 1868, in sublattices_lattice
        G.relabel(lambda x: self.sublattice(x))
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/graphs/generic_graph.py", line 19817, in relabel
        perm = dict( [ i, perm(i) ] for i in self.vertices() )
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/graphs/generic_graph.py", line 19817, in <genexpr>
        perm = dict( [ i, perm(i) ] for i in self.vertices() )
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/lattices.py", line 1868, in <lambda>
        G.relabel(lambda x: self.sublattice(x))
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/lattices.py", line 1680, in sublattice
        return LatticePoset(self.subposet(current_set))
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/posets.py", line 4513, in subposet
        elements = [self(e) for e in elements]
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/posets.py", line 1232, in __call__
        return super(FinitePoset, self).__call__(element)
      File "sage/structure/parent.pyx", line 1107, in sage.structure.parent.Parent.__call__ (/home/buildbot/slave/sage_git/build/src/build/cythonized/sage/structure/parent.c:9904)
        return mor._call_(x)
      File "sage/structure/coerce_maps.pyx", line 110, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_ (/home/buildbot/slave/sage_git/build/src/build/cythonized/sage/structure/coerce_maps.c:4651)
        raise
      File "sage/structure/coerce_maps.pyx", line 105, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_ (/home/buildbot/slave/sage_git/build/src/build/cythonized/sage/structure/coerce_maps.c:4539)
        return C._element_constructor(x)
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/posets/posets.py", line 1208, in _element_constructor_
        % type(element))
    ValueError: <type 'int'> is not an element of this poset
**********************************************************************
File "src/sage/combinat/posets/lattices.py", line 1856, in sage.combinat.posets.lattices.FiniteLatticePoset.sublattices_lattice
Failed example:
    sll.is_isomorphic(Posets.BoolenLattice(3))
Exception raised:
    Traceback (most recent call last):
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 499, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/home/buildbot/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 862, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.combinat.posets.lattices.FiniteLatticePoset.sublattices_lattice[10]>", line 1, in <module>
        sll.is_isomorphic(Posets.BoolenLattice(Integer(3)))
    AttributeError: type object 'Posets' has no attribute 'BoolenLattice'
**********************************************************************
1 item had failures:
   3 of  24 in sage.combinat.posets.lattices.FiniteLatticePoset.sublattices_lattice
    [310 tests, 3 failures, 0.75 s]

archive/issue_events_291803.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-07-23T11:51:22Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20921#event-291803"
}

archive/issue_events_291804.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-07-23T11:51:22Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20921#event-291804"
}

archive/issue_comments_303880.json:

{
    "body": "Changed commit from **[`cf557bb`](https://github.com/sagemath/sagetrac-mirror/commit/cf557bbcdbe1e6d8a306d586a6cd3820c145344c)** to **[`fe8b4f6`](https://github.com/sagemath/sagetrac-mirror/commit/fe8b4f61aff1d5f43753c43dfde493c2d2e3eac2)**",
    "created_at": "2016-07-23T19:53:31Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303880",
    "user": "https://github.com/sagetrac-git"
}

Changed commit from cf557bb to fe8b4f6


archive/issue_comments_303881.json:

{
    "body": "<div id=\"comment:19\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/fe8b4f61aff1d5f43753c43dfde493c2d2e3eac2\"><code>fe8b4f6</code></a></td><td><code>Removed duplicate function.</code></td></tr></table>\n",
    "created_at": "2016-07-23T19:53:31Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303881",
    "user": "https://github.com/sagetrac-git"
}

Branch pushed to git repo; I updated commit sha1. New commits:

fe8b4f6Removed duplicate function.

archive/issue_comments_303882.json:

{
    "body": "<div id=\"comment:20\" align=\"right\">comment:20</div>\n\nAARGHS! There was my temporary copy still in the branch. Now it is removed and tests passed.",
    "created_at": "2016-07-23T19:54:55Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303882",
    "user": "https://github.com/jm58660"
}
comment:20

AARGHS! There was my temporary copy still in the branch. Now it is removed and tests passed.


archive/issue_events_291805.json:

{
    "actor": "https://github.com/jm58660",
    "created_at": "2016-07-23T19:54:55Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "label": "https://github.com/sagemath/sage/labels/needs%20work",
    "label_color": "ffff00",
    "label_name": "needs work",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20921#event-291805"
}

archive/issue_events_291806.json:

{
    "actor": "https://github.com/jm58660",
    "created_at": "2016-07-23T19:54:55Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20921#event-291806"
}

archive/issue_events_291807.json:

{
    "actor": "https://github.com/tscrim",
    "created_at": "2016-07-26T03:54:43Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "label": "https://github.com/sagemath/sage/labels/needs%20review",
    "label_color": "7fff00",
    "label_name": "needs review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20921#event-291807"
}

archive/issue_events_291808.json:

{
    "actor": "https://github.com/tscrim",
    "created_at": "2016-07-26T03:54:43Z",
    "event": "labeled",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20921#event-291808"
}

archive/issue_events_291809.json:

{
    "actor": "https://github.com/vbraun",
    "created_at": "2016-07-27T20:24:45Z",
    "event": "unlabeled",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "label": "https://github.com/sagemath/sage/labels/positive%20review",
    "label_color": "dfffc0",
    "label_name": "positive review",
    "label_text_color": "ffffff",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20921#event-291809"
}

archive/issue_events_291810.json:

{
    "actor": "https://github.com/vbraun",
    "commit_id": "a35225fd19591a62da3c37fc462d7203487cbbaf",
    "commit_repository": "https://github.com/sagemath/sage",
    "created_at": "2016-07-27T20:24:45Z",
    "event": "closed",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_event",
    "url": "https://github.com/sagemath/sage/issues/20921#event-291810"
}

archive/issue_comments_303883.json:

{
    "body": "Changed branch from **[u/jmantysalo/latticeposet__add_function_to_get_lattice_of_sublattices](https://github.com/sagemath/sagetrac-mirror/tree/u/jmantysalo/latticeposet__add_function_to_get_lattice_of_sublattices)** to **[`fe8b4f6`](https://github.com/sagemath/sagetrac-mirror/commit/fe8b4f61aff1d5f43753c43dfde493c2d2e3eac2)**",
    "created_at": "2016-07-27T20:24:45Z",
    "formatter": "markdown",
    "issue": "https://github.com/sagemath/sage/issues/20921",
    "type": "issue_comment",
    "url": "https://github.com/sagemath/sage/issues/20921#issuecomment-303883",
    "user": "https://github.com/vbraun"
}

Changed branch from u/jmantysalo/latticeposet__add_function_to_get_lattice_of_sublattices to fe8b4f6