archive/issues_020728.json:
{
"assignees": [],
"body": "<div id=\"comment:0\"></div>\n\nas a step towars py3\n\ndone using first\n\n```\nfuturize -w -f absolute_import src/sage/modular/\n```\nand then battling with the import-hell there.\n\nComponent: **python3**\n\nAuthor: **Fr\u00e9d\u00e9ric Chapoton**\n\nBranch/Commit: **[`1455cc3`](https://github.com/sagemath/sagetrac-mirror/commit/1455cc3379c4f71f4c1cc3d3dd270e7aa67a2d04)**\n\nReviewer: **Jori M\u00e4ntysalo**\n\n_Issue created by migration from https://trac.sagemath.org/ticket/20965_\n\n",
"closed_at": "2016-07-09T07:46:07Z",
"created_at": "2016-07-06T19:18:42Z",
"labels": [
"https://github.com/sagemath/sage/labels/c%3A%20python3",
"https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"https://github.com/sagemath/sage/labels/enhancement"
],
"milestone": "https://github.com/sagemath/sage/milestones/sage-7.3",
"reactions": [],
"repository": "https://github.com/sagemath/sage",
"title": "py3 import in modular folder (futurize)",
"type": "issue",
"updated_at": "2016-07-09T07:46:07Z",
"url": "https://github.com/sagemath/sage/issues/20965",
"user": "https://github.com/fchapoton"
}as a step towars py3
done using first
futurize -w -f absolute_import src/sage/modular/
and then battling with the import-hell there.
Component: python3
Author: Frédéric Chapoton
Branch/Commit: 1455cc3
Reviewer: Jori Mäntysalo
Issue created by migration from https://trac.sagemath.org/ticket/20965
archive/issue_events_292337.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-07-06T19:18:42Z",
"event": "milestoned",
"issue": "https://github.com/sagemath/sage/issues/20965",
"milestone_number": null,
"milestone_title": "sage-7.3",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20965#event-292337"
}archive/issue_events_292338.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-07-06T19:18:42Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20965",
"label": "https://github.com/sagemath/sage/labels/c%3A%20python3",
"label_color": "0000b0",
"label_name": "c: python3",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20965#event-292338"
}archive/issue_events_292339.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-07-06T19:18:42Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20965",
"label": "https://github.com/sagemath/sage/labels/p%3A%20major%20/%203",
"label_color": "ffbb00",
"label_name": "p: major / 3",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20965#event-292339"
}archive/issue_events_292340.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-07-06T19:18:42Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20965",
"label": "https://github.com/sagemath/sage/labels/enhancement",
"label_color": "696969",
"label_name": "enhancement",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20965#event-292340"
}archive/issue_comments_304546.json:
{
"body": "Branch: **[public/20965](https://github.com/sagemath/sagetrac-mirror/tree/public/20965)**",
"created_at": "2016-07-06T19:32:58Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20965",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20965#issuecomment-304546",
"user": "https://github.com/fchapoton"
}Branch: public/20965
archive/issue_comments_304547.json:
{
"body": "<div id=\"comment:1\"></div>\n\nNew commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/d527f1da706ed180103482d0ffec4a123ce0a6f0\"><code>d527f1d</code></a></td><td><code>python3 absolute imports in modular folder</code></td></tr></table>\n",
"created_at": "2016-07-06T19:32:58Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20965",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20965#issuecomment-304547",
"user": "https://github.com/fchapoton"
}New commits:
d527f1d | python3 absolute imports in modular folder |
archive/issue_events_292341.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-07-06T19:32:58Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20965",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20965#event-292341"
}archive/issue_comments_304548.json:
{
"body": "Commit: **[`d527f1d`](https://github.com/sagemath/sagetrac-mirror/commit/d527f1da706ed180103482d0ffec4a123ce0a6f0)**",
"created_at": "2016-07-06T19:32:58Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20965",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20965#issuecomment-304548",
"user": "https://github.com/fchapoton"
}Commit: d527f1d
archive/issue_comments_304549.json:
{
"body": "Reviewer: **Jori M\u00e4ntysalo**",
"created_at": "2016-07-06T19:54:35Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20965",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20965#issuecomment-304549",
"user": "https://github.com/jm58660"
}Reviewer: Jori Mäntysalo
archive/issue_events_292342.json:
{
"actor": "https://github.com/jm58660",
"created_at": "2016-07-06T19:54:35Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20965",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20965#event-292342"
}archive/issue_events_292343.json:
{
"actor": "https://github.com/jm58660",
"created_at": "2016-07-06T19:54:35Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20965",
"label": "https://github.com/sagemath/sage/labels/needs%20work",
"label_color": "ffff00",
"label_name": "needs work",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20965#event-292343"
}archive/issue_comments_304550.json:
{
"body": "<div id=\"comment:2\" align=\"right\">comment:2</div>\n\nLong doctest on `src/sage/modular/modsym/g1list.py` fails.\n\n`src/sage/modular/modform_hecketriangle/all.py` contains unnecessay line continuation marks.\n\nWhy you added `from .ghlist import GHlist` to `src/sage/modular/modsym/all.py`?",
"created_at": "2016-07-06T19:54:35Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20965",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20965#issuecomment-304550",
"user": "https://github.com/jm58660"
}comment:2
Long doctest on src/sage/modular/modsym/g1list.py fails.
src/sage/modular/modform_hecketriangle/all.py contains unnecessay line continuation marks.
Why you added from .ghlist import GHlist to src/sage/modular/modsym/all.py?
archive/issue_comments_304551.json:
{
"body": "Changed commit from **[`d527f1d`](https://github.com/sagemath/sagetrac-mirror/commit/d527f1da706ed180103482d0ffec4a123ce0a6f0)** to **[`972541a`](https://github.com/sagemath/sagetrac-mirror/commit/972541a913c5e062914b9ef48a0df6092d1757d3)**",
"created_at": "2016-07-06T19:57:06Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20965",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20965#issuecomment-304551",
"user": "https://github.com/sagetrac-git"
}Changed commit from d527f1d to 972541a
archive/issue_comments_304552.json:
{
"body": "<div id=\"comment:3\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/972541a913c5e062914b9ef48a0df6092d1757d3\"><code>972541a</code></a></td><td><code>trac 20965 correct failing doctest</code></td></tr></table>\n",
"created_at": "2016-07-06T19:57:06Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20965",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20965#issuecomment-304552",
"user": "https://github.com/sagetrac-git"
}Branch pushed to git repo; I updated commit sha1. New commits:
972541a | trac 20965 correct failing doctest |
archive/issue_comments_304553.json:
{
"body": "<div id=\"comment:4\" align=\"right\">comment:4</div>\n\nReplying to [@jm58660](#comment%3A2):\n> Long doctest on `src/sage/modular/modsym/g1list.py` fails.\n\nsolved by adding an import again, as I did before for ghlist\n\n> `src/sage/modular/modform_hecketriangle/all.py` contains unnecessay line continuation marks.\n\nfor another ticket, maybe ? This one is already rather huge..\n\n> Why you added `from .ghlist import GHlist` to `src/sage/modular/modsym/all.py`?\n\nThis was to solve some failing doctest in ghlist, similar to the ones in g1list.",
"created_at": "2016-07-06T19:59:05Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20965",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20965#issuecomment-304553",
"user": "https://github.com/fchapoton"
}comment:4
Replying to @jm58660:
Long doctest on
src/sage/modular/modsym/g1list.pyfails.
solved by adding an import again, as I did before for ghlist
src/sage/modular/modform_hecketriangle/all.pycontains unnecessay line continuation marks.
for another ticket, maybe ? This one is already rather huge..
Why you added
from .ghlist import GHlisttosrc/sage/modular/modsym/all.py?
This was to solve some failing doctest in ghlist, similar to the ones in g1list.
archive/issue_events_292344.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-07-06T20:00:44Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20965",
"label": "https://github.com/sagemath/sage/labels/needs%20work",
"label_color": "ffff00",
"label_name": "needs work",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20965#event-292344"
}archive/issue_events_292345.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-07-06T20:00:44Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20965",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20965#event-292345"
}archive/issue_events_292346.json:
{
"actor": "https://github.com/jm58660",
"created_at": "2016-07-07T04:32:42Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20965",
"label": "https://github.com/sagemath/sage/labels/needs%20review",
"label_color": "7fff00",
"label_name": "needs review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20965#event-292346"
}archive/issue_events_292347.json:
{
"actor": "https://github.com/jm58660",
"created_at": "2016-07-07T04:32:42Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20965",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20965#event-292347"
}archive/issue_comments_304554.json:
{
"body": "<div id=\"comment:6\" align=\"right\">comment:6</div>\n\nReplying to [@fchapoton](#comment%3A4):\n\n> > `src/sage/modular/modform_hecketriangle/all.py` contains unnecessay line continuation marks.\n> \n> \n> for another ticket, maybe ? This one is already rather huge..\n\nYes, can be done later.\n\nNow also the last file passes tests. Thanks again.",
"created_at": "2016-07-07T04:32:42Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20965",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20965#issuecomment-304554",
"user": "https://github.com/jm58660"
}comment:6
Replying to @fchapoton:
src/sage/modular/modform_hecketriangle/all.pycontains unnecessay line continuation marks.for another ticket, maybe ? This one is already rather huge..
Yes, can be done later.
Now also the last file passes tests. Thanks again.
archive/issue_events_292348.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-07-07T20:23:44Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20965",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20965#event-292348"
}archive/issue_events_292349.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-07-07T20:23:44Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20965",
"label": "https://github.com/sagemath/sage/labels/needs%20work",
"label_color": "ffff00",
"label_name": "needs work",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20965#event-292349"
}archive/issue_comments_304555.json:
{
"body": "<div id=\"comment:7\" align=\"right\">comment:7</div>\n\nFails because of a newly-added module, please merge in next beta \n\n```\nDO NOT INTERRUPT THIS.\nDone updating paths.\nTraceback (most recent call last):\n File \"/home/buildslave-sage/slave/sage_git/build/src/bin/sage-eval\", line 4, in <module>\n from sage.all import *\n File \"/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/all.py\", line 113, in <module>\n from sage.modular.all import *\n File \"/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/modular/all.py\", line 38, in <module>\n from btquotients.all import *\nImportError: No module named btquotients.all\nSage failed to start up.\n```",
"created_at": "2016-07-07T20:23:44Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20965",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20965#issuecomment-304555",
"user": "https://github.com/vbraun"
}comment:7
Fails because of a newly-added module, please merge in next beta
DO NOT INTERRUPT THIS.
Done updating paths.
Traceback (most recent call last):
File "/home/buildslave-sage/slave/sage_git/build/src/bin/sage-eval", line 4, in <module>
from sage.all import *
File "/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/all.py", line 113, in <module>
from sage.modular.all import *
File "/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/modular/all.py", line 38, in <module>
from btquotients.all import *
ImportError: No module named btquotients.all
Sage failed to start up.
archive/issue_comments_304556.json:
{
"body": "Changed commit from **[`972541a`](https://github.com/sagemath/sagetrac-mirror/commit/972541a913c5e062914b9ef48a0df6092d1757d3)** to **[`1455cc3`](https://github.com/sagemath/sagetrac-mirror/commit/1455cc3379c4f71f4c1cc3d3dd270e7aa67a2d04)**",
"created_at": "2016-07-08T09:39:52Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20965",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20965#issuecomment-304556",
"user": "https://github.com/sagetrac-git"
}Changed commit from 972541a to 1455cc3
archive/issue_comments_304557.json:
{
"body": "<div id=\"comment:8\"></div>\n\nBranch pushed to git repo; I updated commit sha1. New commits:\n<table><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/3fa9d88fb906d6327be9a30306cce605295b524f\"><code>3fa9d88</code></a></td><td><code>Merge branch 'public/20965' int 7.3.b7</code></td></tr><tr><td><a href=\"https://github.com/sagemath/sagetrac-mirror/commit/1455cc3379c4f71f4c1cc3d3dd270e7aa67a2d04\"><code>1455cc3</code></a></td><td><code>trac 20965 detail</code></td></tr></table>\n",
"created_at": "2016-07-08T09:39:52Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20965",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20965#issuecomment-304557",
"user": "https://github.com/sagetrac-git"
}Branch pushed to git repo; I updated commit sha1. New commits:
3fa9d88 | Merge branch 'public/20965' int 7.3.b7 |
1455cc3 | trac 20965 detail |
archive/issue_comments_304558.json:
{
"body": "<div id=\"comment:9\" align=\"right\">comment:9</div>\n\ntrivial rebase, I am setting this back to positive review",
"created_at": "2016-07-08T09:40:27Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20965",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20965#issuecomment-304558",
"user": "https://github.com/fchapoton"
}comment:9
trivial rebase, I am setting this back to positive review
archive/issue_events_292350.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-07-08T09:40:27Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20965",
"label": "https://github.com/sagemath/sage/labels/needs%20work",
"label_color": "ffff00",
"label_name": "needs work",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20965#event-292350"
}archive/issue_events_292351.json:
{
"actor": "https://github.com/fchapoton",
"created_at": "2016-07-08T09:40:27Z",
"event": "labeled",
"issue": "https://github.com/sagemath/sage/issues/20965",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20965#event-292351"
}archive/issue_events_292352.json:
{
"actor": "https://github.com/vbraun",
"created_at": "2016-07-09T07:46:07Z",
"event": "unlabeled",
"issue": "https://github.com/sagemath/sage/issues/20965",
"label": "https://github.com/sagemath/sage/labels/positive%20review",
"label_color": "dfffc0",
"label_name": "positive review",
"label_text_color": "ffffff",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20965#event-292352"
}archive/issue_events_292353.json:
{
"actor": "https://github.com/vbraun",
"commit_id": "53411a655bf69e481d9549afbb42248604cca681",
"commit_repository": "https://github.com/sagemath/sage",
"created_at": "2016-07-09T07:46:07Z",
"event": "closed",
"issue": "https://github.com/sagemath/sage/issues/20965",
"type": "issue_event",
"url": "https://github.com/sagemath/sage/issues/20965#event-292353"
}archive/issue_comments_304559.json:
{
"body": "Changed branch from **[public/20965](https://github.com/sagemath/sagetrac-mirror/tree/public/20965)** to **[`1455cc3`](https://github.com/sagemath/sagetrac-mirror/commit/1455cc3379c4f71f4c1cc3d3dd270e7aa67a2d04)**",
"created_at": "2016-07-09T07:46:07Z",
"formatter": "markdown",
"issue": "https://github.com/sagemath/sage/issues/20965",
"type": "issue_comment",
"url": "https://github.com/sagemath/sage/issues/20965#issuecomment-304559",
"user": "https://github.com/vbraun"
}Changed branch from public/20965 to 1455cc3